提交 a6651086 编写于 作者: P Patrice Chotard 提交者: Tom Rini

board_f.c: Ensure gd->new_bootstage alignment

In reserve_bootstage(), in case size is odd, gd->new_bootstage
is not aligned. In bootstage_relocate(), the platform hangs when
getting access to data->record[i].name.
To avoid this issue, make gd->new_bootstage 16 byte aligned.

To ensure that new_bootstage is 16 byte aligned (at least needed for
x86_64 and ARMv8) and new_bootstage starts down to get enough space,
ALIGN_DOWN macro is used.

Fixes: ac9cd480 ("bootstage: Correct relocation algorithm")
Signed-off-by: NPatrice Chotard <patrice.chotard@st.com>
Reviewed-by: NVikas MANOCHA <vikas.manocha@st.com>
Reviewed-by: NPatrick Delaunay <patrick.delaunay@st.com>
Tested-by: NPatrick Delaunay <patrick.delaunay@st.com>
Signed-off-by: NPatrick Delaunay <patrick.delaunay@st.com>
上级 9d82cbd3
......@@ -564,6 +564,11 @@ static int reserve_bootstage(void)
int size = bootstage_get_size();
gd->start_addr_sp -= size;
/*
* Ensure that start_addr_sp is aligned down to reserve enough
* space for new_bootstage
*/
gd->start_addr_sp = ALIGN_DOWN(gd->start_addr_sp, 16);
gd->new_bootstage = map_sysmem(gd->start_addr_sp, size);
debug("Reserving %#x Bytes for bootstage at: %08lx\n", size,
gd->start_addr_sp);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册