提交 757f64a8 编写于 作者: S Simon Glass

patman: Deal with 'git apply' failures correctly

This sort of failure is rare, but the code to deal with it is wrong.
Fix it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
上级 75b3c3aa
...@@ -11,6 +11,7 @@ import subprocess ...@@ -11,6 +11,7 @@ import subprocess
import sys import sys
import terminal import terminal
import checkpatch
import settings import settings
...@@ -193,6 +194,7 @@ def ApplyPatch(verbose, fname): ...@@ -193,6 +194,7 @@ def ApplyPatch(verbose, fname):
Args: Args:
fname: filename of patch file to apply fname: filename of patch file to apply
""" """
col = terminal.Color()
cmd = ['git', 'am', fname] cmd = ['git', 'am', fname]
pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE, pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE,
stderr=subprocess.PIPE) stderr=subprocess.PIPE)
...@@ -203,8 +205,8 @@ def ApplyPatch(verbose, fname): ...@@ -203,8 +205,8 @@ def ApplyPatch(verbose, fname):
print line print line
match = re_error.match(line) match = re_error.match(line)
if match: if match:
print GetWarningMsg('warning', match.group(1), int(match.group(2)), print checkpatch.GetWarningMsg(col, 'warning', match.group(1),
'Patch failed') int(match.group(2)), 'Patch failed')
return pipe.returncode == 0, stdout return pipe.returncode == 0, stdout
def ApplyPatches(verbose, args, start_point): def ApplyPatches(verbose, args, start_point):
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册