提交 4cf2b221 编写于 作者: S Simon Glass

buildman: Rename the good, better, worse variables

At present we don't distinguish between errors and warnings when printing
the architecture summary. Rename the variables to better describe their
purpose.

'Worse' at present means we got an error, so use that as the name.
Signed-off-by: NSimon Glass <sjg@chromium.org>
上级 2d48333e
......@@ -1196,10 +1196,10 @@ class Builder:
Print(' ' + line, newline=True, colour=col)
better = [] # List of boards fixed since last commit
worse = [] # List of new broken boards since last commit
new = [] # List of boards that didn't exist last time
unknown = [] # List of boards that were not built
ok_boards = [] # List of boards fixed since last commit
err_boards = [] # List of new broken boards since last commit
new_boards = [] # List of boards that didn't exist last time
unknown_boards = [] # List of boards that were not built
for target in board_dict:
if target not in board_selected:
......@@ -1210,13 +1210,13 @@ class Builder:
base_outcome = self._base_board_dict[target].rc
outcome = board_dict[target]
if outcome.rc == OUTCOME_UNKNOWN:
unknown.append(target)
unknown_boards.append(target)
elif outcome.rc < base_outcome:
better.append(target)
ok_boards.append(target)
elif outcome.rc > base_outcome:
worse.append(target)
err_boards.append(target)
else:
new.append(target)
new_boards.append(target)
# Get a list of errors that have appeared, and disappeared
better_err, worse_err = _CalcErrorDelta(self._base_err_lines,
......@@ -1225,16 +1225,16 @@ class Builder:
self._base_warn_line_boards, warn_lines, warn_line_boards, 'w')
# Display results by arch
if (better or worse or unknown or new or worse_err or better_err
or worse_warn or better_warn):
if any((ok_boards, err_boards, unknown_boards, new_boards, worse_err,
better_err, worse_warn, better_warn)):
arch_list = {}
self.AddOutcome(board_selected, arch_list, better, '',
self.AddOutcome(board_selected, arch_list, ok_boards, '',
self.col.GREEN)
self.AddOutcome(board_selected, arch_list, worse, '+',
self.AddOutcome(board_selected, arch_list, err_boards, '+',
self.col.RED)
self.AddOutcome(board_selected, arch_list, new, '*', self.col.BLUE)
self.AddOutcome(board_selected, arch_list, new_boards, '*', self.col.BLUE)
if self._show_unknown:
self.AddOutcome(board_selected, arch_list, unknown, '?',
self.AddOutcome(board_selected, arch_list, unknown_boards, '?',
self.col.MAGENTA)
for arch, target_list in arch_list.iteritems():
Print('%10s: %s' % (arch, target_list))
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册