• A
    ehci-pci: Prepare for usage of readl()/writel() accessors · 2cb7b900
    Alexey Brodkin 提交于
    We used to have opencoded ehci_readl()/writel() which required no
    external functions to be called.
    
    Now with attempt to switch to generic readl()/writel() accessors
    we see a missing declaration of those accessors in ehci-ppc4xx.
    Something like that happens if applied
    http://patchwork.ozlabs.org/patch/726714/:
    --------------------------------->8---------------------------
      CC      drivers/usb/host/ehci-pci.o
    In file included from drivers/usb/host/ehci-pci.c:14:0:
    drivers/usb/host/ehci-pci.c: In function 'ehci_pci_init':
    drivers/usb/host/ehci.h:108:36: warning: implicit declaration of function 'readl' [-Wimplicit-function-declaration]
     #define ehci_readl(x)  cpu_to_le32(readl(x))
                                        ^
    drivers/usb/host/ehci.h:23:26: note: in definition of macro 'HC_LENGTH'
     #define HC_LENGTH(p)  (((p) >> 0) & 0x00ff)
                              ^
    include/linux/byteorder/generic.h:89:21: note: in expansion of macro '__cpu_to_le32'
     #define cpu_to_le32 __cpu_to_le32
                         ^~~~~~~~~~~~~
    drivers/usb/host/ehci-pci.c:33:14: note: in expansion of macro 'ehci_readl'
        HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
                  ^~~~~~~~~~
    --------------------------------->8---------------------------
    
    This the same fix as we have for "ehci-ppc4xx" in
    83cb46c2 "ehci-ppc4xx: Prepare for usage of readl()/writel() accessors".
    Signed-off-by: NAlexey Brodkin <abrodkin@synopsys.com>
    Cc: Simon Glass <sjg@chromium.org>
    Cc: Tom Rini <trini@konsulko.com>
    Cc: Marek Vasut <marex@denx.de>
    Cc: Stefan Roese <sr@denx.de>
    2cb7b900
ehci-pci.c 3.5 KB