• J
    aspeed/watchdog: Correct timeout value · 894e235f
    Joel Stanley 提交于
    The driver was using milliseconds and programming it into a register
    which takes ticks of the watchdog clock, which runs at 1MHz. This meant
    we were off by 1000 with the desired value.
    
    When 06985289 ("watchdog: Implement generic watchdog_reset()
    version") was added the aspeed board would leave the watchdog running,
    causing it to bite before u-boot was done.
    
    Discovered by booting in qemu:
    
      $ qemu-system-arm -M ast2500-evb -drive file=test.img,format=raw,if=mtd -nographic -no-reboot -d cpu_reset
    
      U-Boot 2019.07-rc3-00091-g2253e40c (Jun 06 2019 - 16:53:23 +0930)
    
      Model: Aspeed BMC
      DRAM:  496 MiB
      WDT:   Started with servicing (60s timeout)
      MMC:
      In:    serial@1e784000
      Out:   serial@1e784000
      Err:   serial@1e784000
      Watchdog timer expired.
    
    Fixes: 06985289 ("watchdog: Implement generic watchdog_reset() version")
    Signed-off-by: NJoel Stanley <joel@jms.id.au>
    894e235f
ast_wdt.c 2.9 KB