• M
    Avoid pre-decrement of pointer in big-endian CRC calculation. · d1d57749
    Mark Adler 提交于
    There was a small optimization for PowerPCs to pre-increment a
    pointer when accessing a word, instead of post-incrementing. This
    required prefacing the loop with a decrement of the pointer,
    possibly pointing before the object passed. This is not compliant
    with the C standard, for which decrementing a pointer before its
    allocated memory is undefined. When tested on a modern PowerPC
    with a modern compiler, the optimization no longer has any effect.
    Due to all that, and per the recommendation of a security audit of
    the zlib code by Trail of Bits and TrustInSoft, in support of the
    Mozilla Foundation, this "optimization" was removed, in order to
    avoid the possibility of undefined behavior.
    d1d57749
crc32.c 12.8 KB