1. 13 3月, 2018 1 次提交
  2. 12 3月, 2018 2 次提交
  3. 10 3月, 2018 1 次提交
  4. 09 3月, 2018 2 次提交
  5. 08 3月, 2018 2 次提交
    • B
      Fix issues in ia32 RDRAND asm leading to reduced entropy · 082193ef
      Bryan Donlan 提交于
      This patch fixes two issues in the ia32 RDRAND assembly code that result in a
      (possibly significant) loss of entropy.
      
      The first, less significant, issue is that, by returning success as 0 from
      OPENSSL_ia32_rdrand() and OPENSSL_ia32_rdseed(), a subtle bias was introduced.
      Specifically, because the assembly routine copied the remaining number of
      retries over the result when RDRAND/RDSEED returned 'successful but zero', a
      bias towards values 1-8 (primarily 8) was introduced.
      
      The second, more worrying issue was that, due to a mixup in registers, when a
      buffer that was not size 0 or 1 mod 8 was passed to OPENSSL_ia32_rdrand_bytes
      or OPENSSL_ia32_rdseed_bytes, the last (n mod 8) bytes were all the same value.
      This issue impacts only the 64-bit variant of the assembly.
      
      This change fixes both issues by first eliminating the only use of
      OPENSSL_ia32_rdrand, replacing it with OPENSSL_ia32_rdrand_bytes, and fixes the
      register mixup in OPENSSL_ia32_rdrand_bytes. It also adds a sanity test for
      OPENSSL_ia32_rdrand_bytes and OPENSSL_ia32_rdseed_bytes to help catch problems
      of this nature in the future.
      Reviewed-by: NAndy Polyakov <appro@openssl.org>
      Reviewed-by: NRich Salz <rsalz@openssl.org>
      (Merged from https://github.com/openssl/openssl/pull/5342)
      082193ef
    • M
      Remove OPENSSL_USE_NODELETE guards in shlibloadtest · d8b67b9d
      Matt Caswell 提交于
      PR #3399 converted shlibloadtest to the new test framework. It also
      seemed to add some `OPENSSL_USE_NODELETE` guards to the library
      unloading part of the test. This part was added in a commit with this
      description:
      
          Review feedback; use single main, #ifdef ADD_TEST
      
          Suppose OPENSSL_USE_NODELETE (via Nick Reilly)
      
      Strangely though there doesn't seem to be any relevant review feedback
      in that PR that could justify the addition of those guards. The guards
      do not appear in 1.1.0.
      
      Having the guards changes the nature of the test, so that we only test
      library unloading on platforms where OPENSSL_USE_NODELETE is set (Linux
      and Windows). I can't think of any good reason for this and as it doesn't
      seem to be necessary in 1.1.0 so I think we should remove them.
      Reviewed-by: NRichard Levitte <levitte@openssl.org>
      (Merged from https://github.com/openssl/openssl/pull/5530)
      d8b67b9d
  6. 07 3月, 2018 1 次提交
  7. 05 3月, 2018 2 次提交
  8. 04 3月, 2018 1 次提交
  9. 02 3月, 2018 1 次提交
  10. 01 3月, 2018 4 次提交
  11. 27 2月, 2018 3 次提交
  12. 26 2月, 2018 1 次提交
  13. 23 2月, 2018 3 次提交
  14. 21 2月, 2018 4 次提交
  15. 20 2月, 2018 5 次提交
  16. 19 2月, 2018 2 次提交
  17. 15 2月, 2018 1 次提交
  18. 14 2月, 2018 2 次提交
    • R
      VMS: for testutil, make sure to use BIO_f_linebuffer · f11a023a
      Richard Levitte 提交于
      Without that, output comes one character per line.  It's the same
      issue as has been observed before, this happens when using write()
      on a record oriented stream (possibly unbuffered too).
      
      This also uncovered a bug in BIO_f_linebuffer, where this would cause
      an error:
      
          BIO_write(bio, "1\n", 1);
      
      I.e. there's a \n just after the part of the string that we currently
      ask to get written.
      Reviewed-by: NRich Salz <rsalz@openssl.org>
      (Merged from https://github.com/openssl/openssl/pull/5352)
      f11a023a
    • D
      DRBG: make the derivation function the default for ctr_drbg · 8164d91d
      Dr. Matthias St. Pierre 提交于
      The NIST standard presents two alternative ways for seeding the
      CTR DRBG, depending on whether a derivation function is used or not.
      In Section 10.2.1 of NIST SP800-90Ar1 the following is assessed:
      
        The use of the derivation function is optional if either an
        approved RBG or an entropy source provides full entropy output
        when entropy input is requested by the DRBG mechanism.
        Otherwise, the derivation function shall be used.
      
      Since the OpenSSL DRBG supports being reseeded from low entropy random
      sources (using RAND_POOL), the use of a derivation function is mandatory.
      For that reason we change the default and replace the opt-in flag
      RAND_DRBG_FLAG_CTR_USE_DF with an opt-out flag RAND_DRBG_FLAG_CTR_NO_DF.
      This change simplifies the RAND_DRBG_new() calls.
      Reviewed-by: NRich Salz <rsalz@openssl.org>
      (Merged from https://github.com/openssl/openssl/pull/5294)
      8164d91d
  19. 13 2月, 2018 1 次提交
  20. 10 2月, 2018 1 次提交