提交 de7d61d5 编写于 作者: M Matt Caswell

Improve some comment documentation following the extensions refactor

Reviewed-by: NKurt Roeckx <kurt@openssl.org>
Reviewed-by: NRich Salz <rsalz@openssl.org>
上级 b1b4b543
...@@ -432,8 +432,7 @@ int ssl_get_new_session(SSL *s, int session) ...@@ -432,8 +432,7 @@ int ssl_get_new_session(SSL *s, int session)
* ssl_get_prev attempts to find an SSL_SESSION to be used to resume this * ssl_get_prev attempts to find an SSL_SESSION to be used to resume this
* connection. It is only called by servers. * connection. It is only called by servers.
* *
* ext: ClientHello extensions (including length prefix) * hello: The parsed ClientHello data
* session_id: ClientHello session ID.
* *
* Returns: * Returns:
* -1: error * -1: error
......
...@@ -175,6 +175,10 @@ static int compare_extensions(const void *p1, const void *p2) ...@@ -175,6 +175,10 @@ static int compare_extensions(const void *p1, const void *p2)
* types, and 0 if the extensions contain duplicates, could not be successfully * types, and 0 if the extensions contain duplicates, could not be successfully
* parsed, or an internal error occurred. * parsed, or an internal error occurred.
*/ */
/*
* TODO(TLS1.3): Refactor ServerHello extension parsing to use this and then
* remove tls1_check_duplicate_extensions()
*/
int tls_collect_extensions(PACKET *packet, RAW_EXTENSION **res, int tls_collect_extensions(PACKET *packet, RAW_EXTENSION **res,
size_t *numfound, int *ad) size_t *numfound, int *ad)
{ {
......
...@@ -2888,8 +2888,11 @@ int tls_get_ticket_from_client(SSL *s, CLIENTHELLO_MSG *hello, ...@@ -2888,8 +2888,11 @@ int tls_get_ticket_from_client(SSL *s, CLIENTHELLO_MSG *hello,
} }
/* /*
* Sets the extended master secret flag is set if the extension is present * Sets the extended master secret flag if the extension is present in the
* in the ClientHello * ClientHello
* Returns:
* 1 on success
* 0 on error
*/ */
int tls_check_client_ems_support(SSL *s, CLIENTHELLO_MSG *hello) int tls_check_client_ems_support(SSL *s, CLIENTHELLO_MSG *hello)
{ {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册