• J
    Clarify error for unrecognized arguments. · fd6a0f5e
    Jacob Hoffman-Andrews 提交于
    Many of the sub-commands under apps/ accept cipher or digest arguments like
    "-sha256". These are implemented using a catchall flag that runs the result
    through opt_md() or opt_cipher(). That means any unrecognized flag, including
    typos, gets sent to those two functions, producing confusing error messages like
    below:
    
        $ ./apps/openssl req -x590
        req: Unrecognized digest x590
        req: Use -help for summary.
    
    This change switches these two functions to say "Unrecognized flag X" instead.
    The new message deliberately leaves off the "-" from the flag name, because
    there are some cases where opt_md() and opt_cipher() are passed a flag value
    instead (for instance, openssl ca -md). I think the new message is generic
    enough that it can serve both cases with improved clarity.
    
    CLA: trivial
    Reviewed-by: NAndy Polyakov <appro@openssl.org>
    Reviewed-by: NRich Salz <rsalz@openssl.org>
    (Merged from https://github.com/openssl/openssl/pull/4972)
    fd6a0f5e
opt.c 24.1 KB