1. 05 4月, 2013 9 次提交
    • R
    • R
      eliminate bits/wchar.h · c7af2710
      Rich Felker 提交于
      the preprocessor can reliably determine the signedness of wchar_t.
      L'\0' is used for 0 in the expressions so that, if the underlying type
      of wchar_t is long rather than int, the promoted type of the
      expression will match the type of wchar_t.
      c7af2710
    • R
      201995f3
    • R
      add put*ent functions for passwd/group files and similar for shadow · ddfb267b
      Rich Felker 提交于
      since shadow does not yet support enumeration (getspent), the
      corresponding FILE-based get and put versions are also subbed out for
      now. this is partly out of laziness and partly because it's not clear
      how they should work in the presence of TCB shadow files. the stubs
      should make it possible to compile some software that expects them to
      exist, but such software still may not work properly.
      ddfb267b
    • R
      cleanup wcstombs · 771c6cea
      Rich Felker 提交于
      remove redundant headers and comments; this file is completely trivial
      now. also, avoid temp var.
      771c6cea
    • R
      cleanup mbstowcs wrapper · b5a527f9
      Rich Felker 提交于
      remove unneeded headers. this file is utterly trivial now and there's
      no sense in having a comment to state that it's in the public domain.
      b5a527f9
    • R
      minor optimization to mbstowcs · f62b12d0
      Rich Felker 提交于
      there is no need to zero-fill an mbstate_t object in the caller;
      mbsrtowcs will automatically treat a null pointer as the initial
      state.
      f62b12d0
    • R
      fix incorrect range checks in wcsrtombs · 40b2b5fa
      Rich Felker 提交于
      negative values of wchar_t need to be treated in the non-ASCII case so
      that they can properly generate EILSEQ rather than getting truncated
      to 8bit values and stored in the output.
      40b2b5fa
    • R
      overhaul mbsrtowcs · 50d9661d
      Rich Felker 提交于
      these changes fix at least two bugs:
      - misaligned access to the input as uint32_t for vectorized ASCII test
      - incorrect src pointer after stopping on EILSEQ
      
      in addition, the text of the standard makes it unclear whether the
      mbstate_t object is to be modified when the destination pointer is
      null; previously it was cleared either way; now, it's only cleared
      when the destination is non-null. this change may need revisiting, but
      it should not affect most applications, since calling mbsrtowcs with
      non-zero state can only happen when the head of the string was already
      processed with mbrtowc.
      
      finally, these changes shave about 20% size off the function and seem
      to improve performance by 1-5%.
      50d9661d
  2. 02 4月, 2013 10 次提交
  3. 01 4月, 2013 3 次提交
  4. 27 3月, 2013 2 次提交
    • R
      remove __SYSCALL_SSLEN arch macro in favor of using public _NSIG · ccc7b4c3
      Rich Felker 提交于
      the issue at hand is that many syscalls require as an argument the
      kernel-ABI size of sigset_t, intended to allow the kernel to switch to
      a larger sigset_t in the future. previously, each arch was defining
      this size in syscall_arch.h, which was redundant with the definition
      of _NSIG in bits/signal.h. as it's used in some not-quite-portable
      application code as well, _NSIG is much more likely to be recognized
      and understood immediately by someone reading the code, and it's also
      shorter and less cluttered.
      
      note that _NSIG is actually 65/129, not 64/128, but the division takes
      care of throwing away the off-by-one part.
      ccc7b4c3
    • R
      provide emulation of fcntl F_DUPFD_CLOEXEC on old kernels · 00f1521f
      Rich Felker 提交于
      I'm not entirely happy with the amount of ugliness here, but since
      F_DUPFD_CLOEXEC is used elsewhere in code that's expected to work on
      old kernels (popen), it seems necessary. reportedly even some modern
      kernels went back and broke F_DUPFD_CLOEXEC (making it behave like
      plain F_DUPFD), so it might be necessary to add some additional fixup
      code later to deal with that issue too.
      00f1521f
  5. 25 3月, 2013 3 次提交
  6. 24 3月, 2013 2 次提交
    • R
      add deprecated SIGIOT alias for SIGABRT · 2d0f495e
      Rich Felker 提交于
      reportedly some programs (e.g. showkeys in the kbd package) use it.
      2d0f495e
    • R
      fix multiple bugs in syslog interfaces · 427c0ca7
      Rich Felker 提交于
      1. as reported by William Haddon, the value returned by snprintf was
      wrongly used as a length passed to sendto, despite it possibly
      exceeding the buffer length. this could lead to invalid reads and
      leaking additional data to syslog.
      
      2. openlog was storing a pointer to the ident string passed by the
      caller, rather than copying it. this bug is shared with (and even
      documented in) other implementations like glibc, but such behavior
      does not seem to meet the requirements of the standard.
      
      3. extremely long ident provided to openlog, or corrupt ident due to
      the above issue, could possibly have resulted in buffer overflows.
      despite having the potential for smashing the stack, i believe the
      impact is low since ident points to a short string literal in typical
      application usage (and per the above bug, other usages will break
      horribly on other implementations).
      
      4. when used with LOG_NDELAY, openlog was not connecting the
      newly-opened socket; sendto was being used instead. this defeated the
      main purpose of LOG_NDELAY: preparing for chroot.
      
      5. the default facility was not being used at all, so all messages
      without an explicit facility passed to syslog were getting logged at
      the kernel facility.
      
      6. setlogmask was not thread-safe; no synchronization was performed
      updating the mask. the fix uses atomics rather than locking to avoid
      introducing a lock in the fast path for messages whose priority is not
      in the mask.
      
      7. in some code paths, the syslog lock was being unlocked twice; this
      could result in releasing a lock that was actually held by a different
      thread.
      
      some additional enhancements to syslog such as a default identifier
      based on argv[0] or similar may still be desired; at this time, only
      the above-listed bugs have been fixed.
      427c0ca7
  7. 10 3月, 2013 1 次提交
    • R
      remove soname from libc.so/ld-musl · dfdc337b
      Rich Felker 提交于
      it serves no purpose (binaries linked against musl as -lc/libc.so
      automatically get the right DT_NEEDED value of libc.so) and causes
      ldconfig to misbehave (making a symlink to ld-musl named libc.so in
      /lib). ldconfig is not used on pure musl systems, but if ld-musl is
      installed on a system where it's not the primary libc, this will
      pollute the system /lib with a symlink to musl named libc.so, which
      should NOT exist and could cause problems linking native apps. also,
      the existence of the soname caused spurious warnings from ldconfig
      when /lib and /usr/lib were the same physical directory.
      dfdc337b
  8. 07 3月, 2013 1 次提交
    • R
      fix epoll structure alignment on non-x86_64 archs · 08514d06
      Rich Felker 提交于
      this fix is far from ideal and breaks the rule of not using
      arch-specific #ifdefs, but for now we just need a solution to the
      existing breakage.
      
      the underlying problem is that the kernel folks made a very stupid
      decision to make misalignment of this struct part of the kernel
      API/ABI for x86_64, in order to avoid writing a few extra lines of
      code to handle both 32- and 64-bit userspace on 64-bit kernels. I had
      just added the packed attribute unconditionally thinking it was
      harmless on 32-bit archs, but non-x86 32-bit archs have 8-byte
      alignment on 64-bit types.
      08514d06
  9. 06 3月, 2013 1 次提交
  10. 05 3月, 2013 2 次提交
    • R
      fix types for wctype_t and wctrans_t · da1442c9
      Rich Felker 提交于
      wctype_t was incorrectly "int" rather than "long" on x86_64. not only
      is this an ABI incompatibility; it's also a major design flaw if we
      ever wanted wctype_t to be implemented as a pointer, which would be
      necessary if locales support custom character classes, since int is
      too small to store a converted pointer. this commit fixes wctype_t to
      be unsigned long on all archs, matching the LSB ABI; this change does
      not matter for C code, but for C++ it affects mangling.
      
      the same issue applied to wctrans_t. glibc/LSB defines this type as
      const __int32_t *, but since no such definition is visible, I've just
      expanded the definition, int, everywhere.
      
      it would be nice if these types (which don't vary by arch) could be in
      wctype.h, but the OB XSI requirement in POSIX that wchar.h expose some
      types and functions from wctype.h precludes doing so. glibc works
      around this with some hideous hacks, but trying to duplicate that
      would go against the intent of musl's headers.
      da1442c9
    • R
      fix some obscure header type size/alignment issues · 8c741783
      Rich Felker 提交于
      8c741783
  11. 26 2月, 2013 5 次提交
  12. 22 2月, 2013 1 次提交