1. 01 8月, 2011 2 次提交
  2. 31 7月, 2011 3 次提交
    • R
      consistency: use struct __ucontext instead of ucontext_t in prototypes · acfd06df
      Rich Felker 提交于
      this is necessary to avoid build errors if feature test macros are not
      properly defined when including ucontext.h
      acfd06df
    • R
      fix race condition in sigqueue · 07827d1a
      Rich Felker 提交于
      this race is fundamentally due to linux's bogus requirement that
      userspace, rather than kernelspace, fill in the siginfo structure. an
      intervening signal handler that calls fork could cause both the parent
      and child process to send signals claiming to be from the parent,
      which could in turn have harmful effects depending on what the
      recipient does with the signal. we simply block all signals for the
      interval between getuid and sigqueue syscalls (much like what raise()
      does already) to prevent the race and make the getuid/sigqueue pair
      atomic.
      
      this will be a non-issue if linux is fixed to validate the siginfo
      structure or fill it in from kernelspace.
      07827d1a
    • R
      clean up pthread_sigmask/sigprocmask dependency order · ad588184
      Rich Felker 提交于
      it's nicer for the function that doesn't use errno to be independent,
      and have the other one call it. saves some time and avoids clobbering
      errno.
      ad588184
  3. 30 7月, 2011 6 次提交
    • R
      fix some bugs in setxid and update setrlimit to use __synccall · 544ee752
      Rich Felker 提交于
      setrlimit is supposed to be per-process, not per-thread, but again
      linux gets it wrong. work around this in userspace. not only is it
      needed for correctness; setxid also depends on the resource limits for
      all threads being the same to avoid situations where temporarily
      unlimiting the limit succeeds in some threads but fails in others.
      544ee752
    • R
      add proper fuxed-based locking for stdio · dba68bf9
      Rich Felker 提交于
      previously, stdio used spinlocks, which would be unacceptable if we
      ever add support for thread priorities, and which yielded
      pathologically bad performance if an application attempted to use
      flockfile on a key file as a major/primary locking mechanism.
      
      i had held off on making this change for fear that it would hurt
      performance in the non-threaded case, but actually support for
      recursive locking had already inflicted that cost. by having the
      internal locking functions store a flag indicating whether they need
      to perform unlocking, rather than using the actual recursive lock
      counter, i was able to combine the conditionals at unlock time,
      eliminating any additional cost, and also avoid a nasty corner case
      where a huge number of calls to ftrylockfile could cause deadlock
      later at the point of internal locking.
      
      this commit also fixes some issues with usage of pthread_self
      conflicting with __attribute__((const)) which resulted in crashes with
      some compiler versions/optimizations, mainly in flockfile prior to
      pthread_create.
      dba68bf9
    • R
      eliminate dependence of perror on printf · 7683fcee
      Rich Felker 提交于
      7683fcee
    • R
    • R
      afade235
    • R
      new attempt at making set*id() safe and robust · acb04806
      Rich Felker 提交于
      changing credentials in a multi-threaded program is extremely
      difficult on linux because it requires synchronizing the change
      between all threads, which have their own thread-local credentials on
      the kernel side. this is further complicated by the fact that changing
      the real uid can fail due to exceeding RLIMIT_NPROC, making it
      possible that the syscall will succeed in some threads but fail in
      others.
      
      the old __rsyscall approach being replaced was robust in that it would
      report failure if any one thread failed, but in this case, the program
      would be left in an inconsistent state where individual threads might
      have different uid. (this was not as bad as glibc, which would
      sometimes even fail to report the failure entirely!)
      
      the new approach being committed refuses to change real user id when
      it cannot temporarily set the rlimit to infinity. this is completely
      POSIX conformant since POSIX does not require an implementation to
      allow real-user-id changes for non-privileged processes whatsoever.
      still, setting the real uid can fail due to memory allocation in the
      kernel, but this can only happen if there is not already a cached
      object for the target user. thus, we forcibly serialize the syscalls
      attempts, and fail the entire operation on the first failure. this
      *should* lead to an all-or-nothing success/failure result, but it's
      still fragile and highly dependent on kernel developers not breaking
      things worse than they're already broken.
      
      ideally linux will eventually add a CLONE_USERCRED flag that would
      give POSIX conformant credential changes without any hacks from
      userspace, and all of this code would become redundant and could be
      removed ~10 years down the line when everyone has abandoned the old
      broken kernels. i'm not holding my breath...
      acb04806
  4. 29 7月, 2011 3 次提交
  5. 25 7月, 2011 2 次提交
  6. 24 7月, 2011 6 次提交
  7. 22 7月, 2011 4 次提交
  8. 17 7月, 2011 2 次提交
  9. 15 7月, 2011 1 次提交
    • R
      fix various bugs in new integer parser framework · 47d027ee
      Rich Felker 提交于
      1. my interpretation of subject sequence definition was wrong. adjust
      parser to conform to the standard.
      
      2. some code for handling tail overflow case was missing (forgot to
      finish writing it).
      
      3. typo (= instead of ==) caused ERANGE to wrongly behave like EINVAL
      47d027ee
  10. 14 7月, 2011 2 次提交
    • R
      fix wcsto[iu]max with high characters · d3fd1925
      Rich Felker 提交于
      stopping without letting the parser see a stop character prevented
      getting a result. so treat all high chars as the null character and
      pass them into the parser.
      
      also eliminated ugly tmp var using compound literals.
      d3fd1925
    • R
      new restartable integer parsing framework. · ecc9c5fc
      Rich Felker 提交于
      this fixes a number of bugs in integer parsing due to lazy haphazard
      wrapping, as well as some misinterpretations of the standard. the new
      parser is able to work character-at-a-time or on whole strings, making
      it easy to support the wide functions without unbounded space for
      conversion. it will also be possible to update scanf to use the new
      parser.
      ecc9c5fc
  11. 13 7月, 2011 1 次提交
  12. 12 7月, 2011 3 次提交
  13. 10 7月, 2011 1 次提交
  14. 04 7月, 2011 4 次提交