1. 23 6月, 2013 2 次提交
    • R
      fix scanf %c conversion wrongly storing a terminating null byte · ef550786
      Rich Felker 提交于
      this seems to have been a regression from the refactoring which added
      the 'm' modifier.
      ef550786
    • R
      fix major scanf breakage with unbuffered streams, fmemopen, etc. · c2080450
      Rich Felker 提交于
      the shgetc api, used internally in scanf and int/float scanning code
      to handle field width limiting and pushback, was designed assuming
      that pushback could be achieved via a simple decrement on the file
      buffer pointer. this only worked by chance for regular FILE streams,
      due to the linux readv bug workaround in __stdio_read which moves the
      last requested byte through the buffer rather than directly back to
      the caller. for unbuffered streams and streams not using __stdio_read
      but some other underlying read function, the first character read
      could be completely lost, and replaced by whatever junk happened to be
      in the unget buffer.
      
      to fix this, simply have shgetc, when it performs an underlying read
      operation on the stream, store the character read at the -1 offset
      from the read buffer pointer. this is valid even for unbuffered
      streams, as they have an unget buffer located just below the start of
      the zero-length buffer. the check to avoid storing the character when
      it is already there is to handle the possibility of read-only buffers.
      no application-exposed FILE types are allowed to use read-only
      buffers, but sscanf and strto* may use them internally when calling
      functions which use the shgetc api.
      c2080450
  2. 16 6月, 2013 2 次提交
  3. 13 6月, 2013 1 次提交
    • R
      improve the quality of output from rand_r · 20d01d83
      Rich Felker 提交于
      due to the interface requirement of having the full state contained in
      a single object of type unsigned int, it is difficult to provide a
      reasonable-quality implementation; most good PRNGs are immediately
      ruled out because they need larger state. the old rand_r gave very
      poor output (very short period) in its lower bits; normally, it's
      desirable to throw away the low bits (as in rand()) when using a LCG,
      but this is not possible since the state is only 32 bits and we need
      31 bits of output.
      
      glibc's rand_r uses the same LCG as musl's, but runs it for 3
      iterations and only takes 10-11 bits from each iteration to construct
      the output value. this partially fixes the period issue, but
      introduces bias: not all outputs have the same frequency, and many do
      not appear at all. with such a low period, the bias is likely to be
      observable.
      
      I tried many approaches to "fix" rand_r, and the simplest I found
      which made it pass the "dieharder" tests was applying this
      transformation to the output. the "temper" function is taken from
      mersenne twister, where it seems to have been chosen for some rigorous
      properties; here, the only formal property I'm using is that it's
      one-to-one and thus avoids introducing bias.
      
      should further deficiencies in rand_r be reported, the obvious "best"
      solution is applying a 32-bit cryptographic block cipher in CTR mode.
      I identified several possible ciphers that could be used directly or
      adapted, but as they would be a lot slower and larger, I do not see a
      justification for using them unless the current rand_r proves
      deficient for some real-world use.
      20d01d83
  4. 08 6月, 2013 5 次提交
    • R
      add clock id macros for a number of new(ish) Linux-specific clocks · 4191d244
      Rich Felker 提交于
      arguably CLOCK_MONOTONIC should be redirected to CLOCK_BOOTTIME with a
      fallback for old kernels that don't support it, since Linux's
      CLOCK_BOOTTIME semantics seem to match the spirit of the POSIX
      requirements for CLOCK_MONOTONIC better than Linux's version of
      CLOCK_MONOTONIC does. however, this is a change that would require
      further discussion and research, so for now, I'm simply making them
      all available.
      4191d244
    • R
      fix the type of CLOCKS_PER_SEC to match new clock_t type · 01739902
      Rich Felker 提交于
      originally it was right on 32-bit archs and wrong on 64-bit, but after
      recent changes it was wrong everywhere. with this commit, it's now
      right everywhere.
      01739902
    • R
      support cputime clocks for processes/threads other than self · ea200e38
      Rich Felker 提交于
      apparently these features have been in Linux for a while now, so it
      makes sense to support them. the bit twiddling seems utterly illogical
      and wasteful, especially the negation, but that's how the kernel folks
      chose to encode pids/tids into the clock id.
      ea200e38
    • S
      prng: make rand_r have 2^32 period instead of 2^31 · 0996faa3
      Szabolcs Nagy 提交于
      this is a minor fix to increase the period of the obsolete rand_r a bit.
      an include header in __rand48_step.c is fixed as well.
      0996faa3
    • S
      prng: fix rand() to give good sequence with small state · c79cd27e
      Szabolcs Nagy 提交于
      some applications rely on the low bits of rand() to be reasonably good
      quality prng, so now it fixed by using the top bits of a 64 bit LCG,
      this is simple, has small state and passes statistical tests.
      D.E. Knuth attributes the multiplier to C.E. Haynes in TAOCP Vol2 3.3.4
      c79cd27e
  5. 07 6月, 2013 3 次提交
  6. 06 6月, 2013 3 次提交
  7. 05 6月, 2013 2 次提交
  8. 04 6月, 2013 2 次提交
  9. 27 5月, 2013 2 次提交
  10. 26 5月, 2013 2 次提交
  11. 24 5月, 2013 2 次提交
    • R
      change underlying type of clock_t to be uniform and match ABI · 5e642b5a
      Rich Felker 提交于
      previously we were using an unsigned type on 32-bit systems so that
      subtraction would be well-defined when it wrapped, but since wrapping
      is non-conforming anyway (when clock() overflows, it has to return -1)
      the only use of unsigned would be to buy a little bit more time before
      overflow. this does not seem worth having the type vary per-arch
      (which leads to more arch-specific bugs) or disagree with the ABI musl
      (mostly) follows.
      5e642b5a
    • R
      fix overflow behavior of clock() function · 05453b37
      Rich Felker 提交于
      per Austin Group interpretation for issue #686, which cites the
      requirements of ISO C, clock() cannot wrap. if the result is not
      representable, it must return (clock_t)-1. in addition, the old code
      was performing wrapping via signed overflow and thus invoking
      undefined behavior.
      
      since it seems impossible to accurately check for overflow with the
      old times()-based fallback code, I have simply dropped the fallback
      code for now, thus always returning -1 on ancient systems. if there's
      a demand for making it work and somebody comes up with a way, it could
      be reinstated, but the clock() function is essentially useless on
      32-bit system anyway (it overflows in less than an hour).
      
      it should be noted that I used LONG_MAX rather than ULONG_MAX, despite
      32-bit archs using an unsigned type for clock_t. this discrepency with
      the glibc/LSB type definitions will be fixed now; since wrapping of
      clock_t is no longer supported, there's no use in it being unsigned.
      05453b37
  12. 19 5月, 2013 3 次提交
    • S
      math: add fma TODO comments about the underflow issue · 1e5eb735
      Szabolcs Nagy 提交于
      The underflow exception is not raised correctly in some
      cornercases (see previous fma commit), added comments
      with examples for fmaf, fmal and non-x86 fma.
      
      In fmaf store the result before returning so it has the
      correct precision when FLT_EVAL_METHOD!=0
      1e5eb735
    • S
      math: fix two fma issues (only affects non-nearest rounding mode, x86) · ffd8ac2d
      Szabolcs Nagy 提交于
      1) in downward rounding fma(1,1,-1) should be -0 but it was 0 with
      gcc, the code was correct but gcc does not support FENV_ACCESS ON
      so it used common subexpression elimination where it shouldn't have.
      now volatile memory access is used as a barrier after fesetround.
      
      2) in directed rounding modes there is no double rounding issue
      so the complicated adjustments done for nearest rounding mode are
      not needed. the only exception to this rule is raising the underflow
      flag: assume "small" is an exactly representible subnormal value in
      double precision and "verysmall" is a much smaller value so that
      	(long double)(small plus verysmall) == small
      then
      	(double)(small plus verysmall)
      raises underflow because the result is an inexact subnormal, but
      	(double)(long double)(small plus verysmall)
      does not because small is not a subnormal in long double precision
      and it is exact in double precision.
      now this problem is fixed by checking inexact using fenv when the
      result is subnormal
      ffd8ac2d
    • R
      Merge remote-tracking branch 'nsz/review' · 83af1dd6
      Rich Felker 提交于
      83af1dd6
  13. 18 5月, 2013 5 次提交
    • S
      math: sin cos cleanup · bfda3793
      Szabolcs Nagy 提交于
      * use unsigned arithmetics
      * use unsigned to store arg reduction quotient (so n&3 is understood)
      * remove z=0.0 variables, use literal 0
      * raise underflow and inexact exceptions properly when x is small
      * fix spurious underflow in tanl
      bfda3793
    • R
      make err.h functions print __progname · 69ee9b2c
      Rich Felker 提交于
      patch by Strake. previously is was not feasible to duplicate this
      functionality of the functions these were modeled on, since argv[0]
      was not saved at program startup, but now that it's available it's
      easy to use.
      69ee9b2c
    • S
      math: tan cleanups · 1d5ba3bb
      Szabolcs Nagy 提交于
      * use unsigned arithmetics on the representation
      * store arg reduction quotient in unsigned (so n%2 would work like n&1)
      * use different convention to pass the arg reduction bit to __tan
        (this argument used to be 1 for even and -1 for odd reduction
        which meant obscure bithacks, the new n&1 is cleaner)
      * raise inexact and underflow flags correctly for small x
        (tanl(x) may still raise spurious underflow for small but normal x)
        (this exception raising code increases codesize a bit, similar fixes
        are needed in many other places, it may worth investigating at some
        point if the inexact and underflow flags are worth raising correctly
        as this is not strictly required by the standard)
      * tanf manual reduction optimization is kept for now
      * tanl code path is cleaned up to follow similar logic to tan and tanf
      1d5ba3bb
    • R
      add FLT_TRUE_MIN, etc. macros from C11 · 22730d65
      Rich Felker 提交于
      there was some question as to how many decimal places to use, since
      one decimal place is always sufficient to identify the smallest
      denormal uniquely. for now, I'm following the example in the C
      standard which is consistent with the other min/max macros we already
      had in place.
      22730d65
    • R
      remove the __STDC_FORMAT_MACROS nonsense from inttypes.h · ec9f5353
      Rich Felker 提交于
      somehow I missed this when removing the corresponding
      __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS nonsense from stdint.h.
      these were all attempts by the C committee to guess what the C++
      committee would want, and the guesses turned out to be wrong.
      ec9f5353
  14. 17 5月, 2013 1 次提交
    • R
      fix mknod and mknodat to accept large dev_t values · 1a70198b
      Rich Felker 提交于
      support for these was recently added to sysmacros.h. note that the
      syscall argument is a long, despite dev_t being 64-bit, so on 32-bit
      archs the high bits will be lost. it appears the high bits are just
      glibc silliness and not part of the kernel api, anyway, but it's nice
      that we have them there for future expansion if needed.
      1a70198b
  15. 16 5月, 2013 2 次提交
    • S
      math: use double_t for temporaries to avoid stores on i386 · e216951f
      Szabolcs Nagy 提交于
      When FLT_EVAL_METHOD!=0 (only i386 with x87 fp) the excess
      precision of an expression must be removed in an assignment.
      (gcc needs -fexcess-precision=standard or -std=c99 for this)
      
      This is done by extra load/store instructions which adds code
      bloat when lot of temporaries are used and it makes the result
      less precise in many cases.
      Using double_t and float_t avoids these issues on i386 and
      it makes no difference on other archs.
      
      For now only a few functions are modified where the excess
      precision is clearly beneficial (mostly polynomial evaluations
      with temporaries).
      
      object size differences on i386, gcc-4.8:
                   old   new
      __cosdf.o    123    95
      __cos.o      199   169
      __sindf.o    131    95
      __sin.o      225   203
      __tandf.o    207   151
      __tan.o      605   499
      erff.o      1470  1416
      erf.o       1703  1649
      j0f.o       1779  1745
      j0.o        2308  2274
      j1f.o       1602  1568
      j1.o        2286  2252
      tgamma.o    1431  1424
      math/*.o   64164 63635
      e216951f
    • R
  16. 07 5月, 2013 1 次提交
    • S
      remove compound literals from math.h to please c++ · 2897bfdd
      Szabolcs Nagy 提交于
      __FLOAT_BITS and __DOUBLE_BITS macros used union compound literals,
      now they are changed into static inline functions. A good C compiler
      generates the same code for both and the later is C++ conformant.
      2897bfdd
  17. 06 5月, 2013 2 次提交
    • R
      fix incorrect clock tick scaling in fallback case of clock() · da49b872
      Rich Felker 提交于
      since CLOCKS_PER_SEC is 1000000 (required by XSI) and the times
      syscall reports values in 1/100 second units (Linux), the correct
      scaling factor is 10000, not 100. note that only ancient kernels which
      lack clock_gettime are affected.
      da49b872
    • R
      do not interpret errors in return value of times() syscall · 9293b765
      Rich Felker 提交于
      all return values are valid, and on 32-bit systems, values that look
      like errors can and will occur. since the only actual error this
      function could return is EFAULT, and it is only returnable when the
      application has invoked undefined behavior, simply ignore the
      possibility that the return value is actually an error code.
      9293b765