1. 18 10月, 2013 3 次提交
  2. 13 10月, 2013 1 次提交
    • R
      fix uid/gid-setting error in faccessat with AT_EACCESS flag · 51635856
      Rich Felker 提交于
      this fixes an issue reported by Daniel Thau whereby faccessat with the
      AT_EACCESS flag did not work in cases where the process is running
      suid or sgid but without root privileges. per POSIX, when the process
      does not have "appropriate privileges", setuid changes the euid, not
      the real uid, and the target uid must be equal to the current real or
      saved uid; if this condition is not met, EPERM results. this caused
      the faccessat child process to fail.
      
      using the setreuid syscall rather than setuid works. POSIX leaves it
      unspecified whether setreuid can set the real user id to the effective
      user id on processes without "appropriate privileges", but Linux
      allows this; if it's not allowed, there would be no way for this
      function to work.
      51635856
  3. 09 10月, 2013 1 次提交
    • R
      fix errno value for getcwd when size argument is zero · 4fb7df12
      Rich Felker 提交于
      based on patch by Michael Forney. at the same time, I've changed the
      if branch to be more clear, avoiding the comma operator.
      
      the underlying issue is that Linux always returns ERANGE when size is
      too short, even when it's zero, rather than returning EINVAL for the
      special case of zero as required by POSIX.
      4fb7df12
  4. 08 10月, 2013 2 次提交
  5. 07 10月, 2013 5 次提交
  6. 06 10月, 2013 2 次提交
    • S
      math: remove an unused variable from modfl · b9cd1d4d
      Szabolcs Nagy 提交于
      b9cd1d4d
    • R
      slightly optimize __brk for size · 8acbe4f8
      Rich Felker 提交于
      there is no reason to check the return value for setting errno, since
      brk never returns errors, only the new value of the brk (which may be
      the same as the old, or otherwise differ from the requested brk, on
      failure).
      
      it may be beneficial to eventually just eliminate this file and make
      the syscalls inline in malloc.c.
      8acbe4f8
  7. 05 10月, 2013 4 次提交
  8. 04 10月, 2013 3 次提交
  9. 03 10月, 2013 1 次提交
    • R
      fix new environment always being null with execle · 2b2aff37
      Rich Felker 提交于
      the va_arg call for the argv[]-terminating null pointer was missing,
      so this pointer was being wrongly used as the environment pointer.
      
      issue reported by Timo Teräs. proposed patch slightly modified to
      simplify the resulting code.
      2b2aff37
  10. 29 9月, 2013 1 次提交
  11. 28 9月, 2013 1 次提交
    • R
      fix buffer overflow in mbsrtowcs · 211264e4
      Rich Felker 提交于
      issue reported by Michael Forney:
      
      "If wn becomes 0 after processing a chunk of 4, mbsrtowcs currently
      continues on, wrapping wn around to -1, causing the rest of the string
      to be processed.
      
      This resulted in buffer overruns if there was only space in ws for wn
      wide characters."
      
      the original patch submitted added an additional check for !wn after
      the loop; to avoid extra branching, I instead just changed the wn>=4
      check to wn>=5 to ensure that at least one slot remains after the
      word-at-a-time loop runs. this should not slow down the tail
      processing on real-world usage, since an extra slot that can't be
      processed in the word-at-a-time loop is needed for the null
      termination anyway.
      211264e4
  12. 27 9月, 2013 3 次提交
  13. 24 9月, 2013 1 次提交
  14. 22 9月, 2013 1 次提交
    • R
      fix arm atomic store and generate simpler/less-bloated/faster code · 35a6801c
      Rich Felker 提交于
      atomic store was lacking a barrier, which was fine for legacy arm with
      no real smp and kernel-emulated cas, but unsuitable for more modern
      systems. the kernel provides another "kuser" function, at 0xffff0fa0,
      which could be used for the barrier, but using that would drop support
      for kernels 2.6.12 through 2.6.14 unless an extra conditional were
      added to check for barrier availability. just using the barrier in the
      kernel cas is easier, and, based on my reading of the assembly code in
      the kernel, does not appear to be significantly slower.
      
      at the same time, other atomic operations are adapted to call the
      kernel cas function directly rather than using a_cas; due to small
      differences in their interface contracts, this makes the generated
      code much simpler.
      35a6801c
  15. 20 9月, 2013 2 次提交
    • R
      fix potential deadlock bug in libc-internal locking logic · e803829e
      Rich Felker 提交于
      if a multithreaded program became non-multithreaded (i.e. all other
      threads exited) while one thread held an internal lock, the remaining
      thread would fail to release the lock. the the program then became
      multithreaded again at a later time, any further attempts to obtain
      the lock would deadlock permanently.
      
      the underlying cause is that the value of libc.threads_minus_1 at
      unlock time might not match the value at lock time. one solution would
      be returning a flag to the caller indicating whether the lock was
      taken and needs to be unlocked, but there is a simpler solution: using
      the lock itself as such a flag.
      
      note that this flag is not needed anyway for correctness; if the lock
      is not held, the unlock code is harmless. however, the memory
      synchronization properties associated with a_store are costly on some
      archs, so it's best to avoid executing the unlock code when it is
      unnecessary.
      e803829e
    • R
      correct the sysconf value for RTSIG_MAX · d8e283df
      Rich Felker 提交于
      this is the number of realtime signals available, not the maximum
      signal number or total number of signals.
      d8e283df
  16. 17 9月, 2013 1 次提交
  17. 16 9月, 2013 5 次提交
    • R
      fix clobbering of caller's stack in mips __clone function · cffb9e1e
      Rich Felker 提交于
      this was resulting in crashes in posix_spawn on mips, and would have
      affected applications calling clone too. since the prototype for
      __clone has it as a variadic function, it may not assume that 16($sp)
      is writable for use in making the syscall. instead, it needs to
      allocate additional stack space, and then adjust the stack pointer
      back in both of the code paths for the parent process/thread.
      cffb9e1e
    • S
      sys/resource.h: add PRIO_MIN and PRIO_MAX for getpriority and setpriority · 90710df5
      Szabolcs Nagy 提交于
      These constants are not specified by POSIX, but they are in the reserved
      namespace, glibc and bsd systems seem to provide them as well.
      (Note that POSIX specifies -NZERO and NZERO-1 to be the limits, but
      PRIO_MAX equals NZERO)
      90710df5
    • S
      update include/elf.h following glibc changes · 268375c1
      Szabolcs Nagy 提交于
      the changes were verified using various sources:
      linux: include/uapi/linux/elf.h
      binutils: include/elf/common.h
      glibc: elf/elf.h
      sysv gabi: http://www.sco.com/developers/gabi/latest/contents.html
      sun linker docs: http://docs.oracle.com/cd/E18752_01/pdf/817-1984.pdf
      and platform specific docs
      
      - fixed:
      EF_MIPS_* E_MIPS_* e_flags: fixed accoding to glibc and binutils
      
      - added:
      ELFOSABI_GNU for EI_OSABI entry: glibc, binutils and sysv gabi
      EM_* e_machine values: updated according to linux and glibc
      PN_XNUM e_phnum value: from glibc and linux, see oracle docs
      NT_* note types: updated according to linux and glibc
      DF_1_* flags for DT_FLAGS_1 entry: following glibc and oracle docs
      AT_HWCAP2 auxv entry for more hwcap bits accoding to linux and glibc
      R_386_SIZE32 relocation according to glibc and binutils
      EF_ARM_ABI_FLOAT_* e_flags: added following glibc and binutils
      R_AARCH64_* relocs: added following glibc and aarch64 elf specs
      R_ARM_* relocs: according to glibc, binutils and arm elf specs
      R_X86_64_* relocs: added missing relocs following glibc
      
      - removed:
      HWCAP_SPARC_* flags were moved to arch specific header in glibc
      R_ARM_SWI24 reloc is marked as obsolete in glibc, not present in binutils
        not specified in arm elf spec, R_ARM_TLS_DESC reused its number
        see http://www.codesourcery.com/publications/RFC-TLSDESC-ARM.txt
      
      - glibc changes not pulled in:
      ELFOSABI_ARM_AEABI (bare-metal system, binutils and glibc disagrees about the name)
      R_68K_* relocs for unsupported platform
      R_SPARC_* ditto
      EF_SH* ditto (e_flags)
      EF_S390* ditto (e_flags)
      R_390* ditto
      R_MN10300* ditto
      R_TILE* ditto
      268375c1
    • R
      omit CLONE_PARENT flag to clone in pthread_create · 271c2119
      Rich Felker 提交于
      CLONE_PARENT is not necessary (CLONE_THREAD provides all the useful
      parts of it) and Linux treats CLONE_PARENT as an error in certain
      situations, without noticing that it would be a no-op due to
      CLONE_THREAD. this error case prevents, for example, use of a
      multi-threaded init process and certain usages with containers.
      271c2119
    • R
      use symbolic names for clone flags in pthread_create · f68a3468
      Rich Felker 提交于
      f68a3468
  18. 15 9月, 2013 3 次提交