1. 21 12月, 2014 7 次提交
    • R
      fix signedness of UINT32_MAX and UINT64_MAX at the preprocessor level · dac4fc49
      Rich Felker 提交于
      per the rules for hexadecimal integer constants, the previous
      definitions were correctly treated as having unsigned type except
      possibly when used in preprocessor conditionals, where all artithmetic
      takes place as intmax_t or uintmax_t. the explicit 'u' suffix ensures
      that they are treated as unsigned in all contexts.
      dac4fc49
    • R
      overhaul forkpty function using new login_tty · 814aae20
      Rich Felker 提交于
      based on discussion with and patches by Felix Janda. these changes
      started as an effort to factor forkpty in terms of login_tty, which
      returns an error and skips fd reassignment and closing if setting the
      controlling terminal failed. the previous forkpty code was unable to
      handle errors in the child, and did not attempt to; it just silently
      ignored them. but this would have been unacceptable when switching to
      using login_tty, since the child would start with the wrong stdin,
      stdout, and stderr and thereby clobber the parent's files.
      
      the new code uses the same technique as the posix_spawn implementation
      to convey any possible error in the child to the parent so that the
      parent can report failure to the caller. it is also safe against
      thread cancellation and against signal delivery in the child prior to
      the determination of success.
      814aae20
    • R
      block pthread cancellation in openpty function · 1227e418
      Rich Felker 提交于
      being a nonstandard function, this isn't strictly necessary, but it's
      inexpensive and avoids unpleasant surprises. eventually I would like
      all functions in libc to be safe against cancellation, either ignoring
      it or acting on it cleanly.
      1227e418
    • R
      don't write openpty results until success is determined · 3b26a32d
      Rich Felker 提交于
      not only is this semantically more correct; it also reduces code size
      slightly by eliminating the need for the compiler to assume the
      possibility of aliasing.
      3b26a32d
    • F
      add login_tty function · 4b2cb377
      Felix Janda 提交于
      4b2cb377
    • R
      set optopt in getopt_long · 0217ed72
      Rich Felker 提交于
      this is undocumented but possibly expected behavior of GNU
      getopt_long, and useful when error message printing has been
      suppressed.
      0217ed72
    • R
      add error message printing to getopt_long and make related improvements · 91184c4f
      Rich Felker 提交于
      some related changes are also made to getopt, and the return value of
      getopt_long in the case of missing arguments is fixed.
      91184c4f
  2. 20 12月, 2014 2 次提交
  3. 19 12月, 2014 3 次提交
    • R
      use tkill instead of tgkill in implementing raise · 7d351212
      Rich Felker 提交于
      this shaves off a useless syscall for getting the caller's pid and
      brings raise into alignment with other functions which were adapted to
      use tkill rather than tgkill.
      
      commit 83dc6eb0 documents the
      rationale for this change, and in particular why the tgkill syscall is
      useless for its designed purpose of avoiding races.
      7d351212
    • R
      don't suppress sign output for NANs in printf · 0f859fc9
      Rich Felker 提交于
      formally, it seems a sign is only required when the '+' modifier
      appears in the format specifier, in which case either '+' or '-' must
      be present in the output. but the specification is written such that
      an optional negative sign is part of the output format anyway, and the
      simplest approach to fixing the problem is removing the code that was
      suppressing the sign.
      0f859fc9
    • R
      fix return value computation in one code path of wcsnrtombs · 2e1ae3b6
      Rich Felker 提交于
      the affected code was wrongly counting characters instead of bytes.
      2e1ae3b6
  4. 18 12月, 2014 7 次提交
    • R
      fix signedness of WINT_MIN expression · aee9b152
      Rich Felker 提交于
      since wint_t is unsigned, WINT_MIN needs to expand to an unsigned zero.
      aee9b152
    • R
      make the definition of _Complex_I explicitly complex · a9c2294e
      Rich Felker 提交于
      it's unclear whether compilers which provide pure imaginary types
      might produce a pure imaginary expression for 1.0fi. using 0.0f+1.0fi
      ensures that the result is explicitly complex and makes this obvious
      to human readers too.
      a9c2294e
    • R
      make the result of the cimag macro a non-lvalue · 4075af43
      Rich Felker 提交于
      this change is not necessary but helps diagnose invalid code. based on
      patch by Jens Gustedt.
      4075af43
    • R
      fix definition of CMPLX macros in complex.h to work in constant expressions · 5ff2a118
      Rich Felker 提交于
      based on patches by Jens Gustedt. these macros need to be usable in
      static initializers, and the old definitions were not.
      
      there is no portable way to provide correct definitions for these
      macros unless the compiler supports pure imaginary types. a portable
      definition is provided for this case even though there are presently
      no compilers that can use it. gcc and compatible compilers provide a
      builtin function that can be used, but clang fails to support this and
      instead requires a construct which is a constraint violation and which
      is only a constant expression as a clang-specific extension.
      
      since these macros are a namespace violation in pre-C11 profiles, and
      since no known pre-C11 compilers provide any way to define them
      correctly anyway, the definitions have been made conditional on C11.
      5ff2a118
    • R
      provide CMPLX macros in implementation-internal libm.h · a414e837
      Rich Felker 提交于
      this avoids assuming the presence of C11 macro definitions in the
      public complex.h, which need changes potentially incompatible with the
      way these macros are being used internally.
      a414e837
    • N
      implement FNM_CASEFOLD extension to fnmatch function · efa9d396
      Nagy Szabolcs 提交于
      efa9d396
    • R
      add basic dns record parsing functions · aac59c11
      Rich Felker 提交于
      based on patch by Timo Teräs, with some corrections to bounds checking
      code and other minor changes.
      
      while they are borderline scope creep, the functions added are fairly
      small and are roughly the minimum code needed to use the results of
      the res_query API without re-implementing error-prone DNS packet
      parsing, and they are used in practice by some kerberos related
      software and possibly other things. at this time there is no intent to
      implement further nameser.h API functions.
      aac59c11
  5. 17 12月, 2014 1 次提交
    • R
      correctly handle write errors encountered by printf-family functions · d42269d7
      Rich Felker 提交于
      previously, write errors neither stopped further output attempts nor
      caused the function to return an error to the caller. this could
      result in silent loss of output, possibly in the middle of output in
      the event of a non-permanent error.
      
      the simplest solution is temporarily clearing the error flag for the
      target stream, then suppressing further output when the error flag is
      set and checking/restoring it at the end of the operation to determine
      the correct return value.
      
      since the wide version of the code internally calls the narrow fprintf
      to perform some of its underlying operations, initial clearing of the
      error flag is suppressed when performing a narrow vfprintf on a
      wide-oriented stream. this is not a problem since the behavior of
      narrow operations on wide-oriented streams is undefined.
      d42269d7
  6. 14 12月, 2014 1 次提交
  7. 13 12月, 2014 1 次提交
  8. 11 12月, 2014 4 次提交
  9. 10 12月, 2014 1 次提交
    • B
      don't shadow functions with macros in C++ · f164875a
      Bobby Bingham 提交于
      C++ programmers typically expect something like "::function(x,y)" to work
      and may be surprised to find that "(::function)(x,y)" is actually required
      due to the headers declaring a macro version of some standard functions.
      
      We already omit function-like macros for C++ in most cases where there is
      a real function available. This commit extends this to the remaining
      function-like macros which have a real function version.
      f164875a
  10. 06 12月, 2014 2 次提交
    • R
      use direct syscall rather than write function in posix_spawn child · 8f7bc690
      Rich Felker 提交于
      the write function is a cancellation point and accesses thread-local
      state belonging to the calling thread in the parent process. since
      cancellation is blocked for the duration of posix_spawn, this is
      probably safe, but it's fragile and unnecessary. making the syscall
      directly is just as easy and clearly safe.
      8f7bc690
    • R
      don't fail posix_spawn on failed close · 1c12c243
      Rich Felker 提交于
      the resolution of austin group issue #370 removes the requirement that
      posix_spawn fail when the close file action is performed on an
      already-closed fd. since there are no other meaningful errors for
      close, just ignoring the return value completely is the simplest fix.
      1c12c243
  11. 04 12月, 2014 1 次提交
    • R
      fix getopt handling of ':' modifier for multibyte option characters · 014275b5
      Rich Felker 提交于
      the previous hard-coded offsets of +1 and +2 contained a hidden
      assumption that the option character matched was single-byte, despite
      this implementation of getopt attempting to support multibyte option
      characters. this patch reworks the matching logic to leave the final
      index pointing just past the matched character so that fixed offsets
      can be used to check for ':'.
      014275b5
  12. 03 12月, 2014 4 次提交
  13. 24 11月, 2014 5 次提交
    • R
      adapt dynamic linker for new binutils versions that omit DT_RPATH · d8dc2b7c
      Rich Felker 提交于
      the new DT_RUNPATH semantics for search order are always used, and
      since binutils had always set both DT_RPATH and DT_RUNPATH when the
      latter was used, processing only DT_RPATH worked fine. however, recent
      binutils has stopped generating DT_RPATH when DT_RUNPATH is used,
      which broke support for this feature completely.
      d8dc2b7c
    • R
      fix tabs/spaces in memcpy.s · 9911754b
      Rich Felker 提交于
      this file had been a mess that went unnoticed ever since it was
      imported. some lines used spaces for indention while others used tabs,
      and tabs were used for alignment.
      9911754b
    • R
    • R
      fix build regression in arm asm for memcpy · 9367fe92
      Rich Felker 提交于
      commit 27828f7e fixed compatibility
      with clang's internal assembler, but broke compatibility with gas and
      the traditional arm asm syntax by switching to the arm "unified
      assembler language" (UAL). recent versions of gas also support UAL,
      but require the .syntax directive to be used to switch to it. clang on
      the other hand defaults to UAL. and old versions of gas (still
      relevant) don't support UAL at all.
      
      for the conditional ldm/stm instructions, "ia" is default and can just
      be omitted, resulting in a mnemonic that's compatible with both
      traditional and UAL syntax. but for byte/halfword loads and stores,
      there seems to be no mnemonic compatible with both, and thus .word is
      used to produce the desired opcode explicitly. the .inst directive is
      not used because it is not compatible with older assemblers.
      9367fe92
    • J
      arm assembly changes for clang compatibility · 27828f7e
      Joakim Sindholt 提交于
      27828f7e
  14. 23 11月, 2014 1 次提交
    • R
      unify non-inline version of syscall code across archs · 4134c68d
      Rich Felker 提交于
      except powerpc, which still lacks inline syscalls simply because
      nobody has written the code, these are all fallbacks used to work
      around a clang bug that probably does not exist in versions of clang
      that can compile musl. however, it's useful to have the generic
      non-inline code anyway, as it eases the task of porting to new archs:
      writing inline syscall code is now optional. this approach could also
      help support compilers which don't understand inline asm or lack
      support for the needed register constraints.
      
      mips could not be unified because it has special fixup code for broken
      layout of the kernel's struct stat.
      4134c68d