- 12 9月, 2011 2 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
on spurious wakeups/returns from __timedwait, pthread_join would "succeed" and unmap the thread's stack while it was still running. at best this would lead to SIGSEGV when the thread resumed execution, but in the worst case, the thread would later resume executing on top of another new thread's stack mapped at the same address. spent about 4 hours tracking this bug down, chasing rare difficult-to-reproduce stack corruption in a stress test program. still no idea *what* caused the spurious wakeups; i suspect it's a kernel bug.
-
- 10 9月, 2011 1 次提交
-
-
由 Rich Felker 提交于
this seeme to be the bug that prevented enabling of private futex support. i'm going to hold off on switching to private futexes until after the next release, and until i get a chance to audit all wait/wake calls to make sure they're using the correct private argument, but with this change it should be safe to enable private futex support.
-
- 09 9月, 2011 1 次提交
-
-
由 Rich Felker 提交于
some features are not yet supported, and only minimal testing has been performed. should be considered experimental at this point.
-
- 06 9月, 2011 2 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-
- 05 9月, 2011 5 次提交
-
-
由 Rich Felker 提交于
null termination is only added when current size grows. in update modes, null termination is not added if it does not fit (i.e. it is not allowed to clobber data). these rules make very little sense, but that's how it goes..
-
由 Rich Felker 提交于
read should not be allowed past "current size". append mode should write at "current size", not buffer size. null termination should not be written except when "current size" grows.
-
由 Rich Felker 提交于
this is not strictly required by the standard, but without it, there is a race condition where cancellation arriving just before async cancellation is enabled might not be acted upon. it is impossible for a conforming application to work around this race condition since calling pthread_testcancel after setting async cancellation mode is not allowed (pthread_testcancel is not specified to be async-cancel-safe). thus the implementation should be responsible for eliminating the race, from a quality-of-implementation standpoint.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
disallow seek past end of buffer (per posix) fix position accounting to include data buffered for read don't set eof flag when no data was requested
-
- 04 9月, 2011 7 次提交
-
-
由 Rich Felker 提交于
the addition is safe and cannot overflow because both operands are positive when considered as signed quantities.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
the expression -off is not safe in case off is the most-negative value. instead apply - to base which is known to be non-negative and bounded within sanity.
-
由 Rich Felker 提交于
testing so far has been minimal. may need further work.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
not heavily tested, but it seems to be correct, including the odd behavior that seeking is in terms of wide character count. this precludes any simple buffering, so we just make the stream unbuffered.
-
由 Rich Felker 提交于
the return address was being truncated to 32 bits, preventing the dlsym code from determining which module contains the calling code.
-
- 03 9月, 2011 2 次提交
-
-
由 Rich Felker 提交于
this is the first attempt, and may have bugs. only minimal testing has been performed.
-
由 Rich Felker 提交于
-
- 28 8月, 2011 1 次提交
-
-
由 Rich Felker 提交于
1 is too small if int is 32-bit but unsigned long is 64-bit. be explicit and use 1UL.
-
- 24 8月, 2011 1 次提交
-
-
由 Rich Felker 提交于
its existence doesn't hurt anything, and dynamic-linked binaries using previous versions of musl were wrongly binding to it instead of __environ.
-
- 23 8月, 2011 2 次提交
-
-
由 Rich Felker 提交于
gcc generates extremely bad code (7 byte immediate mov) for the old null pointer write approach. it should be generating something like "xor %eax,%eax ; mov %al,(%eax)". in any case, using a dedicated crashing opcode accomplishes the same thing in one byte.
-
由 Rich Felker 提交于
this behavior (opening fds 0-2 for a suid program) is explicitly allowed (but not required) by POSIX to protect badly-written suid programs from clobbering files they later open. this commit does add some cost in startup code, but the availability of auxv and the security flag will be useful elsewhere in the future. in particular auxv is needed for static-linked vdso support, which is still waiting to be committed (sorry nik!)
-
- 17 8月, 2011 2 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-
- 16 8月, 2011 5 次提交
-
-
由 Rich Felker 提交于
it's missing at least: - derived fields - week numbers - short year (without century) support - locale modifiers
-
由 Rich Felker 提交于
this does not change behavior, but the idea is to avoid letting other code build up between these two points, whereby the environment variables might get used before security it checked.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
the asm wrapper is needed to get the return address without compiler-specific extensions.
-
由 Rich Felker 提交于
-
- 15 8月, 2011 3 次提交
-
-
由 Rich Felker 提交于
a valid mmapped block will have an even (actually aligned) "extra" field, whereas a freed chunk on the heap will always have an in-use neighbor. this fixes a potential bug if mmap ever allocated memory below the main program/brk (in which case it would be wrongly-detected as a double-free by the old code) and allows the double-free check to work for donated memory outside of the brk area (or, in the future, secondary heap zones if support for their creation is added).
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
no sense bloating apps with a function call for an equality comparison...
-
- 13 8月, 2011 2 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
it previously was returning the pseudo-monotonic-realtime clock returned by times() rather than process cputime. it also violated C namespace by pulling in times(). we now use clock_gettime() if available because times() has ridiculously bad resolution. still provide a fallback for ancient kernels without clock_gettime.
-
- 12 8月, 2011 4 次提交
-
-
由 Rich Felker 提交于
this is a "nonstandard" function that was "rejected" by POSIX, but nonetheless had its behavior documented in the POSIX rationale for fork. it's present on solaris and possibly some other systems, and duplicates the whole calling process, not just a single thread. glibc does not have this function. it should not be used in programs intending to be portable, but may be useful for testing, checkpointing, etc. and it's an interesting (and quite small) example of the usefulness of the __synccall framework originally written to work around deficiencies in linux's setuid syscall.
-
由 Rich Felker 提交于
fix up clone signature to match the actual behavior. the new __syncall_wait function allows a __synccall callback to wait for other threads to continue without returning, so that it can resume action after the caller finishes. this interface could be made significantly more general/powerful with minimal effort, but i'll wait to do that until it's actually useful for something.
-
由 Rich Felker 提交于
due to the barrier, it's safe just to block signals in the new thread, rather than blocking and unblocking in the parent thread.
-
由 Rich Felker 提交于
-