1. 23 7月, 2013 1 次提交
    • R
      change wint_t to unsigned · c4dd0c98
      Rich Felker 提交于
      aside from the obvious C++ ABI purpose for this change, it also brings
      musl into alignment with the compiler's idea of the definition of
      wint_t (use in -Wformat), and makes the situation less awkward on ARM,
      where wchar_t is unsigned.
      
      internal code using wint_t and WEOF was checked against this change,
      and while a few cases of storing WEOF into wchar_t were found, they
      all seem to operate properly with the natural conversion from unsigned
      to signed.
      c4dd0c98
  2. 22 7月, 2013 1 次提交
    • R
      refactor headers, especially alltypes.h, and improve C++ ABI compat · 9448b051
      Rich Felker 提交于
      the arch-specific bits/alltypes.h.sh has been replaced with a generic
      alltypes.h.in and minimal arch-specific bits/alltypes.h.in.
      
      this commit is intended to have no functional changes except:
      - exposing additional symbols that POSIX allows but does not require
      - changing the C++ name mangling for some types
      - fixing the signedness of blksize_t on powerpc (POSIX requires signed)
      - fixing the limit macros for sig_atomic_t on x86_64
      - making dev_t an unsigned type (ABI matching goal, and more logical)
      
      in addition, some types that were wrongly defined with long on 32-bit
      archs were changed to int, and vice versa; this change is
      non-functional except for the possibility of making pointer types
      mismatch, and only affects programs that were using them incorrectly,
      and only at build-time, not runtime.
      
      the following changes were made in the interest of moving
      non-arch-specific types out of the alltypes system and into the
      headers they're associated with, and also will tend to improve
      application compatibility:
      - netdb.h now includes netinet/in.h (for socklen_t and uint32_t)
      - netinet/in.h now includes sys/socket.h and inttypes.h
      - sys/resource.h now includes sys/time.h (for struct timeval)
      - sys/wait.h now includes signal.h (for siginfo_t)
      - langinfo.h now includes nl_types.h (for nl_item)
      
      for the types in stdint.h:
      - types which are of no interest to other headers were moved out of
        the alltypes system.
      - fast types for 8- and 64-bit are hard-coded (at least for now); only
        the 16- and 32-bit ones have reason to vary by arch.
      
      and the following types have been changed for C++ ABI purposes;
      - mbstate_t now has a struct tag, __mbstate_t
      - FILE's struct tag has been changed to _IO_FILE
      - DIR's struct tag has been changed to __dirstream
      - locale_t's struct tag has been changed to __locale_struct
      - pthread_t is defined as unsigned long in C++ mode only
      - fpos_t now has a struct tag, _G_fpos64_t
      - fsid_t's struct tag has been changed to __fsid_t
      - idtype_t has been made an enum type (also required by POSIX)
      - nl_catd has been changed from long to void *
      - siginfo_t's struct tag has been removed
      - sigset_t's has been given a struct tag, __sigset_t
      - stack_t has been given a struct tag, sigaltstack
      - suseconds_t has been changed to long on 32-bit archs
      - [u]intptr_t have been changed from long to int rank on 32-bit archs
      - dev_t has been made unsigned
      
      summary of tests that have been performed against these changes:
      - nsz's libc-test (diff -u before and after)
      - C++ ABI check symbol dump (diff -u before, after, glibc)
      - grepped for __NEED, made sure types needed are still in alltypes
      - built gcc 3.4.6
      9448b051
  3. 21 7月, 2013 6 次提交
    • R
      remove init/fini array asm from arm crti/crtn files · 976c0fdc
      Rich Felker 提交于
      this code has been replaced by portable C code that works on all
      archs. the old asm needs to be removed or ctors/dtors will run twice.
      976c0fdc
    • R
      remove __libc_csu_* cruft · 3edfd070
      Rich Felker 提交于
      these functions were mistakenly assumed to be needed to match glibc
      ABI, but glibc has them as part of the non-shared part of libc that's
      always statically linked into the main program. moreover, the only
      place they are referenced from is glibc's crt1.o.
      3edfd070
    • R
      add support for init/fini array in main program, and greatly simplify · 7586360b
      Rich Felker 提交于
      modern (4.7.x and later) gcc uses init/fini arrays, rather than the
      legacy _init/_fini function pasting and crtbegin/crtend ctors/dtors
      system, on most or all archs. some archs had already switched a long
      time ago. without following this change, global ctors/dtors will cease
      to work under musl when building with new gcc versions.
      
      the most surprising part of this patch is that it actually reduces the
      size of the init code, for both static and shared libc. this is
      achieved by (1) unifying the handling main program and shared
      libraries in the dynamic linker, and (2) eliminating the
      glibc-inspired rube goldberg machine for passing around init and fini
      function pointers. to clarify, some background:
      
      the function signature for __libc_start_main was based on glibc, as
      part of the original goal of being able to run some glibc-linked
      binaries. it worked by having the crt1 code, which is linked into
      every application, static or dynamic, obtain and pass pointers to the
      init and fini functions, which __libc_start_main is then responsible
      for using and recording for later use, as necessary. however, in
      neither the static-linked nor dynamic-linked case do we actually need
      crt1.o's help. with dynamic linking, all the pointers are available in
      the _DYNAMIC block. with static linking, it's safe to simply access
      the _init/_fini and __init_array_start, etc. symbols directly.
      
      obviously changing the __libc_start_main function signature in an
      incompatible way would break both old musl-linked programs and
      glibc-linked programs, so let's not do that. instead, the function can
      just ignore the information it doesn't need. new archs need not even
      provide the useless args in their versions of crt1.o. existing archs
      should continue to provide it as long as there is an interest in
      having newly-linked applications be able to run on old versions of
      musl; at some point in the future, this support can be removed.
      7586360b
    • R
      fix order of fini_array execution for shared libs · 1b413572
      Rich Felker 提交于
      1b413572
    • R
      e69ae844
    • R
      fix shm_open wrongly being cancellable · ce8a9957
      Rich Felker 提交于
      ce8a9957
  4. 20 7月, 2013 3 次提交
    • R
      fix uninitialized/stale use of alloc (%m modifier) flag in scanf · 1d92cddb
      Rich Felker 提交于
      for conversion specifiers, alloc is always set when the specifier is
      parsed. however, if scanf stops due to mismatching literal text,
      either an uninitialized (if no conversions have been performed yet) or
      stale (from the previous conversion) of the flag will be used,
      possibly causing an invalid pointer to be passed to free when the
      function returns.
      1d92cddb
    • R
      harden realloc/free to detect simple overflows · 8389520e
      Rich Felker 提交于
      the sizes in the header and footer for a chunk should always match. if
      they don't, the program has definitely invoked undefined behavior, and
      the most likely cause is a simple overflow, either of a buffer in the
      block being freed or the one just below it.
      
      crashing here should not only improve security of buggy programs, but
      also aid in debugging, since the crash happens in a context where you
      have a pointer to the likely-overflowed buffer.
      8389520e
    • R
      add UIO_MAXIOV macro in sys/uio.h · 41e2fd9d
      Rich Felker 提交于
      while there's no POSIX namespace provision for UIO_* in uio.h, this
      exact macro name is reserved in XBD 2.2.2. apparently some
      glibc-centric software expects it to exist, so let's provide it.
      41e2fd9d
  5. 19 7月, 2013 7 次提交
    • R
      improve [f]stat[v]fs functions, and possibly work around old kernels · 6567db65
      Rich Felker 提交于
      the main aim of this patch is to ensure that if not all fields are
      filled in, they contain zeros, so as not to confuse applications.
      reportedly some older kernels, including commonly used openvz kernels,
      lack the f_flags field, resulting in applications reading random junk
      as the mount flags; the common symptom seems to be wrongly considering
      the filesystem to be mounted read-only and refusing to operate. glibc
      has some amazingly ugly fallback code to get the mount flags for old
      kernels, but having them really is not that important anyway; what
      matters most is not presenting incorrect flags to the application.
      
      I have also aimed to fill in some fields of statvfs that were
      previously missing, and added code to explicitly zero the reserved
      space at the end of the structure, which will make things easier in
      the future if this space someday needs to be used.
      6567db65
    • R
      change uid_t, gid_t, and id_t to unsigned types · 648c3b4e
      Rich Felker 提交于
      this change is both to fix one of the remaining type (and thus C++
      ABI) mismatches with glibc/LSB and to allow use of the full range of
      uid and gid values, if so desired.
      
      passwd/group access functions were not prepared to deal with unsigned
      values, so they too have been fixed with this commit.
      648c3b4e
    • R
      fix invalid C in new trycppif tests in configure script · df065781
      Rich Felker 提交于
      an empty program is not valid and would be reasonable grounds for the
      compiler to give an error, which would break these tests.
      df065781
    • R
      3e7f186e
    • R
      make the dynamic linker find its path file relative to its own location · f389c498
      Rich Felker 提交于
      prior to this change, using a non-default syslibdir was impractical on
      systems where the ordinary library paths contain musl-incompatible
      library files. the file containing search paths was always taken from
      /etc, which would either correspond to a system-wide musl
      installation, or fail to exist at all, resulting in searching of the
      default library path.
      
      the new search strategy is safe even for suid programs because the
      pathname used comes from the PT_INTERP header of the program being
      run, rather than any external input.
      
      as part of this change, I have also begun differentiating the names of
      arch variants that differ by endianness or floating point calling
      convention. the corresponding changes in the build system and and gcc
      wrapper script (to use an alternate dynamic linker name) for these
      configurations have not yet been made.
      f389c498
    • R
    • R
      fix FILENAME_MAX to match PATH_MAX · b823ef2d
      Rich Felker 提交于
      POSIX is not clear on whether it includes the termination, but ISO C
      requires that it does. the whole concept of this macro is rather
      useless, but it's better to be correct anyway.
      b823ef2d
  6. 18 7月, 2013 2 次提交
    • R
      make spacing in x86_64 alltypes.h.sh more uniform with other archs · 2f5fe458
      Rich Felker 提交于
      patch by Luka Perkov, who noted that all other archs have a newline.
      2f5fe458
    • R
      make posix_spawn (and functions that use it) use CLONE_VFORK flag · b06dc666
      Rich Felker 提交于
      this is both a minor scheduling optimization and a workaround for a
      difficult-to-fix bug in qemu app-level emulation.
      
      from the scheduling standpoint, it makes no sense to schedule the
      parent thread again until the child has exec'd or exited, since the
      parent will immediately block again waiting for it.
      
      on the qemu side, as regular application code running on an underlying
      libc, qemu cannot make arbitrary clone syscalls itself without
      confusing the underlying implementation. instead, it breaks them down
      into either fork-like or pthread_create-like cases. it was treating
      the code in posix_spawn as pthread_create-like, due to CLONE_VM, which
      caused horribly wrong behavior: CLONE_FILES broke the synchronization
      mechanism, CLONE_SIGHAND broke the parent's signals, and CLONE_THREAD
      caused the child's exec to end the parent -- if it hadn't already
      crashed. however, qemu special-cases CLONE_VFORK and emulates that
      with fork, even when CLONE_VM is also specified. this also gives
      incorrect semantics for code that really needs the memory sharing, but
      posix_spawn does not make use of the vm sharing except to avoid
      momentary double commit charge.
      
      programs using posix_spawn (including via popen) should now work
      correctly under qemu app-level emulation.
      b06dc666
  7. 17 7月, 2013 4 次提交
  8. 14 7月, 2013 1 次提交
    • R
      fix omission of dtv setup in static linked programs on TLS variant I archs · f1292e3d
      Rich Felker 提交于
      apparently this was never noticed before because the linker normally
      optimizes dynamic TLS models to non-dynamic ones when static linking,
      thus eliminating the calls to __tls_get_addr which crash when the dtv
      is missing. however, some libsupc++ code on ARM was calling
      __tls_get_addr when static linked and crashing. the reason is unclear
      to me, but with this issue fixed it should work now anyway.
      f1292e3d
  9. 11 7月, 2013 3 次提交
  10. 09 7月, 2013 6 次提交
  11. 06 7月, 2013 1 次提交
  12. 05 7月, 2013 2 次提交
    • R
      move core memalign code from aligned_alloc to __memalign · 6d861ac8
      Rich Felker 提交于
      there are two motivations for this change. one is to avoid
      gratuitously depending on a C11 symbol for implementing a POSIX
      function. the other pertains to the documented semantics. C11 does not
      define any behavior for aligned_alloc when the length argument is not
      a multiple of the alignment argument. posix_memalign on the other hand
      places no requirements on the length argument. using __memalign as the
      implementation of both, rather than trying to implement one in terms
      of the other when their documented contracts differ, eliminates this
      confusion.
      6d861ac8
    • R
      move alignment check from aligned_alloc to posix_memalign · 65141618
      Rich Felker 提交于
      C11 has no requirement that the alignment be a multiple of
      sizeof(void*), and in fact seems to require any "valid alignment
      supported by the implementation" to work. since the alignment of char
      is 1 and thus a valid alignment, an alignment argument of 1 should be
      accepted.
      65141618
  13. 04 7月, 2013 3 次提交