1. 23 6月, 2015 1 次提交
    • R
      fix calloc when __simple_malloc implementation is used · ba819787
      Rich Felker 提交于
      previously, calloc's implementation encoded assumptions about the
      implementation of malloc, accessing a size_t word just prior to the
      allocated memory to determine if it was obtained by mmap to optimize
      out the zero-filling. when __simple_malloc is used (static linking a
      program with no realloc/free), it doesn't matter if the result of this
      check is wrong, since all allocations are zero-initialized anyway. but
      the access could be invalid if it crosses a page boundary or if the
      pointer is not sufficiently aligned, which can happen for very small
      allocations.
      
      this patch fixes the issue by moving the zero-fill logic into malloc.c
      with the full malloc, as a new function named __malloc0, which is
      provided by a weak alias to __simple_malloc (which always gives
      zero-filled memory) when the full malloc is not in use.
      ba819787
  2. 20 6月, 2015 2 次提交
    • R
      provide __stack_chk_fail_local in libc.a · 55d061f0
      Rich Felker 提交于
      this symbol is needed only on archs where the PLT call ABI is klunky,
      and only for position-independent code compiled with stack protector.
      thus references usually only appear in shared libraries or PIE
      executables, but they can also appear when linking statically if some
      of the object files being linked were built as PIC/PIE.
      
      normally libssp_nonshared.a from the compiler toolchain should provide
      __stack_chk_fail_local, but reportedly it appears prior to -lc in the
      link order, thus failing to satisfy references from libc itself (which
      arise only if libc.a was built as PIC/PIE with stack protector
      enabled).
      55d061f0
    • R
      work around mips detached thread exit breakage due to kernel regression · ce3688ec
      Rich Felker 提交于
      linux kernel commit 46e12c07b3b9603c60fc1d421ff18618241cb081 caused
      the mips syscall mechanism to fail with EFAULT when the userspace
      stack pointer is invalid, breaking __unmapself used for detached
      thread exit. the workaround is to set $sp to a known-valid, readable
      address, and the simplest one to obtain is the address of the current
      function, which is available (per o32 calling convention) in $25.
      ce3688ec
  3. 18 6月, 2015 1 次提交
  4. 16 6月, 2015 8 次提交
    • R
      switch to using trap number 31 for syscalls on sh · 10d0268c
      Rich Felker 提交于
      nominally the low bits of the trap number on sh are the number of
      syscall arguments, but they have never been used by the kernel, and
      some code making syscalls does not even know the number of arguments
      and needs to pass an arbitrary high number anyway.
      
      sh3/sh4 traditionally used the trap range 16-31 for syscalls, but part
      of this range overlapped with hardware exceptions/interrupts on sh2
      hardware, so an incompatible range 32-47 was chosen for sh2.
      
      using trap number 31 everywhere, since it's in the existing sh3/sh4
      range and does not conflict with sh2 hardware, is a proposed
      unification of the kernel syscall convention that will allow binaries
      to be shared between sh2 and sh3/sh4. if this is not accepted into the
      kernel, we can refit the sh2 target with runtime selection mechanisms
      for the trap number, but doing so would be invasive and would entail
      non-trivial overhead.
      10d0268c
    • R
      switch sh port's __unmapself to generic version when running on sh2/nommu · 3366a99b
      Rich Felker 提交于
      due to the way the interrupt and syscall trap mechanism works,
      userspace on sh2 must never set the stack pointer to an invalid value.
      thus, the approach used on most archs, where __unmapself executes with
      no stack for the interval between SYS_munmap and SYS_exit, is not
      viable on sh2.
      
      in order not to pessimize sh3/sh4, the sh asm version of __unmapself
      is not removed. instead it's renamed and redirected through code that
      calls either the generic (safe) __unmapself or the sh3/sh4 asm,
      depending on compile-time and run-time conditions.
      3366a99b
    • R
      add support for sh2 interrupt-masking-based atomics to sh port · f9d84554
      Rich Felker 提交于
      the sh2 target is being considered an ISA subset of sh3/sh4, in the
      sense that binaries built for sh2 are intended to be usable on later
      cpu models/kernels with mmu support. so rather than hard-coding
      sh2-specific atomics, the runtime atomic selection mechanisms that was
      already in place has been extended to add sh2 atomics.
      
      at this time, the sh2 atomics are not SMP-compatible; since the ISA
      lacks actual atomic operations, the new code instead masks interrupts
      for the duration of the atomic operation, producing an atomic result
      on single-core. this is only possible because the kernel/hardware does
      not impose protections against userspace doing so. additional changes
      will be needed to support future SMP systems.
      
      care has been taken to avoid producing significant additional code
      size in the case where it's known at compile-time that the target is
      not sh2 and does not need sh2-specific code.
      f9d84554
    • R
      refactor stdio open file list handling, move it out of global libc struct · 1b0cdc87
      Rich Felker 提交于
      functions which open in-memory FILE stream variants all shared a tail
      with __fdopen, adding the FILE structure to stdio's open file list.
      replacing this common tail with a function call reduces code size and
      duplication of logic. the list is also partially encapsulated now.
      
      function signatures were chosen to facilitate tail call optimization
      and reduce the need for additional accessor functions.
      
      with these changes, static linked programs that do not use stdio no
      longer have an open file list at all.
      1b0cdc87
    • R
      byte-based C locale, phase 3: make MB_CUR_MAX variable to activate code · f22a9eda
      Rich Felker 提交于
      this patch activates the new byte-based C locale (high bytes treated
      as abstract code unit "characters" rather than decoded as multibyte
      characters) by making the value of MB_CUR_MAX depend on the active
      locale. for the C locale, the LC_CTYPE category pointer is null,
      yielding a value of 1. all other locales yield a value of 4.
      f22a9eda
    • R
      byte-based C locale, phase 2: stdio and iconv (multibyte callers) · 16f18d03
      Rich Felker 提交于
      this patch adjusts libc components which use the multibyte functions
      internally, and which depend on them operating in a particular
      encoding, to make the appropriate locale changes before calling them
      and restore the calling thread's locale afterwards. activating the
      byte-based C locale without these changes would cause regressions in
      stdio and iconv.
      
      in the case of iconv, the current implementation was simply using the
      multibyte functions as UTF-8 conversions. setting a multibyte UTF-8
      locale for the duration of the iconv operation allows the code to
      continue working.
      
      in the case of stdio, POSIX requires that FILE streams have an
      encoding rule bound at the time of setting wide orientation. as long
      as all locales, including the C locale, used the same encoding,
      treating high bytes as UTF-8, there was no need to store an encoding
      rule as part of the stream's state.
      
      a new locale field in the FILE structure points to the locale that
      should be made active during fgetwc/fputwc/ungetwc on the stream. it
      cannot point to the locale active at the time the stream becomes
      oriented, because this locale could be mutable (the global locale) or
      could be destroyed (locale_t objects produced by newlocale) before the
      stream is closed. instead, a pointer to the static C or C.UTF-8 locale
      object added in commit commit aeeac9ca
      is used. this is valid since categories other than LC_CTYPE will not
      affect these functions.
      16f18d03
    • R
      byte-based C locale, phase 1: multibyte character handling functions · 1507ebf8
      Rich Felker 提交于
      this patch makes the functions which work directly on multibyte
      characters treat the high bytes as individual abstract code units
      rather than as multibyte sequences when MB_CUR_MAX is 1. since
      MB_CUR_MAX is presently defined as a constant 4, all of the new code
      added is dead code, and optimizing compilers' code generation should
      not be affected at all. a future commit will activate the new code.
      
      as abstract code units, bytes 0x80 to 0xff are represented by wchar_t
      values 0xdf80 to 0xdfff, at the end of the surrogates range. this
      ensures that they will never be misinterpreted as Unicode characters,
      and that all wctype functions return false for these "characters"
      without needing locale-specific logic. a high range outside of Unicode
      such as 0x7fffff80 to 0x7fffffff was also considered, but since C11's
      char16_t also needs to be able to represent conversions of these
      bytes, the surrogate range was the natural choice.
      1507ebf8
    • R
      fix btowc corner case · 38e2f727
      Rich Felker 提交于
      btowc is required to interpret its argument by conversion to unsigned
      char, unless the argument is equal to EOF. since the conversion to
      produces a non-character value anyway, we can just unconditionally
      convert, for now.
      38e2f727
  5. 14 6月, 2015 3 次提交
    • S
      arm: add vdso support · ee59c296
      Szabolcs Nagy 提交于
      vdso will be available on arm in linux v4.2, the user-space code
      for it is in kernel commit 8512287a8165592466cb9cb347ba94892e9c56a5
      ee59c296
    • R
      refactor malloc's expand_heap to share with __simple_malloc · e3bc22f1
      Rich Felker 提交于
      this extends the brk/stack collision protection added to full malloc
      in commit 276904c2 to also protect the
      __simple_malloc function used in static-linked programs that don't
      reference the free function.
      
      it also extends support for using mmap when brk fails, which full
      malloc got in commit 54463033, to
      __simple_malloc.
      
      since __simple_malloc may expand the heap by arbitrarily large
      increments, the stack collision detection is enhanced to detect
      interval overlap rather than just proximity of a single address to the
      stack. code size is increased a bit, but this is partly offset by the
      sharing of code between the two malloc implementations, which due to
      linking semantics, both get linked in a program that needs the full
      malloc with realloc/free support.
      e3bc22f1
    • R
      remove cancellation points in stdio · 4ef9b828
      Rich Felker 提交于
      commit 58165923 added these optional
      cancellation points on the basis that cancellable stdio could be
      useful, to unblock threads stuck on stdio operations that will never
      complete. however, the only way to ensure that cancellation can
      achieve this is to violate the rules for side effects when
      cancellation is acted upon, discarding knowledge of any partial data
      transfer already completed. our implementation exhibited this behavior
      and was thus non-conforming.
      
      in addition to improving correctness, removing these cancellation
      points moderately reduces code size, and should significantly improve
      performance on i386, where sysenter/syscall instructions can be used
      instead of "int $128" for non-cancellable syscalls.
      4ef9b828
  6. 13 6月, 2015 3 次提交
    • R
      fix idiom for setting stdio stream orientation to wide · 536c6d5a
      Rich Felker 提交于
      the old idiom, f->mode |= f->mode+1, was adapted from the idiom for
      setting byte orientation, f->mode |= f->mode-1, but the adaptation was
      incorrect. unless the stream was alreasdy set byte-oriented, this code
      incremented f->mode each time it was executed, which would eventually
      lead to overflow. it could be fixed by changing it to f->mode |= 1,
      but upcoming changes will require slightly more work at the time of
      wide orientation, so it makes sense to just call fwide. as an
      optimization in the single-character functions, fwide is only called
      if the stream is not already wide-oriented.
      536c6d5a
    • R
      add printing of null %s arguments as "(null)" in wide printf · f8f565df
      Rich Felker 提交于
      this is undefined, but supported in our implementation of the normal
      printf, so for consistency the wide variant should support it too.
      f8f565df
    • R
      add %m support to wide printf · f9e25d81
      Rich Felker 提交于
      f9e25d81
  7. 11 6月, 2015 1 次提交
  8. 10 6月, 2015 3 次提交
    • R
      implement arch-generic version of __unmapself · c30cbcb0
      Rich Felker 提交于
      this can be used to put off writing an asm version of __unmapself for
      new archs, or as a permanent solution on archs where it's not
      practical or even possible to run momentarily with no stack.
      
      the concept here is simple: the caller takes a lock on a global shared
      stack and uses it to make the munmap and exit syscalls. the only trick
      is unlocking, which must be done after the thread exits, and this is
      achieved by using the set_tid_address syscall to have the kernel zero
      and futex-wake the lock word as part of the exit syscall.
      c30cbcb0
    • R
      in malloc, refuse to use brk if it grows into stack · 276904c2
      Rich Felker 提交于
      the linux/nommu fdpic ELF loader sets up the brk range to overlap
      entirely with the main thread's stack (but growing from opposite
      ends), so that the resulting failure mode for malloc is not to return
      a null pointer but to start returning pointers to memory that overlaps
      with the caller's stack. needless to say this extremely dangerous and
      makes brk unusable.
      
      since it's non-trivial to detect execution environments that might be
      affected by this kernel bug, and since the severity of the bug makes
      any sort of detection that might yield false-negatives unsafe, we
      instead check the proximity of the brk to the stack pointer each time
      the brk is to be expanded. both the main thread's stack (where the
      real known risk lies) and the calling thread's stack are checked. an
      arbitrary gap distance of 8 MB is imposed, chosen to be larger than
      linux default main-thread stack reservation sizes and larger than any
      reasonable stack configuration on nommu.
      
      the effeciveness of this patch relies on an assumption that the amount
      by which the brk is being grown is smaller than the gap limit, which
      is always true for malloc's use of brk. reliance on this assumption is
      why the check is being done in malloc-specific code and not in __brk.
      276904c2
    • R
      fix spurious errors from pwd/grp functions when nscd backend is absent · bd1eacea
      Rich Felker 提交于
      for several pwd/grp functions, the only way the caller can distinguish
      between a successful negative result ("no such user/group") and an
      internal error is by clearing errno before the call and checking errno
      afterwards. the nscd backend support code correctly simulated a
      not-found response on systems where such a backend is not running, but
      failed to restore errno.
      
      this commit also fixed an outdated/incorrect comment.
      bd1eacea
  9. 08 6月, 2015 1 次提交
    • R
      fix regression in pre-v7 arm on kernels with kuser helper removed · 75ce4503
      Rich Felker 提交于
      the arm atomics/TLS runtime selection code is called from
      __set_thread_area and depends on having libc.auxv and __hwcap
      available. commit 71f099cb moved the
      first call to __set_thread_area to the top of dynamic linking stage 3,
      before this data is made available, causing the runtime detection code
      to always see __hwcap as zero and thereby select the atomics/TLS
      implementations based on kuser helper.
      
      upcoming work on superh will use similar runtime detection.
      
      ideally this early-init code should be cleanly refactored and shared
      between the dynamic linker and static-linked startup.
      75ce4503
  10. 07 6月, 2015 6 次提交
  11. 05 6月, 2015 2 次提交
  12. 04 6月, 2015 1 次提交
    • R
      fix dynamic linker regression processing R_*_NONE type relocations · b6a6cd70
      Rich Felker 提交于
      commit f3ddd173 inadvertently removed
      the early check for "none" type relocations, causing the address
      dso->base+0 to be dereferenced to obtain an addend. shared libraries,
      (including libc.so) and PIE executables were unaffected, since their
      base addresses are the actual address of their mappings and are
      readable. non-PIE main executables, however, have a base address of 0
      because their load addresses are absolute and not offset at load time.
      
      in practice none-type relocations do not arise with toolchains that
      are in use except on mips, and on mips it's moderately rare for a
      non-PIE executable to have a relocation table, since the mips-specific
      got processing serves in its place for most purposes.
      b6a6cd70
  13. 03 6月, 2015 1 次提交
  14. 29 5月, 2015 2 次提交
    • R
      fix failure of ungetc and ungetwc to work on files in eof status · 2b4fcfda
      Rich Felker 提交于
      these functions were written to handle clearing eof status, but failed
      to account for the __toread function's handling of eof. with this
      patch applied, __toread still returns EOF when the file is in eof
      status, so that read operations will fail, but it also sets up valid
      buffer pointers for read mode, which are set to the end of the buffer
      rather than the beginning in order to make the whole buffer available
      to ungetc/ungetwc.
      
      minor changes to __uflow were needed since it's now possible to have
      non-zero buffer pointers while in eof status. as made, these changes
      remove a 'fast path' bypassing the function call to __toread, which
      could be reintroduced with slightly different logic, but since
      ordinary files have a syscall in f->read, optimizing the code path
      does not seem worthwhile.
      
      the __stdio_read function is also updated not to zero the read buffer
      pointers on eof/error. while not necessary for correctness, this
      change avoids the overhead of calling __toread in ungetc after
      reaching eof, and it also reduces code size and increases consistency
      with the fmemopen read operation which does not zero the pointers.
      2b4fcfda
    • R
      add missing legacy LFS64 macros in sys/resource.h · b6e7c664
      Rich Felker 提交于
      based on patch by Felix Janda, with RLIM64_SAVED_CUR and
      RLIM64_SAVED_MAX added for completeness.
      b6e7c664
  15. 28 5月, 2015 2 次提交
    • S
      configure: work around compilers that merely warn for unknown options · fc431d3f
      Shiz 提交于
      some compilers (such as clang) accept unknown options without error,
      but then print warnings on each invocation, cluttering the build
      output and burying meaningful warnings. this patch makes configure's
      tryflag and tryldflag functions use additional options to turn the
      unknown-option warnings into errors, if available, but only at check
      time. these options are not output in config.mak to avoid the risk of
      spurious build breakage; if they work, they will have already done
      their job at configure time.
      fc431d3f
    • R
      implement fail-safe static locales for newlocale · aeeac9ca
      Rich Felker 提交于
      this frees applications which need to make temporary use of the C
      locale (via uselocale) from the possibility that newlocale might fail.
      
      the C.UTF-8 locale is also provided as a static locale. presently they
      behave the same, but this may change in the future.
      aeeac9ca
  16. 27 5月, 2015 3 次提交
    • R
      rename internal locale file handling locale maps · 11858d31
      Rich Felker 提交于
      since the __setlocalecat function was removed, the filename
      __setlocalecat.c no longer made sense.
      11858d31
    • R
      overhaul locale internals to treat categories roughly uniformly · 61a3364d
      Rich Felker 提交于
      previously, LC_MESSAGES was treated specially as the only category
      which could be set to a locale name without a definition file, in
      order to facilitate gettext message translations when no libc locale
      was available. LC_NUMERIC was completely un-settable, and LC_CTYPE
      stored a flag intended to be used for a possible future byte-based C
      locale, instead of storing a __locale_map pointer like the other
      categories use.
      
      this patch changes all categories to be represented by pointers to
      __locale_map structures, and allows locale names without definition
      files to be treated as valid locales with trivial definition when used
      in any category. outwardly visible functional changes should be minor,
      limited mainly to the strings read back from setlocale and the way
      gettext handles translations in categories other than LC_MESSAGES.
      
      various internal refactoring has also been performed, and improvements
      in const correctness have been made.
      61a3364d
    • R
      replace atomics with locks in locale-setting code · 63c188ec
      Rich Felker 提交于
      this is part of a general program of removing direct use of atomics
      where they are not necessary to meet correctness or performance needs,
      but in this case it's also an optimization. only the global locale
      needs synchronization; allocated locales referenced with locale_t
      handles are immutable during their lifetimes, and using atomics to
      initialize them increases their cost of setup.
      63c188ec