1. 22 4月, 2015 15 次提交
    • R
      minor optimization to pthread_spin_trylock · afbcac68
      Rich Felker 提交于
      use CAS instead of swap since it's lighter for most archs, and keep
      EBUSY in the lock value so that the old value obtained by CAS can be
      used directly as the return value for pthread_spin_trylock.
      afbcac68
    • R
      7b1fb0c5
    • R
      in visibility preinclude, remove overrides for stdin/stdout/stderr · b8dda24f
      Rich Felker 提交于
      the motivation for this change is that the extra declaration (with or
      without visibility) using "struct _IO_FILE" instead of "FILE" seems to
      trigger a bug in gcc 3.x where it considers the types mismatched.
      however, this change also results in slightly better code and it is
      valid because (1) these three objects are constant, and (2) applying
      the & operator to any of them is invalid C, since they are not even
      specified to be objects. thus it does not matter if the application
      and libc see different addresses for them, as long as the (initial,
      unchanging) value is seen the same by both.
      b8dda24f
    • R
      fix inconsistent visibility for __hwcap and __sysinfo symbols · f203b351
      Rich Felker 提交于
      these are used as hidden by asm files (and such use is the whole
      reason they exist), but their actual definitions were not hidden.
      f203b351
    • R
      remove additional libc struct accessor cruft · 3e827b7e
      Rich Felker 提交于
      commit f9cccfc1 left behind the part
      in libc.c; remove it too.
      3e827b7e
    • R
      remove useless visibility application from static-linking-only code · c267fb84
      Rich Felker 提交于
      part of the goal here is to eliminate use of the ATTR_LIBC_VISIBILITY
      macro outside of libc.h, since it was never intended to be 'public'.
      c267fb84
    • R
      9d836f44
    • R
      remove cruft for libc struct accessor function and broken visibility · f9cccfc1
      Rich Felker 提交于
      these were hacks to work around toolchains that could not properly
      optimize PIC accesses based on visibility and would generate GOT
      lookups even for hidden data, which broke the old dynamic linker.
      since commit f3ddd173 it no longer
      matters; the dynamic linker does not assume accessibility of this data
      until stage 3.
      f9cccfc1
    • R
      make configure check for visibility preinclude compatible with pcc · 428462a4
      Rich Felker 提交于
      pcc does not search for -include relative to the working directory
      unless -I. is used. rather than adding -I., which could be problematic
      if there's extra junk in the top-level directory, switch back to the
      old method (reverting commit 60ed988f)
      of using -include vis.h and relying on -I./src/internal being present
      on the command line (which the Makefile guarantees). to fix the
      breakage that was present in trycppif checks with the old method,
      $CFLAGS_AUTO is removed from the command line passed to trycppif; this
      is valid since $CFLAGS_AUTO should not contain options that alter
      compiler semantics or ABI, only optimizations, warnings, etc.
      428462a4
    • R
      fix duplocale clobbering of new locale struct with memcpy of old · 873e0ec7
      Rich Felker 提交于
      when the non-stub duplocale code was added as part of the locale
      framework in commit 0bc03091, the old
      code to memcpy the old locale object to the new one was left behind.
      the conditional for the memcpy no longer makes sense, because the
      conditions are now always-true when it's reached, and the memcpy is
      wrong because it clobbers the new->messages_name pointer setup just
      above.
      
      since the messages_name and ctype_utf8 members have already been
      copied, all that remains is the cat[] array. these pointers are
      volatile, so using memcpy to copy them is formally wrong; use a for
      loop instead.
      873e0ec7
    • A
      configure: check for -march and -mtune passed via CC · a6274a19
      Andre McCurdy 提交于
      Some build environments pass -march and -mtune as part of CC, therefore
      update configure to check both CC and CFLAGS before making the decision
      to fall back to generic -march and -mtune options for x86.
      Signed-off-by: NAndre McCurdy <armccurdy@gmail.com>
      a6274a19
    • R
      remove dead case for F_SETLKW in fcntl · ea1b6bb6
      Rich Felker 提交于
      the first switch already returns in the F_SETLKW code path so it need
      not be handled in the second switch. moreover the code in the second
      switch is wrong for the F_SETLKW command: it's not cancellable.
      ea1b6bb6
    • R
      fix mmap leak in sem_open failure path for link call · 086793ad
      Rich Felker 提交于
      the leak was found by static analysis (reported by Alexander Monakov),
      not tested/observed, but seems to have occured both when failing due
      to O_EXCL, and in a race condition with O_CREAT but not O_EXCL where a
      semaphore by the same name was created concurrently.
      086793ad
    • R
      remove always-true conditional in dynamic linker TLSDESC processing · c5ab5bd3
      Rich Felker 提交于
      the allocating path which can fail is for dynamic TLS, which can only
      occur at runtime, and the check for runtime was already made in the
      outer conditional.
      c5ab5bd3
    • R
      remove redundant code in do_dlsym function · 97b72d22
      Rich Felker 提交于
      commit 637dd2d3 introduced the checks
      for RTLD_DEFAULT and RTLD_NEXT here, claiming they fixed a regression,
      but the above conditional block clearly already covered these cases,
      and removing the checks produces no difference in the generated code.
      97b72d22
  2. 21 4月, 2015 2 次提交
  3. 20 4月, 2015 5 次提交
    • R
      add optional global visibility override · de2b67f8
      Rich Felker 提交于
      this is implemented via the build system and does not affect source
      files. the idea is to use protected or hidden visibility to prevent
      the compiler from pessimizing function calls within a shared (or
      position-independent static) libc in the form of overhead setting up
      for a call through the PLT. the ld-time symbol binding via the
      -Bsymbolic-functions option already optimized out the PLT itself, but
      not the code in the caller needed to support a call through the PLT.
      on some archs this overhead can be substantial; on others it's
      trivial.
      de2b67f8
    • R
      remove invalid PLT calls from or1k asm · 51fc77c7
      Rich Felker 提交于
      analogous to commit 646cb9a4 for sh.
      51fc77c7
    • R
      remove possible-textrels from powerpc asm · cf1a9d9d
      Rich Felker 提交于
      these are perfectly fine with ld-time symbol binding, but otherwise
      result in textrels. they cannot be replaced with @PLT jump targets
      because the PLT thunks require a GOT register to be setup, so use a
      hidden alias instead.
      cf1a9d9d
    • R
      remove invalid PLT calls from microblaze asm · a880e6ce
      Rich Felker 提交于
      analogous to commit 646cb9a4 for sh.
      a880e6ce
    • R
      remove invalid PLT calls from sh asm · 646cb9a4
      Rich Felker 提交于
      these are perfectly fine with ld-time symbol binding, but if the calls
      go through a PLT thunk, they are invalid because the caller does not
      setup a GOT register. use a hidden alias to bypass the issue.
      646cb9a4
  4. 19 4月, 2015 4 次提交
  5. 18 4月, 2015 14 次提交