1. 27 11月, 2013 2 次提交
    • R
      adjust fallback INFINITY definition for FLT_EVAL_METHOD==2 case · a663c930
      Rich Felker 提交于
      on archs with excess precision, the floating point constant 1e40f may
      be evaluated such that it does not actually produce an infinity.
      1e5000f is sufficiently large to produce an infinity for all supported
      floating point formats. note that this definition of INFINITY is only
      used for old or non-GNUC compilers anyway; despite being a portable,
      conforming definition, it leads to erroneous warnings on many
      compilers and thus using the builtin is preferred.
      a663c930
    • R
      fix off-by-one length failure in strftime/wcsftime and improve error behavior · f63b8c8c
      Rich Felker 提交于
      these functions were spuriously failing in the case where the buffer
      size was exactly the number of bytes/characters to be written,
      including null termination. since these functions do not have defined
      error conditions other than buffer size, a reasonable application may
      fail to check the return value when the format string and buffer size
      are known to be valid; such an application could then attempt to use a
      non-terminated buffer.
      
      in addition to fixing the bug, I have changed the error handling
      behavior so that these functions always null-terminate the output
      except in the case where the buffer size is zero, and so that they
      always write as many characters as possible before failing, rather
      than dropping whole fields that do not fit. this actually simplifies
      the logic somewhat anyway.
      f63b8c8c
  2. 26 11月, 2013 1 次提交
  3. 25 11月, 2013 3 次提交
    • R
      restore type of NULL to void * except when used in C++ programs · c8a9c221
      Rich Felker 提交于
      unfortunately this eliminates the ability of the compiler to diagnose
      some dangerous/incorrect usage, but POSIX requires (as an extension to
      the C language, i.e. CX shaded) that NULL have type void *. plain C
      allows it to be defined as any null pointer constant.
      
      the definition 0L is preserved for C++ rather than reverting to plain
      0 to avoid dangerous behavior in non-conforming programs which use
      NULL as a variadic sentinel. (it's impossible to use (void *)0 for C++
      since C++ lacks the proper implicit pointer conversions, and other
      popular alternatives like the GCC __null extension seem non-conforming
      to the standard's requirements.)
      c8a9c221
    • M
      shadow: Implement fgetspent · 7e771e62
      Michael Forney 提交于
      7e771e62
    • M
      shadow: Move spent parsing to internal function · b3646b30
      Michael Forney 提交于
      b3646b30
  4. 24 11月, 2013 12 次提交
  5. 23 11月, 2013 5 次提交
    • R
      timeradd/timersub: cast result to void to get rid of warnings · 8ff810d7
      rofl0r 提交于
      previously:
      timersub(&now, t, &diff);
      
      warning: value computed is not used [-Wunused-value]
      8ff810d7
    • R
      fix and refactor child reaping logic in wordexp · aeea71dc
      Rich Felker 提交于
      loop condition was incorrect and confusing and caused an infinite loop
      when (broken) applications reaped the pid from a signal handler or
      another thread before wordexp's call to waitpid could do so.
      aeea71dc
    • R
      caaf7d44
    • R
      fix resource exhaustion and zero-word cases in wordexp · 8253f59e
      Rich Felker 提交于
      when WRDE_NOSPACE is returned, the we_wordv and we_wordc members must
      be valid, because the interface contract allows them to return partial
      results.
      
      in the case of zero results (due either to resource exhaustion or a
      zero-word input) the we_wordv array still should contain a terminating
      null pointer and the initial we_offs null pointers. this is impossible
      on resource exhaustion, so a correct application must presumably check
      for a null pointer in we_wordv; POSIX however seems to ignore the
      issue. the previous code may have crashed under this situation.
      8253f59e
    • R
      improve robustness of wordexp and fix handling of 0-word case · d8f1908b
      Rich Felker 提交于
      avoid using exit status to determine if a shell error occurred, since
      broken programs may install SIGCHLD handlers which reap all zombies,
      including ones that don't belong to them. using clone and __WCLONE
      does not seem to work for avoiding this problem since exec resets the
      exit signal to SIGCHLD.
      
      instead, the new code uses a dummy word at the beginning of the
      shell's output, which is ignored, to determine whether the command was
      executed successfully. this also fixes a corner case where a word
      string containing zero words was interpreted as a single zero-length
      word rather than no words at all. POSIX does not seem to require this
      case to be supported anyway, though.
      
      in addition, the new code uses the correct retry idiom for waitpid to
      ensure that spurious STOP/CONT signals in the child and/or EINTR in
      the parent do not prevent successful wait for the child, and blocks
      signals in the child.
      d8f1908b
  6. 21 11月, 2013 6 次提交
  7. 11 11月, 2013 1 次提交
  8. 10 11月, 2013 1 次提交
    • R
      fix harmless inconsistency in semtimedop · 35cf8b3e
      Rich Felker 提交于
      this should not matter since the reality is that either all the sysv
      sem syscalls are individual syscalls, or all of them are multiplexed
      on the SYS_ipc syscall (depending on arch). but best to be consistent
      anyway.
      35cf8b3e
  9. 09 11月, 2013 4 次提交
    • R
      implement semtimedop · 4571f9f8
      Rich Felker 提交于
      this is a Linux-specific extension to the sysv semaphore api.
      4571f9f8
    • R
      adjust sys/wait.h not to produde errors in strict ISO C feature profile · f5980e33
      Rich Felker 提交于
      siginfo_t is not available from signal.h when the strict ISO C feature
      profile (e.g. passing -std=c99 to gcc without defining any other
      feature test macros) is used, but the type is needed to declare
      waitid. using sys/wait.h (or any POSIX headers) in strict ISO C mode
      is an application bug, but in the interest of compatibility, it's best
      to avoid producing gratuitous errors. the simplest fix I could find is
      suppressing the declaration of waitid (and also signal.h inclusion,
      since it's not needed for anything else) in this case, while still
      exposing everything else in sys/wait.h
      f5980e33
    • R
      remove O_NOFOLLOW from __map_file used for time zone file loading · 41a9ba25
      Rich Felker 提交于
      it's not clear why I originally wrote O_NOFOLLOW into this; I suspect
      the reason was with an aim of making the function more general for
      mapping partially or fully untrusted files provided by the user.
      however, the timezone code already precludes use of absolute or
      relative pathnames in suid/sgid programs, and disallows .. in
      pathnames which are relative to one of the system timezone locations,
      so there is no threat of opening a symlink which is not trusted by
      appropriate user. since some users may wish to put symbolic links in
      the zoneinfo directories to alias timezones, it seems preferable to
      allow this.
      41a9ba25
    • R
      fix handling of overly-long TZ environment variable values · 1d0d2df6
      Rich Felker 提交于
      the rest of the code is not prepared to handle an empty TZ string, so
      falling back to __gmt ("GMT"), just as if TZ had been blank or unset,
      is the preferable action.
      1d0d2df6
  10. 05 11月, 2013 1 次提交
  11. 04 11月, 2013 2 次提交
  12. 02 11月, 2013 2 次提交