1. 03 11月, 2019 7 次提交
    • R
      move msghdr and cmsghdr out of bits/socket.h · a0252bc7
      Rich Felker 提交于
      these structures can now be defined generically in terms of endianness
      and long size. previously, the 32-bit archs all shared a common
      definition from the generic bits header, and each 64-bit arch had to
      repeat the 64-bit version, with endian conditionals if the arch had
      variants of each endianness.
      
      I would prefer getting rid of the preprocessor conditionals for
      padding and instead using unnamed bitfield members, like commit
      9b2921be did for struct timespec.
      however, at present sendmsg, recvmsg, and recvmmsg need access to the
      padding members by name to zero them. this could perhaps be cleaned up
      in the future.
      a0252bc7
    • R
      fix x32 msghdr struct by removing x32 bits/socket.h · 573a4d2d
      Rich Felker 提交于
      being that it contains pointers and (from the kernel perspective,
      which is wrong) size_t members, x32 uses the 32-bit version of the
      structure, not a half-32-bit, half-64-bit layout like we had here. the
      x86_64 definition was inadvertently copied when x32 was first added.
      
      unlike errors in the opposite direction (missing padding), this error
      was not easily detected breakage, because the layout of the commonly
      used initial subset of members still matched. breakage could only be
      observed in the presence of control messages or flags.
      573a4d2d
    • R
      make time-related socket options overridable by arch bits files · 0bbc04c9
      Rich Felker 提交于
      SO_RCVTIMEO and SO_SNDTIMEO already were, but only in aggregate with
      SO_DEBUG and all of the other low/traditional options that varied per
      arch. SO_TIMESTAMP* are newly overridable. the two groups have to be
      done separately since mips64 and powerpc64 will override the former
      but not the latter.
      
      at some point this should be cleaned up to use bits headers more
      idiomatically.
      0bbc04c9
    • R
      add framework for arch-provided makefile fragments, compat source dirs · de90f38e
      Rich Felker 提交于
      the immediate usage case for this is to let 32-bit archs moving to
      64-bit time_t via symbol redirection pull in wrapper shims that
      provide the old symbol names. in the future it may be used for other
      types of compatibility-only source files that are not relevant to all
      archs.
      de90f38e
    • R
      5a25759a
    • R
      add time64 redirect for, and redirecting implementation of, dlsym · 22daaea3
      Rich Felker 提交于
      if symbols are being redirected to provide the new time64 ABI, dlsym
      must perform matching redirections; otherwise, it would poke a hole in
      the magic and return pointers to functions that are not safe to call
      from a caller using time64 types.
      
      rather than duplicating a table of redirections, use the time64
      symbols present in libc's symbol table to derive the decision for
      whether a particular symbol needs to be redirected.
      22daaea3
    • R
      add time32 ABI compat shims, compat source tree · c0450320
      Rich Felker 提交于
      these files provide the symbols for the traditional 32-bit time_t ABI
      on existing 32-bit archs by wrapping the real, internal versions of
      the corresponding functions, which always work with 64-bit time_t.
      they are written to be as agnostic as possible to the implementation
      details of the real functions, so that they can be written once and
      mostly forgotten, but they are aware of details of the old (and
      sometimes new) ABI, which is okay since ABI is fixed and cannot
      change.
      
      a new compat tree is added, separate from src, which the Makefile does
      not see or use now, but which archs will be able to add to the build
      process. we could also consider moving other things that are compat
      shims here, like functions which are purely for glibc-ABI-compat, with
      the goal of making it optional or just cleaning up the main src tree
      to make the distinction between actual implementation/API files and
      ABI-compat shims clear.
      c0450320
  2. 29 10月, 2019 5 次提交
    • R
      make fstatat fill in old time32 stat fields too · 0961bb94
      Rich Felker 提交于
      here _REDIR_TIME64 is used as an indication that there's an old ABI,
      and thereby the old time32 timespec fields of struct stat.
      
      keeping struct stat compatible and providing both versions of the
      timespec fields is done so that ftw/nftw does not need painful compat
      shims, and (more importantly) so that similar interfaces between pairs
      of libc consumers (applications/libraries) will be less likely to
      break when one has been rebuilt for time64 but the other has not.
      0961bb94
    • R
      disable lfs64 aliases for remapped time64 functions · 50018f92
      Rich Felker 提交于
      these functions cannot provide the glibc lfs64-ABI-compatible symbols
      when time_t differs from what it was in that ABI. instead, the aliases
      need to be provided by the time32 compat shims or through some other
      mechanism.
      50018f92
    • R
      prepare struct sched_param for change in time_t definition · 2d69fcf5
      Rich Felker 提交于
      the time_t members in struct sched_param are just reserved space to
      preserve size and alignment. when time_t changes to 64-bit on 32-bit
      archs, this structure should not change.
      
      make definition conditional on _REDIR_TIME64 to match the size of the
      old time_t, which can be assumed to be long if _REDIR_TIME64 is
      defined.
      2d69fcf5
    • R
      add time64 symbol name redirects to public headers, under arch control · 1febd21d
      Rich Felker 提交于
      a _REDIR_TIME64 macro is introduced, which the arch's alltypes.h is
      expected to define, to control redirection of symbol names for
      interfaces that involve time_t and derived types. this ensures that
      object files will only be linked to libc interfaces matching the ABI
      whose headers they were compiled against.
      
      along with time32 compat shims, which will be introduced separately,
      the redirection also makes it possible for a single libc (static or
      shared) to be used with object files produced with either the old
      (32-bit time_t) headers or the new ones after 64-bit time_t switchover
      takes place. mixing of such object files (or shared libraries) in the
      same program will also be possible, but must be done with care; ABI
      between libc and a consumer of the libc interfaces is guaranteed to
      match by the the symbol name redirection, but pairwise ABI between
      consumers of libc that define interfaces between each other in terms
      of time_t is not guaranteed to match.
      
      this change adds a dependency on an additional "GNU C" feature to the
      public headers for existing 32-bit archs, which is generally
      undesirable; however, the feature is one which glibc has depended on
      for a long time, and thus which any viable alternative compiler is
      going to need to provide. 64-bit archs are not affected, nor will
      future 32-bit archs be, regardless of whether they are "new" on the
      kernel side (e.g. riscv32) or just newly-added (e.g. a new sparc or
      xtensa port). the same applies to newly-added ABIs for existing
      machine-level archs.
      1febd21d
    • R
      add missing m68k user.h/procfs.h regset types · f7f12e4c
      Rich Felker 提交于
      f7f12e4c
  3. 26 10月, 2019 4 次提交
    • R
      update case mappings to unicode 12.1.0 · 06d4075a
      Rich Felker 提交于
      06d4075a
    • U
      update ctype data to unicode 12.1.0 · e95538fa
      u_quark 提交于
      e95538fa
    • R
      overhaul wide character case mapping implementation · a11a6246
      Rich Felker 提交于
      the existing implementation of case mappings was very small (typically
      around 1.5k), but unmaintainable, requiring manual addition of new
      case mappings with each new edition of Unicode. often, it turned out
      that newly-added case mappings were not easily representable in the
      existing tightly-constrained table structures, requiring new hacks to
      be invented and delaying support for new characters.
      
      the new implementation added here follows the pattern used for
      character class membership, with a two-level table allowing Unicode
      blocks for which no data is needed to be elided. however, rather than
      single-bit data, each character maps to a one of up to 6 case-mapping
      rules available to its block, where 6 is floor(cbrt(256)) and allow 3
      characters to be represented per byte (vs 8 with bit tables). blocks
      that would need more than 6 rules designate one as an exception and
      let lookup pass into a binary search of exceptional cases for the
      block.
      
      the number 6 was chosen empirically; many blocks would be ok with 4
      rules (uncased, lower, upper, possible exceptions), some even just
      with 2, but the latter are rare and fitting 4 characters per byte
      rather than 3 does not save significant space. moreover, somewhat
      surprisingly, there are sufficiently many blocks where even 4 rules
      don't suffice without a lot of exceptions (blocks where some case
      pairs are laced, others offset) that originally I was looking at
      supporting variable-width tables, with 1-, 2-, or 3-bit entries,
      thereby allowing blocks with 8 rules. as implemented in my
      experiments, that version was significantly larger and involved more
      memory accesses/cache lines.
      
      improvements in size at the expense of some performance might be
      possible by utilizing iswalpha data or merging the table of case
      mapping identity with alphabetic identity. these were explored
      somewhat when the code was first written, and might be worth
      revisiting in the future.
      a11a6246
    • R
      add missing case mapping between U+03F3 and U+037F · e8aba58a
      Rich Felker 提交于
      somehow this seems to have been overlooked. add it now so that
      subsequent overhaul of case mapping implementation will not introduce
      a functional change at the same time.
      e8aba58a
  4. 24 10月, 2019 1 次提交
  5. 20 10月, 2019 6 次提交
    • R
      adjust struct timespec definition to be time64-ready · 9b2921be
      Rich Felker 提交于
      for time64 support on 32-bit archs, the kernel interfaces use a
      timespec layout padded to match the representation of a pair of 64-bit
      values, which requires endian-specific padding.
      
      use of an ordinary, non-bitfield, named member for the padding is
      undesirable because, on big endian archs, it would alter the
      interpretation of traditional (non-designated) initializers of the
      form {s,ns}, initializing the padding instead of the tv_nsec member.
      unnamed bitfield members solve this problem by not taking part in
      initialization, and were the expected solution when the kernel
      interfaces were designed. however, they also have further advantages
      which we take advantage of here:
      
      positioning of the padding could be controlled by having a
      preprocessor conditional with separate definitions of struct timespec
      for little and big endian, but whether padding should appear at all is
      a function of whether time_t is larger than long. this condition is
      not something the preprocessor can determine unless we were to define
      a new macro specifically for that purpose.
      
      by using unnamed bitfield members instead of ordinary named members,
      we can arrange for the size of the padding to collapse to zero when it
      should not be present, just by using sizeof(time_t) and sizeof(long)
      in the bitfield width expression, which can be any integer constant
      expression.
      9b2921be
    • R
      clock_adjtime: generalize time64 not to assume old struct layout match · 928674dc
      Rich Felker 提交于
      commit 2b4fd6f7 added time64 for this
      function, but did so with a hidden assumption that the new time64
      version of struct timex will be layout-compatible with the old one.
      however, there is little benefit to doing it that way, and the cost is
      permanent special-casing of 32-bit archs with 64-bit time_t in the
      public interface definitions.
      
      instead, do a full translation of the structure going in and out. this
      commit is actually a revision to an earlier uncommited version of the
      code.
      928674dc
    • R
      wait4, getrusage: add time64/x32 variant · 5850546e
      Rich Felker 提交于
      presently the kernel does not actually define time64 versions of these
      syscalls, and they're not really needed except to represent extreme
      cpu time usage. however, x32's versions of the syscalls already behave
      as time64 ones, meaning the functions were broken on x32 if the caller
      used any part of the rusage result other than ru_utime and ru_stime.
      commit 7e817114 made it possible to
      fix this by treating x32's syscalls as time64 versions.
      
      in the non-time64-syscall case, make the syscall with the rusage
      destination pointer adjusted so that all members but the timevals line
      up between the libc and kernel structures. on 64-bit archs, or present
      32-bit archs with 32-bit time_t, the timevals will line up too and no
      further work is needed. for future 32-bit archs with 64-bit time_t,
      the timevals are copied into place, contingent on time_t being larger
      than long.
      5850546e
    • R
      internally, define time64 rusage syscalls on x32 as the existing ones · 7e817114
      Rich Felker 提交于
      this is analogous to commit 40aa18d5.
      so far, there are not any actual time64 versions of the rusage
      syscalls (getrusage and wait4) and might never be. however, the
      existing x32 ones behave the way time64 versions would if they
      existed: using 64-bit slots in place of all longs.
      
      presently, wait4 and getrusage are broken on x32, storing the timevals
      correctly but messing up everything else due to the long/kernel-long
      mismatch. this would be a huge buffer overflow if not for the 16
      reserved slots we left long ago, which suffice to prevent 14
      double-sized longs from overflowing into unrelated memory. this commit
      will make it possible to fix them.
      7e817114
    • R
      use struct pt_regs * rather than void * for powerpc[64] sigcontext regs · c2518a8e
      Rich Felker 提交于
      this is to match the kernel and glibc interfaces. here, struct pt_regs
      is an incomplete type, but that's harmless, and if it's completed by
      inclusion of another header then members of the struct pointed to by
      the regs member can be accessed directly without going through a cast
      or intermediate pointer object.
      c2518a8e
    • R
      fix fpregset_t type on powerpc64 · c9f48cde
      Rich Felker 提交于
      the userspace ucontext API has this as an array rather than a
      structure.
      
      commit 3c59a868 fixed the
      corresponding mistake for vrregset_t, namely that the original
      powerpc64 port used a mix of types from 32-bit powerpc and powerpc64
      rather than matching the 64-bit types.
      c9f48cde
  6. 19 10月, 2019 2 次提交
    • R
      fix return value of ungetc when argument is outside unsigned char range · f6ecd0c2
      Rich Felker 提交于
      aside from the special value EOF, ungetc is specified to accept and
      convert values outside the range of unsigned char. conversion takes
      place automatically as part of assignment when storing into the
      buffer, but the return value is also required to be the resulting
      converted value, and this requirement was not satisfied.
      
      simplified from patch by Wang Jianjian.
      f6ecd0c2
    • R
      fix incorrect use of fabs on long double operand in floatscan.c · bff78954
      Rich Felker 提交于
      based on patch by Dan Gohman, who caught this via compiler warnings.
      analysis by Szabolcs Nagy determined that it's a bug, whereby errno
      can be set incorrectly for values where the coercion from long double
      to double causes rounding. it seems likely that floating point status
      flags may be set incorrectly as a result too.
      
      at the same time, clean up use of preprocessor concatenation involving
      LDBL_MANT_DIG, which spuriously depends on it being a single unadorned
      decimal integer literal, and instead use the equivalent formulation
      2/LDBL_EPSILON. an equivalent change on the printf side was made in
      commit bff6095d.
      bff78954
  7. 18 10月, 2019 8 次提交
    • R
      move pthread types out of per-arch alltypes.h · 2d3083e7
      Rich Felker 提交于
      policy has long been that these definitions are purely a function of
      whether long/pointer is 32- or 64-bit, and that they are not allowed
      to vary per-arch. move the definition to the shared alltypes.h.in
      fragment, using integer constant expressions in terms of sizeof to
      vary the array dimensions appropriately. I'm not sure whether this is
      more or less ugly than using preprocessor conditionals and two sets of
      definitions here, but either way is a lot less ugly than repeating the
      same thing for every arch.
      2d3083e7
    • R
      define LONG_MAX via arch alltypes.h, strip down bits/limits.h · 7cc79d10
      Rich Felker 提交于
      LLONG_MAX is uniform for all archs we support and plenty of header and
      code level logic assumes it is, so it does not make sense for limits.h
      bits mechanism to pretend it's variable.
      
      LONG_BIT can be defined in terms of LONG_MAX; there's no reason to put
      it in bits.
      
      by moving LONG_MAX definition to __LONG_MAX in alltypes.h and moving
      LLONG_MAX out of bits, there are now no plain-C limits that are
      defined in the bits header, so the bits header only needs to be
      included in the POSIX or extended profiles. this allows the feature
      test macro logic to be removed from the bits header, facilitating a
      long-term goal of getting such logic out of bits.
      
      having __LONG_MAX in alltypes.h will allow further generalization of
      headers.
      
      archs without a constant PAGESIZE no longer need bits/limits.h at all.
      7cc79d10
    • R
      make endian.h expose unprefixed macros, functions in standard profile · 316730cd
      Rich Felker 提交于
      the resolution of Austin Group issue #162 adds endian.h as a standard
      header for future versions of the standard, making it no longer
      acceptable for some of the functionality to be hidden behind
      _BSD_SOURCE or _GNU_SOURCE. the definitions of the [lb]etoh{16,32,64}
      function-like macros are kept conditional since they are alternate
      names which the standard did not adopt.
      316730cd
    • R
      remove use of endian.h from arch reloc.h headers, clean up · 4d3a162d
      Rich Felker 提交于
      building on commit 97d35a55,
      __BYTE_ORDER is now available wherever alltypes.h is included. since
      reloc.h is only used from src/internal/dynlink.h, it can be assumed
      that __BYTE_ORDER is exposed. reloc.h is not permitted to be included
      in other contexts, and generally, like most arch headers, lacks
      inclusion guards that would allow such usage. the mips64 version
      mistakenly included such guards; they are removed for consistency.
      4d3a162d
    • R
      remove indirect use of endian.h from public headers · 71d23fbe
      Rich Felker 提交于
      building on commit 97d35a55,
      __BYTE_ORDER is now available wherever alltypes.h is included.
      endian.h should not be used since, in the future, it will expose
      identifiers that are not in the reserved namespace for the headers
      which were previously using it.
      71d23fbe
    • R
      move __BYTE_ORDER definition to alltypes.h · 97d35a55
      Rich Felker 提交于
      this change is motivated by the intersection of several factors.
      presently, despite being a nonstandard header, endian.h is exposing
      the unprefixed byte order macros and functions only if _BSD_SOURCE or
      _GNU_SOURCE is defined. this is to accommodate use of endian.h from
      other headers, including bits headers, which need to define structure
      layout in terms of endianness. with time64 switch-over, even more
      headers will need to do this.
      
      at the same time, the resolution of Austin Group issue 162 makes
      endian.h a standard header for POSIX-future, requiring that it expose
      the unprefixed macros and the functions even in standards-conforming
      profiles. changes to meet this new requirement would break existing
      internal usage of endian.h by causing it to violate namespace where
      it's used.
      
      instead, have the arch's alltypes.h define __BYTE_ORDER, either as a
      fixed constant or depending on the right arch-specific predefined
      macros for determining endianness. explicit literals 1234 and 4321 are
      used instead of __LITTLE_ENDIAN and __BIG_ENDIAN so that there's no
      danger of getting the wrong result if a macro is undefined and
      implicitly evaluates to 0 at the preprocessor level.
      
      the powerpc (32-bit) bits/endian.h being removed had logic for varying
      endianness, but our powerpc arch has never supported that and has
      always been big-endian-only. this logic is not carried over to the new
      __BYTE_ORDER definition in alltypes.h.
      97d35a55
    • R
      remove per-arch definitions for va_list · 00ec11d1
      Rich Felker 提交于
      now that commit f7f10797 removed the
      legacy i386 conditional definition, va_list is in no way
      arch-specific, and has no reason to be in the future. move it to the
      shared part of alltypes.h.in
      00ec11d1
    • R
      remove i386 support for legacy struct __va_list · f7f10797
      Rich Felker 提交于
      commit ffaaa6d2 removed the
      corresponding stdarg.h support for compilers without va_list builtins,
      but failed to remove the alternate type definition, leaving incorrect
      va_list definitions in place with compilers that don't define __GNUC__
      with a value >= 3.
      f7f10797
  8. 14 10月, 2019 5 次提交
  9. 07 10月, 2019 1 次提交
    • S
      add Arm to the copyright file · db3cc9a3
      Szabolcs Nagy 提交于
      Several math functions are now from the ARM optimized-routines repo
      licensed under standard MIT terms and copyrighted by Arm Limited,
      so mention this in the COPYRIGHT too.
      db3cc9a3
  10. 02 10月, 2019 1 次提交
    • R
      reintroduce riscv64 struct sigcontext · a0993f8f
      Rich Felker 提交于
      commit ab3eb89a removed it as part of
      correcting the mcontext_t definition, but there is still code using
      struct sigcontext and expecting the member names present in it, most
      notably libgcc_eh. almost all such usage is incorrect, but bring back
      struct sigcontext at least for now so as not to introduce regressions.
      a0993f8f