1. 07 8月, 2011 1 次提交
  2. 05 8月, 2011 1 次提交
    • R
      fix off-by-one bug in siglongjmp that caused unpredictable behavior · 338b663d
      Rich Felker 提交于
      if saved, signal mask would not be restored unless some low signals
      were masked. if not saved, signal mask could be wrongly restored to
      uninitialized values. in any, wrong mask would be restored.
      
      i believe this function was written for a very old version of the
      jmp_buf structure which did not contain a final 0 field for
      compatibility with siglongjmp, and never updated...
      338b663d
  3. 04 8月, 2011 4 次提交
  4. 03 8月, 2011 9 次提交
    • R
      overhaul rwlocks to address several issues · 50304f2e
      Rich Felker 提交于
      like mutexes and semaphores, rwlocks suffered from a race condition
      where the unlock operation could access the lock memory after another
      thread successfully obtained the lock (and possibly destroyed or
      unmapped the object). this has been fixed in the same way it was fixed
      for other lock types.
      
      in addition, the previous implementation favored writers over readers.
      in the absence of other considerations, that is the best behavior for
      rwlocks, and posix explicitly allows it. however posix also requires
      read locks to be recursive. if writers are favored, any attempt to
      obtain a read lock while a writer is waiting for the lock will fail,
      causing "recursive" read locks to deadlock. this can be avoided by
      keeping track of which threads already hold read locks, but doing so
      requires unbounded memory usage, and there must be a fallback case
      that favors readers in case memory allocation failed. and all of this
      must be synchronized. the cost, complexity, and risk of errors in
      getting it right is too great, so we simply favor readers.
      
      tracking of the owner of write locks has been removed, as it was not
      useful for anything. it could allow deadlock detection, but it's not
      clear to me that returning EDEADLK (which a buggy program is likely to
      ignore) is better than deadlocking; at least the latter behavior
      prevents further data corruption. a correct program cannot invoke this
      situation anyway.
      
      the reader count and write lock state, as well as the "last minute"
      waiter flag have all been combined into a single atomic lock. this
      means all state transitions for the lock are atomic compare-and-swap
      operations. this makes establishing correctness much easier and may
      improve performance.
      
      finally, some code duplication has been cleaned up. more is called
      for, especially the standard __timedwait idiom repeated in all locks.
      50304f2e
    • R
      timedwait: play it safe for now · 8aeee8db
      Rich Felker 提交于
      it's unclear whether EINVAL or ENOSYS is used when the operation is
      not supported, so check for both...
      8aeee8db
    • R
      fix stubbed-out reboot call · 4f5ba921
      Rich Felker 提交于
      4f5ba921
    • R
      correctly handle old kernels without FUTEX_WAIT_BITSET · 4717bfec
      Rich Felker 提交于
      futex returns EINVAL, not ENOSYS, when op is not supported.
      unfortunately this looks just like EINVAL from other causes, and we
      end up running the fallback code and getting EINVAL again. fortunately
      this case should be rare since correct code should not generate EINVAL
      anyway.
      4717bfec
    • R
      fix sem_timedwait bug introduced in timedwait unification · bdd89337
      Rich Felker 提交于
      this dec used to be performed by the cancellation handler, which was
      called when popped.
      bdd89337
    • R
      unify and overhaul timed futex waits · ec381af9
      Rich Felker 提交于
      new features:
      
      - FUTEX_WAIT_BITSET op will be used for timed waits if available. this
        saves a call to clock_gettime.
      
      - error checking for the timespec struct is now inside __timedwait so
        it doesn't need to be duplicated everywhere. cond_timedwait still
        needs to duplicate it to avoid unlocking the mutex, though.
      
      - pushing and popping the cancellation handler is delegated to
        __timedwait, and cancellable/non-cancellable waits are unified.
      ec381af9
    • R
      avoid accessing mutex memory after atomic unlock · c68de0be
      Rich Felker 提交于
      this change is needed to fix a race condition and ensure that it's
      possible to unlock and destroy or unmap the mutex as soon as
      pthread_mutex_lock succeeds. POSIX explicitly gives such an example in
      the rationale and requires an implementation to allow such usage.
      c68de0be
    • R
      fix breakage in cancellation due to signal functions overhaul · 344ea148
      Rich Felker 提交于
      sigaddset was not accepting SIGCANCEL as a valid signal number.
      344ea148
    • R
      overhaul posix semaphores to fix destructability race · 88c4e720
      Rich Felker 提交于
      the race condition these changes address is described in glibc bug
      report number 12674:
      
      http://sourceware.org/bugzilla/show_bug.cgi?id=12674
      
      up until now, musl has shared the bug, and i had not been able to
      figure out how to eliminate it. in short, the problem is that it's not
      valid for sem_post to inspect the waiters count after incrementing the
      semaphore value, because another thread may have already successfully
      returned from sem_wait, (rightly) deemed itself the only remaining
      user of the semaphore, and chosen to destroy and free it (or unmap the
      shared memory it's stored in). POSIX is not explicit in blessing this
      usage, but it gives a very explicit analogous example with mutexes
      (which, in musl and glibc, also suffer from the same race condition
      bug) in the rationale for pthread_mutex_destroy.
      
      the new semaphore implementation augments the waiter count with a
      redundant waiter indication in the semaphore value itself,
      representing the presence of "last minute" waiters that may have
      arrived after sem_post read the waiter count. this allows sem_post to
      read the waiter count prior to incrementing the semaphore value,
      rather than after incrementing it, so as to avoid accessing the
      semaphore memory whatsoever after the increment takes place.
      
      a similar, but much simpler, fix should be possible for mutexes and
      other locking primitives whose usage rules are stricter than
      semaphores.
      88c4e720
  5. 01 8月, 2011 3 次提交
  6. 31 7月, 2011 3 次提交
    • R
      consistency: use struct __ucontext instead of ucontext_t in prototypes · acfd06df
      Rich Felker 提交于
      this is necessary to avoid build errors if feature test macros are not
      properly defined when including ucontext.h
      acfd06df
    • R
      fix race condition in sigqueue · 07827d1a
      Rich Felker 提交于
      this race is fundamentally due to linux's bogus requirement that
      userspace, rather than kernelspace, fill in the siginfo structure. an
      intervening signal handler that calls fork could cause both the parent
      and child process to send signals claiming to be from the parent,
      which could in turn have harmful effects depending on what the
      recipient does with the signal. we simply block all signals for the
      interval between getuid and sigqueue syscalls (much like what raise()
      does already) to prevent the race and make the getuid/sigqueue pair
      atomic.
      
      this will be a non-issue if linux is fixed to validate the siginfo
      structure or fill it in from kernelspace.
      07827d1a
    • R
      clean up pthread_sigmask/sigprocmask dependency order · ad588184
      Rich Felker 提交于
      it's nicer for the function that doesn't use errno to be independent,
      and have the other one call it. saves some time and avoids clobbering
      errno.
      ad588184
  7. 30 7月, 2011 6 次提交
    • R
      fix some bugs in setxid and update setrlimit to use __synccall · 544ee752
      Rich Felker 提交于
      setrlimit is supposed to be per-process, not per-thread, but again
      linux gets it wrong. work around this in userspace. not only is it
      needed for correctness; setxid also depends on the resource limits for
      all threads being the same to avoid situations where temporarily
      unlimiting the limit succeeds in some threads but fails in others.
      544ee752
    • R
      add proper fuxed-based locking for stdio · dba68bf9
      Rich Felker 提交于
      previously, stdio used spinlocks, which would be unacceptable if we
      ever add support for thread priorities, and which yielded
      pathologically bad performance if an application attempted to use
      flockfile on a key file as a major/primary locking mechanism.
      
      i had held off on making this change for fear that it would hurt
      performance in the non-threaded case, but actually support for
      recursive locking had already inflicted that cost. by having the
      internal locking functions store a flag indicating whether they need
      to perform unlocking, rather than using the actual recursive lock
      counter, i was able to combine the conditionals at unlock time,
      eliminating any additional cost, and also avoid a nasty corner case
      where a huge number of calls to ftrylockfile could cause deadlock
      later at the point of internal locking.
      
      this commit also fixes some issues with usage of pthread_self
      conflicting with __attribute__((const)) which resulted in crashes with
      some compiler versions/optimizations, mainly in flockfile prior to
      pthread_create.
      dba68bf9
    • R
      eliminate dependence of perror on printf · 7683fcee
      Rich Felker 提交于
      7683fcee
    • R
    • R
      afade235
    • R
      new attempt at making set*id() safe and robust · acb04806
      Rich Felker 提交于
      changing credentials in a multi-threaded program is extremely
      difficult on linux because it requires synchronizing the change
      between all threads, which have their own thread-local credentials on
      the kernel side. this is further complicated by the fact that changing
      the real uid can fail due to exceeding RLIMIT_NPROC, making it
      possible that the syscall will succeed in some threads but fail in
      others.
      
      the old __rsyscall approach being replaced was robust in that it would
      report failure if any one thread failed, but in this case, the program
      would be left in an inconsistent state where individual threads might
      have different uid. (this was not as bad as glibc, which would
      sometimes even fail to report the failure entirely!)
      
      the new approach being committed refuses to change real user id when
      it cannot temporarily set the rlimit to infinity. this is completely
      POSIX conformant since POSIX does not require an implementation to
      allow real-user-id changes for non-privileged processes whatsoever.
      still, setting the real uid can fail due to memory allocation in the
      kernel, but this can only happen if there is not already a cached
      object for the target user. thus, we forcibly serialize the syscalls
      attempts, and fail the entire operation on the first failure. this
      *should* lead to an all-or-nothing success/failure result, but it's
      still fragile and highly dependent on kernel developers not breaking
      things worse than they're already broken.
      
      ideally linux will eventually add a CLONE_USERCRED flag that would
      give POSIX conformant credential changes without any hacks from
      userspace, and all of this code would become redundant and could be
      removed ~10 years down the line when everyone has abandoned the old
      broken kernels. i'm not holding my breath...
      acb04806
  8. 29 7月, 2011 3 次提交
  9. 25 7月, 2011 2 次提交
  10. 24 7月, 2011 6 次提交
  11. 22 7月, 2011 2 次提交