1. 21 7月, 2013 5 次提交
    • R
      remove __libc_csu_* cruft · 3edfd070
      Rich Felker 提交于
      these functions were mistakenly assumed to be needed to match glibc
      ABI, but glibc has them as part of the non-shared part of libc that's
      always statically linked into the main program. moreover, the only
      place they are referenced from is glibc's crt1.o.
      3edfd070
    • R
      add support for init/fini array in main program, and greatly simplify · 7586360b
      Rich Felker 提交于
      modern (4.7.x and later) gcc uses init/fini arrays, rather than the
      legacy _init/_fini function pasting and crtbegin/crtend ctors/dtors
      system, on most or all archs. some archs had already switched a long
      time ago. without following this change, global ctors/dtors will cease
      to work under musl when building with new gcc versions.
      
      the most surprising part of this patch is that it actually reduces the
      size of the init code, for both static and shared libc. this is
      achieved by (1) unifying the handling main program and shared
      libraries in the dynamic linker, and (2) eliminating the
      glibc-inspired rube goldberg machine for passing around init and fini
      function pointers. to clarify, some background:
      
      the function signature for __libc_start_main was based on glibc, as
      part of the original goal of being able to run some glibc-linked
      binaries. it worked by having the crt1 code, which is linked into
      every application, static or dynamic, obtain and pass pointers to the
      init and fini functions, which __libc_start_main is then responsible
      for using and recording for later use, as necessary. however, in
      neither the static-linked nor dynamic-linked case do we actually need
      crt1.o's help. with dynamic linking, all the pointers are available in
      the _DYNAMIC block. with static linking, it's safe to simply access
      the _init/_fini and __init_array_start, etc. symbols directly.
      
      obviously changing the __libc_start_main function signature in an
      incompatible way would break both old musl-linked programs and
      glibc-linked programs, so let's not do that. instead, the function can
      just ignore the information it doesn't need. new archs need not even
      provide the useless args in their versions of crt1.o. existing archs
      should continue to provide it as long as there is an interest in
      having newly-linked applications be able to run on old versions of
      musl; at some point in the future, this support can be removed.
      7586360b
    • R
      fix order of fini_array execution for shared libs · 1b413572
      Rich Felker 提交于
      1b413572
    • R
      e69ae844
    • R
      fix shm_open wrongly being cancellable · ce8a9957
      Rich Felker 提交于
      ce8a9957
  2. 20 7月, 2013 2 次提交
    • R
      fix uninitialized/stale use of alloc (%m modifier) flag in scanf · 1d92cddb
      Rich Felker 提交于
      for conversion specifiers, alloc is always set when the specifier is
      parsed. however, if scanf stops due to mismatching literal text,
      either an uninitialized (if no conversions have been performed yet) or
      stale (from the previous conversion) of the flag will be used,
      possibly causing an invalid pointer to be passed to free when the
      function returns.
      1d92cddb
    • R
      harden realloc/free to detect simple overflows · 8389520e
      Rich Felker 提交于
      the sizes in the header and footer for a chunk should always match. if
      they don't, the program has definitely invoked undefined behavior, and
      the most likely cause is a simple overflow, either of a buffer in the
      block being freed or the one just below it.
      
      crashing here should not only improve security of buggy programs, but
      also aid in debugging, since the crash happens in a context where you
      have a pointer to the likely-overflowed buffer.
      8389520e
  3. 19 7月, 2013 4 次提交
    • R
      improve [f]stat[v]fs functions, and possibly work around old kernels · 6567db65
      Rich Felker 提交于
      the main aim of this patch is to ensure that if not all fields are
      filled in, they contain zeros, so as not to confuse applications.
      reportedly some older kernels, including commonly used openvz kernels,
      lack the f_flags field, resulting in applications reading random junk
      as the mount flags; the common symptom seems to be wrongly considering
      the filesystem to be mounted read-only and refusing to operate. glibc
      has some amazingly ugly fallback code to get the mount flags for old
      kernels, but having them really is not that important anyway; what
      matters most is not presenting incorrect flags to the application.
      
      I have also aimed to fill in some fields of statvfs that were
      previously missing, and added code to explicitly zero the reserved
      space at the end of the structure, which will make things easier in
      the future if this space someday needs to be used.
      6567db65
    • R
      change uid_t, gid_t, and id_t to unsigned types · 648c3b4e
      Rich Felker 提交于
      this change is both to fix one of the remaining type (and thus C++
      ABI) mismatches with glibc/LSB and to allow use of the full range of
      uid and gid values, if so desired.
      
      passwd/group access functions were not prepared to deal with unsigned
      values, so they too have been fixed with this commit.
      648c3b4e
    • R
      make the dynamic linker find its path file relative to its own location · f389c498
      Rich Felker 提交于
      prior to this change, using a non-default syslibdir was impractical on
      systems where the ordinary library paths contain musl-incompatible
      library files. the file containing search paths was always taken from
      /etc, which would either correspond to a system-wide musl
      installation, or fail to exist at all, resulting in searching of the
      default library path.
      
      the new search strategy is safe even for suid programs because the
      pathname used comes from the PT_INTERP header of the program being
      run, rather than any external input.
      
      as part of this change, I have also begun differentiating the names of
      arch variants that differ by endianness or floating point calling
      convention. the corresponding changes in the build system and and gcc
      wrapper script (to use an alternate dynamic linker name) for these
      configurations have not yet been made.
      f389c498
    • R
  4. 18 7月, 2013 1 次提交
    • R
      make posix_spawn (and functions that use it) use CLONE_VFORK flag · b06dc666
      Rich Felker 提交于
      this is both a minor scheduling optimization and a workaround for a
      difficult-to-fix bug in qemu app-level emulation.
      
      from the scheduling standpoint, it makes no sense to schedule the
      parent thread again until the child has exec'd or exited, since the
      parent will immediately block again waiting for it.
      
      on the qemu side, as regular application code running on an underlying
      libc, qemu cannot make arbitrary clone syscalls itself without
      confusing the underlying implementation. instead, it breaks them down
      into either fork-like or pthread_create-like cases. it was treating
      the code in posix_spawn as pthread_create-like, due to CLONE_VM, which
      caused horribly wrong behavior: CLONE_FILES broke the synchronization
      mechanism, CLONE_SIGHAND broke the parent's signals, and CLONE_THREAD
      caused the child's exec to end the parent -- if it hadn't already
      crashed. however, qemu special-cases CLONE_VFORK and emulates that
      with fork, even when CLONE_VM is also specified. this also gives
      incorrect semantics for code that really needs the memory sharing, but
      posix_spawn does not make use of the vm sharing except to avoid
      momentary double commit charge.
      
      programs using posix_spawn (including via popen) should now work
      correctly under qemu app-level emulation.
      b06dc666
  5. 17 7月, 2013 4 次提交
  6. 14 7月, 2013 1 次提交
    • R
      fix omission of dtv setup in static linked programs on TLS variant I archs · f1292e3d
      Rich Felker 提交于
      apparently this was never noticed before because the linker normally
      optimizes dynamic TLS models to non-dynamic ones when static linking,
      thus eliminating the calls to __tls_get_addr which crash when the dtv
      is missing. however, some libsupc++ code on ARM was calling
      __tls_get_addr when static linked and crashing. the reason is unclear
      to me, but with this issue fixed it should work now anyway.
      f1292e3d
  7. 11 7月, 2013 1 次提交
    • R
      fix invalid library phdr pointers passed to callback from dl_iterate_phdr · 30763fd0
      Rich Felker 提交于
      map_library was saving pointers to an automatic-storage buffer rather
      than pointers into the mapping. this should be a fairly simple fix,
      but the patch here is slightly complicated by two issues:
      
      1. supporting gratuitously obfuscated ELF files where the program
      headers are not right at the beginning of the file.
      
      2. cleaning up the map_library function so that data isn't clobbered
      by the time we need it.
      30763fd0
  8. 09 7月, 2013 6 次提交
  9. 05 7月, 2013 2 次提交
    • R
      move core memalign code from aligned_alloc to __memalign · 6d861ac8
      Rich Felker 提交于
      there are two motivations for this change. one is to avoid
      gratuitously depending on a C11 symbol for implementing a POSIX
      function. the other pertains to the documented semantics. C11 does not
      define any behavior for aligned_alloc when the length argument is not
      a multiple of the alignment argument. posix_memalign on the other hand
      places no requirements on the length argument. using __memalign as the
      implementation of both, rather than trying to implement one in terms
      of the other when their documented contracts differ, eliminates this
      confusion.
      6d861ac8
    • R
      move alignment check from aligned_alloc to posix_memalign · 65141618
      Rich Felker 提交于
      C11 has no requirement that the alignment be a multiple of
      sizeof(void*), and in fact seems to require any "valid alignment
      supported by the implementation" to work. since the alignment of char
      is 1 and thus a valid alignment, an alignment argument of 1 should be
      accepted.
      65141618
  10. 02 7月, 2013 1 次提交
  11. 30 6月, 2013 3 次提交
  12. 29 6月, 2013 6 次提交
    • R
      fix missing synchronization in calls from dynamic linker to global ctors · 509b50ed
      Rich Felker 提交于
      this change is needed to correctly handle the case where a constructor
      creates a new thread which calls dlopen. previously, the lock was not
      held in this case. the reason for the complex logic to avoid locking
      whenever possible is that, since the mutex is recursive, it will need
      to inspect the thread pointer to get the current thread's tid, and
      this requires initializing the thread pointer. we do not want
      non-multi-threaded programs to attempt to access the thread pointer
      unnecessarily; doing so could make them crash on ancient kernels that
      don't support threads but which may otherwise be capable of running
      the program.
      509b50ed
    • R
      prevent shmget from allocating objects that overflow ptrdiff_t · 17aef0b4
      Rich Felker 提交于
      rather than returning an error, we have to increase the size argument
      so high that the kernel will have no choice but to fail. this is
      because POSIX only permits the EINVAL error for size errors when a new
      shared memory segment would be created; if it already exists, the size
      argument must be ignored. unfortunately Linux is non-conforming in
      this regard, but I want to keep the code correct in userspace anyway
      so that if/when Linux is fixed, the behavior applications see will be
      conforming.
      17aef0b4
    • R
      work around wrong kernel type for sem_nsems member of struct semid_ds · 062f40ef
      Rich Felker 提交于
      rejecting invalid values for n is fine even in the case where a new
      sem will not be created, since the kernel does its range checks on n
      even in this case as well.
      
      by default, the kernel will bound the limit well below USHRT_MAX
      anyway, but it's presumably possible that an administrator could
      override this limit and break things.
      062f40ef
    • R
      implement week-based-year year numbers in strftime · aea79190
      Rich Felker 提交于
      in the process, I refactored the week-number code so it can be used by
      the week-based-year formats to determine year adjustments at the
      boundary values. this also improves indention/code readability.
      aea79190
    • R
      fix breakage in last commit to strftime due to missing INT_MAX · 062446a8
      Rich Felker 提交于
      that's what I get for changing a hard-coded threshold to a proper
      non-magic-number without testing.
      062446a8
    • R
      implement week numbers and half of the week-based-year logic for strftime · c5faf1bf
      Rich Felker 提交于
      output for plain week numbers (%U and %W) has been sanity-checked, and
      output for the week-based-year week numbers (%V) has been checked
      extensively against known-good data for the full non-negative range of
      32-bit time_t.
      
      year numbers for week-based years (%g and %G) are not yet implemented.
      c5faf1bf
  13. 28 6月, 2013 1 次提交
    • R
      disallow creation of objects larger than PTRDIFF_MAX via mmap · 3cd6f522
      Rich Felker 提交于
      internally, other parts of the library assume sizes don't overflow
      ssize_t and/or ptrdiff_t, and the way this assumption is made valid is
      by preventing creating of such large objects. malloc already does so,
      but the check was missing from mmap.
      
      this is also a quality of implementation issue: even if the
      implementation internally could handle such objects, applications
      could inadvertently invoke undefined behavior by subtracting pointers
      within an object. it is very difficult to guard against this in
      applications, so a good implementation should simply ensure that it
      does not happen.
      3cd6f522
  14. 27 6月, 2013 3 次提交