1. 12 11月, 2015 1 次提交
    • R
      fix dynamic loader library mapping for nommu systems · 9439ebd7
      Rich Felker 提交于
      on linux/nommu, non-writable private mappings of files may actually
      use memory shared with other processes or the fs cache. the old nommu
      loader code (used when mmap with MAP_FIXED fails) simply wrote over
      top of the original file mapping, possibly clobbering this shared
      memory. no such breakage was observed in practice, but it should have
      been possible.
      
      the new code starts by mapping anonymous writable memory on archs that
      might support nommu, then maps load segments over top of it, falling
      back to read if MAP_FIXED fails. we use an anonymous map rather than a
      writable file map to avoid reading more data from disk than needed.
      since pages cannot be loaded lazily on fault, in case of large
      data/bss, mapping the full file may read a lot of data that will
      subsequently be thrown away when processing additional LOAD segments.
      as a result, we cannot skip the first LOAD segment when operating in
      this mode.
      
      these changes affect only non-FDPIC nommu support.
      9439ebd7
  2. 11 11月, 2015 1 次提交
  3. 10 11月, 2015 3 次提交
    • R
      explicitly assemble all arm asm sources as UAL · 4e73d121
      Rich Felker 提交于
      these files are all accepted as legacy arm syntax when producing arm
      code, but legacy syntax cannot be used for producing thumb2 with
      access to the full ISA. even after switching to UAL, some asm source
      files contain instructions which are not valid in thumb mode, so these
      will need to be addressed separately.
      4e73d121
    • R
      remove non-working pre-armv4t support from arm asm · 9f290a49
      Rich Felker 提交于
      the idea of the three-instruction sequence being removed was to be
      able to return to thumb code when used on armv4t+ from a thumb caller,
      but also to be able to run on armv4 without the bx instruction
      available (in which case the low bit of lr would always be 0).
      however, without compiler support for generating such a sequence from
      C code, which does not exist and which there is unlikely to be
      interest in implementing, there is little point in having it in the
      asm, and it would likely be easier to add pre-armv4t support via
      enhanced linker handling of R_ARM_V4BX than at the compiler level.
      
      removing this code simplifies adding support for building libc in
      thumb2-only form (for cortex-m).
      9f290a49
    • R
      use vfp mnemonics rather than hard-coded opcodes in arm setjmp/longjmp · cf40375e
      Rich Felker 提交于
      the code to save/restore vfp registers needs to build even when the
      configured target does not have fpu; this is because code using vfp
      fpu (but with the standard soft-float EABI) may call a libc built for
      a soft-float only, and the EABI considers these registers call-saved
      when they exist. thus, extra directives are used to force the
      assembler to allow vfp instructions and to avoid marking the resulting
      object files as requiring vfp.
      
      moving away from using hard-coded opcode words is necessary in order
      to eventually support producing thumb2-only output for cortex-m.
      
      conditional execution of these instructions based on hwcap flags was
      already implemented. when building for arm (non-thumb) output, the
      only currently-supported configuration, this commit does not change
      the code emitted.
      cf40375e
  4. 08 11月, 2015 1 次提交
  5. 06 11月, 2015 2 次提交
  6. 05 11月, 2015 4 次提交
    • R
      remove external linkage from __simple_malloc definition · 918b1c1d
      Rich Felker 提交于
      this function is used only as a weak definition for malloc, for static
      linking in programs which do not call realloc or free. since it had
      external linkage and was thereby exported in libc.so's dynamic symbol
      table, --gc-sections was unable to drop it. this was merely an
      oversight; there's no reason for it to be external, so make it static.
      918b1c1d
    • R
      have configure check/add --gc-sections linker option · 6a851e3a
      Rich Felker 提交于
      this allowing the linker to drop certain weak definitions that are
      only used as dummies for static linking. they could be eliminated for
      shared library builds using the preprocessor instead, but we are
      trying to transition to using the same object files for shared and
      static libc, so a link-time solution is preferable.
      6a851e3a
    • R
      have configure check/add linker options to reduce size lost to padding · 2efd38e8
      Rich Felker 提交于
      based on patch by Denys Vlasenko. sorting sections and common data
      symbols by alignment acts as an approximation for optimal packing,
      which the linker does not actually support.
      2efd38e8
    • R
      have configure check/add -ffunction-sections and -fdata-sections · 27c1eccf
      Rich Felker 提交于
      based on patch by Denys Vlasenko. the original intent for using these
      options was to enable linking optimizations. these are immediately
      available for static linking applications to libc.a, and will also be
      used for linking libc.so in a subsequent commit.
      
      in addition to the original motives, this change works around a whole
      class of toolchain bugs where the compiler generates relative address
      expressions using a weak symbol and the assembler "optimizes out" the
      relocation which should result by using the weak definition. (see gas
      pr 18561 and gcc pr 66609, 68178, etc. for examples.) by having
      different functions and data objects in their own sections, all
      relative address expressions are cross-section and thus cannot be
      resolved to constants until link time. this allows us to retain
      support for affected compiler/assembler versions without invasive
      and fragile source-level workarounds.
      27c1eccf
  7. 03 11月, 2015 7 次提交
    • R
      fix mismatched parens in CMPLX def for annex-g-conforming compilers · 2f1d1f1e
      Rich Felker 提交于
      this conditional path was never tested because there are no compilers
      that conform to annex g (none with _Imaginary_I).
      2f1d1f1e
    • R
      generalize sh entry point asm not to assume call dests fit in 12 bits · 4fcb4827
      Rich Felker 提交于
      this assumption is borderline-unsafe to begin with, and fails badly
      with -ffunction-sections since the linker can move the callee
      arbitrarily far away when it lies in a different section.
      4fcb4827
    • R
      keep user-provided CFLAGS/LDFLAGS separate from those added by configure · 4cd8b472
      Rich Felker 提交于
      this way, overriding these variables on the make command line (or just
      re-passing the originally-passed values when invoking make) won't
      suppress use of the flags added by configure.
      4cd8b472
    • R
      fix mremap memory synchronization and use of variadic argument · fda365a5
      Rich Felker 提交于
      since mremap with the MREMAP_FIXED flag is an operation that unmaps
      existing mappings, it needs to use the vm lock mechanism to ensure
      that any in-progress synchronization operations using vm identities
      from before the call have finished.
      
      also, the variadic argument was erroneously being read even if the
      MREMAP_FIXED flag was not passed. in practice this didn't break
      anything, but it's UB and in theory LTO could turn it into a hard
      error.
      fda365a5
    • D
      prevent allocs than PTRDIFF_MAX via mremap · f9ecb6bf
      Daniel Micay 提交于
      It's quite feasible for this to happen via MREMAP_MAYMOVE.
      f9ecb6bf
    • R
      use explicit __cp_cancel label in cancellable syscall asm for all archs · 36e8b6a2
      Rich Felker 提交于
      previously, only archs that needed to do stack cleanup defined a
      __cp_cancel label for acting on cancellation in their syscall asm, and
      a default definition was provided by a weak alias to __cancel, the C
      function. this resulted in wrong codegen for arm on gcc versions
      affected by pr 68178 and possibly similar issues (like pr 66609) on
      other archs, and also created an inconsistency where the __cp_begin
      and __cp_end labels were treated as const data but __cp_cancel was
      treated as a function. this in turn caused incorrect code generation
      on archs where function pointers point to function descriptors rather
      than code (for now, only sh/fdpic).
      36e8b6a2
    • R
      properly access mcontext_t program counter in cancellation handler · cb1bf2f3
      Rich Felker 提交于
      using the actual mcontext_t definition rather than an overlaid pointer
      array both improves correctness/readability and eliminates some ugly
      hacks for archs with 64-bit registers bit 32-bit program counter.
      
      also fix UB due to comparison of pointers not in a common array
      object.
      cb1bf2f3
  8. 29 10月, 2015 1 次提交
    • R
      fix missing bss handling in FDPIC ELF loader · fead7e3f
      Rich Felker 提交于
      when a library being loaded has bss (i.e. data segment with
      p_memsz>p_filesz), this region needs to be zeroed with a combination
      of memset and/or mmap. the regular ELF loader always did this but the
      FDPIC code path omitted it, leading to objects in bss having
      uninitialized/junk contents.
      fead7e3f
  9. 27 10月, 2015 2 次提交
    • H
      getnameinfo: make size check not fail for bigger sizes · 6eada2ed
      Hauke Mehrtens 提交于
      getnameinfo() compares the size of the given struct sockaddr with
      sizeof(struct sockaddr_in) and sizeof(struct sockaddr_in6) depending on
      the net family. When you add a sockaddr of size sizeof(struct
      sockaddr_storage) this function will fail because the size of the
      sockaddr is too big. Change the check that it only fails if the size is
      too small, but make it work when it is too big for example when someone
      calls this function with a struct sockaddr_storage and its size.
      This fixes a problem with IoTivity 1.0.0 and musl.
      
      glibc and bionic are only failing if it is smaller, net/freebsd
      implemented the != check.
      Signed-off-by: NHauke Mehrtens <hauke@hauke-m.de>
      6eada2ed
    • R
      safely handle failure to open hosts, services, resolv.conf files · 2683e267
      Rich Felker 提交于
      previously, transient failures like fd exhaustion or other
      resource-related errors were treated the same as non-existence of
      these files, leading to fallbacks or false-negative results. in
      particular:
      
      - failure to open hosts resulted in fallback to dns, possibly yielding
        EAI_NONAME for a hostname that should be defined locally, or an
        unwanted result from dns that the hosts file was intended to
        replace.
      
      - failure to open services resulted in EAI_SERVICE.
      
      - failure to open resolv.conf resulted in querying localhost rather
        than the configured nameservers.
      
      now, only permanent errors trigger the fallback behaviors above; all
      other errors are reportable to the caller as EAI_SYSTEM.
      2683e267
  10. 25 10月, 2015 1 次提交
    • R
      fix single-byte overflow of malloc'd buffer in getdelim · b114190b
      Rich Felker 提交于
      the buffer enlargement logic here accounted for the terminating null
      byte, but not for the possibility of hitting the delimiter in the
      buffer-refill code path that uses getc_unlocked, in which case two
      additional bytes (the delimiter and the null termination) are written
      without another chance to enlarge the buffer.
      
      this patch and the corresponding bug report are by Felix Janda.
      b114190b
  11. 23 10月, 2015 2 次提交
    • R
      prevent user CFLAGS overrides from exposing executable stack · bc0c4841
      Rich Felker 提交于
      the option to suppress executable stack tagging was placed in CFLAGS,
      which is treated as optional and overridable by the build system. if a
      user replaces CFLAGS after configure has run, it could get lost,
      resulting in a libc.so that's flagged as needing executable stack,
      which would cause the kernel to map the initial stack as executable.
      
      move -Wa,--noexecstack to CFLAGS_C99FSE, the make variable used for
      mandatory compiler options.
      bc0c4841
    • R
      fix breakage when user overrides CFLAGS on the make command line · be76cdcf
      Rich Felker 提交于
      these per-target CFLAGS adjustments are mandatory additions to the
      command line for building the affected targets, not part of the
      user-provided CFLAGS for tuning. my intent was always that the
      variable append operations would take place after user settings, but
      when a variable is set on the command line, it overrides all
      definitions in the makefile, including target-specific ones.
      
      based on patch by Szabolcs Nagy.
      be76cdcf
  12. 20 10月, 2015 1 次提交
  13. 19 10月, 2015 1 次提交
  14. 16 10月, 2015 6 次提交
    • B
      add missing memory barrier to pthread_join · 53cd8c5a
      Bobby Bingham 提交于
      POSIX requires pthread_join to synchronize memory on success.  The
      futex wait inside __timedwait_cp cannot handle this because it's not
      called in all cases.  Also, in the case of a spurious wake, tid can
      become zero between the wake and when the joining thread checks it.
      53cd8c5a
    • R
      fix dladdr treatment of function descriptors for fdpic · bde0b4b9
      Rich Felker 提交于
      when determining which module an address belongs to, all function
      descriptor ranges must be checked first, in case the allocated memory
      falls inside another module's memory range.
      
      dladdr itself must also check addresses against function descriptors
      before doing a best-match search against the symbol table. even when
      doing the latter (e.g. for code addresses obtained from mcontext_t),
      also check whether the best-match was a function, and if so, replace
      the result with a function descriptor address. which is the nominal
      "base address" of the function and which the caller needs if it
      intends to subsequently call the matching function.
      bde0b4b9
    • R
      fix visibility mismatch in dynamic linker stage 2 function definition · bc9b6ea0
      Rich Felker 提交于
      since commits 2907afb8 and
      6fc30c24, __dls2 is no longer called
      via symbol lookup, but instead uses relative addressing that needs to
      be resolved at link time. on some linker versions, and/or if
      -Bsymbolic-functions is not used, the linker may leave behind a
      dynamic relocation, which is not suitable for bootstrapping the
      dynamic linker, if the reference to __dls2 is marked hidden but the
      definition is not actually hidden. correcting the definition to use
      hidden visibility fixes the problem.
      
      the static-PIE entry point rcrt1 was likewise affected and is also
      fixed by this patch.
      bc9b6ea0
    • R
      suppress sh assembler rejection of instructions based on isa level · 79789980
      Rich Felker 提交于
      we need access to all instructions in order for runtime selection of
      atomic model to work correctly. without this patch, some versions of
      gcc instruct gas to reject instructions outside the target isa level.
      79789980
    • R
      prevent reordering of or1k and powerpc thread pointer loads · 92637bb0
      Rich Felker 提交于
      other archs use asm for the thread pointer load, so making that asm
      volatile is sufficient to inform the compiler that it has a "side
      effect" (crashing or giving the wrong result if the thread pointer was
      not yet initialized) that prevents reordering. however, powerpc and
      or1k have dedicated general purpose registers for the thread pointer
      and did not need to use any asm to access it; instead, "local register
      variables with a specified register" were used. however, there is no
      specification for ordering constraints on this type of usage, and
      presumably use of the thread pointer could be reordered across its
      initialization.
      
      to impose an ordering, I have added empty volatile asm blocks that
      produce the "local register variable with a specified register" as
      an output constraint.
      92637bb0
    • R
      mark arm thread-pointer-loading inline asm as volatile · 74483c59
      Rich Felker 提交于
      this builds on commits a603a75a and
      0ba35d69 to ensure that a compiler
      cannot conclude that it's valid to reorder the asm to a point before
      the thread pointer is set up, or to treat the inline function as if it
      were declared with attribute((const)).
      
      other archs already use volatile asm for thread pointer loading.
      74483c59
  15. 15 10月, 2015 4 次提交
  16. 14 10月, 2015 3 次提交