1. 15 3月, 2017 9 次提交
    • S
      fix threshold constants in j0f, y0f, j1f, y1f · 8cba1dc4
      Szabolcs Nagy 提交于
      partly following freebsd rev 279491
      https://svnweb.freebsd.org/base?view=revision&revision=279491
      (musl had some of the fixes before freebsd).
      
      the change should not matter much for j0f, y0f, but it improves
      j1f and y1f in [2.5,~3.75] (that is [0x40200000,~0x40700000]).
      near roots (e.g. around 3.8317 for j1f) there are still large
      ulp errors.
      
      dropped code that tried to raise inexact.
      8cba1dc4
    • R
      remove unused refcnt field for shared libraries · cb525397
      Rich Felker 提交于
      cb525397
    • R
      avoid loading of multiple libc versions via explicit pathname · c49d3c8a
      Rich Felker 提交于
      such loading is unsafe, and can happen when programs use their own
      logic to locate a .so file then pass the absolute pathname to dlopen,
      or if an absolute pathname ends up in DT_NEEDED headers. multiple
      loads with only the base name were already precluded, provided libc
      was named appropriately, by special-casing standard library names.
      
      one function symbol (in the reserved namespace, but public, since it's
      part of the crt1 entry point ABI) and one data symbol are checked.
      this way we avoid likely false positives, particularly from libraries
      interposing and wrapping functions. there is no hard requirement to
      avoid breaking such usage, since trying to run a hook before libc is
      even initialized is not a supported usage case, but it's friendlier
      not to break things.
      c49d3c8a
    • R
      fix one-byte overflow in legacy getpass function · 3ec8b3ae
      Rich Felker 提交于
      if the length of the input was equal to the buffer size (128), a fixed
      value of zero was written one byte past the end of the static buffer.
      3ec8b3ae
    • R
      733d1ea7
    • R
    • R
      in static dl_iterate_phdr, fix use of possibly-uninitialized aux data · 500f5bee
      Rich Felker 提交于
      this could only happen if an incomplete auxv was passed into the
      program, but it's better to just initialize the data anyway.
      500f5bee
    • R
      fix free of uninitialized buffer pointer on error in regexec · 6582baa7
      Rich Felker 提交于
      the fix in commit c3edc06d for
      CVE-2016-8859 used gotos to exit on overflow conditions, but the code
      in that error path assumed the buffer pointer was valid or null. thus,
      the conditions which previously led to under-allocation and buffer
      overflow could instead lead to an invalid pointer being passed to
      free.
      6582baa7
    • R
      emulate lazy relocation as deferrable relocation · 6476b813
      Rich Felker 提交于
      traditional lazy relocation with call-time plt resolver is
      intentionally not implemented, as it is a huge bug surface and demands
      significant amounts of arch-specific code and requires ongoing
      maintenance to ensure compatibility with applications which make use
      of new additions to the arch's register file in passing function
      arguments.
      
      some applications, however, depend on the ability to dlopen modules
      which have unsatisfied symbol references at the time they are loaded,
      either avoiding use of the affected interfaces or manually loading
      another module to provide the missing definition via their own module
      dependency tracking outside the ELF data structures. while such usage
      is non-conforming, failure to support it has been a significant
      obstacle for users/distributions trying to support affected software,
      particularly the X.org server.
      
      instead of resolving lazy relocations at call time, this patch saves
      unresolved GOT/PLT relocations for deferral and retries them after
      each subsequent dlopen until they are resolved. since dlopen is the
      only time at which the effective global symbol table can change, this
      behavior is not observably different from traditional lazy binding,
      and the required code is minimal.
      6476b813
  2. 13 3月, 2017 2 次提交
    • R
      reorder addend handling before symbol lookup in relocation code · 4823b13a
      Rich Felker 提交于
      these two tasks are independent now, but in order to support lazy
      relocations, the failure path for symbol lookup may want the addend to
      be available.
      4823b13a
    • R
      rework ldso handling of global symbol table for consistency · 4ff234f6
      Rich Felker 提交于
      when loading libraries with dlopen, the caller can request that the
      library's symbols become part of the global symbol table, or that they
      only be used for resolving relocations in the loaded library and its
      dependencies. in the latter case, a subsequent dlopen of the same
      library can upgrade it to global status.
      
      previously, if a library was upgraded from local to global mode, its
      symbols entered the symbol lookup search order at the point where the
      library was originally loaded. this means that a new call to dlopen
      could change the value of a symbol that already had a visible
      definition, an inconsistency which applications could observe.
      
      POSIX is unclear whether this should happen or whether it's permitted
      to happen, but the resolution of Austin Group issue #982 made it
      formally unspecified.
      
      with this patch, a library whose mode is upgraded from local to global
      enters the symbol lookup order at the point where it was made global,
      so that symbol resolution before and after the upgrade are consistent.
      
      in order to implement this change, the per-dso global flag is replaced
      with a separate set of linked-list pointers for participation in the
      global symbol table. this permits the order of dso objects for symbol
      resolution to differ from the order used for iteration of all loaded
      libraries. it also improves performance of find_sym, by avoiding a
      branch per iteration and skipping, and especially in the case where
      many non-global libraries have been loaded, by allowing the loop to
      skip over them entirely. logic for temporarily adding non-global
      libraries to the symbol table for relocation purposes is also mildly
      simplified.
      4ff234f6
  3. 12 3月, 2017 1 次提交
    • S
      treat STB_WEAK and STB_GNU_UNIQUE like STB_GLOBAL in find_sym · c9783e4d
      Szabolcs Nagy 提交于
      A weak symbol definition is not special during dynamic linking, so
      don't let a strong definition in a later module override it.
      (glibc dynamic linker allows overriding weak definitions if
      LD_DYNAMIC_WEAK is set, musl does not.)
      
      STB_GNU_UNIQUE means that the symbol is global, even if it is in a
      module that's loaded with RTLD_LOCAL, and all references resolve to
      the same definition. This semantics is only relevant for c++ plugin
      systems and even there it's often not what the user wants (so it can
      be turned off in g++ by -fno-gnu-unique when the c++ shared lib is
      compiled). In musl just treat it like STB_GLOBAL.
      c9783e4d
  4. 09 3月, 2017 1 次提交
    • R
      fix ld-behavior-dependent crash in ppc64 ldso startup · fc85fb38
      Rich Felker 提交于
      the 32-bit pc-relative address for stage 2 of dynamic linker entry was
      wrongly loaded with a zero-extending load instead of sign-extending
      load, resulting in an invalid jump if the offset happened to be
      negative, which depends on the linker's ordering of text sections.
      fc85fb38
  5. 06 3月, 2017 1 次提交
    • S
      fix lsearch and lfind to pass key as first arg to the compar callback · 827c4e6f
      Szabolcs Nagy 提交于
      this is not a conformance issue as posix does not specify the
      argument order, but the order is specified for bsearch and some
      systems document the order for lsearch consistently (openbsd).
      
      since there were two indpendent reports of this issue it's better
      to use the more widely expected argument order.
      827c4e6f
  6. 23 2月, 2017 1 次提交
    • R
      allow page size to vary on arm · 0a4a16d1
      Rich Felker 提交于
      the ABI for arm was silently changed at some point to allow page sizes
      other than 4k; traditional binaries built with only 4k-aligned offsets
      between load segments cannot run on such systems, but newer binutils
      versions use 64k offset alignment.
      
      while larger page size is undesirable for various reasons, users have
      encountered hardware and/or kernels that lock the page size to a
      larger value, so follow the new ABI and allow it to vary.
      0a4a16d1
  7. 16 2月, 2017 2 次提交
    • R
      fix build regression in arm atomics asm with new binutils · b261a242
      Rich Felker 提交于
      binutils commit bada43421274615d0d5f629a61a60b7daa71bc15 tightened
      immediate fixup handling in gas in such a way that the final .arch of
      an object file must be compatible with the fixups used when the
      instruction was assembled; this in turn broke assembling of atomics.s,
      at least in thumb mode.
      
      it's not clear whether this should be considered a bug in gas, but
      .object_arch is preferable anyway for our purpose here of controlling
      the ISA level tag on the object file being produced, and it's the
      intended directive for use in object files with runtime code
      selection. research by Szabolcs Nagy confirmed that .object_arch is
      supported in all relevant versions of binutils and clang's integrated
      assembler.
      
      patch by Reiner Herrmann.
      b261a242
    • B
      s390x: implement dlsym · 9201c3af
      Bobby Bingham 提交于
      This was missed when writing the port initially.
      9201c3af
  8. 30 1月, 2017 2 次提交
    • R
      avoid unbounded strlen in gettext functions · d6601f0a
      Rich Felker 提交于
      use the standard strnlen idiom for cases where lengths greater than an
      imposed limit are going to be rejected immediately anyway.
      d6601f0a
    • R
      fix use of uninitialized pointer in gettext core · dbbb3734
      Rich Felker 提交于
      the plural_rule field of allocated msgcat structures was assumed to be
      initially-null but was never initialized. for future-proofing, the
      nplurals field which was left uninitialized should also be cleared.
      
      likewise, in the binding structure, the active field could be used
      uninitialized by a technicality: the a_store which stores the initial
      value of 0 may be implemented as a cas operation, which reads the old
      value.
      
      rather than fixing these issues individually, just use calloc for both
      allocations. this does result in wasteful clearing of name buffers (up
      to NAME_MAX+PATH_MAX) before filling them, but since the size if
      bounded and the time is dominated by filesystem operations, it really
      doesn't matter; simplicity and future-proofing have more value here.
      
      modified from patch submitted by He X.
      dbbb3734
  9. 29 1月, 2017 1 次提交
  10. 20 1月, 2017 1 次提交
    • R
      fix spurious EINTR errors from multithreaded set*id, etc. · 6894f847
      Rich Felker 提交于
      commit 78a8ef47 inadvertently removed
      the SA_RESTART flag from the sigaction for the internal signal handler
      used by __synccall for broadcasting. as a result, programs which did
      not use interrupting signals but which used set*id() in a
      multithreaded context could wrongly observe EINTR errors they're not
      prepared to handle.
      6894f847
  11. 13 1月, 2017 1 次提交
    • R
      fix crashes in x32 __tls_get_addr · 1f53e7d0
      rofl0r 提交于
      x32 has another gratuitous difference to all other archs:
      it passes an array of 64bit values to __tls_get_addr().
      usually it is an array of size_t.
      1f53e7d0
  12. 05 1月, 2017 4 次提交
    • R
      fix crash from corrupted tls module list after failed dlopen · 27b3fd68
      Rich Felker 提交于
      commit d56460c9 introduced this
      regression as part of splitting the tls module list out of the dso
      list. the new code added to dlopen's failure path to undo the changes
      adding the partially-loaded libraries reset the tls_tail pointer
      correctly, but did not clear its link to the next list entry. thus, at
      least until the next successful dlopen, the list was not terminated
      but ended with an invalid next pointer, which __copy_tls attempted to
      follow when a new thread was created.
      
      patch by Mikael Vidstedt.
      27b3fd68
    • R
      treat base 1 as an error in strtol-family functions · 809ff8cf
      Rich Felker 提交于
      ISO C and POSIX only specify behavior for base arguments of 0 and
      2-36; POSIX mandates an EINVAL error for unsupported bases. it's not
      clear that there's a requirement for implementations not to "support"
      additional bases as an extension, but "base 1" did not work in any
      meaningful way anyway, so it should be considered unsupported and thus
      an error.
      809ff8cf
    • R
      fix getopt[_long] clobbering of optopt on success · 786fda87
      Rich Felker 提交于
      getopt is only specified to modify optopt on error, and some software
      apparently infers an error from optopt!=0.
      
      getopt_long is changed analogously. the resulting behavior differs
      slightly from the behavior of the GNU implementation of getopt_long,
      which keeps an internal shadow copy of optopt and copies it to the
      public one on return, but since the GNU implementation also exhibits
      this shadow-copy behavior for plain getopt where is is non-conforming,
      I think this can reasonably be considered a bug rather than an
      intentional behavior that merits mimicing.
      786fda87
    • R
      reduce impact of REG_* namespace pollution in x86[_64] signal.h · 150747b4
      Rich Felker 提交于
      when _GNU_SOURCE is defined, which is always the case when compiling
      c++ with gcc, these macros for the the indices in gregset_t are
      exposed and likely to clash with applications. by using enum constants
      rather than macros defined with integer literals, we can make the
      clash slightly less likely to break software. the macros are still
      defined in case anything checks for them with #ifdef, but they're
      defined to expand to themselves so that non-file-scope (e.g.
      namespaced) identifiers by the same names still work.
      
      for the sake of avoiding mistakes, the changes were generated with sed
      via the command:
      
      sed -i -e 's/#define  *\(REG_[A-Z_0-9]\{1,\}\)  *\([0-9]\{1,\}\)'\
      '/enum { \1 = \2 };\n#define \1 \1/' \
      arch/i386/bits/signal.h arch/x86_64/bits/signal.h arch/x32/bits/signal.h
      150747b4
  13. 03 1月, 2017 2 次提交
    • R
      make globfree safe after failed glob from over-length argument · 769f5359
      Rich Felker 提交于
      commit 0dc99ac4 added input length
      checking to avoid unsafe VLA allocation, but put it in the wrong
      place, before the glob_t structure was zeroed out. while POSIX isn't
      clear on whether it's permitted to call globfree after glob failed
      with GLOB_NOSPACE, making it safe is clearly better than letting
      uninitialized pointers get passed to free in non-conforming callers.
      
      while we're fixing this, change strlen check to the idiomatic strnlen
      version to avoid unbounded input scanning before returning an error.
      769f5359
    • R
      fix strftime %y for negative years · 61fb81e3
      Rich Felker 提交于
      commit 583ea835 fixed the case where
      tm_year is negative but the resulting year (offset by 1900) was still
      positive, which is always the case for time_t values that fit in 32
      bits, but not for arbitrary inputs.
      
      based on an earlier patch by Julien Ramseier which was overlooked at
      the time the previous fix was applied.
      61fb81e3
  14. 01 1月, 2017 1 次提交
  15. 30 12月, 2016 3 次提交
  16. 21 12月, 2016 1 次提交
    • R
      fix support for initialized TLS in static PIE binaries · 5bf7eba2
      Rich Felker 提交于
      the static-linked version of __init_tls needs to locate the TLS
      initialization image via the ELF program headers, which requires
      determining the base address at which the program was loaded. the
      existing code attempted to do this by comparing the actual address of
      the program headers (obtained via auxv) with the virtual address for
      the PT_PHDR record in the program headers. however, the linker seems
      to produce a PT_PHDR record only when a program interpreter (dynamic
      linker) is used. thus the computation failed and used the default base
      address of 0, leading to a crash when trying to access the TLS image
      at the wrong address.
      
      the dynamic linker entry point and static-PIE rcrt1.o startup code
      compute the base address instead by taking the difference between the
      run-time address of _DYNAMIC and the virtual address in the PT_DYNAMIC
      record. this patch copies the approach they use, but with a weak
      symbolic reference to _DYNAMIC instead of obtaining the address from
      the crt_arch.h asm. this works because relocations have already been
      performed at the time __init_tls is called.
      5bf7eba2
  17. 20 12月, 2016 2 次提交
    • R
      when building for arm as thumb2 code, also request assembly as thumb · 088c9674
      Rich Felker 提交于
      all assembly is now thumb2-compatible. on existing targets this is at
      best a size optimization, but it will also facilitate porting to
      thumb2-isa-only arm variants.
      088c9674
    • R
      rework arm atomic/tp backends to be thumb-compatible and fdpic-ready · 29237f7f
      Rich Felker 提交于
      three problems are addressed:
      
      - use of pc arithmetic, which was difficult if not impossible to make
        correct in thumb mode on all models, so that relative rather than
        absolute pointers to the backends could be used. this was designed
        back when there was no coherent model for the early stages of the
        dynamic linker before relocations, and is no longer necessary.
      
      - assumption that data (the relative pointers to the backends) can be
        accessed at a constant displacement from the code. this will not be
        possible on future fdpic subarchs (for cortex-m), so move
        responsibility for loading the backend code address to the caller.
      
      - hard-coded arm opcodes using the .word directive. instead, use the
        .arch directive to work around the assembler's refusal to assemble
        instructions not available (or in some cases, available but just
        considered deprecated) in the target isa level. the obscure v6t2
        arch is used for v6 code so as to (1) allow generation of thumb2
        output if -mthumb is active, and (2) avoid warnings/errors for mcr
        barriers that clang would produce if we just set arch to v7-a.
      
      in addition, the __aeabi_read_tp function is moved out of the inner
      workings and implemented as an asm wrapper around a C function, so
      that asm code does not need to read global data. the asm wrapper
      serves to satisfy the ABI calling convention requirements for this
      function.
      29237f7f
  18. 18 12月, 2016 3 次提交
  19. 17 12月, 2016 2 次提交
    • S
      handle ^ and $ in BRE subexpression start and end as anchors · 7a4c25d7
      Szabolcs Nagy 提交于
      In BRE, ^ is an anchor at the beginning of an expression, optionally
      it may be an anchor at the beginning of a subexpression and must be
      treated as a literal otherwise.
      
      Previously musl treated ^ in subexpressions as literal, but at least
      glibc and gnu sed treats it as an anchor and that's the more useful
      behaviour: it can always be escaped to get back the literal meaning.
      
      Same for $ at the end of a subexpression.
      
      Portable BRE should not rely on this, but there are sed commands in
      build scripts which do.
      
      This changes the meaning of the BREs:
      
      	\(^a\)
      	\(a\|^b\)
      	\(a$\)
      	\(a$\|b\)
      7a4c25d7
    • R
      fix mrand48/jrand48 return value on 64-bit archs · adfe682e
      Rich Felker 提交于
      POSIX specifies the result to have signed 32-bit range. on 32-bit
      archs, the implicit conversion to long achieved the desired range
      already, but when long is 64-bit, a cast is needed.
      
      patch by Ed Schouten.
      adfe682e