1. 07 9月, 2019 3 次提交
    • R
      synchronously clean up pthread_create failure due to scheduling errors · 8a544ee3
      Rich Felker 提交于
      previously, when pthread_create failed due to inability to set
      explicit scheduling according to the requested attributes, the nascent
      thread was detached and made responsible for its own cleanup via the
      standard pthread_exit code path. this left it consuming resources
      potentially well after pthread_create returned, in a way that the
      application could not see or mitigate, and unnecessarily exposed its
      existence to the rest of the implementation via the global thread
      list.
      
      instead, attempt explicit scheduling early and reuse the failure path
      for __clone failure if it fails. the nascent thread's exit futex is
      not needed for unlocking the thread list, since the thread calling
      pthread_create holds the thread list lock the whole time, so it can be
      repurposed to ensure the thread has finished exiting. no pthread_exit
      is needed, and freeing the stack, if needed, can happen just as it
      would if __clone failed.
      8a544ee3
    • R
      set explicit scheduling for new thread from calling thread, not self · 022f27d5
      Rich Felker 提交于
      if setting scheduling properties succeeds, the new thread may end up
      with lower priority than the caller, and may be unable to continue
      running due to another intermediate-priority thread. this produces a
      priority inversion situation for the thread calling pthread_create,
      since it cannot return until the new thread reports success.
      
      originally, the parent was responsible for setting the new thread's
      priority; commits b8742f32 and
      40bae2d3 changed it as part of
      trimming down the pthread structure. since then, commit
      04335d92 partly reversed the changes,
      but did not switch responsibilities back. do that now.
      022f27d5
    • R
      fix unsynchronized decrement of thread count on pthread_create error · dd0a23dd
      Rich Felker 提交于
      commit 8f11e612 wrongly documented
      that all changes to libc.threads_minus_1 were guarded by the thread
      list lock, but the decrement for failed SYS_clone took place after the
      thread list lock was released.
      dd0a23dd
  2. 31 8月, 2019 2 次提交
    • R
      add public declaration for optreset under appropriate feature profiles · a882841b
      Rich Felker 提交于
      commit 030e5263 added optreset, a BSD
      extension to getopt duplicating the functionality (also an extension)
      of setting optind to 0, but failed to provide a public declaration for
      it. according to the BSD documentation and headers, the application is
      not supposed to need to provide its own declaration.
      a882841b
    • R
      add posix_spawn [f]chdir file actions · 74244e5b
      Rich Felker 提交于
      these are presently extensions, thus named with _np to match glibc and
      other implementations that provide them; however they are likely to be
      standardized in the future without the _np suffix as a result of
      Austin Group issue 1208. if so, both names will be kept as aliases.
      74244e5b
  3. 24 8月, 2019 1 次提交
  4. 19 8月, 2019 1 次提交
    • R
      fix clash between sys/user.h and kernel ptrace.h on powerpc[64], sh · 6ad514e4
      Rich Felker 提交于
      due to historical accident/sloppiness in glibc, the powerpc,
      powerpc64, and sh versions of struct user, defined by sys/user.h, used
      struct pt_regs from the kernel asm/ptrace.h for their regs member.
      this made it impossible to define the type in an API-compatible manner
      without either including asm/ptrace.h like glibc does (contrary to our
      policy of not depending on kernel headers), or clashing with
      asm/ptrace.h's definition of struct pt_regs if both headers are
      included (which is almost always the case in software using
      sys/user.h).
      
      for a long time I viewed this problem as having no reasonable fix. I
      even explored the possibility of having the powerpc[64] and sh
      versions of user.h just include the kernel header (breaking with
      policy), but that looked like it might introduce new clashes with
      sys/ptrace.h. and it would also bring in a lot of additional cruft
      that makes no sense for sys/user.h to expose. glibc goes out of its
      way to suppress some of that with #undef, possibly leading to
      different problems. this is a rabbit-hole that should be explored no
      further.
      
      as it turns out, however, nothing actually uses struct user
      sufficiently to care about the type of the regs member; most software
      including sys/user.h does not even use struct user at all. so, the
      problem can be fixed just by doing away with the insistence on strict
      glibc API compatibility for the struct tag of the regs member.
      
      rather than renaming the tag, which might lead to the new name
      entering use as API, simply use an untagged structure inside struct
      user with the same members/layout as struct pt_regs.
      
      for sh, struct pt_dspregs is just removed entirely since it was not
      used.
      6ad514e4
  5. 18 8月, 2019 1 次提交
  6. 15 8月, 2019 1 次提交
    • R
      remove sporadic server members from struct sched_param · 827aa8fb
      Rich Felker 提交于
      these members are associated with an unsupported option group. with
      time_t changing size on 32-bit archs, all interfaces taking struct
      sched_param arguments would need redirection and compat shims in order
      to be able to continue offering these members, for no benefit. just
      convert them to reserved space instead.
      827aa8fb
  7. 14 8月, 2019 2 次提交
    • K
      re-add ELF gregs and fpregs types to riscv64 user.h · 29e8737f
      Khem Raj 提交于
      d493206d deleted all the content of
      user.h, but sys/procfs.h expects this from sys/user.h
      threfore we retain the non conflicting parts
      29e8737f
    • R
      fix regression whereby main thread didn't get TLS relocations · 9d35fec9
      Rich Felker 提交于
      commit ffab4360 broke this by moving
      relocations after not only the allocation of storage for the main
      thread's static TLS, but after the copying of the TLS image. thus,
      relocation results were not reflected in the main thread's copy. this
      could be fixed by calling __reset_tls after relocations, but instead
      split the allocation and installation before/after relocations so that
      there's not a redundant copy.
      
      due to commit 71af5309, updating of
      static_tls_cnt needs to be kept with allocation of static TLS, before
      relocations, rather than after installation.
      9d35fec9
  8. 13 8月, 2019 3 次提交
    • R
      fix accidentlly-external cmp symbol introduced with catgets · b19fa247
      Rich Felker 提交于
      commit 7590203c omitted static here.
      b19fa247
    • S
      make relocation time symbol lookup and dlsym consistent · f2435263
      Szabolcs Nagy 提交于
      Using common code path for all symbol lookups fixes three dlsym issues:
      
      - st_shndx of STT_TLS symbols were not checked and thus an undefined
        tls symbol reference could be incorrectly treated as a definition
        (the sysv hash lookup returns undefined symbols, gnu does not, so should
        be rare in practice).
      
      - symbol binding was not checked so a hidden symbol may be returned
        (in principle STB_LOCAL symbols may appear in the dynamic symbol table
        for hidden symbols, but linkers most likely don't produce it).
      
      - mips specific behaviour was not applied (ARCH_SYM_REJECT_UND) so
        undefined symbols may be returned on mips.
      
      always_inline is used to avoid relocation performance regression, the
      code generation for find_sym should not be affected.
      f2435263
    • R
      ldso: correct condition for local symbol handling in do_relocs · 1f060ed2
      Rich Felker 提交于
      commit 7a9669e9 added use of the
      symbol reference as the definition, in place of performing a lookup,
      for STT_SECTION symbol references that were first found used in FDPIC.
      such references may happen in certain other cases, such as
      local-dynamic TLS and with relocation types that require a symbol but
      that are being used for non-symbolic purposes, like the powerpc
      unaligned address relocations.
      
      in all such cases I'm aware of, the symbol referenced is a section
      symbol (STT_SECTION); however, the important semantic property is not
      its being a section, but rather its binding local (STB_LOCAL). check
      the latter instead of the former for greater generality and semantic
      correctness.
      1f060ed2
  9. 12 8月, 2019 1 次提交
    • S
      add support for powerpc/powerpc64 unaligned relocations · 08869deb
      Samuel Holland 提交于
      R_PPC_UADDR32 (R_PPC64_UADDR64) has the same meaning as R_PPC_ADDR32
      (R_PPC64_ADDR64), except that its address need not be aligned. For
      powerpc64, BFD ld(1) will automatically convert between ADDR<->UADDR
      relocations when the address is/isn't at its native alignment. This
      will happen if, for example, there is a pointer in a packed struct.
      
      gold and lld do not currently generate R_PPC64_UADDR64, but pass
      through misaligned R_PPC64_ADDR64 relocations from object files,
      possibly relaxing them to misaligned R_PPC64_RELATIVE. In both cases
      (relaxed or not) this violates the PSABI, which defines the relevant
      field type as "a 64-bit field occupying 8 bytes, the alignment of
      which is 8 bytes unless otherwise specified."
      
      All three linkers violate the PSABI on 32-bit powerpc, where the only
      difference is that the field is 32 bits wide, aligned to 4 bytes.
      
      Currently musl fails to load executables linked by BFD ld containing
      R_PPC64_UADDR64, with the error "unsupported relocation type 43".
      This change provides compatibility with BFD ld on powerpc64, and any
      static linker on either architecture that starts following the PSABI
      more closely.
      08869deb
  10. 11 8月, 2019 2 次提交
    • R
      ldso: remove redundant runtime checks in static TLS logic · 71af5309
      Rich Felker 提交于
      as a result of commit ffab4360,
      static_tls_cnt is now valid during relocations at program startup, so
      it's no longer necessary to condition the check against static_tls_cnt
      on this being a runtime (dlopen) relocation.
      71af5309
    • R
      ldso: fix calloc misuse allocating initial tls · ffab4360
      Rich Felker 提交于
      this is analogous to commit 2f1f51ae,
      and should have been caught at the same time since it was right next
      to the code moved in that commit. between final stage 3 reloc_all and
      the jump to the main program's entry point, it is not valid to call
      any functions which may be interposed by the application; doing so
      results in execution of application code before ctors have run, and on
      fdpic archs, before the main program's fdpic self-fixups have taken
      place, which will produce runaway wrong execution.
      ffab4360
  11. 08 8月, 2019 5 次提交
  12. 07 8月, 2019 6 次提交
    • R
      fix regression in select with no timeout · d0b547df
      Rich Felker 提交于
      commit 722a1ae3 inadvertently passed a
      copy of {s,us} to the syscall even if the timeout argument tv was
      null, thereby causing immediate timeout (polling) in place of
      unlimited timeout. only archs using SYS_select were affected.
      d0b547df
    • R
      fix failure of glob to match broken symlinks under some conditions · e408deef
      Rich Felker 提交于
      when the pattern ended with one or more literal path components, or
      when the GLOB_MARK flag was passed to request that glob flag directory
      results and the type obtained by readdir was unknown or inconclusive
      (symlink), the stat function was called to evaluate existence and/or
      determine type. however, stat fails with ENOENT for broken symlinks,
      and this caused the match to be omitted from the results.
      
      instead, use stat only for the unknown/inconclusive cases with
      GLOB_MARK, and otherwise, or if stat fails, use lstat existence still
      needs to be determined. this minimizes the number of costly syscalls,
      performing both only in the case where GLOB_MARK is in use and there
      is a final literal path component which is a broken symlink.
      
      based on/simplified from patch by James Y Knight.
      e408deef
    • R
      remove riscv64 bits/user.h contents · d493206d
      Rich Felker 提交于
      the contents conflicted with asm/ptrace.h. glibc does not provide
      anything in user.h for riscv, so software cannot be depending on it.
      
      simplified from patch submitted by Baruch Siach.
      d493206d
    • B
      fix risc64 conflict with kernel headers · 8acc6885
      Baruch Siach 提交于
      Rename user registers struct definitions to avoid conflict with the
      asm/ptrace.h kernel header that defines the same structs. Use the
      __riscv_mc prefix as glibc does.
      8acc6885
    • P
      in arm cancellation point asm, don't unnecessarily preserve link register · e0e8ae75
      Patrick Oppenlander 提交于
      The only reason we needed to preserve the link register was because we
      were using a branch-link instruction to branch to __cp_cancel.
      Replacing this with a branch means we can avoid the save/restore as
      the link register is no longer modified.
      e0e8ae75
    • I
      glob: implement GLOB_TILDE and GLOB_TILDE_CHECK · 49eacf29
      Ismael Luceno 提交于
      49eacf29
  13. 06 8月, 2019 4 次提交
    • R
      use setitimer function rather than syscall to implement alarm · f522de81
      Rich Felker 提交于
      otherwise alarm will break on 32-bit archs when time_t is changed to
      64-bit. a second itimerval object is introduced for retrieving the old
      value, since the setitimer function has restrict-qualified arguments.
      f522de81
    • R
      fix build regression in i386 asm for atan2, atan2f · 6818c31c
      Rich Felker 提交于
      commit f3ed8bfe inadvertently removed
      labels that were still needed.
      6818c31c
    • R
      fix x87 stack imbalance in corner cases of i386 math asm · f3ed8bfe
      Rich Felker 提交于
      commit 31c5fb80 introduced underflow
      code paths for the i386 math asm, along with checks on the fpu status
      word to skip the underflow-generation instructions if the underflow
      flag was already raised. unfortunately, at least one such path, in
      log1p, returned with 2 items on the x87 stack rather than just 1 item
      for the return value. this is a violation of the ABI's calling
      convention, and could cause subsequent floating point code to produce
      NANs due to x87 stack overflow. if floating point results are used in
      flow control, this can lead to runaway wrong code execution.
      
      rather than reviewing each "underflow already raised" code path for
      correctness, remove them all. they're likely slower than just
      performing the underflow code unconditionally, and significantly more
      complex.
      
      all of this code should be ripped out and replaced by C source files
      with inline asm. doing so would preclude this kind of error by having
      the compiler perform all x87 stack register allocation and stack
      manipulation, and would produce comparable or better code. however
      such a change is a much larger project.
      f3ed8bfe
    • R
      fix regression in clock_gettime on 32-bit archs without vdso · 244778f7
      Rich Felker 提交于
      commit 72f50245 broke this by creating
      a code path where r is uninitialized.
      244778f7
  14. 04 8月, 2019 1 次提交
    • R
      update riscv64 syscall numbers to linux v5.1 · 6fcb440d
      Rich Felker 提交于
      commit f3f96f2d added these for the
      rest of the archs, but the patch it corresponded to missed riscv64
      since riscv64 was not yet upstream at the time. this caused commit
      dfc81828 to break riscv64 build, due
      to a wrong assumption that SYS_statx was unconditionally defined.
      6fcb440d
  15. 03 8月, 2019 1 次提交
    • R
      clock_gettime: add support for 32-bit vdso with 64-bit time_t · 0705fe93
      Rich Felker 提交于
      this fixes a major upcoming performance regression introduced by
      commit 72f50245, whereby 32-bit archs
      would lose vdso clock_gettime after switching to 64-bit time_t, unless
      the kernel supports time64 and provides a time64 version of the vdso
      function. this would incur not just one but two syscalls: first, the
      failed time64 syscall, then the fallback time32 one.
      
      overflow of the 32-bit result is detected and triggers a revert to
      syscalls. normally, on a system that's not Y2038-ready, this would
      still overflow, but if the process has been migrated to a
      time64-capable kernel or if the kernel has been hot-patched to add
      time64 syscalls, it may conceivably work.
      0705fe93
  16. 02 8月, 2019 5 次提交
    • R
      move IPC_STAT definition to a new bits/ipcstat.h file · 006a75a9
      Rich Felker 提交于
      otherwise, 32-bit archs that could otherwise share the generic
      bits/ipc.h would need to duplicate the struct ipc_perm definition,
      obscuring the fact that it's the same. sysvipc is not widely used and
      these headers are not commonly included, so there is no performance
      gain to be had by limiting the number of indirectly included files
      here.
      
      files with the existing time32 definition of IPC_STAT are added to all
      current 32-bit archs now, so that when it's changed the change will
      show up as a change rather than addition of a new file where it's less
      obvious that the value is changing vs the generic one that was used
      before.
      006a75a9
    • R
      fix missing declarations for pthread_join extensions in source file · 3541925f
      Rich Felker 提交于
      per policy, define the feature test macro to get declarations for the
      pthread_tryjoin_np and pthread_timedjoin_np functions. in the past
      this has been only for checking; with 32-bit archs getting 64-bit
      time_t it will also be necessary for symbols to get redirected
      correctly.
      3541925f
    • R
      allow archs to define IPC_STAT, propagate time64 bit to other macros · 3c02bacf
      Rich Felker 提交于
      to make use of {sem,shm,msg}ctl IPC_STAT functionality to provide
      64-bit time_t on 32-bit archs, IPC_STAT and related macros must be
      defined with bit 8 (0x100) set. allow archs to define IPC_STAT in
      bits/ipc.h, and define the other macros in terms of it so that they
      all get the same value of the time64 bit.
      3c02bacf
    • R
      clock_gettime: add time64 syscall support, decouple 32-bit time_t · 72f50245
      Rich Felker 提交于
      the time64 syscall has to be used if time_t is 64-bit, since there's
      no way of knowing before making a syscall whether the result will fit
      in 32 bits, and the 32-bit syscalls do not report overflow as an
      error.
      
      on 64-bit archs, there is no change to the code after preprocessing.
      on current 32-bit archs, the result is now read from the kernel
      through long[2] array, then copied into the timespec, to remove the
      assumption that time_t is the same as long.
      
      vdso clock_gettime is still used in place of a syscall if available.
      32-bit archs with 64-bit time_t must use the time64 version of the
      vdso function; if it's not available, performance will significantly
      suffer. support for both vdso functions could be added, but would
      break the ability to move a long-lived process from a pre-time64
      kernel to one that can outlast Y2038 with checkpoint/resume, at least
      without added hacks to identify that the 32-bit function is no longer
      usable and stop using it (e.g. by seeing negative tv_sec). this
      possibility may be explored in future work on the function.
      72f50245
    • R
      clock_adjtime: add time64 support, decouple 32-bit time_t, fix x32 · 2b4fd6f7
      Rich Felker 提交于
      the 64-bit/time64 version of the syscall is not API-compatible with
      the userspace timex structure definition; fields specified as long
      have type long long. so when using the time64 syscall, we have to
      convert the entire structure. this was always the case for x32 as
      well, but went unnoticed, meaning that clock_adjtime just passed junk
      to the kernel on x32. it should be fixed now.
      
      for the fallback case, we avoid encoding any assumptions about the new
      location of the time member or naming of the legacy slots by accessing
      them through a union of the kernel type and the new userspace type.
      the only assumption is that the non-time members live at the same
      offsets as in the (non-time64, long-based) kernel timex struct. this
      property saves us from having to convert the whole thing, and avoids a
      lot of additional work in compat shims.
      
      the new code is statically unreachable for now except on x32, where it
      fixes major brokenness. it is permanently unreachable on 64-bit.
      2b4fd6f7
  17. 01 8月, 2019 1 次提交
    • R
      ioctl: add fallback for new time64 SIOCGSTAMP[NS] · 2e554617
      Rich Felker 提交于
      without this, the SIOCGSTAMP and SIOCGSTAMPNS ioctl commands, for
      obtaining timestamps, would stop working on pre-5.1 kernels after
      time_t is switched to 64-bit and their values are changed to the new
      time64 versions.
      
      new code is written such that it's statically unreachable on 64-bit
      archs, and on existing 32-bit archs until the macro values are changed
      to activate 64-bit time_t.
      2e554617