1. 26 3月, 2014 2 次提交
  2. 25 3月, 2014 3 次提交
    • R
      fix pointer type mismatch and misplacement of const · 689e0e6b
      Rich Felker 提交于
      689e0e6b
    • T
      fix confstr return value · 0a8d9828
      Timo Teräs 提交于
      per the specification, the terminating null byte is counted.
      0a8d9828
    • R
      always initialize thread pointer at program start · dab441ae
      Rich Felker 提交于
      this is the first step in an overhaul aimed at greatly simplifying and
      optimizing everything dealing with thread-local state.
      
      previously, the thread pointer was initialized lazily on first access,
      or at program startup if stack protector was in use, or at certain
      random places where inconsistent state could be reached if it were not
      initialized early. while believed to be fully correct, the logic was
      fragile and non-obvious.
      
      in the first phase of the thread pointer overhaul, support is retained
      (and in some cases improved) for systems/situation where loading the
      thread pointer fails, e.g. old kernels.
      
      some notes on specific changes:
      
      - the confusing use of libc.main_thread as an indicator that the
        thread pointer is initialized is eliminated in favor of an explicit
        has_thread_pointer predicate.
      
      - sigaction no longer needs to ensure that the thread pointer is
        initialized before installing a signal handler (this was needed to
        prevent a situation where the signal handler caused the thread
        pointer to be initialized and the subsequent sigreturn cleared it
        again) but it still needs to ensure that implementation-internal
        thread-related signals are not blocked.
      
      - pthread tsd initialization for the main thread is deferred in a new
        manner to minimize bloat in the static-linked __init_tp code.
      
      - pthread_setcancelstate no longer needs special handling for the
        situation before the thread pointer is initialized. it simply fails
        on systems that cannot support a thread pointer, which are
        non-conforming anyway.
      
      - pthread_cleanup_push/pop now check for missing thread pointer and
        nop themselves out in this case, so stdio no longer needs to avoid
        the cancellable path when the thread pointer is not available.
      
      a number of cases remain where certain interfaces may crash if the
      system does not support a thread pointer. at this point, these should
      be limited to pthread interfaces, and the number of such cases should
      be fewer than before.
      dab441ae
  3. 24 3月, 2014 2 次提交
    • R
      reduce static linking overhead from TLS support by inlining mmap syscall · 98221c36
      Rich Felker 提交于
      the external mmap function is heavy because it has to handle error
      reporting that the kernel cannot do, and has to do some locking for
      arcane race-condition-avoidance purposes. for allocating initial TLS,
      we do not need any of that; the raw syscall suffices.
      
      on i386, this change shaves off 13% of the size of .text for the empty
      program.
      98221c36
    • R
      include header that declares __syscall_ret where it's defined · 30c1205a
      Rich Felker 提交于
      in general, we aim to always include the header that's declaring a
      function before defining it so that the compiler can check that
      prototypes match.
      
      additionally, the internal syscall.h declares __syscall_ret with a
      visibility attribute to improve code generation for shared libc (to
      prevent gratuitous GOT-register loads). this declaration should be
      visible at the point where __syscall_ret is defined, too, or the
      inconsistency could theoretically lead to problems at link-time.
      30c1205a
  4. 20 3月, 2014 6 次提交
  5. 19 3月, 2014 8 次提交
  6. 18 3月, 2014 2 次提交
    • R
      make configure accept alternate gcc tuples for x32 · f162c064
      Rich Felker 提交于
      the previous pattern required "x32" to be used as the second field of
      the gcc tuple, which is usually reserved for vendor use and not
      appropriate as an ABI specifier. with this change, putting "x32" at
      the end of the tuple, the way ABI specifiers are normally done, is
      also permitted.
      f162c064
    • R
      x32: fix struct statfs · 797f9a32
      rofl0r 提交于
      the omission of the padding was uncovered by the latest regression
      statvfs regression test added to libc-test.
      797f9a32
  7. 17 3月, 2014 2 次提交
    • R
      fix negated error codes from ptsname_r · 66193171
      Rich Felker 提交于
      the incorrect error codes also made their way into errno when
      __ptsname_r was called by plain ptsname, which reports errors via
      errno rather than a return value.
      66193171
    • B
      superh: fix dynamic linking of __fpscr_values · 611eabd4
      Bobby Bingham 提交于
      Applications ended up with copy relocations for this array, which
      resulted in libc's references to this array pointing to the
      application's copy.  The dynamic linker, however, can require this array
      before the application is relocated, and therefore before the
      application's copy of this array is initialized.  This resulted in
      garbage being loaded into FPSCR before executing main, which violated
      the ABI.
      
      We fix this by putting the array in crt1 and making the libc copy
      private.  This prevents libc's reference to the array from pointing to
      an uninitialized copy in the application.
      611eabd4
  8. 14 3月, 2014 1 次提交
    • R
      semctl: fix UB causing crashes on powerpc · 2b47a7af
      rofl0r 提交于
      it's UB to fetch variadic args when none are passed, and this caused
      real crashes on ppc due to its calling convention, which defines that
      for variadic functions aggregate types be passed as pointers.
      the assignment caused that pointer to get dereferenced, resulting in
      a crash.
      2b47a7af
  9. 13 3月, 2014 1 次提交
    • S
      fix statfs struct on mips · 7673acd3
      Szabolcs Nagy 提交于
      The mips statfs struct layout is different than on other archs, so the
      statfs, fstatfs, statvfs and fstatvfs APIs were broken on mips.
      Now the ordering is fixed, the types are kept consistent with other archs.
      7673acd3
  10. 12 3月, 2014 4 次提交
    • S
      fix semid_ds structure on mips · 3ceb89ed
      Szabolcs Nagy 提交于
      This used to be broken when all archs had the same semid_ds definition:
      there is no padding around the time_t members on mips.
      3ceb89ed
    • R
      fix socket.h struct msghdr member types on powerpc · 514c2dd2
      Rich Felker 提交于
      these were incorrectly copied from the kernel, whose ABI matches the
      POSIX requirements but with the wrong underlying types and wrong
      signedness.
      514c2dd2
    • R
      fix sysvipc structures on powerpc · ad66ae93
      Rich Felker 提交于
      these have been wrong for a long time and were never detected or
      corrected. powerpc needs some gratuitous extra padding/reserved slots
      in ipc_perm, big-endian ordering for the padding of time_t slots that
      was intended by the kernel folks to allow a transition to 64-bit
      time_t, and some minor gratuitous reordering of struct members.
      ad66ae93
    • R
      move struct semid_ds to from shared sys/sem.h to bits · f6e2f7e1
      Rich Felker 提交于
      the definition was found to be incorrect at least for powerpc, and
      fixing this cleanly requires making the definition arch-specific. this
      will allow cleaning up the definition for other archs to make it more
      specific, and reversing some of the ugliness (time_t hacks) introduced
      with the x32 port.
      
      this first commit simply copies the existing definition to each arch
      without any changes. this is intentional, to make it easier to review
      changes made on a per-arch basis.
      f6e2f7e1
  11. 10 3月, 2014 1 次提交
  12. 09 3月, 2014 2 次提交
    • R
      fix incorrect rounding in printf floating point corner cases · 9743a399
      Rich Felker 提交于
      the printf floating point formatting code contains an optimization to
      avoid computing digits that will be thrown away by rounding at the
      specified (or default) precision. while it was correctly retaining all
      places up to the last decimal place to be printed, it was not
      retaining enough precision to see the next nonzero decimal place in
      all cases. this could cause incorrect rounding down in round-to-even
      (default) rounding mode, for example, when printing 0.5+DBL_EPSILON
      with "%.0f".
      
      in the fix, LDBL_MANT_DIG/3 is a lazy (non-sharp) upper bound on the
      number of zeros between any two nonzero decimal digits.
      9743a399
    • R
      fix buffer overflow in printf formatting of denormals with low bit set · ba231cf9
      Rich Felker 提交于
      empirically the overflow was an off-by-one, and it did not seem to be
      overwriting meaningful data. rather than simply increasing the buffer
      size by one, however, I have attempted to make the size obviously
      correct in terms of bounds on the number of iterations for the loops
      that fill the buffer. this still results in no more than a negligible
      size increase of the buffer on the stack (6-7 32-bit slots) and is a
      "safer" fix unless/until somebody wants to do the proof that a smaller
      buffer would suffice.
      ba231cf9
  13. 08 3月, 2014 3 次提交
    • R
      in sys/procfs.h, avoid using __WORDSIZE macro · 73f5b096
      Rich Felker 提交于
      this was problematic because several archs don't define __WORDSIZE. we
      could add it, but I would rather phase this macro out in the long
      term. in our version of the headers, UINTPTR_MAX is available here, so
      just use it instead.
      73f5b096
    • R
      add bits/user.h for sh port · e12fda3b
      Rich Felker 提交于
      this seems to have been overlooked, and resulted in breakage in
      anything including sys/user.h.
      e12fda3b
    • R
      in fcntl, use unsigned long instead of long for variadic argument type · b576766d
      Rich Felker 提交于
      neither is correct; different commands take different argument types,
      and some take no arguments at all. I have a much larger overhaul of
      fcntl prepared to address this, but it's not appropriate to commit
      during freeze.
      
      the immediate problem being addressed affects forward-compatibility on
      x32: if new commands are added and they take pointers, but the
      libc-level fcntl function is not aware of them, using long would
      sign-extend the pointer to 64 bits and give the kernel an invalid
      pointer. on the kernel side, the argument to fcntl is always treated
      as unsigned long, so no harm is done by treating possibly-signed
      integer arguments as unsigned. for every command that takes an integer
      argument except for F_SETOWN, large integer arguments and negative
      arguments are handled identically anyway. in the case of F_SETOWN, the
      kernel is responsible for converting the argument which it received as
      unsigned long to int, so the sign of negative arguments is recovered.
      
      the other problem that will be addressed later is that the type passed
      to va_arg does not match the type in the caller of fcntl. an advanced
      compiler doing cross-translation-unit analysis could potentially see
      this mismatch and issue warnings or otherwise make trouble.
      
      on i386, this patch was confirmed not to alter the code generated by
      gcc 4.7.3. in principle the generated code should not be affected on
      any arch except x32.
      b576766d
  14. 07 3月, 2014 1 次提交
  15. 06 3月, 2014 2 次提交
    • R
      x32: fix sysinfo() · dae8ca73
      rofl0r 提交于
      the kernel uses long longs in the struct, but the documentation
      says they're long. so we need to fixup the mismatch between the
      userspace and kernelspace structs.
      since the struct offers a mem_unit member, we can avoid truncation
      by adjusting that value.
      dae8ca73
    • R
      fix strerror on mips: one error code is out of the 8-bit table range · abdd2e48
      Rich Felker 提交于
      if we ever encounter other targets where error codes don't fit in the
      8-bit range, the table should probably just be bumped to 16-bit, but
      for now I don't want to increase the table size on all archs just
      because of a bug in the mips abi.
      abdd2e48