1. 25 10月, 2012 3 次提交
    • R
      correct locking in stdio functions that tried to be lock-free · c8cb6bcd
      Rich Felker 提交于
      these functions must behave as if they obtain the lock via flockfile
      to satisfy POSIX requirements. since another thread can provably hold
      the lock when they are called, they must wait to obtain the lock
      before they can return, even if the correct return value could be
      obtained without locking. in the case of fclose and freopen, failure
      to do so could cause correct (albeit obscure) programs to crash or
      otherwise misbehave; in the case of feof, ferror, and fwide, failure
      to obtain the lock could sometimes return incorrect results. in any
      case, having these functions proceed and return while another thread
      held the lock was wrong.
      c8cb6bcd
    • R
      greatly improve freopen behavior · 892cafff
      Rich Felker 提交于
      1. don't open /dev/null just as a basis to copy flags; use shared
      __fmodeflags function to get the right file flags for the mode.
      
      2. handle the case (probably invalid, but whatever) case where the
      original stream's file descriptor was closed; previously, the logic
      re-closed it.
      
      3. accept the "e" mode flag for close-on-exec; update dup3 to fallback
      to using dup2 so we can simply call __dup3 instead of putting fallback
      logic in freopen itself.
      892cafff
    • R
      708c91f4
  2. 23 10月, 2012 1 次提交
  3. 22 10月, 2012 3 次提交
  4. 20 10月, 2012 3 次提交
  5. 19 10月, 2012 7 次提交
  6. 18 10月, 2012 2 次提交
  7. 16 10月, 2012 2 次提交
    • R
      add memmem function (gnu extension) · c86f2974
      Rich Felker 提交于
      based on strstr. passes gnulib tests and a few quick checks of my own.
      c86f2974
    • R
      add support for TLS variant I, presently needed for arm and mips · 9ec4283b
      Rich Felker 提交于
      despite documentation that makes it sound a lot different, the only
      ABI-constraint difference between TLS variants II and I seems to be
      that variant II stores the initial TLS segment immediately below the
      thread pointer (i.e. the thread pointer points to the end of it) and
      variant I stores the initial TLS segment above the thread pointer,
      requiring the thread descriptor to be stored below. the actual value
      stored in the thread pointer register also tends to have per-arch
      random offsets applied to it for silly micro-optimization purposes.
      
      with these changes applied, TLS should be basically working on all
      supported archs except microblaze. I'm still working on getting the
      necessary information and a working toolchain that can build TLS
      binaries for microblaze, but in theory, static-linked programs with
      TLS and dynamic-linked programs where only the main executable uses
      TLS should already work on microblaze.
      
      alignment constraints have not yet been heavily tested, so it's
      possible that this code does not always align TLS segments correctly
      on archs that need TLS variant I.
      9ec4283b
  8. 15 10月, 2012 3 次提交
    • R
      block uid/gid changes during posix_spawn · d5304147
      Rich Felker 提交于
      usage of vfork creates a situation where a process of lower privilege
      may momentarily have write access to the memory of a process of higher
      privilege.
      
      consider the case of a multi-threaded suid program which is calling
      posix_spawn in one thread while another thread drops the elevated
      privileges then runs untrusted (relative to the elevated privilege)
      code as the original invoking user. this untrusted code can then
      potentially modify the data the child process will use before calling
      exec, for example changing the pathname or arguments that will be
      passed to exec.
      
      note that if vfork is implemented as fork, the lock will not be held
      until the child execs, but since memory is not shared it does not
      matter.
      d5304147
    • R
      fix overlap of thread stacks with thread tls segments · 42c36f95
      Rich Felker 提交于
      42c36f95
    • R
      fix main program TLS alignment for dynamic-linked programs · c62b9f39
      Rich Felker 提交于
      this change brings the behavior in line with the static-linked code,
      which seems to be correct.
      c62b9f39
  9. 14 10月, 2012 3 次提交
    • R
      workaround broken hidden-visibility handling in pcc · 36be5284
      Rich Felker 提交于
      with this change, pcc-built musl libc.so seems to work correctly. the
      problem is that pcc generates GOT lookups for external-linkage symbols
      even if they are hidden, rather than using GOT-relative addressing.
      the entire reason we're using hidden visibility on the __libc object
      is to make it accessible prior to relocations -- not to mention
      inexpensive to access. unfortunately, the workaround makes it even
      more expensive on pcc.
      
      when the pcc issue is fixed, an appropriate version test should be
      added so new pcc can use the much more efficient variant.
      36be5284
    • R
      fix namespace clash (libc) in dynlink.c · e23d358f
      Rich Felker 提交于
      this makes it so the #undef libc and __libc name are no longer needed,
      which were problematic because the "accessor function" mode for
      accessing the libc struct could not be used, breaking build on any
      compiler without (working) visibility.
      e23d358f
    • R
      remove dead code from dynamic linker · 31f340a1
      Rich Felker 提交于
      31f340a1
  10. 12 10月, 2012 3 次提交
  11. 08 10月, 2012 3 次提交
    • R
      f2b1f1af
    • R
      clean up and refactor program initialization · 0a96a37f
      Rich Felker 提交于
      the code in __libc_start_main is now responsible for parsing auxv,
      rather than duplicating the parsing all over the place. this should
      shave off a few cycles and some code size. __init_libc is left as an
      external-linkage function despite the fact that it could be static, to
      prevent it from being inlined and permanently wasting stack space when
      main is called.
      
      a few other minor changes are included, like eliminating per-thread
      ssp canaries (they were likely broken when combined with certain
      dlopen usages, and completely unnecessary) and some other unnecessary
      checks. since this code gets linked into every program, it should be
      as small and simple as possible.
      0a96a37f
    • R
      fix breakage due to initializing thread pointer when loading libs · 017bf140
      Rich Felker 提交于
      at initial program load, all libraries must be loaded before the
      thread pointer can be setup, since the TP-relative addresses of all
      initial TLS objects must be constant.
      017bf140
  12. 07 10月, 2012 3 次提交
  13. 06 10月, 2012 4 次提交
    • R
      fix symbol acceptance/rejection rules for TLS · bd17431a
      Rich Felker 提交于
      symbol value of 0 is not "undefined" for TLS; it's the address of the
      first symbol in the TLS segment. however, non-definition TLS
      references also have values of 0, so check the section.
      
      hopefully the new logic is more clear, too.
      bd17431a
    • R
      TLS fixes, mainly alignment handling · cf3fd3d0
      Rich Felker 提交于
      compute offsets from the thread pointer statically when loading the
      library, rather than repeating the logic on each thread creation. not
      only is the latter less efficient at runtime; it also fails to provide
      solid guarantees that the offsets will remain the same when the
      initial alignment of memory is different. the new alignment handling
      is both more rigorous and simpler.
      
      the old code was also clobbering TLS bss with random image data in
      some cases due to using tls_size (size of TLS segment) instead of
      tls_len (length of the TLS data image).
      cf3fd3d0
    • R
      fix/improve shared library ctor/dtor handling, allow recursive dlopen · f4f77c06
      Rich Felker 提交于
      some libraries call dlopen from their constructors, resulting in
      recursive calls to dlopen. previously, this resulted in deadlock. I'm
      now unlocking the dlopen lock before running constructors (this is
      especially important since the lock also blocked pthread_create and
      was being held while application code runs!) and using a separate
      recursive mutex protecting the ctor/dtor state instead.
      
      in order to prevent the same ctor from being called more than once, a
      module is considered "constructed" just before the ctor runs.
      
      also, switch from using atexit to register each dtor to using a single
      atexit call to register the dynamic linker's dtor processing as just
      one handler. this is necessary because atexit performs allocation and
      may fail, but the library has already been loaded and cannot be
      backed-out at the time dtor registration is performed. this change
      also ensures that all dtors run after all atexit functions, rather
      than in mixed order.
      f4f77c06
    • R
      small dynamic linker module search fix · 5f88c0ed
      Rich Felker 提交于
      libraries loaded more than once by pathname should not get shortnames
      that would cause them to later be used to satisfy non-pathname load
      requests.
      5f88c0ed