- 24 4月, 2015 5 次提交
-
-
由 Rich Felker 提交于
versions of reloc.h that rely on endian macros much include endian.h to ensure they are available.
-
由 Rich Felker 提交于
both static and dynamic linked versions of the __copy_tls function have a hidden assumption that the alignment of the beginning or end of the memory passed is suitable for storing an array of pointers for the dtv. pthread_create satisfies this requirement except when libc.tls_size is misaligned, which cannot happen with dynamic linking due to way update_tls_size computes the total size, but could happen with static linking and odd-sized TLS.
-
由 Rich Felker 提交于
commit dab441ae, which made thread pointer init mandatory for all programs, rendered this store obsolete by removing the early-return path for static programs with no TLS.
-
由 Rich Felker 提交于
this slightly reduces the code size cost of TLS/thread-pointer for static linking since __init_tp can be inlined into its only caller and removed. this is analogous to the handling of __init_libc in __libc_start_main, where the function only has external linkage when it needs to be called from the dynamic linker.
-
由 Rich Felker 提交于
-
- 23 4月, 2015 2 次提交
-
-
由 Rich Felker 提交于
the implicit-operand form of fucomip is rejected by binutils 2.19 and perhaps other versions still in use. writing both operands explicitly fixes the issue. there is no change to the resulting output. commit a732e80d was the source of this regression.
-
由 Rich Felker 提交于
-
- 22 4月, 2015 15 次提交
-
-
由 Rich Felker 提交于
use CAS instead of swap since it's lighter for most archs, and keep EBUSY in the lock value so that the old value obtained by CAS can be used directly as the return value for pthread_spin_trylock.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
the motivation for this change is that the extra declaration (with or without visibility) using "struct _IO_FILE" instead of "FILE" seems to trigger a bug in gcc 3.x where it considers the types mismatched. however, this change also results in slightly better code and it is valid because (1) these three objects are constant, and (2) applying the & operator to any of them is invalid C, since they are not even specified to be objects. thus it does not matter if the application and libc see different addresses for them, as long as the (initial, unchanging) value is seen the same by both.
-
由 Rich Felker 提交于
these are used as hidden by asm files (and such use is the whole reason they exist), but their actual definitions were not hidden.
-
由 Rich Felker 提交于
commit f9cccfc1 left behind the part in libc.c; remove it too.
-
由 Rich Felker 提交于
part of the goal here is to eliminate use of the ATTR_LIBC_VISIBILITY macro outside of libc.h, since it was never intended to be 'public'.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
these were hacks to work around toolchains that could not properly optimize PIC accesses based on visibility and would generate GOT lookups even for hidden data, which broke the old dynamic linker. since commit f3ddd173 it no longer matters; the dynamic linker does not assume accessibility of this data until stage 3.
-
由 Rich Felker 提交于
pcc does not search for -include relative to the working directory unless -I. is used. rather than adding -I., which could be problematic if there's extra junk in the top-level directory, switch back to the old method (reverting commit 60ed988f) of using -include vis.h and relying on -I./src/internal being present on the command line (which the Makefile guarantees). to fix the breakage that was present in trycppif checks with the old method, $CFLAGS_AUTO is removed from the command line passed to trycppif; this is valid since $CFLAGS_AUTO should not contain options that alter compiler semantics or ABI, only optimizations, warnings, etc.
-
由 Rich Felker 提交于
when the non-stub duplocale code was added as part of the locale framework in commit 0bc03091, the old code to memcpy the old locale object to the new one was left behind. the conditional for the memcpy no longer makes sense, because the conditions are now always-true when it's reached, and the memcpy is wrong because it clobbers the new->messages_name pointer setup just above. since the messages_name and ctype_utf8 members have already been copied, all that remains is the cat[] array. these pointers are volatile, so using memcpy to copy them is formally wrong; use a for loop instead.
-
由 Andre McCurdy 提交于
Some build environments pass -march and -mtune as part of CC, therefore update configure to check both CC and CFLAGS before making the decision to fall back to generic -march and -mtune options for x86. Signed-off-by: NAndre McCurdy <armccurdy@gmail.com>
-
由 Rich Felker 提交于
the first switch already returns in the F_SETLKW code path so it need not be handled in the second switch. moreover the code in the second switch is wrong for the F_SETLKW command: it's not cancellable.
-
由 Rich Felker 提交于
the leak was found by static analysis (reported by Alexander Monakov), not tested/observed, but seems to have occured both when failing due to O_EXCL, and in a race condition with O_CREAT but not O_EXCL where a semaphore by the same name was created concurrently.
-
由 Rich Felker 提交于
the allocating path which can fail is for dynamic TLS, which can only occur at runtime, and the check for runtime was already made in the outer conditional.
-
由 Rich Felker 提交于
commit 637dd2d3 introduced the checks for RTLD_DEFAULT and RTLD_NEXT here, claiming they fixed a regression, but the above conditional block clearly already covered these cases, and removing the checks produces no difference in the generated code.
-
- 21 4月, 2015 2 次提交
-
-
由 Rich Felker 提交于
the jmp instruction requires a 64-bit register, so cast the desired PC address up to uint64_t, going through uintptr_t to ensure that it's zero-extended rather than possibly sign-extended.
-
由 Rich Felker 提交于
commit de2b67f8 introduced a regression by adding a -include option to CFLAGS_AUTO which did not work without additional -I options. this broke subsequent trycppif tests and caused x86_64 to be misdetected as x32, among other issues. simply using the full relative pathname to vis.h rather than -I is the cleanest way to fix the problem.
-
- 20 4月, 2015 5 次提交
-
-
由 Rich Felker 提交于
this is implemented via the build system and does not affect source files. the idea is to use protected or hidden visibility to prevent the compiler from pessimizing function calls within a shared (or position-independent static) libc in the form of overhead setting up for a call through the PLT. the ld-time symbol binding via the -Bsymbolic-functions option already optimized out the PLT itself, but not the code in the caller needed to support a call through the PLT. on some archs this overhead can be substantial; on others it's trivial.
-
由 Rich Felker 提交于
analogous to commit 646cb9a4 for sh.
-
由 Rich Felker 提交于
these are perfectly fine with ld-time symbol binding, but otherwise result in textrels. they cannot be replaced with @PLT jump targets because the PLT thunks require a GOT register to be setup, so use a hidden alias instead.
-
由 Rich Felker 提交于
analogous to commit 646cb9a4 for sh.
-
由 Rich Felker 提交于
these are perfectly fine with ld-time symbol binding, but if the calls go through a PLT thunk, they are invalid because the caller does not setup a GOT register. use a hidden alias to bypass the issue.
-
- 19 4月, 2015 4 次提交
-
-
由 Rich Felker 提交于
analogous to commit 8ed66ecb for i386.
-
由 Rich Felker 提交于
none of these are actual textrels because of ld-time binding performed by -Bsymbolic-functions, but I'm changing them with the goal of making ld-time binding purely an optimization rather than relying on it for semantic purposes. in the case of memmove's call to memcpy, making it explicit that the memmove asm is assuming the forward-copying behavior of the memcpy asm is desirable anyway; in case memcpy is ever changed, the semantic mismatch would be apparent while editing memmcpy.s.
-
由 Rich Felker 提交于
this fixes truncation of error messages containing long pathnames or symbol names. the dlerror state was previously required by POSIX to be global. the resolution of bug 97 relaxed the requirements to allow thread-safe implementations of dlerror with thread-local state and message buffer.
-
由 Alexander Monakov 提交于
-
- 18 4月, 2015 7 次提交
-
-
由 Szabolcs Nagy 提交于
this reverts the commit f29fea00 which was based on a bug in C99 and POSIX and did not match IEEE-754 http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1515.pdf
-
由 Rich Felker 提交于
these functions are never called directly; only their addresses are used, so PLT indirections should never happen unless a broken application tries to redefine them, but it's still best to make them hidden.
-
由 Szabolcs Nagy 提交于
-
由 Rich Felker 提交于
this change is made in preparation to support linking without -Bsymbolic-functions.
-
由 Szabolcs Nagy 提交于
new in linux v4.0, commit 9791554b45a2acc28247f66a5fd5bbc212a6b8c8 used to work around a floating-point abi issue on mips
-
由 Szabolcs Nagy 提交于
new in linux v3.19, commit fe3d197f84319d3bce379a9c0dc17b1f48ad358c used for on-demand kernel allocation of bounds tables for mpx on x86
-
由 Szabolcs Nagy 提交于
new in linux v4.0, commit ad6f939ab193750cc94a265f58e007fb598c97b7
-