1. 20 10月, 2019 3 次提交
    • R
      internally, define time64 rusage syscalls on x32 as the existing ones · 7e817114
      Rich Felker 提交于
      this is analogous to commit 40aa18d5.
      so far, there are not any actual time64 versions of the rusage
      syscalls (getrusage and wait4) and might never be. however, the
      existing x32 ones behave the way time64 versions would if they
      existed: using 64-bit slots in place of all longs.
      
      presently, wait4 and getrusage are broken on x32, storing the timevals
      correctly but messing up everything else due to the long/kernel-long
      mismatch. this would be a huge buffer overflow if not for the 16
      reserved slots we left long ago, which suffice to prevent 14
      double-sized longs from overflowing into unrelated memory. this commit
      will make it possible to fix them.
      7e817114
    • R
      use struct pt_regs * rather than void * for powerpc[64] sigcontext regs · c2518a8e
      Rich Felker 提交于
      this is to match the kernel and glibc interfaces. here, struct pt_regs
      is an incomplete type, but that's harmless, and if it's completed by
      inclusion of another header then members of the struct pointed to by
      the regs member can be accessed directly without going through a cast
      or intermediate pointer object.
      c2518a8e
    • R
      fix fpregset_t type on powerpc64 · c9f48cde
      Rich Felker 提交于
      the userspace ucontext API has this as an array rather than a
      structure.
      
      commit 3c59a868 fixed the
      corresponding mistake for vrregset_t, namely that the original
      powerpc64 port used a mix of types from 32-bit powerpc and powerpc64
      rather than matching the 64-bit types.
      c9f48cde
  2. 19 10月, 2019 2 次提交
    • R
      fix return value of ungetc when argument is outside unsigned char range · f6ecd0c2
      Rich Felker 提交于
      aside from the special value EOF, ungetc is specified to accept and
      convert values outside the range of unsigned char. conversion takes
      place automatically as part of assignment when storing into the
      buffer, but the return value is also required to be the resulting
      converted value, and this requirement was not satisfied.
      
      simplified from patch by Wang Jianjian.
      f6ecd0c2
    • R
      fix incorrect use of fabs on long double operand in floatscan.c · bff78954
      Rich Felker 提交于
      based on patch by Dan Gohman, who caught this via compiler warnings.
      analysis by Szabolcs Nagy determined that it's a bug, whereby errno
      can be set incorrectly for values where the coercion from long double
      to double causes rounding. it seems likely that floating point status
      flags may be set incorrectly as a result too.
      
      at the same time, clean up use of preprocessor concatenation involving
      LDBL_MANT_DIG, which spuriously depends on it being a single unadorned
      decimal integer literal, and instead use the equivalent formulation
      2/LDBL_EPSILON. an equivalent change on the printf side was made in
      commit bff6095d.
      bff78954
  3. 18 10月, 2019 8 次提交
    • R
      move pthread types out of per-arch alltypes.h · 2d3083e7
      Rich Felker 提交于
      policy has long been that these definitions are purely a function of
      whether long/pointer is 32- or 64-bit, and that they are not allowed
      to vary per-arch. move the definition to the shared alltypes.h.in
      fragment, using integer constant expressions in terms of sizeof to
      vary the array dimensions appropriately. I'm not sure whether this is
      more or less ugly than using preprocessor conditionals and two sets of
      definitions here, but either way is a lot less ugly than repeating the
      same thing for every arch.
      2d3083e7
    • R
      define LONG_MAX via arch alltypes.h, strip down bits/limits.h · 7cc79d10
      Rich Felker 提交于
      LLONG_MAX is uniform for all archs we support and plenty of header and
      code level logic assumes it is, so it does not make sense for limits.h
      bits mechanism to pretend it's variable.
      
      LONG_BIT can be defined in terms of LONG_MAX; there's no reason to put
      it in bits.
      
      by moving LONG_MAX definition to __LONG_MAX in alltypes.h and moving
      LLONG_MAX out of bits, there are now no plain-C limits that are
      defined in the bits header, so the bits header only needs to be
      included in the POSIX or extended profiles. this allows the feature
      test macro logic to be removed from the bits header, facilitating a
      long-term goal of getting such logic out of bits.
      
      having __LONG_MAX in alltypes.h will allow further generalization of
      headers.
      
      archs without a constant PAGESIZE no longer need bits/limits.h at all.
      7cc79d10
    • R
      make endian.h expose unprefixed macros, functions in standard profile · 316730cd
      Rich Felker 提交于
      the resolution of Austin Group issue #162 adds endian.h as a standard
      header for future versions of the standard, making it no longer
      acceptable for some of the functionality to be hidden behind
      _BSD_SOURCE or _GNU_SOURCE. the definitions of the [lb]etoh{16,32,64}
      function-like macros are kept conditional since they are alternate
      names which the standard did not adopt.
      316730cd
    • R
      remove use of endian.h from arch reloc.h headers, clean up · 4d3a162d
      Rich Felker 提交于
      building on commit 97d35a55,
      __BYTE_ORDER is now available wherever alltypes.h is included. since
      reloc.h is only used from src/internal/dynlink.h, it can be assumed
      that __BYTE_ORDER is exposed. reloc.h is not permitted to be included
      in other contexts, and generally, like most arch headers, lacks
      inclusion guards that would allow such usage. the mips64 version
      mistakenly included such guards; they are removed for consistency.
      4d3a162d
    • R
      remove indirect use of endian.h from public headers · 71d23fbe
      Rich Felker 提交于
      building on commit 97d35a55,
      __BYTE_ORDER is now available wherever alltypes.h is included.
      endian.h should not be used since, in the future, it will expose
      identifiers that are not in the reserved namespace for the headers
      which were previously using it.
      71d23fbe
    • R
      move __BYTE_ORDER definition to alltypes.h · 97d35a55
      Rich Felker 提交于
      this change is motivated by the intersection of several factors.
      presently, despite being a nonstandard header, endian.h is exposing
      the unprefixed byte order macros and functions only if _BSD_SOURCE or
      _GNU_SOURCE is defined. this is to accommodate use of endian.h from
      other headers, including bits headers, which need to define structure
      layout in terms of endianness. with time64 switch-over, even more
      headers will need to do this.
      
      at the same time, the resolution of Austin Group issue 162 makes
      endian.h a standard header for POSIX-future, requiring that it expose
      the unprefixed macros and the functions even in standards-conforming
      profiles. changes to meet this new requirement would break existing
      internal usage of endian.h by causing it to violate namespace where
      it's used.
      
      instead, have the arch's alltypes.h define __BYTE_ORDER, either as a
      fixed constant or depending on the right arch-specific predefined
      macros for determining endianness. explicit literals 1234 and 4321 are
      used instead of __LITTLE_ENDIAN and __BIG_ENDIAN so that there's no
      danger of getting the wrong result if a macro is undefined and
      implicitly evaluates to 0 at the preprocessor level.
      
      the powerpc (32-bit) bits/endian.h being removed had logic for varying
      endianness, but our powerpc arch has never supported that and has
      always been big-endian-only. this logic is not carried over to the new
      __BYTE_ORDER definition in alltypes.h.
      97d35a55
    • R
      remove per-arch definitions for va_list · 00ec11d1
      Rich Felker 提交于
      now that commit f7f10797 removed the
      legacy i386 conditional definition, va_list is in no way
      arch-specific, and has no reason to be in the future. move it to the
      shared part of alltypes.h.in
      00ec11d1
    • R
      remove i386 support for legacy struct __va_list · f7f10797
      Rich Felker 提交于
      commit ffaaa6d2 removed the
      corresponding stdarg.h support for compilers without va_list builtins,
      but failed to remove the alternate type definition, leaving incorrect
      va_list definitions in place with compilers that don't define __GNUC__
      with a value >= 3.
      f7f10797
  4. 14 10月, 2019 5 次提交
  5. 07 10月, 2019 1 次提交
    • S
      add Arm to the copyright file · db3cc9a3
      Szabolcs Nagy 提交于
      Several math functions are now from the ARM optimized-routines repo
      licensed under standard MIT terms and copyrighted by Arm Limited,
      so mention this in the COPYRIGHT too.
      db3cc9a3
  6. 02 10月, 2019 1 次提交
    • R
      reintroduce riscv64 struct sigcontext · a0993f8f
      Rich Felker 提交于
      commit ab3eb89a removed it as part of
      correcting the mcontext_t definition, but there is still code using
      struct sigcontext and expecting the member names present in it, most
      notably libgcc_eh. almost all such usage is incorrect, but bring back
      struct sigcontext at least for now so as not to introduce regressions.
      a0993f8f
  7. 30 9月, 2019 3 次提交
    • R
      fix riscv64 elf_fpregset_t type and member names mismatch · 2c2477da
      Rich Felker 提交于
      in order for sys/procfs.h (provided by sys/user.h) to be useful, it
      needs to match the API its consumers (gdb, etc.) expect, including the
      member names established by glibc.
      
      this partly reverts commit 29e8737f,
      which partly reverted d493206d,
      eliminating struct user_fpregs_struct which seems to have had no
      precedent and using union __riscv_mc_fp_state for elf_fpregset_t. this
      requires indirect inclusion of signal.h to make union
      __riscv_mc_fp_state visible, but being that these are nonstandard
      "junk" headers with no official restrictions on what they can pull in,
      that's no big deal.
      
      split off and expanded from patch by Khem Raj.
      2c2477da
    • R
      fix riscv64 signal.h namespace violations and ucontext API mismatches · ab3eb89a
      Rich Felker 提交于
      the top-level mcontext_t member names were namespace-violating in
      standards profiles before, and nested-level member names (some of them
      single-letter) were egregiously bad namespace impositions even in
      non-strict profiles. moreover, they mismatched those used in the
      public API first defined in glibc, breaking any code making use of
      them.
      
      unlike most archs, the public API used in glibc for riscv mcontext_t
      members was designed to be namespace-safe, so we can and should expose
      the members regardless of feature test macros. only the typedefs for
      greg_t, gregset_t, and fpregset_t need to be protected behind FTMs.
      
      the struct tags for mcontext_t and ucontext_t are also changed. for
      mcontext_t this is necessary to make the common definition across
      profiles namespace-safe. for ucontext_t, it's just a matter of
      matching the tag from the glibc-defined API.
      
      these changes are split off and expanded from a patch by Khem Raj.
      ab3eb89a
    • S
      remove remaining traces of __tls_get_new · 33bc7f05
      Szabolcs Nagy 提交于
      Some declarations of __tls_get_new were left in the code, even
      though the definition got removed in
      
        commit 9d44b646
        install dynamic tls synchronously at dlopen, streamline access
      
      this can make the build fail with
      
        ld: lib/libc.so: hidden symbol `__tls_get_new' isn't defined
      
      when libc.so is linked without --gc-sections, because a .hidden
      declaration in asm code creates a reference even if the symbol
      is not actually used.
      33bc7f05
  8. 27 9月, 2019 5 次提交
    • S
      math: optimize lrint on 32bit targets · ca577951
      Szabolcs Nagy 提交于
      lrint in (LONG_MAX, 1/DBL_EPSILON) and in (-1/DBL_EPSILON, LONG_MIN)
      is not trivial: rounding to int may be inexact, but the conversion to
      int may overflow and then the inexact flag must not be raised. (the
      overflow threshold is rounding mode dependent).
      
      this matters on 32bit targets (without single instruction lrint or
      rint), so the common case (when there is no overflow) is optimized by
      inlining the lrint logic, otherwise the old code is kept as a fallback.
      
      on my laptop an i486 lrint call is asm:10ns, old c:30ns, new c:21ns
      on a smaller arm core: old c:71ns, new c:34ns
      on a bigger arm core: old c:27ns, new c:19ns
      ca577951
    • R
      clean up mips (32-bit, o32) syscall asm constraints · 604f8d3d
      Rich Felker 提交于
      analogous to commit ddc7c4f9 for
      mips64 and n32, remove the hack to load the syscall number into $2 via
      asm, and use a constraint to let the compiler load it instead.
      
      now, only $4, $5, and $6 are potential input-only registers. $2 is
      always input and output, and $7 is both when it's an argument,
      otherwise output-only. previously, $7 was treated as an input (with a
      "1" constraint matching its output position) even when it was not an
      input, which was arguably undefined behavior (asm input from
      indeterminate value). this is corrected.
      
      as before, $8, $9, and $10 are conditionally input-output registers
      for 5-, 6-, and 7-argument syscalls. their role in input is carrying
      in the values that will be stored on the stack for arguments 5-7.
      their role in output is carrying back whatever the kernel has
      clobbered them with, so that the compiler cannot assume they still
      contain the input values.
      604f8d3d
    • R
      document mips r6 in INSTALL file · 12fecbb4
      Rich Felker 提交于
      12fecbb4
    • R
      fix mips setjmp/longjmp fpu state on r6, related issues · 370679ba
      Rich Felker 提交于
      mips32 has two fpu register file variants: FR=0 with 32 32-bit
      registers, where pairs of neighboring even/odd registers are used to
      represent doubles, and FR=1 with 32 64-bit registers, each of which
      can store a single or double.
      
      up through r5 (our "mips" arch), the supported ABI uses FR=0, but
      modern compilers generate "fpxx" model code that can safely operate
      with either model. r6, which is an incompatible but similar ISA, drops
      FR=0 and only provides the FR=1 model. as such, setjmp and longjmp,
      which depended on being able to save and restore call-saved doubles by
      storing and loading their 32-bit halves, were completely broken in the
      presence of floating point code on mips r6.
      
      to fix this, use the s.d and l.d mnemonics to store and load fpu
      registers. these expand to the existing swc1 and lwc1 instructions for
      pairs of 32-bit fpu registers on mips1, but on mips2 and later they
      translate directly to the 64-bit sdc1 and ldc1.
      
      with FR=0, sdc1 and ldc1 behave just like the pairs of swc1 and lwc1
      instructions they replace, storing or loading the even/odd pair of fpu
      registers that can be treated as separate single-precision floats or
      as a unit representing a double. but with FR=1, they store/load
      individual 64-bit registers. this yields the ABI-correct behavior on
      mips r6, and should make linking of pre-r6 (plain "mips") code with
      "fp64" model code workable, although this is and will likely remain
      unsupported usage.
      
      in addition to the mips r6 problem this change fixes, reportedly
      clang's internal assembler refuses to assemble swc1 and lwc1
      instructions for odd register indices when building for "fpxx" model
      (the default). this caused setjmp and longjmp not to build. by using
      the s.d and l.d forms, this problem is avoided too.
      
      as a bonus, code size is reduced everywhere but mips1.
      370679ba
    • R
      fix mips r6 syscall clobber lists not to include hi/lo registers · 9f6dd785
      Rich Felker 提交于
      mips r6 (an incompatible isa from traditional mips) removes the hi and
      lo registers used for mul/div results. older gcc versions accepted
      them in the clobber list for asm, but their presence is incorrect and
      breaks on later versions.
      
      in the process of fixing this, the clobber list for 32-bit mips
      syscalls has been deduplicated via a macro like on mips64 and n32.
      9f6dd785
  9. 26 9月, 2019 3 次提交
    • S
      arm: fix setjmp and longjmp asm for armv8-a · b678f7b4
      Szabolcs Nagy 提交于
      armv8 removed the coprocessor instructions other than cp14, so
      on an armv8 system the related hwcaps should never be set.
      
      new llvm complains about the use of coprocessor instructions in
      armv8-a mode (even though they are never executed at runtime),
      so ifdef them out when musl is built for armv8.
      b678f7b4
    • R
      fix data race in timer_create with SIGEV_THREAD notification · 29bad49d
      Rich Felker 提交于
      in the timer thread start function, self->timer_id was accessed
      without synchronization; the timer thread could fail to see the store
      from the calling thread, resulting in timer_delete failing to delete
      the correct kernel-level timer.
      
      this fix is based on a patch by changdiankang, but with the load moved
      to after receiving the timer_delete signal rather than just after the
      start barrier, so as not to retain the possibility of data race with
      timer_delete.
      29bad49d
    • P
      correct the operand specifiers in the riscv64 CAS routines · 7d5c5706
      Palmer Dabbelt 提交于
      The operand sepcifiers in a_cas and a_cas_p for riscv64 were incorrect:
      there's a backwards branch in the routine, so despite tmp being written
      at the end of the assembly fragment it cannot be allocated in one of the
      input registers because the input values may be needed for another trip
      around the loop.
      
      For code that follows the guaranteed forward progress requirements, the
      backwards branch is rarely taken: SiFive's hardware only fails a store
      conditional on execptional cases (ie, instruction cache misses inside
      the loop), and until recently a bug in QEMU allowed back-to-back
      store conditionals to succeed.  The bug has been fixed in the latest
      QEMU release, but it turns out that the fix caused this latent bug in
      musl to manifest.
      7d5c5706
  10. 14 9月, 2019 2 次提交
    • R
      harden thread start with failed scheduling against broken __clone · f5eee489
      Rich Felker 提交于
      commit 8a544ee3 introduced a
      dependency of the failure path for explicit scheduling at thread
      creation on __clone's handling of the start function returning, which
      should result in SYS_exit.
      
      as noted in commit 05870abe, the arm
      version of __clone was broken in this case. in the past, the mips
      version was also broken; it was fixed in commit
      8b2b61e0.
      
      since this code path is pretty much entirely untested (previously only
      reachable in applications that call the public clone() and return from
      the start function) and consists of fragile per-arch asm, don't assume
      it works, at least not until it's been thoroughly tested. instead make
      the SYS_exit syscall from the start function's failure path.
      f5eee489
    • B
      fix %lf in wprintf · f7e464bf
      Brion Vibber 提交于
      commit cc3a4466 fixed this for printf
      but neglected to fix wprintf.
      
      Previously, %lf caused a failure to output.
      f7e464bf
  11. 12 9月, 2019 3 次提交
    • R
      fix arm __tlsdesc_dynamic when built as thumb code without __ARM_ARCH>=5 · 1ef37aa0
      Rich Felker 提交于
      we don't actually support building asm source files as thumb1, but
      it's possible that the condition __ARM_ARCH>=5 would be false on old
      compilers that did not define __ARM_ARCH at all. avoiding that would
      require enumerating all of the possible __ARM_ARCH_*__ macros for
      testing.
      
      as noted in commit 05870abe, mov lr,pc
      is not valid for saving a return address when in thumb mode. since
      this code is a hot path (dynamic TLS access), don't do the out-of-line
      bl->bx chaining to save the return value; instead, use the fact that
      this file is preprocessed asm to add the missing thumb bit with an add
      in place of the mov.
      
      the change here does not affect builds for ISA levels new enough to
      have a thread pointer read instruction, or for armv5 and later as long
      as the compiler properly defines __ARM_ARCH, or for any build as arm
      (not thumb) code. it's likely that it makes no difference whatsoever
      to any present-day practical build environments, but nonetheless now
      it's safe.
      
      as an alternative, we could just assume __thumb__ implies availability
      of blx since we don't support building asm source files as thumb1. I
      didn't do that in order to avoid having a wrong assumption here if
      that ever changes.
      1ef37aa0
    • R
      fix arm __a_barrier_oldkuser when built as thumb · b0301f47
      Rich Felker 提交于
      as noted in commit 05870abe, mov lr,pc
      is not a valid method for saving the return address in code that might
      be built as thumb.
      
      this one is unlikely to matter, since any ISA level that has thumb2
      should also have native implementations of atomics that don't involve
      kuser_helper, and the affected code is only used on very old kernels
      to begin with.
      b0301f47
    • R
      fix code path where child function returns in arm __clone built as thumb · 05870abe
      Rich Felker 提交于
      mov lr,pc is not a valid way to save the return address in thumb mode
      since it omits the thumb bit. use a chain of bl and bx to emulate blx.
      this could be avoided by converting to a .S file with preprocessor
      conditions to use blx if available, but the time cost here is
      dominated by the syscall anyway.
      
      while making this change, also remove the remnants of support for
      pre-bx ISA levels. commit 9f290a49
      removed the hack from the parent code paths, but left the unnecessary
      code in the child. keeping it would require rewriting two code paths
      rather than one, and is useless for reasons described in that commit.
      05870abe
  12. 11 9月, 2019 4 次提交
    • S
      aarch64: add HWCAP2 flags from linux v5.2 · 9920bf45
      Szabolcs Nagy 提交于
      AT_HWCAP2 flags, see
      
        linux commit 671db581815faf17cbedd7fcbc48823a247d90b1
        arm64: Expose DC CVADP to userspace
      
        linux commit 06a916feca2b262ab0c1a2aeb68882f4b1108a07
        arm64: Expose SVE2 features for userspace
      9920bf45
    • S
      add new syscall numbers from linux v5.2 · b6076309
      Szabolcs Nagy 提交于
      new mount api syscalls were added, same numers on all targets, see
      
        linux commit a07b20004793d8926f78d63eb5980559f7813404
        vfs: syscall: Add open_tree(2) to reference or clone a mount
      
        linux commit 2db154b3ea8e14b04fee23e3fdfd5e9d17fbc6ae
        vfs: syscall: Add move_mount(2) to move mounts around
      
        linux commit 24dcb3d90a1f67fe08c68a004af37df059d74005
        vfs: syscall: Add fsopen() to prepare for superblock creation
      
        linux commit ecdab150fddb42fe6a739335257949220033b782
        vfs: syscall: Add fsconfig() for configuring and managing a context
      
        linux commit 93766fbd2696c2c4453dd8e1070977e9cd4e6b6d
        vfs: syscall: Add fsmount() to create a mount for a superblock
      
        linux commit cf3cba4a429be43e5527a3f78859b1bfd9ebc5fb
        vfs: syscall: Add fspick() to select a superblock for reconfiguration
      
        linux commit 9c8ad7a2ff0bfe58f019ec0abc1fb965114dde7d
        uapi, x86: Fix the syscall numbering of the mount API syscalls [ver #2]
      
        linux commit d8076bdb56af5e5918376cd1573a6b0007fc1a89
        uapi: Wire up the mount API syscalls on non-x86 arches [ver #2]
      b6076309
    • S
      fcntl.h: add AT_RECURSIVE from linux v5.2 · 81e795e1
      Szabolcs Nagy 提交于
      apply open_tree with OPEN_TREE_CLONE call to the entire subtree, see
      
        linux commit a07b20004793d8926f78d63eb5980559f7813404
        vfs: syscall: Add open_tree(2) to reference or clone a mount
      81e795e1
    • S
      fcntl.h: add AT_STATX_ statx sync flag definitions · cc1a5351
      Szabolcs Nagy 提交于
      see
      
        linux commit a528d35e8bfcc521d7cb70aaf03e1bd296c8493f
        statx: Add a system call to make enhanced file info available
      
      these are linux specific and not reserved names for fcntl.h so they
      are under _BSD_SOURCE|_GNU_SOURCE.
      cc1a5351