1. 29 10月, 2013 1 次提交
    • S
      fenv: fix i386 fesetround for sse · 7e01b8f0
      Szabolcs Nagy 提交于
      i386 fenv code checks __hwcap for sse support, but in fesetround the sse
      code was unconditionally jumped over after the test so the sse rounding
      mode was never set.
      7e01b8f0
  2. 28 10月, 2013 1 次提交
    • S
      math: extensive log*.c cleanup · 71d23b31
      Szabolcs Nagy 提交于
      The log, log2 and log10 functions share a lot of code and to a lesser
      extent log1p too. A small part of the code was kept separately in
      __log1p.h, but since it did not capture much of the common code and
      it was inlined anyway, it did not solve the issue properly. Now the
      log functions have significant code duplication, which may be resolved
      later, until then they need to be modified together.
      
      logl, log10l, log2l, log1pl:
      * Fix the sign when the return value should be -inf.
      * Remove the volatile hack from log10l (seems unnecessary)
      
      log1p, log1pf:
      * Change the handling of small inputs: only |x|<2^-53 is special
        (then it is enough to return x with the usual subnormal handling)
        this fixes the sign of log1p(0) in downward rounding.
      * Do not handle the k==0 case specially (other than skipping the
        elaborate argument reduction)
      * Do not handle 1+x close to power-of-two specially (this code was
        used rarely, did not give much speed up and the precision wasn't
        better than the general)
      * Fix the correction term formula (c=1-(u-x) was used incorrectly
        when x<1 but (double)(x+1)==2, this was not a critical issue)
      * Use the exact same method for calculating log(1+f) as in log
        (except in log1p the c correction term is added to the result).
      
      log, logf, log10, log10f, log2, log2f:
      * Use double_t and float_t consistently.
      * Now the first part of log10 and log2 is identical to log (until the
        return statement, hopefully this makes maintainence easier).
      * Most special case formulas were removed (close to power-of-two and
        k==0 cases), they increase the code size without providing precision
        or performance benefits (and obfuscate the code).
        Only x==1 is handled specially so in downward rounding mode the
        sign of zero is correct (the general formula happens to give -0).
      * For x==0 instead of -1/0.0 or -two54/0.0, return -1/(x*x) to force
        raising the exception at runtime.
      * Arg reduction code is changed (slightly simplified)
      * The thresholds for arg reduction to [sqrt(2)/2,sqrt(2)] are now
        consistently the [0x3fe6a09e00000000,0x3ff6a09dffffffff] and the
        [0x3f3504f3,0x3fb504f2] intervals for double and float reductions
        respectively (the exact threshold values are not critical)
      * Remove the obsolete comment for the FLT_EVAL_METHOD!=0 case in log2f
        (The same code is used for all eval methods now, on i386 slightly
        simpler code could be used, but we have asm there anyway)
      
      all:
      * Fix signed int arithmetics (using unsigned for bitmanipulation)
      * Fix various comments
      71d23b31
  3. 26 10月, 2013 1 次提交
    • R
      add legacy ftime function and sys/timeb.h · 4b15d9f4
      Rich Felker 提交于
      despite being marked legacy, this was specified by SUSv3 as part of
      the XSI option; only the most recent version of the standard dropped
      it. reportedly there's actual code using it.
      4b15d9f4
  4. 23 10月, 2013 1 次提交
    • S
      fix inet_pton · 78f88915
      Szabolcs Nagy 提交于
      * parse IPv4 dotted-decimal correctly (without strtoul, no leading zeros)
      * disallow single leading ':' in IPv6 address
      * allow at most 4 hex digits in IPv6 address (according to RFC 2373)
      * have enough hex fields in IPv4 mapped IPv6 address
      * disallow leading zeros in IPv4 mapped IPv6 address
      78f88915
  5. 22 10月, 2013 3 次提交
  6. 20 10月, 2013 1 次提交
  7. 18 10月, 2013 1 次提交
  8. 13 10月, 2013 1 次提交
    • R
      fix uid/gid-setting error in faccessat with AT_EACCESS flag · 51635856
      Rich Felker 提交于
      this fixes an issue reported by Daniel Thau whereby faccessat with the
      AT_EACCESS flag did not work in cases where the process is running
      suid or sgid but without root privileges. per POSIX, when the process
      does not have "appropriate privileges", setuid changes the euid, not
      the real uid, and the target uid must be equal to the current real or
      saved uid; if this condition is not met, EPERM results. this caused
      the faccessat child process to fail.
      
      using the setreuid syscall rather than setuid works. POSIX leaves it
      unspecified whether setreuid can set the real user id to the effective
      user id on processes without "appropriate privileges", but Linux
      allows this; if it's not allowed, there would be no way for this
      function to work.
      51635856
  9. 09 10月, 2013 1 次提交
    • R
      fix errno value for getcwd when size argument is zero · 4fb7df12
      Rich Felker 提交于
      based on patch by Michael Forney. at the same time, I've changed the
      if branch to be more clear, avoiding the comma operator.
      
      the underlying issue is that Linux always returns ERANGE when size is
      too short, even when it's zero, rather than returning EINVAL for the
      special case of zero as required by POSIX.
      4fb7df12
  10. 08 10月, 2013 2 次提交
  11. 07 10月, 2013 4 次提交
  12. 06 10月, 2013 2 次提交
    • S
      math: remove an unused variable from modfl · b9cd1d4d
      Szabolcs Nagy 提交于
      b9cd1d4d
    • R
      slightly optimize __brk for size · 8acbe4f8
      Rich Felker 提交于
      there is no reason to check the return value for setting errno, since
      brk never returns errors, only the new value of the brk (which may be
      the same as the old, or otherwise differ from the requested brk, on
      failure).
      
      it may be beneficial to eventually just eliminate this file and make
      the syscalls inline in malloc.c.
      8acbe4f8
  13. 05 10月, 2013 4 次提交
  14. 04 10月, 2013 3 次提交
  15. 03 10月, 2013 1 次提交
    • R
      fix new environment always being null with execle · 2b2aff37
      Rich Felker 提交于
      the va_arg call for the argv[]-terminating null pointer was missing,
      so this pointer was being wrongly used as the environment pointer.
      
      issue reported by Timo Teräs. proposed patch slightly modified to
      simplify the resulting code.
      2b2aff37
  16. 29 9月, 2013 1 次提交
  17. 28 9月, 2013 1 次提交
    • R
      fix buffer overflow in mbsrtowcs · 211264e4
      Rich Felker 提交于
      issue reported by Michael Forney:
      
      "If wn becomes 0 after processing a chunk of 4, mbsrtowcs currently
      continues on, wrapping wn around to -1, causing the rest of the string
      to be processed.
      
      This resulted in buffer overruns if there was only space in ws for wn
      wide characters."
      
      the original patch submitted added an additional check for !wn after
      the loop; to avoid extra branching, I instead just changed the wn>=4
      check to wn>=5 to ensure that at least one slot remains after the
      word-at-a-time loop runs. this should not slow down the tail
      processing on real-world usage, since an extra slot that can't be
      processed in the word-at-a-time loop is needed for the null
      termination anyway.
      211264e4
  18. 20 9月, 2013 2 次提交
    • R
      fix potential deadlock bug in libc-internal locking logic · e803829e
      Rich Felker 提交于
      if a multithreaded program became non-multithreaded (i.e. all other
      threads exited) while one thread held an internal lock, the remaining
      thread would fail to release the lock. the the program then became
      multithreaded again at a later time, any further attempts to obtain
      the lock would deadlock permanently.
      
      the underlying cause is that the value of libc.threads_minus_1 at
      unlock time might not match the value at lock time. one solution would
      be returning a flag to the caller indicating whether the lock was
      taken and needs to be unlocked, but there is a simpler solution: using
      the lock itself as such a flag.
      
      note that this flag is not needed anyway for correctness; if the lock
      is not held, the unlock code is harmless. however, the memory
      synchronization properties associated with a_store are costly on some
      archs, so it's best to avoid executing the unlock code when it is
      unnecessary.
      e803829e
    • R
      correct the sysconf value for RTSIG_MAX · d8e283df
      Rich Felker 提交于
      this is the number of realtime signals available, not the maximum
      signal number or total number of signals.
      d8e283df
  19. 17 9月, 2013 1 次提交
  20. 16 9月, 2013 3 次提交
    • R
      fix clobbering of caller's stack in mips __clone function · cffb9e1e
      Rich Felker 提交于
      this was resulting in crashes in posix_spawn on mips, and would have
      affected applications calling clone too. since the prototype for
      __clone has it as a variadic function, it may not assume that 16($sp)
      is writable for use in making the syscall. instead, it needs to
      allocate additional stack space, and then adjust the stack pointer
      back in both of the code paths for the parent process/thread.
      cffb9e1e
    • R
      omit CLONE_PARENT flag to clone in pthread_create · 271c2119
      Rich Felker 提交于
      CLONE_PARENT is not necessary (CLONE_THREAD provides all the useful
      parts of it) and Linux treats CLONE_PARENT as an error in certain
      situations, without noticing that it would be a no-op due to
      CLONE_THREAD. this error case prevents, for example, use of a
      multi-threaded init process and certain usages with containers.
      271c2119
    • R
      use symbolic names for clone flags in pthread_create · f68a3468
      Rich Felker 提交于
      f68a3468
  21. 15 9月, 2013 3 次提交
    • S
      support configurable page size on mips, powerpc and microblaze · b20760c0
      Szabolcs Nagy 提交于
      PAGE_SIZE was hardcoded to 4096, which is historically what most
      systems use, but on several archs it is a kernel config parameter,
      user space can only know it at execution time from the aux vector.
      
      PAGE_SIZE and PAGESIZE are not defined on archs where page size is
      a runtime parameter, applications should use sysconf(_SC_PAGE_SIZE)
      to query it. Internally libc code defines PAGE_SIZE to libc.page_size,
      which is set to aux[AT_PAGESZ] in __init_libc and early in __dynlink
      as well. (Note that libc.page_size can be accessed without GOT, ie.
      before relocations are done)
      
      Some fpathconf settings are hardcoded to 4096, these should be actually
      queried from the filesystem using statfs.
      b20760c0
    • R
      fix overflow in sysconf for _SC_MQ_PRIO_MAX · 7a34dd34
      Rich Felker 提交于
      the value of MQ_PRIO_MAX does not fit, so it needs to use OFLOW.
      7a34dd34
    • R
      fix child stack alignment on mips clone · bfba15c9
      Rich Felker 提交于
      unlike other archs, the mips version of clone was not doing anything
      to align the stack pointer. this seems to have been the cause for some
      SIGBUS crashes that were observed in posix_spawn.
      bfba15c9
  22. 13 9月, 2013 1 次提交
    • R
      fix x86_64 lrintl asm, again · 2f1de805
      Rich Felker 提交于
      the underlying problem was not incorrect sign extension (fixed in the
      previous commit to this file by nsz) but that code that treats "long"
      as 32-bit was copied blindly from i386 to x86_64.
      
      now lrintl is identical to llrintl on x86_64, as it should be.
      2f1de805
  23. 10 9月, 2013 1 次提交
    • R
      do not use default when dynamic linker fails to open existing path file · ff4be700
      Rich Felker 提交于
      if fopen fails for a reason other than ENOENT, we must assume the
      intent is that the path file be used. failure may be due to
      misconfiguration or intentional resource-exhaustion attack (against
      suid programs), in which case falling back to loading libraries from
      an unintended path could be dangerous.
      ff4be700