1. 16 10月, 2018 2 次提交
  2. 13 10月, 2018 3 次提交
    • R
      allow escaped path-separator slashes in glob · 481006fd
      Rich Felker 提交于
      previously (before and after rewrite), spurious escaping of path
      separators as \/ was not treated the same as /, but rather got split
      as an unpaired \ at the end of the fnmatch pattern and an unescaped /,
      resulting in a mismatch/error.
      
      for the case of \/ as part of the maximal literal prefix, remove the
      explicit rejection of it and move the handling of / below escape
      processing.
      
      for the case of \/ after a proper glob pattern, it's hard to parse the
      pattern, so don't. instead cheat and count repetitions of \ prior to
      the already-found / character. if there are an odd number, the last is
      escaping the /, so back up the split position by one. now the
      char clobbered by null termination is variable, so save it and restore
      as needed.
      481006fd
    • R
      rewrite core of the glob implementation for correctness & optimization · d44b07fc
      Rich Felker 提交于
      this code has been long overdue for a rewrite, but the immediate cause
      that necessitated it was total failure to see past unreadable path
      components. for example, A/B/* would fail to match anything, even
      though it should succeed, when both A and A/B are searchable but only
      A/B is readable. this problem both was caught in conformance testing,
      and impacted users.
      
      the old glob implementation insisted on searching the listing of each
      path component for a match, even if the next component was a literal.
      it also used considerable stack space, up to length of the pattern,
      per recursion level, and relied on an artificial bound of the pattern
      length by PATH_MAX, which was incorrect because a pattern can be much
      longer than PATH_MAX while having matches shorter (for example, with
      necessarily long bracket expressions, or with redundancy).
      
      in the new implementation, each level of recursion starts by consuming
      the maximal literal (possibly escaped-literal) path prefix remaining
      in the pattern, and only opening a directory to read when there is a
      proper glob pattern in the next path component. it then recurses into
      each matching entry. the top-level glob function provided automatic
      storage (up to PATH_MAX) for construction of candidate/result strings,
      and allocates a duplicate of the pattern that can be modified in-place
      with temporary null-termination to pass to fnmatch. this allocation is
      not a big deal since glob already has to perform allocation, and has
      to link free to clean up if it experiences an allocation failure or
      other error after some results have already been allocated.
      
      care is taken to use the d_type field from iterated dirents when
      possible; stat is called only when there are literal path components
      past the last proper-glob component, or when needed to disambiguate
      symlinks for the purpose of GLOB_MARK.
      
      one peculiarity with the new implementation is the manner in which the
      error handling callback will be called. if attempting to match */B/C/D
      where a directory A exists that is inaccessible, the error reported
      will be a stat error for A/B/C/D rather than (previous and wrong
      implementation) an opendir error for A, or (likely on other
      implementations) a stat error for A/B. such behavior does not seem to
      be non-conforming, but if it turns out to be undesirable for any
      reason, backtracking could be done on error to report the first
      component producing it.
      
      also, redundant slashes are no longer normalized, but preserved as
      they appear in the pattern; this is probably more correct, and falls
      out naturally from the algorithm used. since trailing slashes (which
      force all matches to be directories) are preserved as well, the
      behavior of GLOB_MARK has been adjusted not to append an additional
      slash to results that already end in slash.
      d44b07fc
    • R
      fix dlsym of thread-local symbols on archs with DTP_OFFSET!=0 · 37cd1676
      Rich Felker 提交于
      commit 6ba5517a modified
      __tls_get_addr to offset the address by +DTP_OFFSET (0x8000 on
      powerpc, mips, etc.) and adjusted the result of DTPREL relocations by
      -DTP_OFFSET to compensate, but missed changing the argument setup for
      calls to __tls_get_addr from dlsym.
      37cd1676
  3. 12 10月, 2018 3 次提交
    • R
      combine arch ABI's DTP_OFFSET into DTV pointers · b6d701a4
      Rich Felker 提交于
      as explained in commit 6ba5517a, some
      archs use an offset (typicaly -0x8000) with their DTPOFF relocations,
      which __tls_get_addr needs to invert. on affected archs, which lack
      direct support for large immediates, this can cost multiple extra
      instructions in the hot path. instead, incorporate the DTP_OFFSET into
      the DTV entries. this means they are no longer valid pointers, so
      store them as an array of uintptr_t rather than void *; this also
      makes it easier to access slot 0 as a valid slot count.
      
      commit e75b16cf left behind cruft in
      two places, __reset_tls and __tls_get_new, from back when it was
      possible to have uninitialized gap slots indicated by a null pointer
      in the DTV. since the concept of null pointer is no longer meaningful
      with an offset applied, remove this cruft.
      
      presently there are no archs with both TLSDESC and nonzero DTP_OFFSET,
      but the dynamic TLSDESC relocation code is also updated to apply an
      inverted offset to its offset field, so that the offset DTV would not
      impose a runtime cost in TLSDESC resolver functions.
      b6d701a4
    • R
      fix redundant computations of strlen in glob append function · 09a805a6
      Rich Felker 提交于
      len was already passed as an argument, so don't use strcat, and use
      memcpy instead of strcpy.
      09a805a6
    • R
      e2552581
  4. 11 10月, 2018 1 次提交
  5. 09 10月, 2018 1 次提交
    • R
      fix build regression on armhf in tlsdesc asm · b3389bbf
      Rich Felker 提交于
      when invoking the assembler, arm gcc does not always pass the right
      flags to enable use of vfp instruction mnemonics. for C code it
      produces, it emits the .fpu directive, but this does not help when
      building asm source files, which tlsdesc needs to be. to fix, use an
      explicit directive here.
      
      commit 0beb9dfb introduced this
      regression. it has not appeared in any release.
      b3389bbf
  6. 05 10月, 2018 1 次提交
    • R
      allow freeaddrinfo of arbitrary sublists of addrinfo list · d1395c43
      Rich Felker 提交于
      the specification for freeaddrinfo allows it to be used to free
      "arbitrary sublists" of the list returned by getaddrinfo. it's not
      clearly stated how such sublists come into existence, but the
      interpretation seems to be that the application can edit the ai_next
      pointers to cut off a portion of the list and then free it.
      
      actual freeing of individual list slots is contrary to the design of
      our getaddrinfo implementation, which has no failure paths after
      making a single allocation, so that light callers can avoid linking
      realloc/free. freeing individual slots is also incompatible with
      sharing the string for ai_canonname, which the current implementation
      does despite no requirement that it be present except on the first
      result. so, rather than actually freeing individual slots, provide a
      way to find the start of the allocated array, and reference-count it,
      freeing the memory all at once after the last slot has been freed.
      
      since the language in the spec is "arbitrary sublists", no provision
      for handling other constructs like multiple lists glued together,
      circular links, etc. is made. presumably passing such a construct to
      freeaddrinfo produces undefined behavior.
      d1395c43
  7. 02 10月, 2018 2 次提交
    • R
      inline cp15 thread pointer load in arm dynamic TLSDESC asm when possible · 7bf773a8
      Rich Felker 提交于
      the indirect function call is a significant portion of the code path
      for the dynamic case, and most users are probably building for ISA
      levels where it can be omitted.
      
      we could drop at least one register save/restore (lr) with this
      change, and possibly another (ip) with some clever shuffling, but it's
      not clear whether there's a way to do it that's not more expensive, or
      whether avoiding the save/restore would have any practical effect, so
      in the interest of avoiding complexity it's omitted for now.
      7bf773a8
    • R
      add TLSDESC support for 32-bit arm · 0beb9dfb
      Rich Felker 提交于
      unlike other asm where the baseline ISA is used, these functions are
      hot paths and use ISA-level specializations.
      
      call-clobbered vfp registers are saved before calling __tls_get_new,
      since there is no guarantee it won't use them. while setjmp/longjmp
      have to use hwcap to decide whether to the fpu is in use, since
      application code could be using vfp registers even if libc was
      compiled as pure softfloat, __tls_get_new is part of libc and can be
      assumed not to have access to vfp registers if tlsdesc.S does not.
      thus it suffices just to check the predefined preprocessor macros. the
      check for __ARM_PCS_VFP is redundant; !__SOFTFP__ must always be true
      if the target ISA level includes fpu instructions/registers.
      0beb9dfb
  8. 27 9月, 2018 1 次提交
    • R
      fix aliasing-based undefined behavior in string functions · 4d0a8217
      Rich Felker 提交于
      use the GNU C may_alias attribute if available, and fallback to naive
      byte-by-byte loops if __GNUC__ is not defined.
      
      this patch has been written to minimize changes so that history
      remains reviewable; it does not attempt to bring the affected code
      into a more consistent or elegant form.
      4d0a8217
  9. 23 9月, 2018 3 次提交
    • R
      optimize nop case of wmemmove · 8cd738bb
      Rich Felker 提交于
      8cd738bb
    • R
      fix undefined pointer comparison in wmemmove · 82c41e92
      Rich Felker 提交于
      82c41e92
    • R
      fix undefined pointer comparison in memmove · debadaa2
      Rich Felker 提交于
      the comparison must take place in the address space model as an
      integer type, since comparing pointers that are not pointing into the
      same array is undefined.
      
      the subsequent d<s comparison however is valid, because it's only
      reached in the case where the source and dest overlap, in which case
      they are necessarily pointing to parts of the same array.
      
      to make the comparison, use an unsigned range check for dist(s,d)>=n,
      algebraically !(-n<s-d<n). subtracting n yields !(-2*n<s-d-n<0), which
      mapped into unsigned modular arithmetic is !(-2*n<s-d-n) or rather
      -2*n>=s-d-n.
      debadaa2
  10. 21 9月, 2018 2 次提交
    • S
      new tsearch implementation · c50985d5
      Szabolcs Nagy 提交于
      Rewrote the AVL tree implementation:
      
      - It is now non-recursive with fixed stack usage (large enough for
      worst case tree height). twalk and tdestroy are still recursive as
      that's smaller/simpler.
      
      - Moved unrelated interfaces into separate translation units.
      
      - The node structure is changed to use indexed children instead of
      left/right pointers, this simplifies the balancing logic.
      
      - Using void * pointers instead of struct node * in various places,
      because this better fits the api (node address is passed in a void**
      argument, so it is tempting to incorrectly cast it to struct node **).
      
      - As a further performance improvement the rebalancing now stops
      when it is not needed (subtree height is unchanged). Otherwise
      the behaviour should be the same as before (checked over generated
      random inputs that the resulting tree shape is equivalent).
      
      - Removed the old copyright notice (including prng related one: it
      should be licensed under the same terms as the rest of the project).
      
      .text size of pic tsearch + tfind + tdelete + twalk:
      
         x86_64 i386 aarch64  arm mips powerpc ppc64le  sh4 m68k s390x
      old   941  899    1220 1068 1852    1400    1600 1008 1008  1488
      new   857  881    1040  976 1564    1192    1360  736  820  1408
      c50985d5
    • S
      add arm and sh bits/ptrace.h · 5ef60206
      Szabolcs Nagy 提交于
      These should have been added in commit
      df6d9450
      that added target specific PTRACE_ macros, but somehow got missed.
      5ef60206
  11. 20 9月, 2018 1 次提交
    • R
      fix getaddrinfo regression with AI_ADDRCONFIG on some configurations · f381c118
      Rich Felker 提交于
      despite not being documented to do so in the standard or Linux
      documentation, attempts to udp connect to 127.0.0.1 or ::1 generate
      EADDRNOTAVAIL when the loopback device is not configured and there is
      no default route for IPv6. this caused getaddrinfo with AI_ADDRCONFIG
      to fail with EAI_SYSTEM and EADDRNOTAVAIL on some no-IPv6
      configurations, rather than the intended behavior of detecting IPv6 as
      unsuppported and producing IPv4-only results.
      
      previously, only EAFNOSUPPORT was treated as unavailability of the
      address family being probed. instead, treat all errors related to
      inability to get an address or route as conclusive that the family
      being probed is unsupported, and only fail with EAI_SYSTEM on other
      errors.
      
      further improvements may be desirable, such as reporting EAI_AGAIN
      instead of EAI_SYSTEM for errors which are expected to be transient,
      but this patch should suffice to fix the serious regression.
      f381c118
  12. 19 9月, 2018 6 次提交
    • R
      support clang internal assembler when building for arm as thumb2 code · dffc2059
      Rich Felker 提交于
      the clang internal assembler does not accept assembler options passed
      via the usual -Wa mechanism, but it does accept -mimplicit-it directly
      as an option to the compiler driver.
      dffc2059
    • R
      support setting of default thread stack size via PT_GNU_STACK header · 7b3348a9
      Rich Felker 提交于
      this facilitates building software that assumes a large default stack
      size without any patching to call pthread_setattr_default_np or
      pthread_attr_setstacksize at each thread creation site, using just
      LDFLAGS.
      
      normally the PT_GNU_STACK header is used only to reflect whether
      executable stack is desired, but with GNU ld at least, passing
      -Wl,-z,stack-size=N will set a size on the program header. with this
      patch, that size will be incorporated into the default stack size
      (subject to increase-only rule and DEFAULT_STACK_MAX limit).
      
      both static and dynamic linking honor the program header. for dynamic
      linking, all libraries loaded at program start, including preloaded
      ones, are considered. dlopened libraries are not considered, for
      several reasons. extra logic would be needed to defer processing until
      the load of the new library is commited, synchronization woud be
      needed since other threads may be running concurrently, and the
      effectiveness woud be limited since the larger size would not apply to
      threads that already existed at the time of dlopen. programs that will
      dlopen code expecting a large stack need to declare the requirement
      themselves, or pthread_setattr_default_np can be used.
      7b3348a9
    • R
      increase default thread stack/guard size · c0058ab4
      Rich Felker 提交于
      stack size default is increased from 80k to 128k. this coincides with
      Linux's hard-coded default stack for the main thread (128k is
      initially committed; growth beyond that up to ulimit is contingent on
      additional allocation succeeding) and GNU ld's default PT_GNU_STACK
      size for FDPIC, at least on sh.
      
      guard size default is increased from 4k to 8k to reduce the risk of
      guard page jumping on overflow, since use of just over 4k of stack is
      common (PATH_MAX buffers, etc.).
      c0058ab4
    • R
      limit the configurable default stack/guard size for threads · 792f3277
      Rich Felker 提交于
      limit to 8MB/1MB, repectively. since the defaults cannot be reduced
      once increased, excessively large settings would lead to an
      unrecoverably broken state. this change is in preparation to allow
      defaults to be increased via program headers at the linker level.
      
      creation of threads that really need larger sizes needs to be done
      with an explicit attribute.
      792f3277
    • R
      remove redundant declarations of __default_stacksize, __default_guardsize · c7ed3e90
      Rich Felker 提交于
      these are now declared in pthread_impl.h.
      c7ed3e90
    • R
      fix benign data race in pthread_attr_init · 11ce1b13
      Rich Felker 提交于
      access to defaults should be protected against concurrent changes.
      11ce1b13
  13. 18 9月, 2018 2 次提交
    • R
      fix deletion of pthread tsd keys that still have non-null values stored · 84d061d5
      Rich Felker 提交于
      per POSIX, deletion of a key for which some threads still have values
      stored is permitted, and newly created keys must initially hold the
      null value in all threads. these properties were not met by our
      implementation; if a key was deleted with values left and a new key
      was created in the same slot, the old values were still visible.
      
      moreover, due to lack of any synchronization in pthread_key_delete,
      there was a TOCTOU race whereby a concurrent pthread_exit could
      attempt to call a null destructor pointer for the newly orphaned
      value.
      
      this commit introduces a solution based on __synccall, stopping the
      world to zero out the values for deleted keys, but only does so lazily
      when all key slots have been exhausted. pthread_key_delete is split
      off into a separate translation unit so that static-linked programs
      which only create keys but never delete them will not pull in the
      __synccall machinery.
      
      a global rwlock is added to synchronize creation and deletion of keys
      with dtor execution. since the dtor execution loop now has to release
      and retake the lock around its call to each dtor, checks are made not
      to call the nodtor dummy function for keys which lack a dtor.
      84d061d5
    • K
      fix race condition in file locking · 0db393d3
      Kaarle Ritvanen 提交于
      The condition occurs when
      - thread #1 is holding the lock
      - thread #2 is waiting for it on __futexwait
      - thread #1 is about to release the lock and performs a_swap
      - thread #3 enters the __lockfile function and manages to grab the lock
        before thread #1 calls __wake, resetting the MAYBE_WAITERS flag
      - thread #1 calls __wake
      - thread #2 wakes up but goes again to __futexwait as the lock is
        held by thread #3
      - thread #3 releases the lock but does not call __wake as the
        MAYBE_WAITERS flag is not set
      
      This condition results in thread #2 not being woken up. This patch fixes
      the problem by making the woken up thread ensure that the flag is
      properly set before going to sleep again.
      
      Mainainer's note: This fixes a regression introduced in commit
      c21f7507.
      0db393d3
  14. 17 9月, 2018 2 次提交
    • R
      getdelim: only grow buffer when necessary, improve OOM behavior · 1f6cbdb4
      Rich Felker 提交于
      commit b114190b introduced spurious
      realloc of the output buffer in cases where the result would exactly
      fit in the caller-provided buffer. this is contrary to a strict
      reading of the spec, which only allows realloc when the provided
      buffer is "of insufficient size".
      
      revert the adjustment of the realloc threshold, and instead push the
      byte read by getc_unlocked (for which the adjustment was made) back
      into the stdio buffer if it does not fit in the output buffer, to be
      read in the next loop iteration.
      
      in order not to leave a pushed-back byte in the stdio buffer if
      realloc fails (which would violate the invariant that logical FILE
      position and underlying open file description offset match for
      unbuffered FILEs), the OOM code path must be changed. it would suffice
      move just one byte in this case, but from a QoI perspective, in the
      event of ENOMEM the entire output buffer (up to the allocated length
      reported via *n) should contain bytes read from the FILE stream.
      otherwise the caller has no way to distinguish trunated data from
      uninitialized buffer space.
      
      the SIZE_MAX/2 check is removed since the sum of disjoint object sizes
      is assumed not to be able to overflow, leaving just one OOM code path.
      1f6cbdb4
    • R
      fix null pointer subtraction and comparison in stdio · 849e7603
      Rich Felker 提交于
      morally, for null pointers a and b, a-b, a<b, and a>b should all be
      defined as 0; however, C does not define any of them.
      
      the stdio implementation makes heavy use of such pointer comparison
      and subtraction for buffer logic, and also uses null pos/base/end
      pointers to indicate that the FILE is not in the corresponding (read
      or write) mode ready for accesses through the buffer.
      
      all of the comparisons are fixed trivially by using != in place of the
      relational operators, since the opposite relation (e.g. pos>end) is
      logically impossible. the subtractions have been reviewed to check
      that they are conditional the stream being in the appropriate reading-
      or writing-through-buffer mode, with checks added where needed.
      
      in fgets and getdelim, the checks added should improve performance for
      unbuffered streams by avoiding a do-nothing call to memchr, and should
      be negligible for buffered streams.
      849e7603
  15. 16 9月, 2018 3 次提交
    • R
      fix failure of getdelim to set stream orientation on error · 5cd309f0
      Rich Felker 提交于
      if EINVAL or ENOMEM happened before the first getc_unlocked, it was
      possible that the stream orientation had not yet been set.
      5cd309f0
    • R
      check for kernel support before allowing robust mutex creation · 5994de4e
      Rich Felker 提交于
      on some archs, linux support for futex operations (including
      robust_list processing) that depend on kernelspace CAS is conditional
      on a runtime check. as of linux 4.18, this check fails unconditionally
      on nommu archs that perform it, and spurious failure on powerpc64 was
      observed but not explained. it's also possible that futex support is
      omitted entirely, or that the kernel is older than 2.6.17. for most
      futex ops, ENOSYS does not yield hard breakage; userspace will just
      spin at 100% cpu load. but for robust mutexes, correct behavior
      depends on the kernel functionality.
      
      use the get_robust_list syscall to probe for support at the first call
      to pthread_mutexattr_setrobust, and block creation of robust mutexes
      with a reportable error if they can't be supported.
      5994de4e
    • B
      always reset DST rules during tzset · dbcfb16e
      Benjamin Peterson 提交于
      do_tzset() did't always reset the DST transition rules r0 and r1. That
      means the rules from older TZ settings could leak into newer ones.
      dbcfb16e
  16. 15 9月, 2018 5 次提交
    • R
      fix undefined behavior in strto* via FILE buffer pointer abuse · d6c855ca
      Rich Felker 提交于
      in order to produce FILE objects to pass to the intscan/floatscan
      backends without any (prohibitively costly) extra buffering layer, the
      strto* functions set the FILE's rend (read end) buffer pointer to an
      invalid value at the end of the address space, or SIZE_MAX/2 past the
      beginning of the string. this led to undefined behavior comparing and
      subtracting the end pointer with the buffer position pointer (rpos).
      
      the comparison issue is easily eliminated by using != instead of <.
      however the subtractions require nontrivial changes:
      
      previously, f->shcnt stored the count that would have been read if
      consuming the whole buffer, which required an end pointer for the
      buffer. the purpose for this was that it allowed reading it and adding
      rpos-rend at any time to get the actual count so far, and required no
      adjustment at the time of __shgetc (actual function call) since the
      call would only happen when reaching the end of the buffer.
      
      to get rid of the dependency on rend, instead offset shcnt by buf-rpos
      (start of buffer) at the time of last __shlim/__shgetc call. this
      makes for slightly more work in __shgetc the function, but for the
      inline macro it's still just as easy to compute the current count.
      
      since the scan helper interfaces used here are a big hack, comments
      are added to document their contracts and what's going on with their
      implementations.
      d6c855ca
    • B
      improve error handling of ttyname_r and isatty · c8497199
      Benjamin Peterson 提交于
      POSIX allows ttyname(_r) and isatty to return EBADF if passed file
      descriptor is invalid.
      
      maintainer's note: these are optional ("may fail") errors, but it's
      non-conforming for ttyname_r to return ENOTTY when it failed for a
      different reason.
      c8497199
    • R
      add hidden version of &errno accessor function · e13063aa
      Rich Felker 提交于
      this significantly improves codegen in functions that need to access
      errno but otherwise have no need for a GOT pointer.
      
      we could probably improve it much more by including an inline version
      of the &errno accessor function, but that depends on having the
      definitions of struct __pthread and __pthread_self(), which at present
      would expose a lot more than is appropriate. moving them to a small
      tls.h later might make this more reasonable.
      e13063aa
    • R
      fix build regression in sysconf for archs with variable page size · da55d488
      Rich Felker 提交于
      commit 5ce37379 removed the inclusion
      of libc.h from this file as spurious, but it's needed to get PAGE_SIZE
      on archs where PAGE_SIZE is not a constant defined by limits.h.
      da55d488
    • R
      drop lazy plural forms init in dcngettext · 017e67dd
      Rich Felker 提交于
      there is no good reason to wait to find and process the plural rules
      for a translated message file until a gettext form requesting plural
      rule processing is used. it just imposes additional synchronization,
      here in the form of clunky use of atomics.
      
      it looks like there may also have been a race condition where nplurals
      could be seen without plural_rule being seen, possibly leading to null
      pointer dereference. if so, this commit fixes it.
      017e67dd
  17. 14 9月, 2018 1 次提交
    • R
      fix broken atomic store on powerpc[64] · 12817793
      Rich Felker 提交于
      in our memory model, all atomics are supposed to be full barriers;
      stores are not release-only. this is important because store is used
      as an unlock operation in places where it needs to acquire the waiter
      count to determine if a futex wake is needed. at least in the
      malloc-internal locks, but possibly elsewhere, soft deadlocks from
      missing futex wake (breakable by poking the threads to restart the
      syscall, e.g. by attaching a tracer) were reported to occur.
      
      once the malloc lock is replaced with Jens Gustedt's new lock
      implementation (see commit 47d0bcd4),
      malloc will not be affected by the issue, but it's not clear that
      other uses won't be. reducing the strength of the ordering properties
      required from a_store would require a thorough analysis of how it's
      used.
      
      to fix the problem, I'm removing the powerpc[64]-specific a_store
      definition; now, the top-level atomic.h will implement a_store using
      a_barrier on both sides of the store.
      
      it's not clear to me yet whether there might be issues with the other
      atomics. it's possible that a_post_llsc needs to be replaced with a
      full barrier to guarantee the formal semanics we want, but either way
      I think the difference is unlikely to impact the way we use them.
      12817793
  18. 13 9月, 2018 1 次提交