1. 26 5月, 2015 1 次提交
    • R
      move call to dynamic linker stage-3 into stage-2 function · 768b82c6
      Rich Felker 提交于
      this move eliminates a duplicate "by-hand" symbol lookup loop from the
      stage-1 code and replaces it with a call to find_sym, which can be
      used once we're in stage 2. it reduces the size of the stage 1 code,
      which is helpful because stage 1 will become the crt start file for
      static-PIE executables, and it will allow stage 3 to access stage 2's
      automatic storage, which will be important in an upcoming commit.
      768b82c6
  2. 25 5月, 2015 2 次提交
    • R
      simplify/shrink relocation processing in dynamic linker stage 1 · 0e0e4942
      Rich Felker 提交于
      the outer-loop approach made sense when we were also processing
      DT_JMPREL, which might be in REL or RELA form, to avoid major code
      duplication. commit 09db855b removed
      processing of DT_JMPREL, and in the remaining two tables, the format
      (REL or RELA) is known by the name of the table. simply writing two
      versions of the loop results in smaller and simpler code.
      0e0e4942
    • R
      remove processing of DT_JMPREL from dynamic linker stage 1 bootstrap · 09db855b
      Rich Felker 提交于
      the DT_JMPREL relocation table necessarily consists entirely of
      JMP_SLOT (REL_PLT in internal nomenclature) relocations, which are
      symbolic; they cannot be resolved in stage 1, so there is no point in
      processing them.
      09db855b
  3. 19 5月, 2015 1 次提交
    • R
      reprocess libc/ldso RELA relocations in stage 3 of dynamic linking · c093e2e8
      Rich Felker 提交于
      this fixes a regression on powerpc that was introduced in commit
      f3ddd173. global data accesses on
      powerpc seem to be using a translation-unit-local GOT filled via
      R_PPC_ADDR32 relocations rather than R_PPC_GLOB_DAT. being a non-GOT
      relocation type, these were not reprocessed after adding the main
      application and its libraries to the chain, causing libc code not to
      see copy relocations in the main program, and therefore to use the
      pre-copy-relocation addresses for global data objects (like environ).
      
      the motivation for the dynamic linker only reprocessing GOT/PLT
      relocation types in stage 3 is that these types always have a zero
      addend, making them safe to process again even if the storage for the
      addend has been clobbered. other relocation types which can be used
      for address constants in initialized data objects may have non-zero
      addends which will be clobbered during the first pass of relocation
      processing if they're stored inline (REL form) rather than out-of-line
      (RELA form).
      
      powerpc generally uses only RELA, so this patch is sufficient to fix
      the regression in practice, but is not fully general, and would not
      suffice if an alternate toolchain generated REL for powerpc.
      c093e2e8
  4. 22 4月, 2015 2 次提交
  5. 19 4月, 2015 1 次提交
    • R
      make dlerror state and message thread-local and dynamically-allocated · 01d42747
      Rich Felker 提交于
      this fixes truncation of error messages containing long pathnames or
      symbol names.
      
      the dlerror state was previously required by POSIX to be global. the
      resolution of bug 97 relaxed the requirements to allow thread-safe
      implementations of dlerror with thread-local state and message buffer.
      01d42747
  6. 18 4月, 2015 5 次提交
    • R
      apply hidden visibility to tlsdesc accessor functions · 1b1cafa5
      Rich Felker 提交于
      these functions are never called directly; only their addresses are
      used, so PLT indirections should never happen unless a broken
      application tries to redefine them, but it's still best to make them
      hidden.
      1b1cafa5
    • S
      comment fixes in aarch64 tlsdesc asm · ca7977b5
      Szabolcs Nagy 提交于
      ca7977b5
    • R
      ensure debugger hook for dynamic linker does not point to a PLT slot · 326e126f
      Rich Felker 提交于
      this change is made in preparation to support linking without
      -Bsymbolic-functions.
      326e126f
    • R
      fix PLT call offset in sh dlsym asm · aecdbb30
      Rich Felker 提交于
      the braf instruction's destination register is an offset from the
      address of the braf instruction plus 4 (or equivalently, the address
      of the next instruction after the delay slot). the code for dlsym was
      incorrectly computing the offset to pass using the address of the
      delay slot itself. in other places, a label was placed after the delay
      slot, but I find this confusing. putting the label on the branch
      instruction itself, and manually adding 4, makes it more clear which
      branch the offset in the constant pool goes with.
      aecdbb30
    • R
      fix sh build regressions in asm · 33615cd5
      Rich Felker 提交于
      even hidden functions need @PLT symbol references; otherwise an
      absolute address is produced instead of a PC-relative one.
      33615cd5
  7. 15 4月, 2015 1 次提交
    • R
      use hidden __tls_get_new for tls/tlsdesc lookup fallback cases · 81e18eb3
      Rich Felker 提交于
      previously, the dynamic tlsdesc lookup functions and the i386
      special-ABI ___tls_get_addr (3 underscores) function called
      __tls_get_addr when the slot they wanted was not already setup;
      __tls_get_addr would then in turn also see that it's not setup and
      call __tls_get_new.
      
      calling __tls_get_new directly is both more efficient and avoids the
      issue of calling a non-hidden (public API/ABI) function from asm.
      
      for the special i386 function, a weak reference to __tls_get_new is
      used since this function is not defined when static linking (the code
      path that needs it is unreachable in static-linked programs).
      81e18eb3
  8. 14 4月, 2015 7 次提交
    • R
      72b25ddb
    • R
      fix inconsistent visibility for internal __tls_get_new function · bc081f62
      Rich Felker 提交于
      at the point of call it was declared hidden, but the definition was
      not hidden. for some toolchains this inconsistency produced textrels
      without ld-time binding.
      bc081f62
    • R
      make _dlstart_c function use hidden visibility · f1faa0e1
      Rich Felker 提交于
      otherwise the call/jump from the crt_arch.h asm may not resolve
      correctly without -Bsymbolic-functions.
      f1faa0e1
    • R
      remove initializers for decoded aux/dyn arrays in dynamic linker · f4f9562c
      Rich Felker 提交于
      the zero initialization is redundant since decode_vec does its own
      clearing, and it increases the risk that buggy compilers will generate
      calls to memset. as long as symbols are bound at ld time, such a call
      will not break anything, but it may be desirable to turn off ld-time
      binding in the future.
      f4f9562c
    • R
      remove remnants of support for running in no-thread-pointer mode · 19a1fe67
      Rich Felker 提交于
      since 1.1.0, musl has nominally required a thread pointer to be setup.
      most of the remaining code that was checking for its availability was
      doing so for the sake of being usable by the dynamic linker. as of
      commit 71f099cb, this is no longer
      necessary; the thread pointer is now valid before any libc code
      (outside of dynamic linker bootstrap functions) runs.
      
      this commit essentially concludes "phase 3" of the "transition path
      for removing lazy init of thread pointer" project that began during
      the 1.1.0 release cycle.
      19a1fe67
    • R
      move thread pointer setup to beginning of dynamic linker stage 3 · 71f099cb
      Rich Felker 提交于
      this allows the dynamic linker itself to run with a valid thread
      pointer, which is a prerequisite for stack protector on archs where
      the ssp canary is stored in TLS. it will also allow us to remove some
      remaining runtime checks for whether the thread pointer is valid.
      
      as long as the application and its libraries do not require additional
      size or alignment, this early thread pointer will be kept and reused
      at runtime. otherwise, a new static TLS block is allocated after
      library loading has finished and the thread pointer is switched over.
      71f099cb
    • R
      stabilize dynamic linker's layout of static TLS · 0f66fcec
      Rich Felker 提交于
      previously, the layout of the static TLS block was perturbed by the
      size of the dtv; dtv size increasing from 0 to 1 perturbed both TLS
      arch types, and the TLS-above-TP type's layout was perturbed by the
      specific number of dtv slots (libraries with TLS). this behavior made
      it virtually impossible to setup a tentative thread pointer address
      before loading libraries and keep it unchanged as long as the
      libraries' TLS size/alignment requirements fit.
      
      the new code fixes the location of the dtv and pthread structure at
      opposite ends of the static TLS block so that they will not move
      unless size or alignment changes.
      0f66fcec
  9. 13 4月, 2015 1 次提交
    • R
      dynamic linker bootstrap overhaul · f3ddd173
      Rich Felker 提交于
      this overhaul further reduces the amount of arch-specific code needed
      by the dynamic linker and removes a number of assumptions, including:
      
      - that symbolic function references inside libc are bound at link time
        via the linker option -Bsymbolic-functions.
      
      - that libc functions used by the dynamic linker do not require
        access to data symbols.
      
      - that static/internal function calls and data accesses can be made
        without performing any relocations, or that arch-specific startup
        code handled any such relocations needed.
      
      removing these assumptions paves the way for allowing libc.so itself
      to be built with stack protector (among other things), and is achieved
      by a three-stage bootstrap process:
      
      1. relative relocations are processed with a flat function.
      2. symbolic relocations are processed with no external calls/data.
      3. main program and dependency libs are processed with a
         fully-functional libc/ldso.
      
      reduction in arch-specific code is achived through the following:
      
      - crt_arch.h, used for generating crt1.o, now provides the entry point
        for the dynamic linker too.
      
      - asm is no longer responsible for skipping the beginning of argv[]
        when ldso is invoked as a command.
      
      - the functionality previously provided by __reloc_self for heavily
        GOT-dependent RISC archs is now the arch-agnostic stage-1.
      
      - arch-specific relocation type codes are mapped directly as macros
        rather than via an inline translation function/switch statement.
      f3ddd173
  10. 04 4月, 2015 2 次提交
    • R
      fix rpath string memory leak on failed dlopen · 07709625
      Rich Felker 提交于
      when dlopen fails, all partially-loaded libraries need to be unmapped
      and freed. any of these libraries using an rpath with $ORIGIN
      expansion may have an allocated string for the expanded rpath;
      previously, this string was not freed when freeing the library data
      structures.
      07709625
    • R
      halt dynamic linker library search on errors resolving $ORIGIN in rpath · 2963a9f7
      Rich Felker 提交于
      this change hardens the dynamic linker against the possibility of
      loading the wrong library due to inability to expand $ORIGIN in rpath.
      hard failures such as excessively long paths or absence of /proc (when
      resolving /proc/self/exe for the main executable's origin) do not stop
      the path search, but memory allocation failures and any other
      potentially transient failures do.
      
      to implement this change, the meaning of the return value of
      fixup_rpath function is changed. returning zero no longer indicates
      that the dso's rpath string pointer is non-null; instead, the caller
      needs to check. a return value of -1 indicates a failure that should
      stop further path search.
      2963a9f7
  11. 02 4月, 2015 1 次提交
    • R
      harden dynamic linker library path search · 5d1c8c99
      Rich Felker 提交于
      transient errors during the path search should not allow the search to
      continue and possibly open the wrong file. this patch eliminates most
      conditions where that could happen, but there is still a possibility
      that $ORIGIN-based rpath processing will have an allocation failure,
      causing the search to skip such a path. fixing this is left as a
      separate task.
      
      a small bug where overly-long path components caused an infinite loop
      rather than being skipped/ignored is also fixed.
      5d1c8c99
  12. 12 3月, 2015 2 次提交
    • S
      add aarch64 port · 01ef3dd9
      Szabolcs Nagy 提交于
      This adds complete aarch64 target support including bigendian subarch.
      
      Some of the long double math functions are known to be broken otherwise
      interfaces should be fully functional, but at this point consider this
      port experimental.
      
      Initial work on this port was done by Sireesh Tripurari and Kevin Bortis.
      01ef3dd9
    • S
      copy the dtv pointer to the end of the pthread struct for TLS_ABOVE_TP archs · 204a69d2
      Szabolcs Nagy 提交于
      There are two main abi variants for thread local storage layout:
      
       (1) TLS is above the thread pointer at a fixed offset and the pthread
       struct is below that. So the end of the struct is at known offset.
      
       (2) the thread pointer points to the pthread struct and TLS starts
       below it. So the start of the struct is at known (zero) offset.
      
      Assembly code for the dynamic TLSDESC callback needs to access the
      dynamic thread vector (dtv) pointer which is currently at the front
      of the pthread struct. So in case of (1) the asm code needs to hard
      code the offset from the end of the struct which can easily break if
      the struct changes.
      
      This commit adds a copy of the dtv at the end of the struct. New members
      must not be added after dtv_copy, only before it. The size of the struct
      is increased a bit, but there is opportunity for size optimizations.
      204a69d2
  13. 07 3月, 2015 1 次提交
    • R
      fix over-alignment of TLS, insufficient builtin TLS on 64-bit archs · bd67959f
      Rich Felker 提交于
      a conservative estimate of 4*sizeof(size_t) was used as the minimum
      alignment for thread-local storage, despite the only requirements
      being alignment suitable for struct pthread and void* (which struct
      pthread already contains). additional alignment required by the
      application or libraries is encoded in their headers and is already
      applied.
      
      over-alignment prevented the builtin_tls array from ever being used in
      dynamic-linked programs on 64-bit archs, thereby requiring allocation
      at startup even in programs with no TLS of their own.
      bd67959f
  14. 04 3月, 2015 1 次提交
    • R
      make all objects used with atomic operations volatile · 56fbaa3b
      Rich Felker 提交于
      the memory model we use internally for atomics permits plain loads of
      values which may be subject to concurrent modification without
      requiring that a special load function be used. since a compiler is
      free to make transformations that alter the number of loads or the way
      in which loads are performed, the compiler is theoretically free to
      break this usage. the most obvious concern is with atomic cas
      constructs: something of the form tmp=*p;a_cas(p,tmp,f(tmp)); could be
      transformed to a_cas(p,*p,f(*p)); where the latter is intended to show
      multiple loads of *p whose resulting values might fail to be equal;
      this would break the atomicity of the whole operation. but even more
      fundamental breakage is possible.
      
      with the changes being made now, objects that may be modified by
      atomics are modeled as volatile, and the atomic operations performed
      on them by other threads are modeled as asynchronous stores by
      hardware which happens to be acting on the request of another thread.
      such modeling of course does not itself address memory synchronization
      between cores/cpus, but that aspect was already handled. this all
      seems less than ideal, but it's the best we can do without mandating a
      C11 compiler and using the C11 model for atomics.
      
      in the case of pthread_once_t, the ABI type of the underlying object
      is not volatile-qualified. so we are assuming that accessing the
      object through a volatile-qualified lvalue via casts yields volatile
      access semantics. the language of the C standard is somewhat unclear
      on this matter, but this is an assumption the linux kernel also makes,
      and seems to be the correct interpretation of the standard.
      56fbaa3b
  15. 24 11月, 2014 1 次提交
    • R
      adapt dynamic linker for new binutils versions that omit DT_RPATH · d8dc2b7c
      Rich Felker 提交于
      the new DT_RUNPATH semantics for search order are always used, and
      since binutils had always set both DT_RPATH and DT_RUNPATH when the
      latter was used, processing only DT_RPATH worked fine. however, recent
      binutils has stopped generating DT_RPATH when DT_RUNPATH is used,
      which broke support for this feature completely.
      d8dc2b7c
  16. 19 11月, 2014 1 次提交
  17. 08 8月, 2014 2 次提交
  18. 19 7月, 2014 1 次提交
    • S
      add or1k (OpenRISC 1000) architecture port · 200d1547
      Stefan Kristiansson 提交于
      With the exception of a fenv implementation, the port is fully featured.
      The port has been tested in or1ksim, the golden reference functional
      simulator for OpenRISC 1000.
      It passes all libc-test tests (except the math tests that
      requires a fenv implementation).
      
      The port assumes an or1k implementation that has support for
      atomic instructions (l.lwa/l.swa).
      
      Although it passes all the libc-test tests, the port is still
      in an experimental state, and has yet experienced very little
      'real-world' use.
      200d1547
  19. 11 7月, 2014 2 次提交
  20. 30 6月, 2014 2 次提交
    • R
      fix regression in mips dynamic linker · 2d8cc92a
      Rich Felker 提交于
      this issue caused the address of functions in shared libraries to
      resolve to their PLT thunks in the main program rather than their
      correct addresses. it was observed causing crashes, though the
      mechanism of the crash was not thoroughly investigated. since the
      issue is very subtle, it calls for some explanation:
      
      on all well-behaved archs, GOT entries that belong to the PLT use a
      special relocation type, typically called JMP_SLOT, so that the
      dynamic linker can avoid having the jump destinations for the PLT
      resolve to PLT thunks themselves (they also provide a definition for
      the symbol, which must be used whenever the address of the function is
      taken so that all DSOs see the same address).
      
      however, the traditional mips PIC ABI lacked such a JMP_SLOT
      relocation type, presumably because, due to the way PIC works, the
      address of the PLT thunk was never needed and could always be ignored.
      
      prior to commit adf94c19, the mips
      version of reloc.h contained a hack that caused all symbol lookups to
      be treated like JMP_SLOT, inhibiting undefined symbols from ever being
      used to resolve symbolic relocations. this hack goes all the way back
      to commit babf8201, when the mips
      dynamic linker was first made usable.
      
      during the recent refactoring to eliminate arch-specific relocation
      processing (commit adf94c19), this
      hack was overlooked and no equivalent functionality was provided in
      the new code.
      
      fixing the problem is not as simple as adding back an equivalent hack,
      since there is now also a "non-PIC ABI" that can be used for the main
      executable, which actually does use a PLT. the closest thing to
      official documentation I could find for this ABI is nonpic.txt,
      attached to Message-ID: 20080701202236.GA1534@caradoc.them.org, which
      can be found in the gcc mailing list archives and elsewhere. per this
      document, undefined symbols corresponding to PLT thunks have the
      STO_MIPS_PLT bit set in the symbol's st_other field. thus, I have
      added an arch-specific rule for mips, applied at the find_sym level
      rather than the relocation level, to reject undefined symbols with the
      STO_MIPS_PLT bit clear.
      
      the previous hack of treating all mips relocations as JMP_SLOT-like,
      rather than rejecting the unwanted symbols in find_sym, probably also
      caused dlsym to wrongly return PLT thunks in place of the correct
      address of a function under at least some conditions. this should now
      be fixed, at least for global-scope symbol lookups.
      2d8cc92a
    • R
      fix regression in dynamic linker error reporting · 9a4ad022
      Rich Felker 提交于
      due to a mistake when refactoring the error printing for the dynamic
      linker (commit 7c73cacd), all messages
      were suppressed and replaced by blank lines.
      9a4ad022
  21. 24 6月, 2014 1 次提交
  22. 20 6月, 2014 2 次提交