1. 08 6月, 2015 1 次提交
    • R
      fix regression in pre-v7 arm on kernels with kuser helper removed · 75ce4503
      Rich Felker 提交于
      the arm atomics/TLS runtime selection code is called from
      __set_thread_area and depends on having libc.auxv and __hwcap
      available. commit 71f099cb moved the
      first call to __set_thread_area to the top of dynamic linking stage 3,
      before this data is made available, causing the runtime detection code
      to always see __hwcap as zero and thereby select the atomics/TLS
      implementations based on kuser helper.
      
      upcoming work on superh will use similar runtime detection.
      
      ideally this early-init code should be cleanly refactored and shared
      between the dynamic linker and static-linked startup.
      75ce4503
  2. 07 6月, 2015 6 次提交
  3. 05 6月, 2015 2 次提交
  4. 04 6月, 2015 1 次提交
    • R
      fix dynamic linker regression processing R_*_NONE type relocations · b6a6cd70
      Rich Felker 提交于
      commit f3ddd173 inadvertently removed
      the early check for "none" type relocations, causing the address
      dso->base+0 to be dereferenced to obtain an addend. shared libraries,
      (including libc.so) and PIE executables were unaffected, since their
      base addresses are the actual address of their mappings and are
      readable. non-PIE main executables, however, have a base address of 0
      because their load addresses are absolute and not offset at load time.
      
      in practice none-type relocations do not arise with toolchains that
      are in use except on mips, and on mips it's moderately rare for a
      non-PIE executable to have a relocation table, since the mips-specific
      got processing serves in its place for most purposes.
      b6a6cd70
  5. 03 6月, 2015 1 次提交
  6. 29 5月, 2015 2 次提交
    • R
      fix failure of ungetc and ungetwc to work on files in eof status · 2b4fcfda
      Rich Felker 提交于
      these functions were written to handle clearing eof status, but failed
      to account for the __toread function's handling of eof. with this
      patch applied, __toread still returns EOF when the file is in eof
      status, so that read operations will fail, but it also sets up valid
      buffer pointers for read mode, which are set to the end of the buffer
      rather than the beginning in order to make the whole buffer available
      to ungetc/ungetwc.
      
      minor changes to __uflow were needed since it's now possible to have
      non-zero buffer pointers while in eof status. as made, these changes
      remove a 'fast path' bypassing the function call to __toread, which
      could be reintroduced with slightly different logic, but since
      ordinary files have a syscall in f->read, optimizing the code path
      does not seem worthwhile.
      
      the __stdio_read function is also updated not to zero the read buffer
      pointers on eof/error. while not necessary for correctness, this
      change avoids the overhead of calling __toread in ungetc after
      reaching eof, and it also reduces code size and increases consistency
      with the fmemopen read operation which does not zero the pointers.
      2b4fcfda
    • R
      add missing legacy LFS64 macros in sys/resource.h · b6e7c664
      Rich Felker 提交于
      based on patch by Felix Janda, with RLIM64_SAVED_CUR and
      RLIM64_SAVED_MAX added for completeness.
      b6e7c664
  7. 28 5月, 2015 2 次提交
    • S
      configure: work around compilers that merely warn for unknown options · fc431d3f
      Shiz 提交于
      some compilers (such as clang) accept unknown options without error,
      but then print warnings on each invocation, cluttering the build
      output and burying meaningful warnings. this patch makes configure's
      tryflag and tryldflag functions use additional options to turn the
      unknown-option warnings into errors, if available, but only at check
      time. these options are not output in config.mak to avoid the risk of
      spurious build breakage; if they work, they will have already done
      their job at configure time.
      fc431d3f
    • R
      implement fail-safe static locales for newlocale · aeeac9ca
      Rich Felker 提交于
      this frees applications which need to make temporary use of the C
      locale (via uselocale) from the possibility that newlocale might fail.
      
      the C.UTF-8 locale is also provided as a static locale. presently they
      behave the same, but this may change in the future.
      aeeac9ca
  8. 27 5月, 2015 3 次提交
    • R
      rename internal locale file handling locale maps · 11858d31
      Rich Felker 提交于
      since the __setlocalecat function was removed, the filename
      __setlocalecat.c no longer made sense.
      11858d31
    • R
      overhaul locale internals to treat categories roughly uniformly · 61a3364d
      Rich Felker 提交于
      previously, LC_MESSAGES was treated specially as the only category
      which could be set to a locale name without a definition file, in
      order to facilitate gettext message translations when no libc locale
      was available. LC_NUMERIC was completely un-settable, and LC_CTYPE
      stored a flag intended to be used for a possible future byte-based C
      locale, instead of storing a __locale_map pointer like the other
      categories use.
      
      this patch changes all categories to be represented by pointers to
      __locale_map structures, and allows locale names without definition
      files to be treated as valid locales with trivial definition when used
      in any category. outwardly visible functional changes should be minor,
      limited mainly to the strings read back from setlocale and the way
      gettext handles translations in categories other than LC_MESSAGES.
      
      various internal refactoring has also been performed, and improvements
      in const correctness have been made.
      61a3364d
    • R
      replace atomics with locks in locale-setting code · 63c188ec
      Rich Felker 提交于
      this is part of a general program of removing direct use of atomics
      where they are not necessary to meet correctness or performance needs,
      but in this case it's also an optimization. only the global locale
      needs synchronization; allocated locales referenced with locale_t
      handles are immutable during their lifetimes, and using atomics to
      initialize them increases their cost of setup.
      63c188ec
  9. 26 5月, 2015 6 次提交
    • R
      add rcrt1 start file for fully static-linked PIE · dc031ee0
      Rich Felker 提交于
      static-linked PIE files need startup code to relocate themselves, much
      like the dynamic linker does. rcrt1.c reuses the code in dlstart.c,
      stage 1 of the dynamic linker, which in turn reuses crt_arch.h, to
      achieve static PIE with no new code. only relative relocations are
      supported.
      
      existing toolchains that don't yet support static PIE directly can be
      repurposed by passing "-shared -Wl,-Bstatic -Wl,-Bsymbolic" instead of
      "-static -pie" and substituting rcrt1.o in place of crt1.o.
      
      all libraries being linked must be built as PIC/PIE; TEXTRELs are not
      supported at this time.
      dc031ee0
    • R
      fix incorrect application of visibility to Scrt1.o · ed0c8249
      Rich Felker 提交于
      commit de2b67f8 attempted to avoid
      having vis.h affect crt files, but the Makefile variable used,
      CRT_LIBS, refers to the final output copies in the lib directory, not
      the copies in the crt build directory, and thus the -DCRT was not
      applied.
      
      while unlikely to be noticed, this regression probably broke
      production of PIE executables whose main functions are not in the
      executable but rather a shared library.
      ed0c8249
    • R
      reprocess all libc/ldso symbolic relocations in dynamic linking stage 3 · 9bbddf73
      Rich Felker 提交于
      commit f3ddd173 introduced early
      relocations and subsequent reprocessing as part of the dynamic linker
      bootstrap overhaul, to allow use of arbitrary libc functions before
      the main application and libraries are loaded, but only reprocessed
      GOT/PLT relocation types.
      
      commit c093e2e8 added reprocessing of
      non-GOT/PLT relocations to fix an actual regression that was observed
      on powerpc, but only for RELA format tables with out-of-line addends.
      REL table (inline addends at the relocation address) reprocessing is
      trickier because the first relocation pass clobbers the addends.
      
      this patch extends symbolic relocation reprocessing for libc/ldso to
      support all relocation types, whether REL or RELA format tables are
      used. it is believed not to alter behavior on any existing archs for
      the current dynamic linker and libc code. the motivations for this
      change are consistency and future-proofing. it ensures that behavior
      does not differ depending on whether REL or RELA tables are used,
      which could lead to undetected arch-specific bugs. it also ensures
      that, if in the future code depending on additional relocation types
      is added to libc.so, either at the source level or as part of the
      compiler runtime that gets pulled in (for example, soft-float with TLS
      for fenv), the new code will work properly.
      
      the implementation concept is simple: stage 2 of the dynamic linker
      counts the number of symbolic relocations in the libc/ldso REL table
      and allocates a VLA to save their addends into; stage 3 then uses the
      saved addends in place of the inline ones which were clobbered. for
      stack safety, a hard limit (currently 4k) is imposed on the number of
      such addends; this should be a couple orders of magnitude larger than
      the actual need. this number is not a runtime variable that could
      break fail-safety; it is constant for a given libc.so build.
      9bbddf73
    • R
      move call to dynamic linker stage-3 into stage-2 function · 768b82c6
      Rich Felker 提交于
      this move eliminates a duplicate "by-hand" symbol lookup loop from the
      stage-1 code and replaces it with a call to find_sym, which can be
      used once we're in stage 2. it reduces the size of the stage 1 code,
      which is helpful because stage 1 will become the crt start file for
      static-PIE executables, and it will allow stage 3 to access stage 2's
      automatic storage, which will be important in an upcoming commit.
      768b82c6
    • R
      mark mips crt code as code · 967bcbf6
      Rich Felker 提交于
      otherwise disassemblers treat it as data.
      967bcbf6
    • R
      mark mips cancellable syscall code as code · 7b75c487
      Rich Felker 提交于
      otherwise disassemblers treat it as data.
      7b75c487
  10. 25 5月, 2015 3 次提交
    • R
      simplify/shrink relocation processing in dynamic linker stage 1 · 0e0e4942
      Rich Felker 提交于
      the outer-loop approach made sense when we were also processing
      DT_JMPREL, which might be in REL or RELA form, to avoid major code
      duplication. commit 09db855b removed
      processing of DT_JMPREL, and in the remaining two tables, the format
      (REL or RELA) is known by the name of the table. simply writing two
      versions of the loop results in smaller and simpler code.
      0e0e4942
    • R
      remove processing of DT_JMPREL from dynamic linker stage 1 bootstrap · 09db855b
      Rich Felker 提交于
      the DT_JMPREL relocation table necessarily consists entirely of
      JMP_SLOT (REL_PLT in internal nomenclature) relocations, which are
      symbolic; they cannot be resolved in stage 1, so there is no point in
      processing them.
      09db855b
    • R
      fix stack alignment code in mips crt_arch.h · 9f26ebde
      Rich Felker 提交于
      the instruction used to align the stack, "and $sp, $sp, -8", does not
      actually exist; it's expanded to 2 instructions using the 'at'
      (assembler temporary) register, and thus cannot be used in a branch
      delay slot. since alignment mod 16 commutes with subtracting 8, simply
      swapping these two operations fixes the problem.
      
      crt1.o was not affected because it's still being generated from a
      dedicated asm source file. dlstart.lo was not affected because the
      stack pointer it receives is already aligned by the kernel. but
      Scrt1.o was affected in cases where the dynamic linker gave it a
      misaligned stack pointer.
      9f26ebde
  11. 22 5月, 2015 3 次提交
    • R
      add .text section directive to all crt_arch.h files missing it · 63caf1d2
      Rich Felker 提交于
      i386 and x86_64 versions already had the .text directive; other archs
      did not. normally, top-level (file scope) __asm__ starts in the .text
      section anyway, but problems were reported with some versions of
      clang, and it seems preferable to set it explicitly anyway, at least
      for the sake of consistency between archs.
      63caf1d2
    • R
      remove outdated and misleading comment in iconv.c · 3b0e8326
      Rich Felker 提交于
      the comment claimed that EUC/GBK/Big5 are not implemented, which has
      been incorrect since commit 19b4a0a2.
      3b0e8326
    • R
      in iconv_open, accept "CHAR" and "" as aliases for "UTF-8" · 39b8ce66
      Rich Felker 提交于
      while not a requirement, it's common convention in other iconv
      implementations to accept "CHAR" as an alias for nl_langinfo(CODESET),
      meaning the encoding used for char[] strings in the current locale,
      and also "" as an alternate form. supporting this is not costly and
      improves compatibility.
      39b8ce66
  12. 20 5月, 2015 1 次提交
  13. 19 5月, 2015 3 次提交
    • B
      inline llsc atomics when building for sh4a · 390f93ef
      Bobby Bingham 提交于
      If we're building for sh4a, the compiler is already free to use
      instructions only available on sh4a, so we can do the same and inline the
      llsc atomics. If we're building for an older processor, we still do the
      same runtime atomics selection as before.
      390f93ef
    • R
      reprocess libc/ldso RELA relocations in stage 3 of dynamic linking · c093e2e8
      Rich Felker 提交于
      this fixes a regression on powerpc that was introduced in commit
      f3ddd173. global data accesses on
      powerpc seem to be using a translation-unit-local GOT filled via
      R_PPC_ADDR32 relocations rather than R_PPC_GLOB_DAT. being a non-GOT
      relocation type, these were not reprocessed after adding the main
      application and its libraries to the chain, causing libc code not to
      see copy relocations in the main program, and therefore to use the
      pre-copy-relocation addresses for global data objects (like environ).
      
      the motivation for the dynamic linker only reprocessing GOT/PLT
      relocation types in stage 3 is that these types always have a zero
      addend, making them safe to process again even if the storage for the
      addend has been clobbered. other relocation types which can be used
      for address constants in initialized data objects may have non-zero
      addends which will be clobbered during the first pass of relocation
      processing if they're stored inline (REL form) rather than out-of-line
      (RELA form).
      
      powerpc generally uses only RELA, so this patch is sufficient to fix
      the regression in practice, but is not fully general, and would not
      suffice if an alternate toolchain generated REL for powerpc.
      c093e2e8
    • R
      fix null pointer dereference in dcngettext under specific conditions · 43e9f652
      Rich Felker 提交于
      if setlocale has not been called, the current locale's messages_name
      may be a null pointer. the code path where it's assumed to be non-null
      was only reachable if bindtextdomain had already been called, which is
      normally not done in programs which do not call setlocale, so the
      omitted check went unnoticed.
      
      patch from Void Linux, with description rewritten.
      43e9f652
  14. 16 5月, 2015 2 次提交
    • R
      eliminate costly tricks to avoid TLS access for current locale state · 68630b55
      Rich Felker 提交于
      the code being removed used atomics to track whether any threads might
      be using a locale other than the current global locale, and whether
      any threads might have abstract 8-bit (non-UTF-8) LC_CTYPE active, a
      feature which was never committed (still pending). the motivations
      were to support early execution prior to setup of the thread pointer,
      to partially support systems (ancient kernels) where thread pointer
      setup is not possible, and to avoid high performance cost on archs
      where accessing the thread pointer may be very slow.
      
      since commit 19a1fe67, the thread
      pointer is always available, so these hacks are no longer needed.
      removing them greatly simplifies the affected code.
      68630b55
    • R
      in i386 __set_thread_area, don't assume %gs register is initially zero · 707d7c30
      Rich Felker 提交于
      commit f630df09 added logic to handle
      the case where __set_thread_area is called more than once by reusing
      the GDT slot already in the %gs register, and only setting up a new
      GDT slot when %gs is zero. this created a hidden assumption that %gs
      is zero when a new process image starts, which is true in practice on
      Linux, but does not seem to be documented ABI, and fails to hold under
      qemu app-level emulation.
      
      while it would in theory be possible to zero %gs in the entry point
      code, this code is shared between static and dynamic binaries, and
      dynamic binaries must not clobber the value of %gs already setup by
      the dynamic linker.
      
      the alternative solution implemented in this commit simply uses global
      data to store the GDT index that's selected. __set_thread_area should
      only be called in the initial thread anyway (subsequent threads get
      their thread pointer setup by __clone), but even if it were called by
      another thread, it would simply read and write back the same GDT index
      that was already assigned to the initial thread, and thus (in the x86
      memory model) there is no data race.
      707d7c30
  15. 15 5月, 2015 2 次提交
    • R
      make arm reloc.h CRTJMP macro compatible with thumb · c0f10cf0
      Rich Felker 提交于
      compilers targeting armv7 may be configured to produce thumb2 code
      instead of arm code by default, and in the future we may wish to
      support targets where only the thumb instruction set is available.
      
      the instructions this patch omits in thumb mode are needed only for
      non-thumb versions of armv4 or earlier, which are not supported by any
      current compilers/toolchains and thus rather pointless to have. at
      some point these compatibility return sequences may be removed from
      all asm source files, and in that case it would make sense to remove
      them here too and remove the ifdef.
      c0f10cf0
    • R
      make arm crt_arch.h compatible with thumb code generation · 83340c7a
      Rich Felker 提交于
      compilers targeting armv7 may be configured to produce thumb2 code
      instead of arm code by default, and in the future we may wish to
      support targets where only the thumb instruction set is available.
      
      the changes made here avoid operating directly on the sp register,
      which is not possible in thumb code, and address an issue with the way
      the address of _DYNAMIC is computed.
      
      previously, the relative address of _DYNAMIC was stored with an
      additional offset of -8 versus the pc-relative add instruction, since
      on arm the pc register evaluates to ".+8". in thumb code, it instead
      evaluates to ".+4". both are two (normal-size) instructions beyond "."
      in the current execution mode, so the numbered label 2 used in the
      relative address expression is simply moved two instructions ahead to
      be compatible with both instruction sets.
      83340c7a
  16. 13 5月, 2015 1 次提交
  17. 08 5月, 2015 1 次提交