1. 16 8月, 2014 1 次提交
    • R
      make futex operations use private-futex mode when possible · bc09d58c
      Rich Felker 提交于
      private-futex uses the virtual address of the futex int directly as
      the hash key rather than requiring the kernel to resolve the address
      to an underlying backing for the mapping in which it lies. for certain
      usage patterns it improves performance significantly.
      
      in many places, the code using futex __wake and __wait operations was
      already passing a correct fixed zero or nonzero flag for the priv
      argument, so no change was needed at the site of the call, only in the
      __wake and __wait functions themselves. in other places, especially
      where the process-shared attribute for a synchronization object was
      not previously tracked, additional new code is needed. for mutexes,
      the only place to store the flag is in the type field, so additional
      bit masking logic is needed for accessing the type.
      
      for non-process-shared condition variable broadcasts, the futex
      requeue operation is unable to requeue from a private futex to a
      process-shared one in the mutex structure, so requeue is simply
      disabled in this case by waking all waiters.
      
      for robust mutexes, the kernel always performs a non-private wake when
      the owner dies. in order not to introduce a behavioral regression in
      non-process-shared robust mutexes (when the owning thread dies), they
      are simply forced to be treated as process-shared for now, giving
      correct behavior at the expense of performance. this can be fixed by
      adding explicit code to pthread_exit to do the right thing for
      non-shared robust mutexes in userspace rather than relying on the
      kernel to do it, and will be fixed in this way later.
      
      since not all supported kernels have private futex support, the new
      code detects EINVAL from the futex syscall and falls back to making
      the call without the private flag. no attempt to cache the result is
      made; caching it and using the cached value efficiently is somewhat
      difficult, and not worth the complexity when the benefits would be
      seen only on ancient kernels which have numerous other limitations and
      bugs anyway.
      bc09d58c
  2. 07 8月, 2011 1 次提交
  3. 03 8月, 2011 1 次提交
    • R
      avoid accessing mutex memory after atomic unlock · c68de0be
      Rich Felker 提交于
      this change is needed to fix a race condition and ensure that it's
      possible to unlock and destroy or unmap the mutex as soon as
      pthread_mutex_lock succeeds. POSIX explicitly gives such an example in
      the rationale and requires an implementation to allow such usage.
      c68de0be
  4. 15 4月, 2011 1 次提交
  5. 30 3月, 2011 1 次提交
    • R
      cheap special-case optimization for normal mutexes · 124b4ebc
      Rich Felker 提交于
      cycle-level benchmark on atom cpu showed typical pthread_mutex_lock
      call dropping from ~120 cycles to ~90 cycles with this change. benefit
      may vary with compiler options and version, but this optimization is
      very cheap to make and should always help some.
      124b4ebc
  6. 18 3月, 2011 2 次提交
    • R
      implement robust mutexes · 047e434e
      Rich Felker 提交于
      some of this code should be cleaned up, e.g. using macros for some of
      the bit flags, masks, etc. nonetheless, the code is believed to be
      working and correct at this point.
      047e434e
    • R
      unify lock and owner fields of mutex structure · b1c43161
      Rich Felker 提交于
      this change is necessary to free up one slot in the mutex structure so
      that we can use doubly-linked lists in the implementation of robust
      mutexes.
      b1c43161
  7. 17 3月, 2011 1 次提交
  8. 18 2月, 2011 1 次提交
    • R
      reorganize pthread data structures and move the definitions to alltypes.h · e8827563
      Rich Felker 提交于
      this allows sys/types.h to provide the pthread types, as required by
      POSIX. this design also facilitates forcing ABI-compatible sizes in
      the arch-specific alltypes.h, while eliminating the need for
      developers changing the internals of the pthread types to poke around
      with arch-specific headers they may not be able to test.
      e8827563
  9. 12 2月, 2011 1 次提交