1. 16 5月, 2015 2 次提交
    • R
      eliminate costly tricks to avoid TLS access for current locale state · 68630b55
      Rich Felker 提交于
      the code being removed used atomics to track whether any threads might
      be using a locale other than the current global locale, and whether
      any threads might have abstract 8-bit (non-UTF-8) LC_CTYPE active, a
      feature which was never committed (still pending). the motivations
      were to support early execution prior to setup of the thread pointer,
      to partially support systems (ancient kernels) where thread pointer
      setup is not possible, and to avoid high performance cost on archs
      where accessing the thread pointer may be very slow.
      
      since commit 19a1fe67, the thread
      pointer is always available, so these hacks are no longer needed.
      removing them greatly simplifies the affected code.
      68630b55
    • R
      in i386 __set_thread_area, don't assume %gs register is initially zero · 707d7c30
      Rich Felker 提交于
      commit f630df09 added logic to handle
      the case where __set_thread_area is called more than once by reusing
      the GDT slot already in the %gs register, and only setting up a new
      GDT slot when %gs is zero. this created a hidden assumption that %gs
      is zero when a new process image starts, which is true in practice on
      Linux, but does not seem to be documented ABI, and fails to hold under
      qemu app-level emulation.
      
      while it would in theory be possible to zero %gs in the entry point
      code, this code is shared between static and dynamic binaries, and
      dynamic binaries must not clobber the value of %gs already setup by
      the dynamic linker.
      
      the alternative solution implemented in this commit simply uses global
      data to store the GDT index that's selected. __set_thread_area should
      only be called in the initial thread anyway (subsequent threads get
      their thread pointer setup by __clone), but even if it were called by
      another thread, it would simply read and write back the same GDT index
      that was already assigned to the initial thread, and thus (in the x86
      memory model) there is no data race.
      707d7c30
  2. 07 5月, 2015 2 次提交
    • R
      fix futimes legacy function with null tv pointer · ece0c48a
      Rich Felker 提交于
      a null pointer is valid here and indicates that the current time
      should be used. based on patch by Felix Janda, simplified.
      ece0c48a
    • R
      fix stack protector crashes on x32 & powerpc due to misplaced TLS canary · 484194db
      Rich Felker 提交于
      i386, x86_64, x32, and powerpc all use TLS for stack protector canary
      values in the default stack protector ABI, but the location only
      matched the ABI on i386 and x86_64. on x32, the expected location for
      the canary contained the tid, thus producing spurious mismatches
      (resulting in process termination) upon fork. on powerpc, the expected
      location contained the stdio_locks list head, so returning from a
      function after calling flockfile produced spurious mismatches. in both
      cases, the random canary was not present, and a predictable value was
      used instead, making the stack protector hardening much less effective
      than it should be.
      
      in the current fix, the thread structure has been expanded to have
      canary fields at all three possible locations, and archs that use a
      non-default location must define a macro in pthread_arch.h to choose
      which location is used. for most archs (which lack TLS canary ABI) the
      choice does not matter.
      484194db
  3. 02 5月, 2015 4 次提交
  4. 28 4月, 2015 1 次提交
    • R
      fix sh jmp_buf size to match ABI · 85d12e02
      Rich Felker 提交于
      while the sh port is still experimental and subject to ABI
      instability, this is not actually an application/libc boundary ABI
      change. it only affects third-party APIs where jmp_buf is used in a
      shared structure at the ABI boundary, because nothing anywhere near
      the end of the jmp_buf object (which includes the oversized sigset_t)
      is accessed by libc.
      
      both glibc and uclibc have 15-slot jmp_buf for sh. presumably the
      smaller version was used in musl because the slots for fpu status
      register and thread pointer register (gbr) were incorrect and must not
      be restored by longjmp, but the size should have been preserved, as
      it's generally treated as a libc-agnostic ABI property for the arch,
      and having extra slots free in case we ever need them for something is
      useful anyway.
      85d12e02
  5. 25 4月, 2015 1 次提交
  6. 24 4月, 2015 4 次提交
    • R
      fix build regression in sh-nofpu subarch due to missing symbol · a658afbf
      Rich Felker 提交于
      commit 646cb9a4 switched sigsetjmp to
      use the new hidden ___setjmp symbol for setjmp, but the nofpu variant
      of setjmp.s was not updated to match.
      a658afbf
    • R
      fix misalignment of dtv in static-linked programs with odd-sized TLS · abead1be
      Rich Felker 提交于
      both static and dynamic linked versions of the __copy_tls function
      have a hidden assumption that the alignment of the beginning or end of
      the memory passed is suitable for storing an array of pointers for the
      dtv. pthread_create satisfies this requirement except when
      libc.tls_size is misaligned, which cannot happen with dynamic linking
      due to way update_tls_size computes the total size, but could happen
      with static linking and odd-sized TLS.
      abead1be
    • R
      remove dead store from static __init_tls · 23129ab8
      Rich Felker 提交于
      commit dab441ae, which made thread
      pointer init mandatory for all programs, rendered this store obsolete
      by removing the early-return path for static programs with no TLS.
      23129ab8
    • R
      make __init_tp function static when static linking · 5f51d529
      Rich Felker 提交于
      this slightly reduces the code size cost of TLS/thread-pointer for
      static linking since __init_tp can be inlined into its only caller and
      removed. this is analogous to the handling of __init_libc in
      __libc_start_main, where the function only has external linkage when
      it needs to be called from the dynamic linker.
      5f51d529
  7. 23 4月, 2015 1 次提交
    • R
      fix regression in x86_64 math asm with old binutils · 18938c29
      Rich Felker 提交于
      the implicit-operand form of fucomip is rejected by binutils 2.19 and
      perhaps other versions still in use. writing both operands explicitly
      fixes the issue. there is no change to the resulting output.
      
      commit a732e80d was the source of this
      regression.
      18938c29
  8. 22 4月, 2015 13 次提交
  9. 20 4月, 2015 5 次提交
    • R
      add optional global visibility override · de2b67f8
      Rich Felker 提交于
      this is implemented via the build system and does not affect source
      files. the idea is to use protected or hidden visibility to prevent
      the compiler from pessimizing function calls within a shared (or
      position-independent static) libc in the form of overhead setting up
      for a call through the PLT. the ld-time symbol binding via the
      -Bsymbolic-functions option already optimized out the PLT itself, but
      not the code in the caller needed to support a call through the PLT.
      on some archs this overhead can be substantial; on others it's
      trivial.
      de2b67f8
    • R
      remove invalid PLT calls from or1k asm · 51fc77c7
      Rich Felker 提交于
      analogous to commit 646cb9a4 for sh.
      51fc77c7
    • R
      remove possible-textrels from powerpc asm · cf1a9d9d
      Rich Felker 提交于
      these are perfectly fine with ld-time symbol binding, but otherwise
      result in textrels. they cannot be replaced with @PLT jump targets
      because the PLT thunks require a GOT register to be setup, so use a
      hidden alias instead.
      cf1a9d9d
    • R
      remove invalid PLT calls from microblaze asm · a880e6ce
      Rich Felker 提交于
      analogous to commit 646cb9a4 for sh.
      a880e6ce
    • R
      remove invalid PLT calls from sh asm · 646cb9a4
      Rich Felker 提交于
      these are perfectly fine with ld-time symbol binding, but if the calls
      go through a PLT thunk, they are invalid because the caller does not
      setup a GOT register. use a hidden alias to bypass the issue.
      646cb9a4
  10. 19 4月, 2015 4 次提交
  11. 18 4月, 2015 3 次提交