- 20 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
the workaround/fallback code for supporting O_PATH file descriptors when the kernel lacks support for performing these operations on them caused EBADF to get replaced by ENOENT (due to missing entry in /proc/self/fd). this is unlikely to affect real-world code (calls that might yield EBADF are generally unsafe, especially in library code) but it was breaking some test cases. the fix I've applied is something of a tradeoff: it adds one syscall to these operations on kernels where the workaround is needed. the alternative would be to catch ENOENT from the /proc lookup and translate it to EBADF, but I want to avoid doing that in the interest of not touching/depending on /proc at all in these functions as long as the kernel correctly supports the operations. this is following the general principle of isolating hacks to code paths that are taken on broken systems, and keeping the code for correct systems completely hack-free.
-
- 19 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
-
- 15 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
the ABI allows the callee to clobber stack slots that correspond to arguments passed in registers, so the caller must adjust the stack pointer to reserve space appropriately. prior to this fix, the argv array was possibly clobbered by dynamic linker code before passing control to the main program.
-
- 13 12月, 2013 2 次提交
-
-
由 Rich Felker 提交于
our getcwd already (as an extension) supports allocation of a buffer when the buffer argument is a null pointer, so there's no need to duplicate the allocation logic in this wrapper function. duplicating it is actually harmful in that it doubles the stack usage from PATH_MAX to 2*PATH_MAX.
-
由 Rich Felker 提交于
and thereby remove otherwise-unnecessary inclusion of stddef.h
-
- 12 12月, 2013 3 次提交
-
-
由 Szabolcs Nagy 提交于
-
由 Szabolcs Nagy 提交于
at most 4 hexadecimal digits are processed in one field so the value cannot overflow. the netdb.h header was not used.
-
由 Szabolcs Nagy 提交于
this makes the prototypes in math.h are visible so they are checked agaist the function definitions
-
- 07 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
this is purely a wrapper for close since Linux does not support EINTR semantics for the close syscall.
-
- 05 12月, 2013 4 次提交
-
-
由 Rich Felker 提交于
the wildcard function in GNU make includes dangling symlinks; if any exist under the .git directory, they would get added as dependencies, causing make to exit with an error due to lacking a rule to build the missing file. as far as I can tell, git operations which should force version.h to be rebuilt must all touch the mtime of the top-level .git directory.
-
由 Szabolcs Nagy 提交于
-
由 Szabolcs Nagy 提交于
-
由 Szabolcs Nagy 提交于
historically these functions appeared in BSD 4.3 without prototypes, then in the bind project prototypes were added to resolv.h, but those were incompatible with the definitions of the implementation. the bind resolv.h became the defacto api most systems use now, but the old internal definitions found their way into the linux manuals and thus into musl.
-
- 04 12月, 2013 2 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-
- 02 12月, 2013 8 次提交
-
-
由 Rich Felker 提交于
based on patch by Richard Pennington, who initially reported the issue.
-
由 Rich Felker 提交于
previously this flag was defined and accepted as a no-op, possibly breaking some software that uses it. given the choice to remove the definition and possibly break applications that were already working, or simply implement the feature, the latter turned out to be easy enough to make the decision easy. in the case where the FNM_PATHNAME flag is also set, this implementation is clean and essentially optimal. otherwise, it's an inefficient "brute force" implementation. at some point, when cleaning up and refactoring this code, I may add a more direct code path for handling FNM_LEADING_DIR in the non-FNM_PATHNAME case, but at this point my main interest is avoiding introducing new bugs in the code that implements the standard fnmatch features specified by POSIX.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
at least a couple of these are used on BSD too, and the FNM_* namespace is reserved in fnmatch.h anyway.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
this is still experimental and subject to change. for git checkouts, an attempt is made to record the exact revision to aid in bug reports and debugging. no version information is recorded in the static libc.a or binaries it's linked into.
-
由 Rich Felker 提交于
the FNM_PATHNAME logic for advancing by /-delimited components was incorrect when the / character was escaped (i.e. \/), and a final \ at the end of pattern was not handled correctly.
-
由 Szabolcs Nagy 提交于
a '/' in the pattern could be incorrectly matched against the terminating null byte in the string causing arbitrarily long sequence of out-of-bounds access in fnmatch("/","",FNM_PATHNAME)
-
- 01 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
a v6 socket will only be used if there is at least one v6 nameserver address. if the kernel lacks v6 support, the code will fall back to using a v4 socket and requests to v6 servers will silently fail. when using a v6 socket, v4 addresses are converted to v4-mapped form and setsockopt is used to ensure that the v6 socket can accept both v4 and v6 traffic (this is on-by-default on Linux but the default is configurable in /proc and so it needs to be set explicitly on the socket level). this scheme avoids increasing resource usage during lookups and allows the existing network io loop to be used without modification. previously, nameservers whose address family did not match the address family of the first-listed nameserver were simply ignored. prior to recent __ipparse fixes, they were not ignored but erroneously parsed.
-
- 30 11月, 2013 1 次提交
-
-
由 Rich Felker 提交于
the old value of 20 was reported by Laurent Bercot as being insufficient for a reasonable real-world usage case. actual problem was the internal buffer used by ttyname(), but the implementation of ttyname uses TTY_NAME_MAX, and for consistency it's best to increase both. the new value is aligned with glibc.
-
- 27 11月, 2013 3 次提交
-
-
由 Rich Felker 提交于
subsequent code assumes the address family requested is either unspecified or one of IPv4/IPv6, and could malfunction if this constraint is not met, so other address families should be explicitly rejected.
-
由 Rich Felker 提交于
on archs with excess precision, the floating point constant 1e40f may be evaluated such that it does not actually produce an infinity. 1e5000f is sufficiently large to produce an infinity for all supported floating point formats. note that this definition of INFINITY is only used for old or non-GNUC compilers anyway; despite being a portable, conforming definition, it leads to erroneous warnings on many compilers and thus using the builtin is preferred.
-
由 Rich Felker 提交于
these functions were spuriously failing in the case where the buffer size was exactly the number of bytes/characters to be written, including null termination. since these functions do not have defined error conditions other than buffer size, a reasonable application may fail to check the return value when the format string and buffer size are known to be valid; such an application could then attempt to use a non-terminated buffer. in addition to fixing the bug, I have changed the error handling behavior so that these functions always null-terminate the output except in the case where the buffer size is zero, and so that they always write as many characters as possible before failing, rather than dropping whole fields that do not fit. this actually simplifies the logic somewhat anyway.
-
- 26 11月, 2013 1 次提交
-
-
由 Szabolcs Nagy 提交于
-
- 25 11月, 2013 3 次提交
-
-
由 Rich Felker 提交于
unfortunately this eliminates the ability of the compiler to diagnose some dangerous/incorrect usage, but POSIX requires (as an extension to the C language, i.e. CX shaded) that NULL have type void *. plain C allows it to be defined as any null pointer constant. the definition 0L is preserved for C++ rather than reverting to plain 0 to avoid dangerous behavior in non-conforming programs which use NULL as a variadic sentinel. (it's impossible to use (void *)0 for C++ since C++ lacks the proper implicit pointer conversions, and other popular alternatives like the GCC __null extension seem non-conforming to the standard's requirements.)
-
由 Michael Forney 提交于
-
由 Michael Forney 提交于
-
- 24 11月, 2013 8 次提交
-
-
由 Michael Forney 提交于
This function is used by ping6 from iputils.
-
由 Michael Forney 提交于
-
由 Szabolcs Nagy 提交于
- remove the HAVE_EFFICIENT_IRINT case: fn is an exact integer, so it can be converted to int32_t a bit more efficiently than with a cast (the rounding mode change can be avoided), but musl does not support this case on any arch. - __rem_pio2: use double_t where possible - __rem_pio2f: use less assignments to avoid stores on i386 - use unsigned int bit manipulation (and union instead of macros) - use hexfloat literals instead of named constants
-
由 Szabolcs Nagy 提交于
some macros in sys/mtio.h and syslog.h used NULL without defining it
-
由 Szabolcs Nagy 提交于
definition in linux: #define O_TMPFILE (__O_TMPFILE | O_DIRECTORY) where __O_TMPFILE and O_DIRECTORY are arch specific
-
由 Szabolcs Nagy 提交于
-
由 Timo Teräs 提交于
-
由 Timo Teräs 提交于
and use _GNU_SOURCE || _BSD_SOURCE guards for all of the RFC 3678 namespace polluting things like glibc/uclibc does.
-