1. 12 7月, 2022 1 次提交
  2. 06 7月, 2022 1 次提交
  3. 04 7月, 2022 1 次提交
  4. 24 6月, 2022 1 次提交
  5. 23 6月, 2022 1 次提交
  6. 22 6月, 2022 1 次提交
  7. 10 5月, 2022 1 次提交
  8. 21 4月, 2022 2 次提交
  9. 20 4月, 2022 2 次提交
  10. 18 4月, 2022 1 次提交
  11. 29 3月, 2022 1 次提交
  12. 15 3月, 2022 1 次提交
  13. 09 3月, 2022 1 次提交
  14. 07 3月, 2022 1 次提交
  15. 16 2月, 2022 1 次提交
  16. 11 1月, 2022 1 次提交
  17. 11 6月, 2021 1 次提交
  18. 31 8月, 2020 1 次提交
  19. 20 8月, 2020 1 次提交
  20. 19 8月, 2020 1 次提交
  21. 17 8月, 2020 1 次提交
  22. 16 1月, 2020 1 次提交
    • R
      fix incorrect __hwcap seen in dynamic-linked __set_thread_area · 0ff18be2
      Rich Felker 提交于
      the bug fixed in commit b82cd6c7 was
      mostly masked on arm because __hwcap was zero at the point of the call
      from the dynamic linker to __set_thread_area, causing the access to
      libc.auxv to be skipped and kuser_helper versions of TLS access and
      atomics to be used instead of the armv6 or v7 versions. however, on
      kernels with kuser_helper removed for hardening it would crash.
      
      since __set_thread_area potentially uses __hwcap, it must be
      initialized before the function is called. move the AT_HWCAP lookup
      from stage 3 to stage 2b.
      0ff18be2
  23. 01 1月, 2020 3 次提交
    • R
      fix fdpic regression in dynamic linker with overly smart compilers · d6bbea2a
      Rich Felker 提交于
      at least gcc 9 broke execution of DT_INIT/DT_FINI for fdpic archs
      (presently only sh) by recognizing that the stores to the
      compound-literal function descriptor constructed to call them were
      dead stores. there's no way to make a "may_alias function", so instead
      launder the descriptor through an asm-statement barrier. in practice
      just making the compound literal volatile seemed to have worked too,
      but this should be less of a hack and more accurately convey the
      semantics of what transformations are not valid.
      d6bbea2a
    • R
      fix crashing ldso on archs where __set_thread_area examines auxv · b82cd6c7
      Rich Felker 提交于
      commit 1c84c999 moved the call to
      __init_tp above the initialization of libc.auxv, inadvertently
      breaking archs where __set_thread_area examines auxv for the sake of
      determining the TLS/atomic model needed at runtime. this broke armv6
      and sh2.
      b82cd6c7
    • R
      move stage3_func typedef out of shared internal dynlink.h header · b529ec9b
      Rich Felker 提交于
      this interface contract is entirely internal to dynlink.c.
      b529ec9b
  24. 03 11月, 2019 1 次提交
    • R
      add time64 redirect for, and redirecting implementation of, dlsym · 22daaea3
      Rich Felker 提交于
      if symbols are being redirected to provide the new time64 ABI, dlsym
      must perform matching redirections; otherwise, it would poke a hole in
      the magic and return pointers to functions that are not safe to call
      from a caller using time64 types.
      
      rather than duplicating a table of redirections, use the time64
      symbols present in libc's symbol table to derive the decision for
      whether a particular symbol needs to be redirected.
      22daaea3
  25. 14 8月, 2019 1 次提交
    • R
      fix regression whereby main thread didn't get TLS relocations · 9d35fec9
      Rich Felker 提交于
      commit ffab4360 broke this by moving
      relocations after not only the allocation of storage for the main
      thread's static TLS, but after the copying of the TLS image. thus,
      relocation results were not reflected in the main thread's copy. this
      could be fixed by calling __reset_tls after relocations, but instead
      split the allocation and installation before/after relocations so that
      there's not a redundant copy.
      
      due to commit 71af5309, updating of
      static_tls_cnt needs to be kept with allocation of static TLS, before
      relocations, rather than after installation.
      9d35fec9
  26. 13 8月, 2019 2 次提交
    • S
      make relocation time symbol lookup and dlsym consistent · f2435263
      Szabolcs Nagy 提交于
      Using common code path for all symbol lookups fixes three dlsym issues:
      
      - st_shndx of STT_TLS symbols were not checked and thus an undefined
        tls symbol reference could be incorrectly treated as a definition
        (the sysv hash lookup returns undefined symbols, gnu does not, so should
        be rare in practice).
      
      - symbol binding was not checked so a hidden symbol may be returned
        (in principle STB_LOCAL symbols may appear in the dynamic symbol table
        for hidden symbols, but linkers most likely don't produce it).
      
      - mips specific behaviour was not applied (ARCH_SYM_REJECT_UND) so
        undefined symbols may be returned on mips.
      
      always_inline is used to avoid relocation performance regression, the
      code generation for find_sym should not be affected.
      f2435263
    • R
      ldso: correct condition for local symbol handling in do_relocs · 1f060ed2
      Rich Felker 提交于
      commit 7a9669e9 added use of the
      symbol reference as the definition, in place of performing a lookup,
      for STT_SECTION symbol references that were first found used in FDPIC.
      such references may happen in certain other cases, such as
      local-dynamic TLS and with relocation types that require a symbol but
      that are being used for non-symbolic purposes, like the powerpc
      unaligned address relocations.
      
      in all such cases I'm aware of, the symbol referenced is a section
      symbol (STT_SECTION); however, the important semantic property is not
      its being a section, but rather its binding local (STB_LOCAL). check
      the latter instead of the former for greater generality and semantic
      correctness.
      1f060ed2
  27. 12 8月, 2019 1 次提交
    • S
      add support for powerpc/powerpc64 unaligned relocations · 08869deb
      Samuel Holland 提交于
      R_PPC_UADDR32 (R_PPC64_UADDR64) has the same meaning as R_PPC_ADDR32
      (R_PPC64_ADDR64), except that its address need not be aligned. For
      powerpc64, BFD ld(1) will automatically convert between ADDR<->UADDR
      relocations when the address is/isn't at its native alignment. This
      will happen if, for example, there is a pointer in a packed struct.
      
      gold and lld do not currently generate R_PPC64_UADDR64, but pass
      through misaligned R_PPC64_ADDR64 relocations from object files,
      possibly relaxing them to misaligned R_PPC64_RELATIVE. In both cases
      (relaxed or not) this violates the PSABI, which defines the relevant
      field type as "a 64-bit field occupying 8 bytes, the alignment of
      which is 8 bytes unless otherwise specified."
      
      All three linkers violate the PSABI on 32-bit powerpc, where the only
      difference is that the field is 32 bits wide, aligned to 4 bytes.
      
      Currently musl fails to load executables linked by BFD ld containing
      R_PPC64_UADDR64, with the error "unsupported relocation type 43".
      This change provides compatibility with BFD ld on powerpc64, and any
      static linker on either architecture that starts following the PSABI
      more closely.
      08869deb
  28. 11 8月, 2019 2 次提交
    • R
      ldso: remove redundant runtime checks in static TLS logic · 71af5309
      Rich Felker 提交于
      as a result of commit ffab4360,
      static_tls_cnt is now valid during relocations at program startup, so
      it's no longer necessary to condition the check against static_tls_cnt
      on this being a runtime (dlopen) relocation.
      71af5309
    • R
      ldso: fix calloc misuse allocating initial tls · ffab4360
      Rich Felker 提交于
      this is analogous to commit 2f1f51ae,
      and should have been caught at the same time since it was right next
      to the code moved in that commit. between final stage 3 reloc_all and
      the jump to the main program's entry point, it is not valid to call
      any functions which may be interposed by the application; doing so
      results in execution of application code before ctors have run, and on
      fdpic archs, before the main program's fdpic self-fixups have taken
      place, which will produce runaway wrong execution.
      ffab4360
  29. 07 7月, 2019 1 次提交
    • R
      fix inadvertent use of uninitialized variable in dladdr · 9b831820
      Rich Felker 提交于
      commit c8b49b2f introduced code that
      checked bestsym to determine whether a matching symbol was found, but
      bestsym is uninitialized if not. instead use best, consistent with use
      in the rest of the function.
      
      simplified from bug report and patch by Cheng Liu.
      9b831820
  30. 26 6月, 2019 1 次提交
    • R
      remove unnecessary and problematic _Noreturn from crt/ldso startup · 54b7564b
      Rich Felker 提交于
      after commit a48ccc15 removed the use
      of _Noreturn on the stage3_func type (which only worked due to it
      being defined to the "GNU C" attribute in C99 mode), GCC could no
      longer assume that the ends of __dls2 and __dls2b are unreachable, and
      produced a warning that a function marked _Noreturn returns.
      
      also, since commit 4390383b, the
      _Noreturn declaration for __libc_start_main in crt1/rcrt1 has been not
      only inconsistent with the definition, but wrong. formally,
      __libc_start_main does return, via a (hopefully) tail call to a helper
      function after the barrier. incorrect usage of _Noreturn in the
      declaration was probably formal UB.
      
      the _Noreturn specifiers were not useful in any of these places, so
      remove them all. now, the only remaining usage of _Noreturn is in
      public interfaces where _Noreturn is part of their contract.
      54b7564b
  31. 17 5月, 2019 2 次提交
    • S
      fix tls offsets when p_vaddr%p_align != 0 on TLS_ABOVE_TP targets · a60b9e06
      Szabolcs Nagy 提交于
      currently the bfd linker does not seem to create tls segments where
      p_vaddr%p_align != 0, but this is valid in ELF and then the runtime
      computed tls offset must satisfy
      
        offset%p_align == (base+p_vaddr)%p_align
      
      and in case of local exec tls (main executable) the smallest such
      offset must be used (otherwise it is incompatible with the offset
      computed by the static linker). the !TLS_ABOVE_TP case is handled
      correctly (the offset is negative then in the formula).
      
      the ldso code for TLS_ABOVE_TP is changed so the static tls offset
      of each module satisfies the formula.
      a60b9e06
    • S
      fix static tls offsets of shared libs on TLS_ABOVE_TP targets · 6104dae9
      Szabolcs Nagy 提交于
      tls_offset should always point to the end of the allocated static tls
      area, but this was not handled correctly on "tls variant 1" targets
      in the dynamic linker:
      
      after application tls was allocated, tls_offset was aligned up,
      potentially wasting tls space. (alignment may be needed at the
      begining of the tls area, not at the end, but that will be fixed
      separately as it is unlikely to affect real binaries.)
      
      when static tls was allocated for a shared library, tls_offset was
      only updated with the size of the tls segment which does not include
      alignment gaps, which can easily happen if the tls size update for
      one library leaves tls_offset misaligned for the next one. this can
      cause oob access in __copy_tls or arbitrary breakage at tls access.
      (the issue was observed on aarch64 with rust binaries)
      6104dae9
  32. 12 5月, 2019 1 次提交
  33. 11 4月, 2019 1 次提交
    • R
      overhaul i386 syscall mechanism not to depend on external asm source · 22e5bbd0
      Rich Felker 提交于
      this is the first part of a series of patches intended to make
      __syscall fully self-contained in the object file produced using
      syscall.h, which will make it possible for crt1 code to perform
      syscalls.
      
      the (confusingly named) i386 __vsyscall mechanism, which this commit
      removes, was introduced before the presence of a valid thread pointer
      was mandatory; back then the thread pointer was setup lazily only if
      threads were used. the intent was to be able to perform syscalls using
      the kernel's fast entry point in the VDSO, which can use the sysenter
      (Intel) or syscall (AMD) instruction instead of int $128, but without
      inlining an access to the __syscall global at the point of each
      syscall, which would incur a significant size cost from PIC setup
      everywhere. the mechanism also shuffled registers/calling convention
      around to avoid spills of call-saved registers, and to avoid
      allocating ebx or ebp via asm constraints, since there are plenty of
      broken-but-supported compiler versions which are incapable of
      allocating ebx with -fPIC or ebp with -fno-omit-frame-pointer.
      
      the new mechanism preserves the properties of avoiding spills and
      avoiding allocation of ebx/ebp in constraints, but does it inline,
      using some fairly simple register shuffling, and uses a field of the
      thread structure rather than global data for the vdso-provided syscall
      code address.
      
      for now, the external __syscall function is refactored not to use the
      old __vsyscall so it can be kept, but the intent is to remove it too.
      22e5bbd0