- 09 1月, 2014 3 次提交
-
-
由 Szabolcs Nagy 提交于
this glibc abi compatibility function was missed when the scanf aliases were added.
-
由 Szabolcs Nagy 提交于
weak_alias was only in the c code, so drem was missing on platforms where remainder is implemented in asm.
-
由 Rich Felker 提交于
per POSIX, the variadic argument has type union semun, which may contain a pointer or int; the type read depends on the command being issued. this allows the userspace part of the implementation to be type-correct without requiring special-casing for different commands. the kernel always expects to receive the argument interpreted as unsigned long (or equivalently, a pointer), and does its own handling of extracting the int portion from the representation, as needed. this change fixes two possible issues: most immediately, reading the argument as a (signed) long and passing it to the syscall would perform incorrect sign-extension of pointers on the upcoming x32 target. the other possible issue is that some archs may use different (user-space) argument-passing convention for unions, preventing va_arg from correctly obtaining the argument when the type long (or even unsigned long or void *) is passed to it.
-
- 08 1月, 2014 1 次提交
-
-
由 Rich Felker 提交于
really, fcntl should be changed to use the correct type corresponding to cmd when calling va_arg, and to carry the correct type through until making the syscall. however, this greatly increases binary size and does not seem to offer any benefits except formal correctness, so I'm holding off on that change for now. the minimal changes made in this patch are in preparation for addition of the x32 port, where the syscall macros need to know whether their arguments are pointers or integers in order to properly pass them to the 64-bit kernel.
-
- 07 1月, 2014 9 次提交
-
-
由 Rich Felker 提交于
it's unclear what the historical signature for this function was, but semantically, the argument should be a pointer to const, and this is what glibc uses. correct programs should not be using this function anyway, so it's unlikely to matter.
-
由 Rich Felker 提交于
both the kernel and glibc agree that this argument is unsigned; the incorrect type ssize_t came from erroneous man pages.
-
由 Rich Felker 提交于
this change is consistent with the corresponding glibc functions and is semantically const-correct. the incorrect argument types without const seem to have been taken from erroneous man pages.
-
由 Rich Felker 提交于
this functionality has essentially always been deprecated in linux, and was never supported by musl. the presence of the header was reported to cause some software to attempt to use the nonexistant function, so removing the header is the cleanest solution.
-
由 Rich Felker 提交于
this was wrong since the original commit adding inotify, and I don't see any explanation for it. not even the man pages have it wrong. it was most likely a copy-and-paste error.
-
由 Rich Felker 提交于
the type int was taken from seemingly erroneous man pages. glibc uses in_addr_t (uint32_t), and semantically, the arguments should be unsigned.
-
由 Rich Felker 提交于
this practice came from very early, before internal/syscall.h defined macros that could accept pointer arguments directly and handle them correctly. aside from being ugly and unnecessary, it looks like it will be problematic when we add support for 32-bit ABIs on archs where registers (and syscall arguments) are 64-bit, e.g. x32 and mips n32.
-
由 Rich Felker 提交于
this agrees with implementation practice on glibc and BSD systems, and is the const-correct way to do things; it eliminates warnings from passing pointers to const. the prototype without const came from seemingly erroneous man pages.
-
由 Rich Felker 提交于
-
- 04 1月, 2014 1 次提交
-
-
由 Rich Felker 提交于
-
- 03 1月, 2014 4 次提交
-
-
由 rofl0r 提交于
the header is included only as a guard to check that the declaration and definition match, so the typo didn't cause any breakage aside from omitting this check.
-
由 Rich Felker 提交于
the reasons are the same as for sbrk. unlike sbrk, there is no safe usage because brk does not return any useful information, so it should just fail unconditionally.
-
由 Rich Felker 提交于
use of sbrk is never safe; it conflicts with malloc, and malloc may be used internally by the implementation basically anywhere. prior to this change, applications attempting to use sbrk to do their own heap management simply caused untrackable memory corruption; now, they will fail with ENOMEM allowing the errors to be fixed. sbrk(0) is still permitted as a way to get the current brk; some misguided applications use this as a measurement of their memory usage or for other related purposes, and such usage is harmless. eventually sbrk may be re-added if/when malloc is changed to avoid using the brk by using mmap for all allocations.
-
由 rofl0r 提交于
-
- 30 12月, 2013 1 次提交
-
-
由 Timo Teräs 提交于
ssi_ptr is really 64-bit in kernel, so fix that. assuming sizeof(void*) for it also caused incorrect padding for 32-bits, as the following 64-bits are aligned to 64-bits (and the padding was not taken into account), so fix the padding as well. add addr_lsb field while there.
-
- 21 12月, 2013 4 次提交
-
-
由 Rich Felker 提交于
based on patch by Timo Teräs; greatly simplified to use fprintf.
-
由 Rich Felker 提交于
based on patch by Timo Teräs.
-
由 Rich Felker 提交于
based on patch by Timo Teräs.
-
由 Timo Teräs 提交于
-
- 20 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
the workaround/fallback code for supporting O_PATH file descriptors when the kernel lacks support for performing these operations on them caused EBADF to get replaced by ENOENT (due to missing entry in /proc/self/fd). this is unlikely to affect real-world code (calls that might yield EBADF are generally unsafe, especially in library code) but it was breaking some test cases. the fix I've applied is something of a tradeoff: it adds one syscall to these operations on kernels where the workaround is needed. the alternative would be to catch ENOENT from the /proc lookup and translate it to EBADF, but I want to avoid doing that in the interest of not touching/depending on /proc at all in these functions as long as the kernel correctly supports the operations. this is following the general principle of isolating hacks to code paths that are taken on broken systems, and keeping the code for correct systems completely hack-free.
-
- 19 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
-
- 15 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
the ABI allows the callee to clobber stack slots that correspond to arguments passed in registers, so the caller must adjust the stack pointer to reserve space appropriately. prior to this fix, the argv array was possibly clobbered by dynamic linker code before passing control to the main program.
-
- 13 12月, 2013 2 次提交
-
-
由 Rich Felker 提交于
our getcwd already (as an extension) supports allocation of a buffer when the buffer argument is a null pointer, so there's no need to duplicate the allocation logic in this wrapper function. duplicating it is actually harmful in that it doubles the stack usage from PATH_MAX to 2*PATH_MAX.
-
由 Rich Felker 提交于
and thereby remove otherwise-unnecessary inclusion of stddef.h
-
- 12 12月, 2013 3 次提交
-
-
由 Szabolcs Nagy 提交于
-
由 Szabolcs Nagy 提交于
at most 4 hexadecimal digits are processed in one field so the value cannot overflow. the netdb.h header was not used.
-
由 Szabolcs Nagy 提交于
this makes the prototypes in math.h are visible so they are checked agaist the function definitions
-
- 07 12月, 2013 1 次提交
-
-
由 Rich Felker 提交于
this is purely a wrapper for close since Linux does not support EINTR semantics for the close syscall.
-
- 05 12月, 2013 4 次提交
-
-
由 Rich Felker 提交于
the wildcard function in GNU make includes dangling symlinks; if any exist under the .git directory, they would get added as dependencies, causing make to exit with an error due to lacking a rule to build the missing file. as far as I can tell, git operations which should force version.h to be rebuilt must all touch the mtime of the top-level .git directory.
-
由 Szabolcs Nagy 提交于
-
由 Szabolcs Nagy 提交于
-
由 Szabolcs Nagy 提交于
historically these functions appeared in BSD 4.3 without prototypes, then in the bind project prototypes were added to resolv.h, but those were incompatible with the definitions of the implementation. the bind resolv.h became the defacto api most systems use now, but the old internal definitions found their way into the linux manuals and thus into musl.
-
- 04 12月, 2013 2 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-
- 02 12月, 2013 2 次提交
-
-
由 Rich Felker 提交于
based on patch by Richard Pennington, who initially reported the issue.
-
由 Rich Felker 提交于
previously this flag was defined and accepted as a no-op, possibly breaking some software that uses it. given the choice to remove the definition and possibly break applications that were already working, or simply implement the feature, the latter turned out to be easy enough to make the decision easy. in the case where the FNM_PATHNAME flag is also set, this implementation is clean and essentially optimal. otherwise, it's an inefficient "brute force" implementation. at some point, when cleaning up and refactoring this code, I may add a more direct code path for handling FNM_LEADING_DIR in the non-FNM_PATHNAME case, but at this point my main interest is avoiding introducing new bugs in the code that implements the standard fnmatch features specified by POSIX.
-