1. 28 9月, 2011 6 次提交
  2. 27 9月, 2011 3 次提交
    • R
      fix ctype macros to cast argument to (unsigned) first · 7e14ed13
      Rich Felker 提交于
      issue reported by nsz, but it's actually not just pedantic. the
      functions can take input of any arithmetic type, including floating
      point, and the behavior needs to be as if the conversion implicit in
      the function call took place.
      7e14ed13
    • R
      another cond var fix: requeue count race condition · 3bec53e0
      Rich Felker 提交于
      lock out new waiters during the broadcast. otherwise the wait count
      added to the mutex might be lower than the actual number of waiters
      moved, and wakeups may be lost.
      
      this issue could also be solved by temporarily setting the mutex
      waiter count higher than any possible real count, then relying on the
      kernel to tell us how many waiters were requeued, and updating the
      counts afterwards. however the logic is more complex, and i don't
      really trust the kernel. the solution here is also nice in that it
      replaces some atomic cas loops with simple non-atomic ops under lock.
      3bec53e0
    • R
      fix lost signals in cond vars · 1fa05210
      Rich Felker 提交于
      due to moving waiters from the cond var to the mutex in bcast, these
      waiters upon wakeup would steal slots in the count from newer waiters
      that had not yet been signaled, preventing the signal function from
      taking any action.
      
      to solve the problem, we simply use two separate waiter counts, and so
      that the original "total" waiters count is undisturbed by broadcast
      and still available for signal.
      1fa05210
  3. 26 9月, 2011 4 次提交
    • R
      cleanup various minor issues reported by nsz · fd142e5e
      Rich Felker 提交于
      the changes to syscall_ret are mostly no-ops in the generated code,
      just cleanup of type issues and removal of some implementation-defined
      behavior. the one exception is the change in the comparison value,
      which is fixed so that 0xf...f000 (which in principle could be a valid
      return value for mmap, although probably never in reality) is not
      treated as an error return.
      fd142e5e
    • R
      redo cond vars again, use sequence numbers · 729d6368
      Rich Felker 提交于
      testing revealed that the old implementation, while correct, was
      giving way too many spurious wakeups due to races changing the value
      of the condition futex. in a test program with 5 threads receiving
      broadcast signals, the number of returns from pthread_cond_wait was
      roughly 3 times what it should have been (2 spurious wakeups for every
      legitimate wakeup). moreover, the magnitude of this effect seems to
      grow with the number of threads.
      
      the old implementation may also have had some nasty race conditions
      with reuse of the cond var with a new mutex.
      
      the new implementation is based on incrementing a sequence number with
      each signal event. this sequence number has nothing to do with the
      number of threads intended to be woken; it's only used to provide a
      value for the futex wait to avoid deadlock. in theory there is a
      danger of race conditions due to the value wrapping around after 2^32
      signals. it would be nice to eliminate that, if there's a way.
      
      testing showed no spurious wakeups (though they are of course
      possible) with the new implementation, as well as slightly improved
      performance.
      729d6368
    • R
      revert previous change in cond var waiter move · c11d1e69
      Rich Felker 提交于
      using swap has a race condition: the waiters must be added to the
      mutex waiter count *before* they are taken off the cond var waiter
      count, or wake events can be lost.
      c11d1e69
    • R
      cf940165
  4. 25 9月, 2011 2 次提交
  5. 24 9月, 2011 3 次提交
    • R
      fix ABA race in cond vars, improve them overall · 97c5b5a8
      Rich Felker 提交于
      previously, a waiter could miss the 1->0 transition of block if
      another thread set block to 1 again after the signal function set
      block to 0. we now use the caller's thread id as a unique token to
      store in block, which no other thread will ever write there. this
      ensures that if block still contains the tid, no signal has occurred.
      spurious wakeups will of course occur whenever there is a spurious
      return from the futex wait and another thread has begun waiting on the
      cond var. this should be a rare occurrence except perhaps in the
      presence of interrupting signal handlers.
      
      signal/bcast operations have been improved by noting that they need
      not avoid inspecting the cond var's memory after changing the futex
      value. because the standard allows spurious wakeups, there is no way
      for an application to distinguish between a spurious wakeup just
      before another thread called signal/bcast, and the deliberate wakeup
      resulting from the signal/bcast call. thus the woken thread must
      assume that the signalling thread may still be waiting to act on the
      cond var, and therefore it cannot destroy/unmap the cond var.
      97c5b5a8
    • R
      FD_ISSET must return an int. this is the easiest way. · c41a76f5
      Rich Felker 提交于
      casting to int would not be correct because high bits could be lost.
      mapping the high bits down onto low bits would be costlier in the
      common case where the result is just used in a conditional. changing
      the type of the bit array elements to int would permute the order of
      the bit array on 64-bit big endian systems, so that's not an option
      either.
      c41a76f5
    • R
      sys/user.h may need stdint.h · 1587224e
      Rich Felker 提交于
      1587224e
  6. 23 9月, 2011 5 次提交
  7. 22 9月, 2011 10 次提交
  8. 21 9月, 2011 3 次提交
  9. 20 9月, 2011 4 次提交