1. 18 4月, 2015 1 次提交
    • R
      redesign sigsetjmp so that signal mask is restored after longjmp · 583e5512
      Rich Felker 提交于
      the conventional way to implement sigsetjmp is to save the signal mask
      then tail-call to setjmp; siglongjmp then restores the signal mask and
      calls longjmp. the problem with this approach is that a signal already
      pending, or arriving between unmasking of signals and restoration of
      the saved stack pointer, will have its signal handler run on the stack
      that was active before siglongjmp was called. this can lead to
      unbounded stack usage when siglongjmp is used to leave a signal
      handler.
      
      in the new design, sigsetjmp saves its own return address inside the
      extended part of the sigjmp_buf (outside the __jmp_buf part used by
      setjmp) then calls setjmp to save a jmp_buf inside its own execution.
      it then tail-calls to __sigsetjmp_tail, which uses the return value of
      setjmp to determine whether to save the current signal mask or restore
      a previously-saved mask.
      
      as an added bonus, this design makes it so that siglongjmp and longjmp
      are identical. this is useful because the __longjmp_chk function we
      need to add for ABI-compatibility assumes siglongjmp and longjmp are
      the same, but for different reasons -- it was designed assuming either
      can access a flag just past the __jmp_buf indicating whether the
      signal masked was saved, and act on that flag. however, early versions
      of musl did not have space past the __jmp_buf for the non-sigjmp_buf
      version of jmp_buf, so our setjmp cannot store such a flag without
      risking clobbering memory on (very) old binaries.
      583e5512
  2. 15 4月, 2015 3 次提交
    • R
      use hidden __tls_get_new for tls/tlsdesc lookup fallback cases · 81e18eb3
      Rich Felker 提交于
      previously, the dynamic tlsdesc lookup functions and the i386
      special-ABI ___tls_get_addr (3 underscores) function called
      __tls_get_addr when the slot they wanted was not already setup;
      __tls_get_addr would then in turn also see that it's not setup and
      call __tls_get_new.
      
      calling __tls_get_new directly is both more efficient and avoids the
      issue of calling a non-hidden (public API/ABI) function from asm.
      
      for the special i386 function, a weak reference to __tls_get_new is
      used since this function is not defined when static linking (the code
      path that needs it is unreachable in static-linked programs).
      81e18eb3
    • R
      cleanup use of visibility attributes in pthread_cancel.c · 9c738dc1
      Rich Felker 提交于
      applying the attribute to a weak_alias macro was a hack. instead use a
      separate declaration to apply the visibility, and consolidate
      declarations together to avoid having visibility mess all over the
      file.
      9c738dc1
    • R
      7405cd1e
  3. 14 4月, 2015 11 次提交
    • R
      72b25ddb
    • R
      consistently use hidden visibility for cancellable syscall internals · cbc02ba2
      Rich Felker 提交于
      in a few places, non-hidden symbols were referenced from asm in ways
      that assumed ld-time binding. while these is no semantic reason these
      symbols need to be hidden, fixing the references without making them
      hidden was going to be ugly, and hidden reduces some bloat anyway.
      
      in the asm files, .global/.hidden directives have been moved to the
      top to unclutter the actual code.
      cbc02ba2
    • R
      fix inconsistent visibility for internal __tls_get_new function · bc081f62
      Rich Felker 提交于
      at the point of call it was declared hidden, but the definition was
      not hidden. for some toolchains this inconsistency produced textrels
      without ld-time binding.
      bc081f62
    • R
      use hidden visibility for i386 asm-internal __vsyscall symbol · da7ccf82
      Rich Felker 提交于
      otherwise the call instruction in the inline syscall asm results in
      textrels without ld-time binding.
      da7ccf82
    • R
      make _dlstart_c function use hidden visibility · f1faa0e1
      Rich Felker 提交于
      otherwise the call/jump from the crt_arch.h asm may not resolve
      correctly without -Bsymbolic-functions.
      f1faa0e1
    • R
      remove initializers for decoded aux/dyn arrays in dynamic linker · f4f9562c
      Rich Felker 提交于
      the zero initialization is redundant since decode_vec does its own
      clearing, and it increases the risk that buggy compilers will generate
      calls to memset. as long as symbols are bound at ld time, such a call
      will not break anything, but it may be desirable to turn off ld-time
      binding in the future.
      f4f9562c
    • R
      allow libc itself to be built with stack protector enabled · 1ef849c6
      Rich Felker 提交于
      this was already essentially possible as a result of the previous
      commits changing the dynamic linker/thread pointer bootstrap process.
      this commit mainly adds build system infrastructure:
      
      configure no longer attempts to disable stack protector. instead it
      simply determines how so the makefile can disable stack protector for
      a few translation units used during early startup.
      
      stack protector is also disabled for memcpy and memset since compilers
      (incorrectly) generate calls to them on some archs to implement
      struct initialization and assignment, and such calls may creep into
      early initialization.
      
      no explicit attempt to enable stack protector is made by configure at
      this time; any stack protector option supported by the compiler can be
      passed to configure in CFLAGS, and if the compiler uses stack
      protector by default, this default is respected.
      1ef849c6
    • R
      remove remnants of support for running in no-thread-pointer mode · 19a1fe67
      Rich Felker 提交于
      since 1.1.0, musl has nominally required a thread pointer to be setup.
      most of the remaining code that was checking for its availability was
      doing so for the sake of being usable by the dynamic linker. as of
      commit 71f099cb, this is no longer
      necessary; the thread pointer is now valid before any libc code
      (outside of dynamic linker bootstrap functions) runs.
      
      this commit essentially concludes "phase 3" of the "transition path
      for removing lazy init of thread pointer" project that began during
      the 1.1.0 release cycle.
      19a1fe67
    • R
      move thread pointer setup to beginning of dynamic linker stage 3 · 71f099cb
      Rich Felker 提交于
      this allows the dynamic linker itself to run with a valid thread
      pointer, which is a prerequisite for stack protector on archs where
      the ssp canary is stored in TLS. it will also allow us to remove some
      remaining runtime checks for whether the thread pointer is valid.
      
      as long as the application and its libraries do not require additional
      size or alignment, this early thread pointer will be kept and reused
      at runtime. otherwise, a new static TLS block is allocated after
      library loading has finished and the thread pointer is switched over.
      71f099cb
    • R
      stabilize dynamic linker's layout of static TLS · 0f66fcec
      Rich Felker 提交于
      previously, the layout of the static TLS block was perturbed by the
      size of the dtv; dtv size increasing from 0 to 1 perturbed both TLS
      arch types, and the TLS-above-TP type's layout was perturbed by the
      specific number of dtv slots (libraries with TLS). this behavior made
      it virtually impossible to setup a tentative thread pointer address
      before loading libraries and keep it unchanged as long as the
      libraries' TLS size/alignment requirements fit.
      
      the new code fixes the location of the dtv and pthread structure at
      opposite ends of the static TLS block so that they will not move
      unless size or alignment changes.
      0f66fcec
    • R
      allow i386 __set_thread_area to be called more than once · f630df09
      Rich Felker 提交于
      previously a new GDT slot was requested, even if one had already been
      obtained by a previous call. instead extract the old slot number from
      GS and reuse it if it was already set. the formula (GS-3)/8 for the
      slot number automatically yields -1 (request for new slot) if GS is
      zero (unset).
      f630df09
  4. 13 4月, 2015 1 次提交
    • R
      dynamic linker bootstrap overhaul · f3ddd173
      Rich Felker 提交于
      this overhaul further reduces the amount of arch-specific code needed
      by the dynamic linker and removes a number of assumptions, including:
      
      - that symbolic function references inside libc are bound at link time
        via the linker option -Bsymbolic-functions.
      
      - that libc functions used by the dynamic linker do not require
        access to data symbols.
      
      - that static/internal function calls and data accesses can be made
        without performing any relocations, or that arch-specific startup
        code handled any such relocations needed.
      
      removing these assumptions paves the way for allowing libc.so itself
      to be built with stack protector (among other things), and is achieved
      by a three-stage bootstrap process:
      
      1. relative relocations are processed with a flat function.
      2. symbolic relocations are processed with no external calls/data.
      3. main program and dependency libs are processed with a
         fully-functional libc/ldso.
      
      reduction in arch-specific code is achived through the following:
      
      - crt_arch.h, used for generating crt1.o, now provides the entry point
        for the dynamic linker too.
      
      - asm is no longer responsible for skipping the beginning of argv[]
        when ldso is invoked as a command.
      
      - the functionality previously provided by __reloc_self for heavily
        GOT-dependent RISC archs is now the arch-agnostic stage-1.
      
      - arch-specific relocation type codes are mapped directly as macros
        rather than via an inline translation function/switch statement.
      f3ddd173
  5. 11 4月, 2015 1 次提交
  6. 10 4月, 2015 4 次提交
    • R
      apply vmlock wait to __unmapself in pthread_exit · a2d30533
      Rich Felker 提交于
      a2d30533
    • R
      redesign and simplify vmlock system · f08ab9e6
      Rich Felker 提交于
      this global lock allows certain unlock-type primitives to exclude
      mmap/munmap operations which could change the identity of virtual
      addresses while references to them still exist.
      
      the original design mistakenly assumed mmap/munmap would conversely
      need to exclude the same operations which exclude mmap/munmap, so the
      vmlock was implemented as a sort of 'symmetric recursive rwlock'. this
      turned out to be unnecessary.
      
      commit 25d12fc0 already shortened the
      interval during which mmap/munmap held their side of the lock, but
      left the inappropriate lock design and some inefficiency.
      
      the new design uses a separate function, __vm_wait, which does not
      hold any lock itself and only waits for lock users which were already
      present when it was called to release the lock. this is sufficient
      because of the way operations that need to be excluded are sequenced:
      the "unlock-type" operations using the vmlock need only block
      mmap/munmap operations that are precipitated by (and thus sequenced
      after) the atomic-unlock they perform while holding the vmlock.
      
      this allows for a spectacular lack of synchronization in the __vm_wait
      function itself.
      f08ab9e6
    • R
      optimize out setting up robust list with kernel when not needed · 4e98cce1
      Rich Felker 提交于
      as a result of commit 12e1e324, kernel
      processing of the robust list is only needed for process-shared
      mutexes. previously the first attempt to lock any owner-tracked mutex
      resulted in robust list initialization and a set_robust_list syscall.
      this is no longer necessary, and since the kernel's record of the
      robust list must now be cleared at thread exit time for detached
      threads, optimizing it out is more worthwhile than before too.
      4e98cce1
    • R
      process robust list in pthread_exit to fix detached thread use-after-unmap · 12e1e324
      Rich Felker 提交于
      the robust list head lies in the thread structure, which is unmapped
      before exit for detached threads. this leaves the kernel unable to
      process the exiting thread's robust list, and with a dangling pointer
      which may happen to point to new unrelated data at the time the kernel
      processes it.
      
      userspace processing of the robust list was already needed for
      non-pshared robust mutexes in order to perform private futex wakes
      rather than the shared ones the kernel would do, but it was
      conditional on linking pthread_mutexattr_setrobust and did not bother
      processing the pshared mutexes in the list, which requires additional
      logic for the robust list pending slot in case pthread_exit is
      interrupted by asynchronous process termination.
      
      the new robust list processing code is linked unconditionally (inlined
      in pthread_exit), handles both private and shared mutexes, and also
      removes the kernel's reference to the robust list before unmapping and
      exit if the exiting thread is detached.
      12e1e324
  7. 08 4月, 2015 1 次提交
    • R
      fix possible clobbering of syscall return values on mips · 25748db3
      Rich Felker 提交于
      depending on the compiler's interpretation of __asm__ register names
      for register class objects, it may be possible for the return value in
      r2 to be clobbered by the function call to __stat_fix. I have not
      observed any such breakage in normal builds and suspect it only
      happens with -O0 or other unusual build options, but since there's an
      ambiguity as to the semantics of this feature, it's best to use an
      explicit temporary to avoid the issue.
      
      based on reporting and patch by Eugene.
      25748db3
  8. 04 4月, 2015 3 次提交
    • S
      05e0e301
    • R
      fix rpath string memory leak on failed dlopen · 07709625
      Rich Felker 提交于
      when dlopen fails, all partially-loaded libraries need to be unmapped
      and freed. any of these libraries using an rpath with $ORIGIN
      expansion may have an allocated string for the expanded rpath;
      previously, this string was not freed when freeing the library data
      structures.
      07709625
    • R
      halt dynamic linker library search on errors resolving $ORIGIN in rpath · 2963a9f7
      Rich Felker 提交于
      this change hardens the dynamic linker against the possibility of
      loading the wrong library due to inability to expand $ORIGIN in rpath.
      hard failures such as excessively long paths or absence of /proc (when
      resolving /proc/self/exe for the main executable's origin) do not stop
      the path search, but memory allocation failures and any other
      potentially transient failures do.
      
      to implement this change, the meaning of the return value of
      fixup_rpath function is changed. returning zero no longer indicates
      that the dso's rpath string pointer is non-null; instead, the caller
      needs to check. a return value of -1 indicates a failure that should
      stop further path search.
      2963a9f7
  9. 02 4月, 2015 6 次提交
    • R
      remove macro definition of longjmp from setjmp.h · 5e25d87b
      Rich Felker 提交于
      the C standard specifies that setjmp is a macro, but longjmp is a
      normal function. a macro version of it would be permitted (albeit
      useless) for C (not C++), but would have to be a function-like macro,
      not an object-like one.
      5e25d87b
    • R
      harden dynamic linker library path search · 5d1c8c99
      Rich Felker 提交于
      transient errors during the path search should not allow the search to
      continue and possibly open the wrong file. this patch eliminates most
      conditions where that could happen, but there is still a possibility
      that $ORIGIN-based rpath processing will have an allocation failure,
      causing the search to skip such a path. fixing this is left as a
      separate task.
      
      a small bug where overly-long path components caused an infinite loop
      rather than being skipped/ignored is also fixed.
      5d1c8c99
    • R
      move O_PATH definition back to arch bits · fd427c4e
      Rich Felker 提交于
      while it's the same for all presently supported archs, it differs at
      least on sparc, and conceptually it's no less arch-specific than the
      other O_* macros. O_SEARCH and O_EXEC are still defined in terms of
      O_PATH in the main fcntl.h.
      fd427c4e
    • R
      abfe1f65
    • R
      aarch64: fix definition of sem_nsems in semid_ds structure · dfc1a37c
      Rich Felker 提交于
      POSIX requires the sem_nsems member to have type unsigned short. we
      have to work around the incorrect kernel type using matching
      endian-specific padding.
      dfc1a37c
    • S
      aarch64: fix namespace pollution in bits/shm.h · b24d813d
      Szabolcs Nagy 提交于
      The shm_info struct is a gnu extension and some of its members do
      not have shm* prefix. This is worked around in sys/shm.h by macros,
      but aarch64 didn't use those.
      b24d813d
  10. 30 3月, 2015 1 次提交
  11. 28 3月, 2015 1 次提交
    • S
      regex: fix character class repetitions · c498efe1
      Szabolcs Nagy 提交于
      Internally regcomp needs to copy some iteration nodes before
      translating the AST into TNFA representation.
      
      Literal nodes were not copied correctly: the class type and list
      of negated class types were not copied so classes were ignored
      (in the non-negated case an ignored char class caused the literal
      to match everything).
      
      This affects iterations when the upper bound is finite, larger
      than one or the lower bound is larger than one. So eg. the EREs
      
       [[:digit:]]{2}
       [^[:space:]ab]{1,4}
      
      were treated as
      
       .{2}
       [^ab]{1,4}
      
      The fix is done with minimal source modification to copy the
      necessary fields, but the AST preparation and node handling
      code of tre will need to be cleaned up for clarity.
      c498efe1
  12. 24 3月, 2015 1 次提交
    • S
      do not treat \0 as a backref in BRE · 32dee9b9
      Szabolcs Nagy 提交于
      The valid BRE backref tokens are \1 .. \9, and 0 is not a special
      character either so \0 is undefined by the standard.
      
      Such undefined escaped characters are treated as literal characters
      currently, following existing practice, so \0 is the same as 0.
      32dee9b9
  13. 23 3月, 2015 2 次提交
    • R
      fix FLT_ROUNDS regression in C++ applications · 11d1e2e2
      Rich Felker 提交于
      commit 559de8f5 redefined FLT_ROUNDS
      to use an external function that can report the actual current
      rounding mode, rather than always reporting round-to-nearest. however,
      float.h did not include 'extern "C"' wrapping for C++, so C++ programs
      using FLT_ROUNDS ended up with an unresolved reference to a
      name-mangled C++ function __flt_rounds.
      11d1e2e2
    • R
      fix internal buffer overrun in inet_pton · fc13acc3
      Rich Felker 提交于
      one stop condition for parsing abbreviated ipv6 addressed was missed,
      allowing the internal ip[] buffer to overflow. this patch adds the
      missing stop condition and masks the array index so that, in case
      there are any remaining stop conditions missing, overflowing the
      buffer is not possible.
      fc13acc3
  14. 21 3月, 2015 2 次提交
    • R
      suppress backref processing in ERE regcomp · 7c8c86f6
      Rich Felker 提交于
      one of the features of ERE is that it's actually a regular language
      and does not admit expressions which cannot be matched in linear time.
      introduction of \n backref support into regcomp's ERE parsing was
      unintentional.
      7c8c86f6
    • R
      fix memory-corruption in regcomp with backslash followed by high byte · 39dfd584
      Rich Felker 提交于
      the regex parser handles the (undefined) case of an unexpected byte
      following a backslash as a literal. however, instead of correctly
      decoding a character, it was treating the byte value itself as a
      character. this was not only semantically unjustified, but turned out
      to be dangerous on archs where plain char is signed: bytes in the
      range 252-255 alias the internal codes -4 through -1 used for special
      types of literal nodes in the AST.
      39dfd584
  15. 20 3月, 2015 1 次提交
  16. 19 3月, 2015 1 次提交