1. 31 3月, 2011 2 次提交
    • R
      avoid all malloc/free in timer creation/destruction · 3990c5c6
      Rich Felker 提交于
      instead of allocating a userspace structure for signal-based timers,
      simply use the kernel timer id. we use the fact that thread pointers
      will always be zero in the low bit (actually more) to encode integer
      timerid values as pointers.
      
      also, this change ensures that the timer_destroy syscall has completed
      before the library timer_destroy function returns, in case it matters.
      3990c5c6
    • R
      optimize timer creation and possibly protect against some minor races · b8be64c4
      Rich Felker 提交于
      the major idea of this patch is not to depend on having the timer
      pointer delivered to the signal handler, and instead use the thread
      pointer to get the callback function address and argument. this way,
      the parent thread can make the timer_create syscall while the child
      thread is starting, and it should never have to block waiting for the
      barrier.
      b8be64c4
  2. 30 3月, 2011 9 次提交
    • R
      avoid crash on stupid but allowable usage of pthread_mutex_unlock · a1eb8cb5
      Rich Felker 提交于
      unlocking an unlocked mutex is not UB for robust or error-checking
      mutexes, so we must avoid calling __pthread_self (which might crash
      due to lack of thread-register initialization) until after checking
      that the mutex is locked.
      a1eb8cb5
    • R
      rename __simple_malloc.c to lite_malloc.c - yes this affects behavior! · 620a1346
      Rich Felker 提交于
      why does this affect behavior? well, the linker seems to traverse
      archive files starting from its current position when resolving
      symbols. since calloc.c comes alphabetically (and thus in sequence in
      the archive file) between __simple_malloc.c and malloc.c, attempts to
      resolve the "malloc" symbol for use by calloc.c were pulling in the
      full malloc.c implementation rather than the __simple_malloc.c
      implementation.
      
      as of now, lite_malloc.c and malloc.c are adjacent in the archive and
      in the correct order, so malloc.c should never be used to resolve
      "malloc" unless it's already needed to resolve another symbol ("free"
      or "realloc").
      620a1346
    • R
      streamline mutex unlock to remove a useless branch, use a_store to unlock · 02084109
      Rich Felker 提交于
      this roughly halves the cost of pthread_mutex_unlock, at least for
      non-robust, normal-type mutexes.
      
      the a_store change is in preparation for future support of archs which
      require a memory barrier or special atomic store operation, and also
      should prevent the possibility of the compiler misordering writes.
      02084109
    • R
      cheap special-case optimization for normal mutexes · 124b4ebc
      Rich Felker 提交于
      cycle-level benchmark on atom cpu showed typical pthread_mutex_lock
      call dropping from ~120 cycles to ~90 cycles with this change. benefit
      may vary with compiler options and version, but this optimization is
      very cheap to make and should always help some.
      124b4ebc
    • R
      reorder timer initialization so that timer_create does not depend on free · 68063001
      Rich Felker 提交于
      this allows small programs which only create times, but never delete
      them, to use simple_malloc instead of the full malloc.
      68063001
    • R
      missing prototype for wcscoll (stub) · 1c1aa32e
      Rich Felker 提交于
      1c1aa32e
    • R
      8524d653
    • R
      implement POSIX timers · 80c4dcd2
      Rich Felker 提交于
      this implementation is superior to the glibc/nptl implementation, in
      that it gives true realtime behavior. there is no risk of timer
      expiration events being lost due to failed thread creation or failed
      malloc, because the thread is created as time creation time, and
      reused until the timer is deleted.
      80c4dcd2
    • R
      major improvements to cancellation handling · bf619d82
      Rich Felker 提交于
      - there is no longer any risk of spoofing cancellation requests, since
        the cancel flag is set in pthread_cancel rather than in the signal
        handler.
      
      - cancellation signal is no longer unblocked when running the
        cancellation handlers. instead, pthread_create will cause any new
        threads created from a cancellation handler to unblock their own
        cancellation signal.
      
      - various tweaks in preparation for POSIX timer support.
      bf619d82
  3. 29 3月, 2011 12 次提交
  4. 28 3月, 2011 1 次提交
    • R
      major stdio overhaul, using readv/writev, plus other changes · e3cd6c5c
      Rich Felker 提交于
      the biggest change in this commit is that stdio now uses readv to fill
      the caller's buffer and the FILE buffer with a single syscall, and
      likewise writev to flush the FILE buffer and write out the caller's
      buffer in a single syscall.
      
      making this change required fundamental architectural changes to
      stdio, so i also made a number of other improvements in the process:
      
      - the implementation no longer assumes that further io will fail
        following errors, and no longer blocks io when the error flag is set
        (though the latter could easily be changed back if desired)
      
      - unbuffered mode is no longer implemented as a one-byte buffer. as a
        consequence, scanf unreading has to use ungetc, to the unget buffer
        has been enlarged to hold at least 2 wide characters.
      
      - the FILE structure has been rearranged to maintain the locations of
        the fields that might be used in glibc getc/putc type macros, while
        shrinking the structure to save some space.
      
      - error cases for fflush, fseek, etc. should be more correct.
      
      - library-internal macros are used for getc_unlocked and putc_unlocked
        now, eliminating some ugly code duplication. __uflow and __overflow
        are no longer used anywhere but these macros. switch to read or
        write mode is also separated so the code can be better shared, e.g.
        with ungetc.
      
      - lots of other small things.
      e3cd6c5c
  5. 26 3月, 2011 3 次提交
  6. 25 3月, 2011 6 次提交
    • R
      simplify and optimize FILE lock handling · a3745243
      Rich Felker 提交于
      a3745243
    • R
      d8dc2faf
    • R
      optimize contended case for pthread_spin_trylock · b8b85a42
      Rich Felker 提交于
      b8b85a42
    • R
      optimize spinlock spin · c322fe4e
      Rich Felker 提交于
      c322fe4e
    • R
      fix non-atomicity of puts · 8ae2fa65
      Rich Felker 提交于
      8ae2fa65
    • R
      overhaul cancellation to fix resource leaks and dangerous behavior with signals · b470030f
      Rich Felker 提交于
      this commit addresses two issues:
      
      1. a race condition, whereby a cancellation request occurring after a
      syscall returned from kernelspace but before the subsequent
      CANCELPT_END would cause cancellable resource-allocating syscalls
      (like open) to leak resources.
      
      2. signal handlers invoked while the thread was blocked at a
      cancellation point behaved as if asynchronous cancellation mode wer in
      effect, resulting in potentially dangerous state corruption if a
      cancellation request occurs.
      
      the glibc/nptl implementation of threads shares both of these issues.
      
      with this commit, both are fixed. however, cancellation points
      encountered in a signal handler will not be acted upon if the signal
      was received while the thread was already at a cancellation point.
      they will of course be acted upon after the signal handler returns, so
      in real-world usage where signal handlers quickly return, it should
      not be a problem. it's possible to solve this problem too by having
      sigaction() wrap all signal handlers with a function that uses a
      pthread_cleanup handler to catch cancellation, patch up the saved
      context, and return into the cancellable function that will catch and
      act upon the cancellation. however that would be a lot of complexity
      for minimal if any benefit...
      b470030f
  7. 24 3月, 2011 1 次提交
  8. 20 3月, 2011 6 次提交