1. 18 7月, 2013 2 次提交
    • R
      make spacing in x86_64 alltypes.h.sh more uniform with other archs · 2f5fe458
      Rich Felker 提交于
      patch by Luka Perkov, who noted that all other archs have a newline.
      2f5fe458
    • R
      make posix_spawn (and functions that use it) use CLONE_VFORK flag · b06dc666
      Rich Felker 提交于
      this is both a minor scheduling optimization and a workaround for a
      difficult-to-fix bug in qemu app-level emulation.
      
      from the scheduling standpoint, it makes no sense to schedule the
      parent thread again until the child has exec'd or exited, since the
      parent will immediately block again waiting for it.
      
      on the qemu side, as regular application code running on an underlying
      libc, qemu cannot make arbitrary clone syscalls itself without
      confusing the underlying implementation. instead, it breaks them down
      into either fork-like or pthread_create-like cases. it was treating
      the code in posix_spawn as pthread_create-like, due to CLONE_VM, which
      caused horribly wrong behavior: CLONE_FILES broke the synchronization
      mechanism, CLONE_SIGHAND broke the parent's signals, and CLONE_THREAD
      caused the child's exec to end the parent -- if it hadn't already
      crashed. however, qemu special-cases CLONE_VFORK and emulates that
      with fork, even when CLONE_VM is also specified. this also gives
      incorrect semantics for code that really needs the memory sharing, but
      posix_spawn does not make use of the vm sharing except to avoid
      momentary double commit charge.
      
      programs using posix_spawn (including via popen) should now work
      correctly under qemu app-level emulation.
      b06dc666
  2. 17 7月, 2013 4 次提交
  3. 14 7月, 2013 1 次提交
    • R
      fix omission of dtv setup in static linked programs on TLS variant I archs · f1292e3d
      Rich Felker 提交于
      apparently this was never noticed before because the linker normally
      optimizes dynamic TLS models to non-dynamic ones when static linking,
      thus eliminating the calls to __tls_get_addr which crash when the dtv
      is missing. however, some libsupc++ code on ARM was calling
      __tls_get_addr when static linked and crashing. the reason is unclear
      to me, but with this issue fixed it should work now anyway.
      f1292e3d
  4. 11 7月, 2013 3 次提交
  5. 09 7月, 2013 6 次提交
  6. 06 7月, 2013 1 次提交
  7. 05 7月, 2013 2 次提交
    • R
      move core memalign code from aligned_alloc to __memalign · 6d861ac8
      Rich Felker 提交于
      there are two motivations for this change. one is to avoid
      gratuitously depending on a C11 symbol for implementing a POSIX
      function. the other pertains to the documented semantics. C11 does not
      define any behavior for aligned_alloc when the length argument is not
      a multiple of the alignment argument. posix_memalign on the other hand
      places no requirements on the length argument. using __memalign as the
      implementation of both, rather than trying to implement one in terms
      of the other when their documented contracts differ, eliminates this
      confusion.
      6d861ac8
    • R
      move alignment check from aligned_alloc to posix_memalign · 65141618
      Rich Felker 提交于
      C11 has no requirement that the alignment be a multiple of
      sizeof(void*), and in fact seems to require any "valid alignment
      supported by the implementation" to work. since the alignment of char
      is 1 and thus a valid alignment, an alignment argument of 1 should be
      accepted.
      65141618
  8. 04 7月, 2013 3 次提交
  9. 02 7月, 2013 2 次提交
    • R
      add stubs for additional legacy ether.h functions · fbcd8204
      Rich Felker 提交于
      these would not be expensive to actually implement, but reading
      /etc/ethers does not sound like a particularly useful feature, so for
      now I'm leaving them as stubs.
      fbcd8204
    • R
      fix Makefile so "make install" works before include/bits symlink exists · d66ab4f1
      Rich Felker 提交于
      previously, determination of the list of header files for installation
      depended on the include/bits symlink (to the arch-specific files)
      already having been created. in other words, running "make install"
      immediately after configure without first running "make" caused the
      bits headers not to be installed.
      
      the solution I have applied is to pull the list of headers directly
      from arch/$(ARCH)/bits rather than include/bits, and likewise to
      install directly from arch/$(ARCH)/bits rather than via the symlink.
      
      at this point, the only purpose served by keeping the symlink around
      is that it enables use of the in-tree headers and libs directly via -I
      and -L, which can be useful when testing against a new version of the
      library before installing it. on the other hand, removing the bits
      symlink would be beneficial if we ever want to support building
      multiple archs in the same source tree.
      d66ab4f1
  10. 30 6月, 2013 5 次提交
  11. 29 6月, 2013 7 次提交
    • R
      fix missing synchronization in calls from dynamic linker to global ctors · 509b50ed
      Rich Felker 提交于
      this change is needed to correctly handle the case where a constructor
      creates a new thread which calls dlopen. previously, the lock was not
      held in this case. the reason for the complex logic to avoid locking
      whenever possible is that, since the mutex is recursive, it will need
      to inspect the thread pointer to get the current thread's tid, and
      this requires initializing the thread pointer. we do not want
      non-multi-threaded programs to attempt to access the thread pointer
      unnecessarily; doing so could make them crash on ancient kernels that
      don't support threads but which may otherwise be capable of running
      the program.
      509b50ed
    • R
      prevent shmget from allocating objects that overflow ptrdiff_t · 17aef0b4
      Rich Felker 提交于
      rather than returning an error, we have to increase the size argument
      so high that the kernel will have no choice but to fail. this is
      because POSIX only permits the EINVAL error for size errors when a new
      shared memory segment would be created; if it already exists, the size
      argument must be ignored. unfortunately Linux is non-conforming in
      this regard, but I want to keep the code correct in userspace anyway
      so that if/when Linux is fixed, the behavior applications see will be
      conforming.
      17aef0b4
    • R
      work around wrong kernel type for sem_nsems member of struct semid_ds · 062f40ef
      Rich Felker 提交于
      rejecting invalid values for n is fine even in the case where a new
      sem will not be created, since the kernel does its range checks on n
      even in this case as well.
      
      by default, the kernel will bound the limit well below USHRT_MAX
      anyway, but it's presumably possible that an administrator could
      override this limit and break things.
      062f40ef
    • R
      add missing type shmatt_t in sys/shm.h · 553d566c
      Rich Felker 提交于
      this type is not really intended to be used; it's just there to allow
      implementations to choose the type for the shm_nattch member of
      struct shmid_sh, presumably since historical implementations disagreed
      on the type. in any case, it needs to be there, so now it is.
      553d566c
    • R
      implement week-based-year year numbers in strftime · aea79190
      Rich Felker 提交于
      in the process, I refactored the week-number code so it can be used by
      the week-based-year formats to determine year adjustments at the
      boundary values. this also improves indention/code readability.
      aea79190
    • R
      fix breakage in last commit to strftime due to missing INT_MAX · 062446a8
      Rich Felker 提交于
      that's what I get for changing a hard-coded threshold to a proper
      non-magic-number without testing.
      062446a8
    • R
      implement week numbers and half of the week-based-year logic for strftime · c5faf1bf
      Rich Felker 提交于
      output for plain week numbers (%U and %W) has been sanity-checked, and
      output for the week-based-year week numbers (%V) has been checked
      extensively against known-good data for the full non-negative range of
      32-bit time_t.
      
      year numbers for week-based years (%g and %G) are not yet implemented.
      c5faf1bf
  12. 28 6月, 2013 2 次提交
    • R
      minor compatibility fixes in utmp.h and fixing mismatch with paths.h · 1e2281b8
      Rich Felker 提交于
      the pathnames prefixed with /dev/null/ are guaranteed never to be
      valid. the previous use of /dev/null alone was mildly dangerous in
      that bad software might attempt to unlink the name when it found a
      non-regular file there and create a new file.
      1e2281b8
    • R
      disallow creation of objects larger than PTRDIFF_MAX via mmap · 3cd6f522
      Rich Felker 提交于
      internally, other parts of the library assume sizes don't overflow
      ssize_t and/or ptrdiff_t, and the way this assumption is made valid is
      by preventing creating of such large objects. malloc already does so,
      but the check was missing from mmap.
      
      this is also a quality of implementation issue: even if the
      implementation internally could handle such objects, applications
      could inadvertently invoke undefined behavior by subtracting pointers
      within an object. it is very difficult to guard against this in
      applications, so a good implementation should simply ensure that it
      does not happen.
      3cd6f522
  13. 27 6月, 2013 2 次提交