1. 24 3月, 2013 2 次提交
    • R
      add deprecated SIGIOT alias for SIGABRT · 2d0f495e
      Rich Felker 提交于
      reportedly some programs (e.g. showkeys in the kbd package) use it.
      2d0f495e
    • R
      fix multiple bugs in syslog interfaces · 427c0ca7
      Rich Felker 提交于
      1. as reported by William Haddon, the value returned by snprintf was
      wrongly used as a length passed to sendto, despite it possibly
      exceeding the buffer length. this could lead to invalid reads and
      leaking additional data to syslog.
      
      2. openlog was storing a pointer to the ident string passed by the
      caller, rather than copying it. this bug is shared with (and even
      documented in) other implementations like glibc, but such behavior
      does not seem to meet the requirements of the standard.
      
      3. extremely long ident provided to openlog, or corrupt ident due to
      the above issue, could possibly have resulted in buffer overflows.
      despite having the potential for smashing the stack, i believe the
      impact is low since ident points to a short string literal in typical
      application usage (and per the above bug, other usages will break
      horribly on other implementations).
      
      4. when used with LOG_NDELAY, openlog was not connecting the
      newly-opened socket; sendto was being used instead. this defeated the
      main purpose of LOG_NDELAY: preparing for chroot.
      
      5. the default facility was not being used at all, so all messages
      without an explicit facility passed to syslog were getting logged at
      the kernel facility.
      
      6. setlogmask was not thread-safe; no synchronization was performed
      updating the mask. the fix uses atomics rather than locking to avoid
      introducing a lock in the fast path for messages whose priority is not
      in the mask.
      
      7. in some code paths, the syslog lock was being unlocked twice; this
      could result in releasing a lock that was actually held by a different
      thread.
      
      some additional enhancements to syslog such as a default identifier
      based on argv[0] or similar may still be desired; at this time, only
      the above-listed bugs have been fixed.
      427c0ca7
  2. 10 3月, 2013 1 次提交
    • R
      remove soname from libc.so/ld-musl · dfdc337b
      Rich Felker 提交于
      it serves no purpose (binaries linked against musl as -lc/libc.so
      automatically get the right DT_NEEDED value of libc.so) and causes
      ldconfig to misbehave (making a symlink to ld-musl named libc.so in
      /lib). ldconfig is not used on pure musl systems, but if ld-musl is
      installed on a system where it's not the primary libc, this will
      pollute the system /lib with a symlink to musl named libc.so, which
      should NOT exist and could cause problems linking native apps. also,
      the existence of the soname caused spurious warnings from ldconfig
      when /lib and /usr/lib were the same physical directory.
      dfdc337b
  3. 07 3月, 2013 1 次提交
    • R
      fix epoll structure alignment on non-x86_64 archs · 08514d06
      Rich Felker 提交于
      this fix is far from ideal and breaks the rule of not using
      arch-specific #ifdefs, but for now we just need a solution to the
      existing breakage.
      
      the underlying problem is that the kernel folks made a very stupid
      decision to make misalignment of this struct part of the kernel
      API/ABI for x86_64, in order to avoid writing a few extra lines of
      code to handle both 32- and 64-bit userspace on 64-bit kernels. I had
      just added the packed attribute unconditionally thinking it was
      harmless on 32-bit archs, but non-x86 32-bit archs have 8-byte
      alignment on 64-bit types.
      08514d06
  4. 06 3月, 2013 1 次提交
  5. 05 3月, 2013 2 次提交
    • R
      fix types for wctype_t and wctrans_t · da1442c9
      Rich Felker 提交于
      wctype_t was incorrectly "int" rather than "long" on x86_64. not only
      is this an ABI incompatibility; it's also a major design flaw if we
      ever wanted wctype_t to be implemented as a pointer, which would be
      necessary if locales support custom character classes, since int is
      too small to store a converted pointer. this commit fixes wctype_t to
      be unsigned long on all archs, matching the LSB ABI; this change does
      not matter for C code, but for C++ it affects mangling.
      
      the same issue applied to wctrans_t. glibc/LSB defines this type as
      const __int32_t *, but since no such definition is visible, I've just
      expanded the definition, int, everywhere.
      
      it would be nice if these types (which don't vary by arch) could be in
      wctype.h, but the OB XSI requirement in POSIX that wchar.h expose some
      types and functions from wctype.h precludes doing so. glibc works
      around this with some hideous hacks, but trying to duplicate that
      would go against the intent of musl's headers.
      da1442c9
    • R
      fix some obscure header type size/alignment issues · 8c741783
      Rich Felker 提交于
      8c741783
  6. 26 2月, 2013 5 次提交
  7. 22 2月, 2013 4 次提交
  8. 21 2月, 2013 4 次提交
  9. 18 2月, 2013 3 次提交
    • R
      f78cdbe8
    • R
      consistently use the internal name __environ for environ · 23ccb80f
      Rich Felker 提交于
      patch by Jens Gustedt.
      previously, the intended policy was to use __environ in code that must
      conform to the ISO C namespace requirements, and environ elsewhere.
      this policy was not followed in practice anyway, making things
      confusing. on top of that, Jens reported that certain combinations of
      link-time optimization options were breaking with the inconsistent
      references; this seems to be a compiler or linker bug, but having it
      go away is a nice side effect of the changes made here.
      23ccb80f
    • R
      add fgetgrent function · cac87295
      Rich Felker 提交于
      based on patch by Isaac Dunham, moved to its own file to avoid
      increasing bss on static linked programs not using this nonstandard
      function but using the standard getgrent function, and vice versa.
      cac87295
  10. 07 2月, 2013 3 次提交
    • R
      fix typo in newly-added error message for EOWNERDEAD · b9e08308
      Rich Felker 提交于
      b9e08308
    • R
      improve error strings · d75348dd
      Rich Felker 提交于
      this definitely has the potential to be a bikeshed topic, so some
      justification is in order. most of the changes made fit into one of
      the following categories:
      1. alignment with text in posix, xsh 2.3
      2. eliminating overly-specific text for shared error codes
      3. making the message match more closely with the macro name
      4. removing extraneous words
      
      in particular, the EAGAIN/EWOULDBLOCK text is updated to match the
      description of EAGAIN (which covers both uses) rather than saying the
      operation would block, and ENOTSUP/EOPNOTSUPP is updated not to
      mention sockets.
      
      the distinction between ENFILE/EMFILE has also been clarified; ENFILE
      is aligned with the posix text, and EMFILE, which lacks concise posix
      text matching any historic message, is updated to emphasize that the
      exhausted resource is not open files/open file descriptions, but
      rather the integer 'address space' of file descriptors.
      
      some messages may be further tweaked based on feedback.
      d75348dd
    • R
      arm: add __aeabi_atexit() · 52690048
      rofl0r 提交于
      arm eabi requires this symbol for static C++ dtors.
      usually it is provided by libstdc++, but when a C++ program
      doesn't use the std lib (free-standing), the libc has to provide
      it.
      this was encountered while building transmission, which
      depends on such a C++ library (libutp).
      
      this function is nearly identical to __cxa_atexit, but it has the
      order of argumens swapped for "performance reasons".
      see page 25 of
      
       http://infocenter.arm.com/help/topic/com.arm.doc.ihi0043d/IHI0043D_rtabi.pdf
      
      there are other aeabi specific C++ support functions missing, but
      it is not clear yet that GCC makes use of them so we omit them for
      the moment.
      52690048
  11. 06 2月, 2013 1 次提交
  12. 04 2月, 2013 4 次提交
    • R
      base system() on posix_spawn · a8799356
      Rich Felker 提交于
      this avoids duplicating the fragile logic for executing an external
      program without fork.
      a8799356
    • R
      fix unsigned comparison bug in posix_spawn · 4862864f
      Rich Felker 提交于
      read should never return anything but 0 or sizeof ec here, but if it
      does, we want to treat any other return as "success". then the caller
      will get back the pid and is responsible for waiting on it when it
      immediately exits.
      4862864f
    • R
      overhaul posix_spawn to use CLONE_VM instead of vfork · fb6b159d
      Rich Felker 提交于
      the proposed change was described in detail in detail previously on
      the mailing list. in short, vfork is unsafe because:
      
      1. the compiler could make optimizations that cause the child to
      clobber the parent's local vars.
      
      2. strace is buggy and allows the vforking parent to run before the
      child execs when run under strace.
      
      the new design uses a close-on-exec pipe instead of vfork semantics to
      synchronize the parent and child so that the parent does not return
      before the child has finished using its arguments (and now, also its
      stack). this also allows reporting exec failures to the caller instead
      of giving the caller a child that mysteriously exits with status 127
      on exec error.
      
      basic testing has been performed on both the success and failure code
      paths. further testing should be done.
      fb6b159d
    • R
      streamline old-kernel fallback path of pipe2 to use syscalls directly · 89d3df6e
      Rich Felker 提交于
      also, don't waste code/time on F_GETFL since pipes always have blank
      flags initially (at least on old kernels, which are all this fallback
      code matters for).
      89d3df6e
  13. 03 2月, 2013 1 次提交
  14. 02 2月, 2013 8 次提交
    • R
      dynamically allocate storage for gethostby* buffers · a47ad3eb
      Rich Felker 提交于
      this change shaves ~1k off libc.so bss size, and also avoids hard
      errors in the case where the static buffer was not large enough to
      hold the result.
      
      this whole framework is really ugly and might should be replaced or at
      least heavily overhauled when some changes/factorizations are made to
      getaddrinfo internals in the future.
      a47ad3eb
    • R
      c0193550
    • R
      b0302863
    • R
      fix error returns in gethostby*_r functions · 70b584bc
      Rich Felker 提交于
      they're supposed to return an error code rather than using errno.
      70b584bc
    • R
      fix uninitialized map_len being used in munmap failure paths in load_library · 74025c80
      Rich Felker 提交于
      this bug seems to have been introduced when the map_library signatures
      was changed to return the mapping in a temp dso structure instead of
      into separate variables.
      74025c80
    • R
      fix stale locks left behind when pthread_create fails · 72768ea9
      Rich Felker 提交于
      this bug seems to have been around a long time.
      72768ea9
    • R
      if pthread_create fails, it must not attempt mmap if there is no mapping · 077549e0
      Rich Felker 提交于
      this bug was introduced when support for application-provided stacks
      was originally added.
      077549e0
    • R
      pthread stack treatment overhaul for application-provided stacks, etc. · d5142642
      Rich Felker 提交于
      the main goal of these changes is to address the case where an
      application provides a stack of size N, but TLS has size M that's a
      significant portion of the size N (or even larger than N), thus giving
      the application less stack space than it expected or no stack at all!
      
      the new strategy pthread_create now uses is to only put TLS on the
      application-provided stack if TLS is smaller than 1/8 of the stack
      size or 2k, whichever is smaller. this ensures that the application
      always has "close enough" to what it requested, and the threshold is
      chosen heuristically to make sure "sane" amounts of TLS still end up
      in the application-provided stack.
      
      if TLS does not fit the above criteria, pthread_create uses mmap to
      obtain space for TLS, but still uses the application-provided stack
      for actual call frame stack. this is to avoid wasting memory, and for
      the sake of supporting ugly hacks like garbage collection based on
      assumptions that the implementation will use the provided stack range.
      
      in order for the above heuristics to ever succeed, the amount of TLS
      space wasted on POSIX TSD (pthread_key_create based) needed to be
      reduced. otherwise, these changes would preclude any use of
      pthread_create without mmap, which would have serious memory usage and
      performance costs for applications trying to create huge numbers of
      threads using pre-allocated stack space. the new value of
      PTHREAD_KEYS_MAX is the minimum allowed by POSIX, 128. this should
      still be plenty more than real-world applications need, especially now
      that C11/gcc-style TLS is now supported in musl, and most apps and
      libraries choose to use that instead of POSIX TSD when available.
      
      at the same time, PTHREAD_STACK_MIN has been decreased. it was
      originally set to PAGE_SIZE back when there was no support for TLS or
      application-provided stacks, and requests smaller than a whole page
      did not make sense. now, there are two good reasons to support
      requests smaller than a page: (1) applications could provide
      pre-allocated stacks smaller than a page, and (2) with smaller stack
      sizes, stack+TLS+TSD can all fit in one page, making it possible for
      applications which need huge numbers of threads with minimal stack
      needs to allocate exactly one page per thread. the new value of
      PTHREAD_STACK_MIN, 2k, is aligned with the minimum size for
      sigaltstack.
      d5142642