1. 29 5月, 2015 1 次提交
    • R
      fix failure of ungetc and ungetwc to work on files in eof status · 2b4fcfda
      Rich Felker 提交于
      these functions were written to handle clearing eof status, but failed
      to account for the __toread function's handling of eof. with this
      patch applied, __toread still returns EOF when the file is in eof
      status, so that read operations will fail, but it also sets up valid
      buffer pointers for read mode, which are set to the end of the buffer
      rather than the beginning in order to make the whole buffer available
      to ungetc/ungetwc.
      
      minor changes to __uflow were needed since it's now possible to have
      non-zero buffer pointers while in eof status. as made, these changes
      remove a 'fast path' bypassing the function call to __toread, which
      could be reintroduced with slightly different logic, but since
      ordinary files have a syscall in f->read, optimizing the code path
      does not seem worthwhile.
      
      the __stdio_read function is also updated not to zero the read buffer
      pointers on eof/error. while not necessary for correctness, this
      change avoids the overhead of calling __toread in ungetc after
      reaching eof, and it also reduces code size and increases consistency
      with the fmemopen read operation which does not zero the pointers.
      2b4fcfda
  2. 28 5月, 2015 1 次提交
    • R
      implement fail-safe static locales for newlocale · aeeac9ca
      Rich Felker 提交于
      this frees applications which need to make temporary use of the C
      locale (via uselocale) from the possibility that newlocale might fail.
      
      the C.UTF-8 locale is also provided as a static locale. presently they
      behave the same, but this may change in the future.
      aeeac9ca
  3. 27 5月, 2015 3 次提交
    • R
      rename internal locale file handling locale maps · 11858d31
      Rich Felker 提交于
      since the __setlocalecat function was removed, the filename
      __setlocalecat.c no longer made sense.
      11858d31
    • R
      overhaul locale internals to treat categories roughly uniformly · 61a3364d
      Rich Felker 提交于
      previously, LC_MESSAGES was treated specially as the only category
      which could be set to a locale name without a definition file, in
      order to facilitate gettext message translations when no libc locale
      was available. LC_NUMERIC was completely un-settable, and LC_CTYPE
      stored a flag intended to be used for a possible future byte-based C
      locale, instead of storing a __locale_map pointer like the other
      categories use.
      
      this patch changes all categories to be represented by pointers to
      __locale_map structures, and allows locale names without definition
      files to be treated as valid locales with trivial definition when used
      in any category. outwardly visible functional changes should be minor,
      limited mainly to the strings read back from setlocale and the way
      gettext handles translations in categories other than LC_MESSAGES.
      
      various internal refactoring has also been performed, and improvements
      in const correctness have been made.
      61a3364d
    • R
      replace atomics with locks in locale-setting code · 63c188ec
      Rich Felker 提交于
      this is part of a general program of removing direct use of atomics
      where they are not necessary to meet correctness or performance needs,
      but in this case it's also an optimization. only the global locale
      needs synchronization; allocated locales referenced with locale_t
      handles are immutable during their lifetimes, and using atomics to
      initialize them increases their cost of setup.
      63c188ec
  4. 26 5月, 2015 3 次提交
    • R
      reprocess all libc/ldso symbolic relocations in dynamic linking stage 3 · 9bbddf73
      Rich Felker 提交于
      commit f3ddd173 introduced early
      relocations and subsequent reprocessing as part of the dynamic linker
      bootstrap overhaul, to allow use of arbitrary libc functions before
      the main application and libraries are loaded, but only reprocessed
      GOT/PLT relocation types.
      
      commit c093e2e8 added reprocessing of
      non-GOT/PLT relocations to fix an actual regression that was observed
      on powerpc, but only for RELA format tables with out-of-line addends.
      REL table (inline addends at the relocation address) reprocessing is
      trickier because the first relocation pass clobbers the addends.
      
      this patch extends symbolic relocation reprocessing for libc/ldso to
      support all relocation types, whether REL or RELA format tables are
      used. it is believed not to alter behavior on any existing archs for
      the current dynamic linker and libc code. the motivations for this
      change are consistency and future-proofing. it ensures that behavior
      does not differ depending on whether REL or RELA tables are used,
      which could lead to undetected arch-specific bugs. it also ensures
      that, if in the future code depending on additional relocation types
      is added to libc.so, either at the source level or as part of the
      compiler runtime that gets pulled in (for example, soft-float with TLS
      for fenv), the new code will work properly.
      
      the implementation concept is simple: stage 2 of the dynamic linker
      counts the number of symbolic relocations in the libc/ldso REL table
      and allocates a VLA to save their addends into; stage 3 then uses the
      saved addends in place of the inline ones which were clobbered. for
      stack safety, a hard limit (currently 4k) is imposed on the number of
      such addends; this should be a couple orders of magnitude larger than
      the actual need. this number is not a runtime variable that could
      break fail-safety; it is constant for a given libc.so build.
      9bbddf73
    • R
      move call to dynamic linker stage-3 into stage-2 function · 768b82c6
      Rich Felker 提交于
      this move eliminates a duplicate "by-hand" symbol lookup loop from the
      stage-1 code and replaces it with a call to find_sym, which can be
      used once we're in stage 2. it reduces the size of the stage 1 code,
      which is helpful because stage 1 will become the crt start file for
      static-PIE executables, and it will allow stage 3 to access stage 2's
      automatic storage, which will be important in an upcoming commit.
      768b82c6
    • R
      mark mips cancellable syscall code as code · 7b75c487
      Rich Felker 提交于
      otherwise disassemblers treat it as data.
      7b75c487
  5. 25 5月, 2015 2 次提交
    • R
      simplify/shrink relocation processing in dynamic linker stage 1 · 0e0e4942
      Rich Felker 提交于
      the outer-loop approach made sense when we were also processing
      DT_JMPREL, which might be in REL or RELA form, to avoid major code
      duplication. commit 09db855b removed
      processing of DT_JMPREL, and in the remaining two tables, the format
      (REL or RELA) is known by the name of the table. simply writing two
      versions of the loop results in smaller and simpler code.
      0e0e4942
    • R
      remove processing of DT_JMPREL from dynamic linker stage 1 bootstrap · 09db855b
      Rich Felker 提交于
      the DT_JMPREL relocation table necessarily consists entirely of
      JMP_SLOT (REL_PLT in internal nomenclature) relocations, which are
      symbolic; they cannot be resolved in stage 1, so there is no point in
      processing them.
      09db855b
  6. 22 5月, 2015 2 次提交
  7. 19 5月, 2015 2 次提交
    • R
      reprocess libc/ldso RELA relocations in stage 3 of dynamic linking · c093e2e8
      Rich Felker 提交于
      this fixes a regression on powerpc that was introduced in commit
      f3ddd173. global data accesses on
      powerpc seem to be using a translation-unit-local GOT filled via
      R_PPC_ADDR32 relocations rather than R_PPC_GLOB_DAT. being a non-GOT
      relocation type, these were not reprocessed after adding the main
      application and its libraries to the chain, causing libc code not to
      see copy relocations in the main program, and therefore to use the
      pre-copy-relocation addresses for global data objects (like environ).
      
      the motivation for the dynamic linker only reprocessing GOT/PLT
      relocation types in stage 3 is that these types always have a zero
      addend, making them safe to process again even if the storage for the
      addend has been clobbered. other relocation types which can be used
      for address constants in initialized data objects may have non-zero
      addends which will be clobbered during the first pass of relocation
      processing if they're stored inline (REL form) rather than out-of-line
      (RELA form).
      
      powerpc generally uses only RELA, so this patch is sufficient to fix
      the regression in practice, but is not fully general, and would not
      suffice if an alternate toolchain generated REL for powerpc.
      c093e2e8
    • R
      fix null pointer dereference in dcngettext under specific conditions · 43e9f652
      Rich Felker 提交于
      if setlocale has not been called, the current locale's messages_name
      may be a null pointer. the code path where it's assumed to be non-null
      was only reachable if bindtextdomain had already been called, which is
      normally not done in programs which do not call setlocale, so the
      omitted check went unnoticed.
      
      patch from Void Linux, with description rewritten.
      43e9f652
  8. 16 5月, 2015 2 次提交
    • R
      eliminate costly tricks to avoid TLS access for current locale state · 68630b55
      Rich Felker 提交于
      the code being removed used atomics to track whether any threads might
      be using a locale other than the current global locale, and whether
      any threads might have abstract 8-bit (non-UTF-8) LC_CTYPE active, a
      feature which was never committed (still pending). the motivations
      were to support early execution prior to setup of the thread pointer,
      to partially support systems (ancient kernels) where thread pointer
      setup is not possible, and to avoid high performance cost on archs
      where accessing the thread pointer may be very slow.
      
      since commit 19a1fe67, the thread
      pointer is always available, so these hacks are no longer needed.
      removing them greatly simplifies the affected code.
      68630b55
    • R
      in i386 __set_thread_area, don't assume %gs register is initially zero · 707d7c30
      Rich Felker 提交于
      commit f630df09 added logic to handle
      the case where __set_thread_area is called more than once by reusing
      the GDT slot already in the %gs register, and only setting up a new
      GDT slot when %gs is zero. this created a hidden assumption that %gs
      is zero when a new process image starts, which is true in practice on
      Linux, but does not seem to be documented ABI, and fails to hold under
      qemu app-level emulation.
      
      while it would in theory be possible to zero %gs in the entry point
      code, this code is shared between static and dynamic binaries, and
      dynamic binaries must not clobber the value of %gs already setup by
      the dynamic linker.
      
      the alternative solution implemented in this commit simply uses global
      data to store the GDT index that's selected. __set_thread_area should
      only be called in the initial thread anyway (subsequent threads get
      their thread pointer setup by __clone), but even if it were called by
      another thread, it would simply read and write back the same GDT index
      that was already assigned to the initial thread, and thus (in the x86
      memory model) there is no data race.
      707d7c30
  9. 07 5月, 2015 2 次提交
    • R
      fix futimes legacy function with null tv pointer · ece0c48a
      Rich Felker 提交于
      a null pointer is valid here and indicates that the current time
      should be used. based on patch by Felix Janda, simplified.
      ece0c48a
    • R
      fix stack protector crashes on x32 & powerpc due to misplaced TLS canary · 484194db
      Rich Felker 提交于
      i386, x86_64, x32, and powerpc all use TLS for stack protector canary
      values in the default stack protector ABI, but the location only
      matched the ABI on i386 and x86_64. on x32, the expected location for
      the canary contained the tid, thus producing spurious mismatches
      (resulting in process termination) upon fork. on powerpc, the expected
      location contained the stdio_locks list head, so returning from a
      function after calling flockfile produced spurious mismatches. in both
      cases, the random canary was not present, and a predictable value was
      used instead, making the stack protector hardening much less effective
      than it should be.
      
      in the current fix, the thread structure has been expanded to have
      canary fields at all three possible locations, and archs that use a
      non-default location must define a macro in pthread_arch.h to choose
      which location is used. for most archs (which lack TLS canary ABI) the
      choice does not matter.
      484194db
  10. 02 5月, 2015 4 次提交
  11. 28 4月, 2015 1 次提交
    • R
      fix sh jmp_buf size to match ABI · 85d12e02
      Rich Felker 提交于
      while the sh port is still experimental and subject to ABI
      instability, this is not actually an application/libc boundary ABI
      change. it only affects third-party APIs where jmp_buf is used in a
      shared structure at the ABI boundary, because nothing anywhere near
      the end of the jmp_buf object (which includes the oversized sigset_t)
      is accessed by libc.
      
      both glibc and uclibc have 15-slot jmp_buf for sh. presumably the
      smaller version was used in musl because the slots for fpu status
      register and thread pointer register (gbr) were incorrect and must not
      be restored by longjmp, but the size should have been preserved, as
      it's generally treated as a libc-agnostic ABI property for the arch,
      and having extra slots free in case we ever need them for something is
      useful anyway.
      85d12e02
  12. 25 4月, 2015 1 次提交
  13. 24 4月, 2015 4 次提交
    • R
      fix build regression in sh-nofpu subarch due to missing symbol · a658afbf
      Rich Felker 提交于
      commit 646cb9a4 switched sigsetjmp to
      use the new hidden ___setjmp symbol for setjmp, but the nofpu variant
      of setjmp.s was not updated to match.
      a658afbf
    • R
      fix misalignment of dtv in static-linked programs with odd-sized TLS · abead1be
      Rich Felker 提交于
      both static and dynamic linked versions of the __copy_tls function
      have a hidden assumption that the alignment of the beginning or end of
      the memory passed is suitable for storing an array of pointers for the
      dtv. pthread_create satisfies this requirement except when
      libc.tls_size is misaligned, which cannot happen with dynamic linking
      due to way update_tls_size computes the total size, but could happen
      with static linking and odd-sized TLS.
      abead1be
    • R
      remove dead store from static __init_tls · 23129ab8
      Rich Felker 提交于
      commit dab441ae, which made thread
      pointer init mandatory for all programs, rendered this store obsolete
      by removing the early-return path for static programs with no TLS.
      23129ab8
    • R
      make __init_tp function static when static linking · 5f51d529
      Rich Felker 提交于
      this slightly reduces the code size cost of TLS/thread-pointer for
      static linking since __init_tp can be inlined into its only caller and
      removed. this is analogous to the handling of __init_libc in
      __libc_start_main, where the function only has external linkage when
      it needs to be called from the dynamic linker.
      5f51d529
  14. 23 4月, 2015 1 次提交
    • R
      fix regression in x86_64 math asm with old binutils · 18938c29
      Rich Felker 提交于
      the implicit-operand form of fucomip is rejected by binutils 2.19 and
      perhaps other versions still in use. writing both operands explicitly
      fixes the issue. there is no change to the resulting output.
      
      commit a732e80d was the source of this
      regression.
      18938c29
  15. 22 4月, 2015 11 次提交