1. 27 9月, 2011 1 次提交
    • R
      fix lost signals in cond vars · 1fa05210
      Rich Felker 提交于
      due to moving waiters from the cond var to the mutex in bcast, these
      waiters upon wakeup would steal slots in the count from newer waiters
      that had not yet been signaled, preventing the signal function from
      taking any action.
      
      to solve the problem, we simply use two separate waiter counts, and so
      that the original "total" waiters count is undisturbed by broadcast
      and still available for signal.
      1fa05210
  2. 26 9月, 2011 1 次提交
    • R
      redo cond vars again, use sequence numbers · 729d6368
      Rich Felker 提交于
      testing revealed that the old implementation, while correct, was
      giving way too many spurious wakeups due to races changing the value
      of the condition futex. in a test program with 5 threads receiving
      broadcast signals, the number of returns from pthread_cond_wait was
      roughly 3 times what it should have been (2 spurious wakeups for every
      legitimate wakeup). moreover, the magnitude of this effect seems to
      grow with the number of threads.
      
      the old implementation may also have had some nasty race conditions
      with reuse of the cond var with a new mutex.
      
      the new implementation is based on incrementing a sequence number with
      each signal event. this sequence number has nothing to do with the
      number of threads intended to be woken; it's only used to provide a
      value for the futex wait to avoid deadlock. in theory there is a
      danger of race conditions due to the value wrapping around after 2^32
      signals. it would be nice to eliminate that, if there's a way.
      
      testing showed no spurious wakeups (though they are of course
      possible) with the new implementation, as well as slightly improved
      performance.
      729d6368
  3. 25 9月, 2011 1 次提交
  4. 24 9月, 2011 1 次提交
    • R
      fix ABA race in cond vars, improve them overall · 97c5b5a8
      Rich Felker 提交于
      previously, a waiter could miss the 1->0 transition of block if
      another thread set block to 1 again after the signal function set
      block to 0. we now use the caller's thread id as a unique token to
      store in block, which no other thread will ever write there. this
      ensures that if block still contains the tid, no signal has occurred.
      spurious wakeups will of course occur whenever there is a spurious
      return from the futex wait and another thread has begun waiting on the
      cond var. this should be a rare occurrence except perhaps in the
      presence of interrupting signal handlers.
      
      signal/bcast operations have been improved by noting that they need
      not avoid inspecting the cond var's memory after changing the futex
      value. because the standard allows spurious wakeups, there is no way
      for an application to distinguish between a spurious wakeup just
      before another thread called signal/bcast, and the deliberate wakeup
      resulting from the signal/bcast call. thus the woken thread must
      assume that the signalling thread may still be waiting to act on the
      cond var, and therefore it cannot destroy/unmap the cond var.
      97c5b5a8
  5. 23 9月, 2011 1 次提交
  6. 03 8月, 2011 1 次提交
    • R
      unify and overhaul timed futex waits · ec381af9
      Rich Felker 提交于
      new features:
      
      - FUTEX_WAIT_BITSET op will be used for timed waits if available. this
        saves a call to clock_gettime.
      
      - error checking for the timespec struct is now inside __timedwait so
        it doesn't need to be duplicated everywhere. cond_timedwait still
        needs to duplicate it to avoid unlocking the mutex, though.
      
      - pushing and popping the cancellation handler is delegated to
        __timedwait, and cancellable/non-cancellable waits are unified.
      ec381af9
  7. 17 4月, 2011 1 次提交
    • R
      overhaul pthread cancellation · feee9890
      Rich Felker 提交于
      this patch improves the correctness, simplicity, and size of
      cancellation-related code. modulo any small errors, it should now be
      completely conformant, safe, and resource-leak free.
      
      the notion of entering and exiting cancellation-point context has been
      completely eliminated and replaced with alternative syscall assembly
      code for cancellable syscalls. the assembly is responsible for setting
      up execution context information (stack pointer and address of the
      syscall instruction) which the cancellation signal handler can use to
      determine whether the interrupted code was in a cancellable state.
      
      these changes eliminate race conditions in the previous generation of
      cancellation handling code (whereby a cancellation request received
      just prior to the syscall would not be processed, leaving the syscall
      to block, potentially indefinitely), and remedy an issue where
      non-cancellable syscalls made from signal handlers became cancellable
      if the signal handler interrupted a cancellation point.
      
      x86_64 asm is untested and may need a second try to get it right.
      feee9890
  8. 07 4月, 2011 1 次提交
  9. 25 3月, 2011 1 次提交
    • R
      overhaul cancellation to fix resource leaks and dangerous behavior with signals · b470030f
      Rich Felker 提交于
      this commit addresses two issues:
      
      1. a race condition, whereby a cancellation request occurring after a
      syscall returned from kernelspace but before the subsequent
      CANCELPT_END would cause cancellable resource-allocating syscalls
      (like open) to leak resources.
      
      2. signal handlers invoked while the thread was blocked at a
      cancellation point behaved as if asynchronous cancellation mode wer in
      effect, resulting in potentially dangerous state corruption if a
      cancellation request occurs.
      
      the glibc/nptl implementation of threads shares both of these issues.
      
      with this commit, both are fixed. however, cancellation points
      encountered in a signal handler will not be acted upon if the signal
      was received while the thread was already at a cancellation point.
      they will of course be acted upon after the signal handler returns, so
      in real-world usage where signal handlers quickly return, it should
      not be a problem. it's possible to solve this problem too by having
      sigaction() wrap all signal handlers with a function that uses a
      pthread_cleanup handler to catch cancellation, patch up the saved
      context, and return into the cancellable function that will catch and
      act upon the cancellation. however that would be a lot of complexity
      for minimal if any benefit...
      b470030f
  10. 08 3月, 2011 1 次提交
  11. 18 2月, 2011 1 次提交
    • R
      reorganize pthread data structures and move the definitions to alltypes.h · e8827563
      Rich Felker 提交于
      this allows sys/types.h to provide the pthread types, as required by
      POSIX. this design also facilitates forcing ABI-compatible sizes in
      the arch-specific alltypes.h, while eliminating the need for
      developers changing the internals of the pthread types to poke around
      with arch-specific headers they may not be able to test.
      e8827563
  12. 12 2月, 2011 1 次提交