- 09 11月, 2012 1 次提交
-
-
由 Rich Felker 提交于
saving the return address from the delay slot is not valid -- by the time the instruction executes, the return address has already been replaced.
-
- 06 11月, 2012 2 次提交
-
-
由 Rich Felker 提交于
checking for EINVAL should be sufficient, but qemu user emulation returns EPROTONOSUPPORT in some of the failure cases, and it seems conceivable that other kernels doing linux-emulation could make the same mistake. since DNS lookups and other important code might break if the fallback does not get invoked, be extra careful and check for either error. note that it's important NOT to perform the fallback code on other errors such as resource-exhaustion cases, since the fallback is not atomic and will lead to file-descriptor leaks in multi-threaded programs that use exec. the fallback code is only "safe" to run when the initial failure is caused by the application's choice of arguments, not the system state.
-
由 Rich Felker 提交于
-
- 05 11月, 2012 1 次提交
-
-
由 Rich Felker 提交于
-
- 02 11月, 2012 3 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
some of these were coming from stdio functions locking files without unlocking them. I believe it's useful for this to throw a warning, so I added a new macro that's self-documenting that the file will never be unlocked to avoid the warning in the few places where it's wrong.
-
由 Rich Felker 提交于
-
- 01 11月, 2012 2 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
patches by Alex Caudill (npx). the dynamic-linked version is almost identical to the final submitted patch; I just added a couple missing lines for saving the phdr address when the dynamic linker is invoked directly to run a program, and removed a couple to avoid introducing another unnecessary type. the static-linked version is based on npx's draft. it could use some improvements which are contingent on the startup code saving some additional information for later use.
-
- 29 10月, 2012 3 次提交
-
-
由 Rich Felker 提交于
ideally, system would also be cancellable while running the external command, but I cannot find any way to make that work without either leaking zombie processes or introducing behavior that is far outside what the standard specifies. glibc handles cancellation by killing the child process with SIGKILL, but this could be unsafe in that it could leave the data being manipulated by the command in an inconsistent state.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-
- 28 10月, 2012 1 次提交
-
-
由 Rich Felker 提交于
for conformance, two functions should not have the same address. a conforming program could use the addresses of getc and fgetc in ways that assume they are distinct. normally i would just use a wrapper, but these functions are so small and performance-critical that an extra layer of function call could make the one that's a wrapper nearly twice as slow, so I'm just duplicating the code instead.
-
- 27 10月, 2012 3 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-lpcc only works if -nostdlib is not passed, so it's useless. instead, use -print-file-name to look up the full pathname for libpcc.a, and check whether that succeeds before trying to link with the result. also, silence pcc's junk printed on stdout during tests.
-
由 Rich Felker 提交于
in old versions of pcc, the directory containing libpcc.a was not in the library path, and other options like -print-file-name may have been needed to locate it. however, -print-file-name itself seems to have been added around the same time that the directory was added to the search path, and moreover, I see no evidence that older versions of pcc are capable of building a working musl shared library. thus, it seems reasonable to just test whether -lpcc is accepted.
-
- 26 10月, 2012 2 次提交
-
-
由 Rich Felker 提交于
on x86 and some other archs, functions which make function calls which might go through a PLT incur a significant overhead cost loading the GOT register prior to making the call. this load is utterly useless in musl, since all calls are bound at library-creation time using -Bsymbolic-functions, but the compiler has no way of knowing this, and attempts to set the default visibility to protected have failed due to bugs in GCC and binutils. this commit simply manually assigns hidden/protected visibility, as appropriate, to a few internal-use-only functions which have many callers, or which have callers that are hot paths like getc/putc. it shaves about 5k off the i386 libc.so with -Os. many of the improvements are in syscall wrappers, where the benefit is just size and performance improvement is unmeasurable noise amid the syscall overhead. however, stdio may be measurably faster. if in the future there are toolchains that can do the same thing globally without introducing linking bugs, it might be worth considering removing these workarounds.
-
由 Rich Felker 提交于
pcc wrongly passes any option beginning with -m to the linker, and will break at link time if these options were added to CFLAGS. testing linking lets us catch this at configure time and skip them.
-
- 25 10月, 2012 3 次提交
-
-
由 Rich Felker 提交于
these functions must behave as if they obtain the lock via flockfile to satisfy POSIX requirements. since another thread can provably hold the lock when they are called, they must wait to obtain the lock before they can return, even if the correct return value could be obtained without locking. in the case of fclose and freopen, failure to do so could cause correct (albeit obscure) programs to crash or otherwise misbehave; in the case of feof, ferror, and fwide, failure to obtain the lock could sometimes return incorrect results. in any case, having these functions proceed and return while another thread held the lock was wrong.
-
由 Rich Felker 提交于
1. don't open /dev/null just as a basis to copy flags; use shared __fmodeflags function to get the right file flags for the mode. 2. handle the case (probably invalid, but whatever) case where the original stream's file descriptor was closed; previously, the logic re-closed it. 3. accept the "e" mode flag for close-on-exec; update dup3 to fallback to using dup2 so we can simply call __dup3 instead of putting fallback logic in freopen itself.
-
由 Rich Felker 提交于
-
- 23 10月, 2012 1 次提交
-
-
由 Rich Felker 提交于
gcc seems to be generating identical or near-identical code for both versions, but the newer code is more expressive of what it's doing.
-
- 22 10月, 2012 4 次提交
-
-
由 Rich Felker 提交于
the W* namespace is not reserved, so the nonstandard ones must be moved under extension features. also WNOHANG and WUNTRACED were missing.
-
由 Rich Felker 提交于
the behavior of putenv is left undefined if the argument does not contain an equal sign, but traditional implementations behave this way and gnulib replaces putenv if it doesn't do this.
-
由 Rich Felker 提交于
this will prevent gnulib from wrapping our strtod to handle this useless feature.
-
由 Rich Felker 提交于
signal mask was not being restored after fork, but instead blocked again.
-
- 21 10月, 2012 1 次提交
-
-
由 nsz 提交于
-
- 20 10月, 2012 4 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
this was broken during the early dynamic-linked TLS commits, which rearranged some of the code for handling new relocation types.
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
__release_ptc() is only valid in the parent; if it's performed in the child, the lock will be unlocked early then double-unlocked later, corrupting the lock state.
-
- 19 10月, 2012 9 次提交
-
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
with this commit, based on testing with patches to qemu which are not yet upstream,
-
由 Rich Felker 提交于
this is necessary to allow $CC with arguments in it
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
since it did not set the return-value register, the caller could wrongly interpret this as failure.
-
由 Rich Felker 提交于
these macros are supported by more compilers
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-
由 Rich Felker 提交于
-