1. 23 10月, 2018 1 次提交
  2. 22 10月, 2018 2 次提交
    • R
      make the default locale (& a variant) failure-free cases for newlocale · 5af1f594
      Rich Felker 提交于
      commit aeeac9ca introduced fail-safe
      invariants that creating a locale_t object for the C locale or C.UTF-8
      locale will always succeed. extend the guarantee to also cover the
      following:
      
      - newlocale(LC_ALL_MASK, "", 0)
      - newlocale(LC_ALL_MASK-LC_CTYPE_MASK, "C", 0)
      
      provided that the LANG/LC_* environment variables have not been
      changed by the program. these usages are idiomatic for getting the
      default locale, and for getting a locale that behaves as the C locale
      except for honoring the default locale's character encoding.
      5af1f594
    • R
      simplify newlocale and allow failure for explicit locale names · 74e70400
      Rich Felker 提交于
      unify the code paths for allocated and non-allocated locale objects,
      always using a tmp object. this is necessary to avoid clobbering the
      base locale object too soon if we allow for the possibility that
      looking up an explicitly requested locale name may fail, and makes the
      code simpler and cleaner anyway.
      
      eliminate the complex and fragile logic for checking whether one of
      the non-allocated locale objects can be used for the result, and
      instead just memcmp against each of them.
      74e70400
  3. 21 10月, 2018 2 次提交
  4. 19 10月, 2018 4 次提交
    • R
      adjust types in FILE struct to make line buffering check less expensive · 8084d6ab
      Rich Felker 提交于
      the choice of signed char for lbf was a theoretically space-saving
      hack that was not helping, and was unwantedly expensive. while
      comparing bytes against a byte-sized member sounds easy, the trick
      here was that the byte to be compared was unsigned while the lbf
      member was signed, making it possible to set lbf negative to disable
      line buffering. however, this imposed a requirement to promote both
      operands, zero-extending one and sign-extending the other, in order to
      compare them.
      
      to fix this, repurpose the waiters count slot (unused since commit
      c21f7507). while we're at it, switch
      mode (orientation) from signed char to int as well. this makes no
      semantic difference (its only possible values are -1, 0, and 1) but it
      might help on archs where byte access is awkward.
      8084d6ab
    • R
      optimize internal putc_unlocked macro used in putc · d8870dcf
      Rich Felker 提交于
      to check whether flush due to line buffering is needed, the int-type
      character argument must be truncated to unsigned char for comparison.
      if the original value is subsequently passed to __overflow, it must be
      preserved, adding to register pressure. since it doesn't matter,
      truncate all uses so the original value is no longer live.
      d8870dcf
    • R
      fix wrong result for putc variants due to operator precedence · a21a6092
      Rich Felker 提交于
      the internal putc_unlocked macro was wrongly returning a meaningless
      boolean result rather than the written character or EOF.
      
      bug was found by reading (very surprising) asm.
      a21a6092
    • R
      further optimize getc/putc when locking is needed · 9dd19122
      Rich Felker 提交于
      check whether the lock is free before loading the calling thread's
      tid. if so, just use a dummy tid value that cannot compare equal to
      any actual thread id (because it's one bit wider). this also avoids
      the need to save the tid and pass it to locking_getc or locking_putc,
      reducing register pressure.
      
      this change might slightly hurt the case where the caller already
      holds the lock, but it does not affect the single-threaded case, and
      may significantly improve the multi-threaded case, especially on archs
      where loading the thread pointer is disproportionately expensive like
      early mips and arm ISA levels. but even on i386 it helps, at least on
      some machines; I measured roughly a 10-15% improvement.
      9dd19122
  5. 18 10月, 2018 8 次提交
    • R
      use prototype for function pointer in static link libc init barrier · 7eda27d0
      Rich Felker 提交于
      this is not needed for correctness, but doesn't hurt, and in some
      cases the compiler may pessimize the call assuming the callee might be
      variadic when it lacks a prototype.
      7eda27d0
    • R
      fix error in constraints for static link libc init barrier · ba0d83e8
      Rich Felker 提交于
      commit 4390383b inadvertently used "r"
      instead of "0" for the input constraint, which only happened to work
      for the configuration I tested it on because it usually makes sense
      for the compiler to choose the same input and output register.
      ba0d83e8
    • R
      fix build regression due to missing file for putc changes · ab5e1e34
      Rich Felker 提交于
      commit d664061a inadvertently omitted
      the new file putc.h.
      ab5e1e34
    • R
      bypass indirection through pointer objects to access stdin/out/err · d8f2efa7
      Rich Felker 提交于
      by ABI, the public stdin/out/err macros use extern pointer objects,
      and this is necessary to avoid copy relocations that would be
      expensive and make the size of the FILE structure part of the ABI.
      however, internally it makes sense to access the underlying FILE
      objects directly. this avoids both an indirection through the GOT to
      find the address of the stdin/out/err pointer objects (which can't be
      computed PC-relative because they may have been moved to the main
      program by copy relocations) and an indirection through the resulting
      pointer object.
      
      in most places this is just a minor optimization, but in the case of
      getchar and putchar (and the unlocked versions thereof), ipa constant
      propagation makes all accesses to members of stdin/out PC-relative or
      GOT-relative, possibly reducing register pressure as well.
      d8f2efa7
    • R
      optimize hot paths of putc with manual shrink-wrapping · d664061a
      Rich Felker 提交于
      this is the analog of commit dd8f02b7,
      but for putc.
      d664061a
    • R
      optimize hot paths of getc with manual shrink-wrapping · dd8f02b7
      Rich Felker 提交于
      with these changes, in a program that has not created any threads
      besides the main thread and that has not called f[try]lockfile, getc
      performs indistinguishably from getc_unlocked. this was measured on
      several i386 and x86_64 models, and should hold on other archs too
      simply by the properties of the code generation.
      
      the case where the caller already holds the lock (via flockfile) is
      improved significantly as well (40-60% reduction in time on machines
      tested) and the case where locking is needed is improved somewhat
      (roughly 10%).
      
      the key technique used here is forcing the non-hot path out-of-line
      and enabling it to be a tail call. a static noinline function
      (conditional on __GNUC__) is used rather than the extern hiddens used
      elsewhere for this purpose, so that the compiler can choose
      non-default calling conventions, making it possible to tail-call to a
      callee that takes more arguments than the caller on archs where
      arguments are passed on the stack or must have space reserved on the
      stack for spilling the. the tid could just be reloaded via the thread
      pointer in locking_getc, but that would be ridiculously expensive on
      some archs where thread pointer load requires a trap or syscall.
      dd8f02b7
    • R
      document and make explicit desired noinline property for __init_libc · 7136836e
      Rich Felker 提交于
      on multiple occasions I've started to flatten/inline the code in
      __init_libc, only to rediscover the reason it was not inlined: GCC
      fails to deallocate its stack (and now, with the changes in commit
      4390383b, fails to produce a tail call
      to the stage 2 function; see PR #87639) before calling main if it was
      inlined.
      
      document this with a comment and use an explicit noinline attribute if
      __GNUC__ is defined so that even with CFLAGS that heavily favor
      inlining it won't get inlined.
      7136836e
    • R
      impose barrier between thread pointer setup and use for static linking · 4390383b
      Rich Felker 提交于
      this is the analog of commit 1c84c999
      for static linking. unlike with dynamic linking, we don't have
      symbolic lookup to use as a barrier. use a dummy (target-agnostic)
      degenerate inline asm fragment instead. this technique has precedent
      in commit 05ac345f where it's used for
      explicit_bzero. if it proves problematic in any way, loading the
      address of the stage 2 function from a pointer object whose address
      leaks to kernelspace during thread pointer init could be used as an
      even stronger barrier.
      4390383b
  6. 17 10月, 2018 5 次提交
  7. 16 10月, 2018 5 次提交
    • R
      fix misleading placement of statement on same line as for loop in ldso · b36c37f6
      Rich Felker 提交于
      the placement triggered -Wmisleading-indentation warnings if enabled,
      and was gratuitously confusing to anyone reading the code.
      b36c37f6
    • S
      x86_64: add single instruction fma · e9016138
      Szabolcs Nagy 提交于
      fma is only available on recent x86_64 cpus and it is much faster than
      a software fma, so this should be done with a runtime check, however
      that requires more changes, this patch just adds the code so it can be
      tested when musl is compiled with -mfma or -mfma4.
      e9016138
    • S
      arm: add single instruction fma · 7396ef0a
      Szabolcs Nagy 提交于
      vfma is available in the vfpv4 fpu and above, the ACLE standard feature
      test for double precision hardware fma support is
        __ARM_FEATURE_FMA && __ARM_FP&8
      we need further checks to work around clang bugs (fixed in clang >=7.0)
        && !__SOFTFP__
      because __ARM_FP is defined even with -mfloat-abi=soft
        && !BROKEN_VFP_ASM
      to disable the single precision code when inline asm handling is broken.
      
      For runtime selection the HWCAP_ARM_VFPv4 hwcap flag can be used, but
      that requires further work.
      7396ef0a
    • S
      powerpc: add single instruction fabs, fabsf, fma, fmaf, sqrt, sqrtf · 7c5f3bb9
      Szabolcs Nagy 提交于
      These are only available on hard float target and sqrt is not available
      in the base ISA, so further check is used.
      7c5f3bb9
    • S
      s390x: add single instruction fma and fmaf · 1da534ad
      Szabolcs Nagy 提交于
      These are available in the s390x baseline isa -march=z900.
      1da534ad
  8. 13 10月, 2018 3 次提交
    • R
      allow escaped path-separator slashes in glob · 481006fd
      Rich Felker 提交于
      previously (before and after rewrite), spurious escaping of path
      separators as \/ was not treated the same as /, but rather got split
      as an unpaired \ at the end of the fnmatch pattern and an unescaped /,
      resulting in a mismatch/error.
      
      for the case of \/ as part of the maximal literal prefix, remove the
      explicit rejection of it and move the handling of / below escape
      processing.
      
      for the case of \/ after a proper glob pattern, it's hard to parse the
      pattern, so don't. instead cheat and count repetitions of \ prior to
      the already-found / character. if there are an odd number, the last is
      escaping the /, so back up the split position by one. now the
      char clobbered by null termination is variable, so save it and restore
      as needed.
      481006fd
    • R
      rewrite core of the glob implementation for correctness & optimization · d44b07fc
      Rich Felker 提交于
      this code has been long overdue for a rewrite, but the immediate cause
      that necessitated it was total failure to see past unreadable path
      components. for example, A/B/* would fail to match anything, even
      though it should succeed, when both A and A/B are searchable but only
      A/B is readable. this problem both was caught in conformance testing,
      and impacted users.
      
      the old glob implementation insisted on searching the listing of each
      path component for a match, even if the next component was a literal.
      it also used considerable stack space, up to length of the pattern,
      per recursion level, and relied on an artificial bound of the pattern
      length by PATH_MAX, which was incorrect because a pattern can be much
      longer than PATH_MAX while having matches shorter (for example, with
      necessarily long bracket expressions, or with redundancy).
      
      in the new implementation, each level of recursion starts by consuming
      the maximal literal (possibly escaped-literal) path prefix remaining
      in the pattern, and only opening a directory to read when there is a
      proper glob pattern in the next path component. it then recurses into
      each matching entry. the top-level glob function provided automatic
      storage (up to PATH_MAX) for construction of candidate/result strings,
      and allocates a duplicate of the pattern that can be modified in-place
      with temporary null-termination to pass to fnmatch. this allocation is
      not a big deal since glob already has to perform allocation, and has
      to link free to clean up if it experiences an allocation failure or
      other error after some results have already been allocated.
      
      care is taken to use the d_type field from iterated dirents when
      possible; stat is called only when there are literal path components
      past the last proper-glob component, or when needed to disambiguate
      symlinks for the purpose of GLOB_MARK.
      
      one peculiarity with the new implementation is the manner in which the
      error handling callback will be called. if attempting to match */B/C/D
      where a directory A exists that is inaccessible, the error reported
      will be a stat error for A/B/C/D rather than (previous and wrong
      implementation) an opendir error for A, or (likely on other
      implementations) a stat error for A/B. such behavior does not seem to
      be non-conforming, but if it turns out to be undesirable for any
      reason, backtracking could be done on error to report the first
      component producing it.
      
      also, redundant slashes are no longer normalized, but preserved as
      they appear in the pattern; this is probably more correct, and falls
      out naturally from the algorithm used. since trailing slashes (which
      force all matches to be directories) are preserved as well, the
      behavior of GLOB_MARK has been adjusted not to append an additional
      slash to results that already end in slash.
      d44b07fc
    • R
      fix dlsym of thread-local symbols on archs with DTP_OFFSET!=0 · 37cd1676
      Rich Felker 提交于
      commit 6ba5517a modified
      __tls_get_addr to offset the address by +DTP_OFFSET (0x8000 on
      powerpc, mips, etc.) and adjusted the result of DTPREL relocations by
      -DTP_OFFSET to compensate, but missed changing the argument setup for
      calls to __tls_get_addr from dlsym.
      37cd1676
  9. 12 10月, 2018 3 次提交
    • R
      combine arch ABI's DTP_OFFSET into DTV pointers · b6d701a4
      Rich Felker 提交于
      as explained in commit 6ba5517a, some
      archs use an offset (typicaly -0x8000) with their DTPOFF relocations,
      which __tls_get_addr needs to invert. on affected archs, which lack
      direct support for large immediates, this can cost multiple extra
      instructions in the hot path. instead, incorporate the DTP_OFFSET into
      the DTV entries. this means they are no longer valid pointers, so
      store them as an array of uintptr_t rather than void *; this also
      makes it easier to access slot 0 as a valid slot count.
      
      commit e75b16cf left behind cruft in
      two places, __reset_tls and __tls_get_new, from back when it was
      possible to have uninitialized gap slots indicated by a null pointer
      in the DTV. since the concept of null pointer is no longer meaningful
      with an offset applied, remove this cruft.
      
      presently there are no archs with both TLSDESC and nonzero DTP_OFFSET,
      but the dynamic TLSDESC relocation code is also updated to apply an
      inverted offset to its offset field, so that the offset DTV would not
      impose a runtime cost in TLSDESC resolver functions.
      b6d701a4
    • R
      fix redundant computations of strlen in glob append function · 09a805a6
      Rich Felker 提交于
      len was already passed as an argument, so don't use strcat, and use
      memcpy instead of strcpy.
      09a805a6
    • R
      e2552581
  10. 11 10月, 2018 1 次提交
  11. 09 10月, 2018 1 次提交
    • R
      fix build regression on armhf in tlsdesc asm · b3389bbf
      Rich Felker 提交于
      when invoking the assembler, arm gcc does not always pass the right
      flags to enable use of vfp instruction mnemonics. for C code it
      produces, it emits the .fpu directive, but this does not help when
      building asm source files, which tlsdesc needs to be. to fix, use an
      explicit directive here.
      
      commit 0beb9dfb introduced this
      regression. it has not appeared in any release.
      b3389bbf
  12. 05 10月, 2018 1 次提交
    • R
      allow freeaddrinfo of arbitrary sublists of addrinfo list · d1395c43
      Rich Felker 提交于
      the specification for freeaddrinfo allows it to be used to free
      "arbitrary sublists" of the list returned by getaddrinfo. it's not
      clearly stated how such sublists come into existence, but the
      interpretation seems to be that the application can edit the ai_next
      pointers to cut off a portion of the list and then free it.
      
      actual freeing of individual list slots is contrary to the design of
      our getaddrinfo implementation, which has no failure paths after
      making a single allocation, so that light callers can avoid linking
      realloc/free. freeing individual slots is also incompatible with
      sharing the string for ai_canonname, which the current implementation
      does despite no requirement that it be present except on the first
      result. so, rather than actually freeing individual slots, provide a
      way to find the start of the allocated array, and reference-count it,
      freeing the memory all at once after the last slot has been freed.
      
      since the language in the spec is "arbitrary sublists", no provision
      for handling other constructs like multiple lists glued together,
      circular links, etc. is made. presumably passing such a construct to
      freeaddrinfo produces undefined behavior.
      d1395c43
  13. 02 10月, 2018 2 次提交
    • R
      inline cp15 thread pointer load in arm dynamic TLSDESC asm when possible · 7bf773a8
      Rich Felker 提交于
      the indirect function call is a significant portion of the code path
      for the dynamic case, and most users are probably building for ISA
      levels where it can be omitted.
      
      we could drop at least one register save/restore (lr) with this
      change, and possibly another (ip) with some clever shuffling, but it's
      not clear whether there's a way to do it that's not more expensive, or
      whether avoiding the save/restore would have any practical effect, so
      in the interest of avoiding complexity it's omitted for now.
      7bf773a8
    • R
      add TLSDESC support for 32-bit arm · 0beb9dfb
      Rich Felker 提交于
      unlike other asm where the baseline ISA is used, these functions are
      hot paths and use ISA-level specializations.
      
      call-clobbered vfp registers are saved before calling __tls_get_new,
      since there is no guarantee it won't use them. while setjmp/longjmp
      have to use hwcap to decide whether to the fpu is in use, since
      application code could be using vfp registers even if libc was
      compiled as pure softfloat, __tls_get_new is part of libc and can be
      assumed not to have access to vfp registers if tlsdesc.S does not.
      thus it suffices just to check the predefined preprocessor macros. the
      check for __ARM_PCS_VFP is redundant; !__SOFTFP__ must always be true
      if the target ISA level includes fpu instructions/registers.
      0beb9dfb
  14. 27 9月, 2018 1 次提交
    • R
      fix aliasing-based undefined behavior in string functions · 4d0a8217
      Rich Felker 提交于
      use the GNU C may_alias attribute if available, and fallback to naive
      byte-by-byte loops if __GNUC__ is not defined.
      
      this patch has been written to minimize changes so that history
      remains reviewable; it does not attempt to bring the affected code
      into a more consistent or elegant form.
      4d0a8217
  15. 23 9月, 2018 1 次提交