1. 28 7月, 2018 1 次提交
    • R
      make pthread_attr_init honor defaults set by pthread_setattr_default_np · 14992d43
      Rich Felker 提交于
      this fixes a major gap in the intended functionality of
      pthread_setattr_default_np. if application/library code creating a
      thread does not pass a null attribute pointer to pthread_create, but
      sets up an attribute object to change other properties while leaving
      the stack alone, the created thread will get a stack with size
      DEFAULT_STACK_SIZE. this makes pthread_setattr_default_np useless for
      working around stack overflow issues in such applications, and leaves
      a major risk of regression if previously-working code switches from
      using a null attribute pointer to an attribute object.
      
      this change aligns the behavior more closely with the glibc
      pthread_setattr_default_np functionality too, albeit via a different
      mechanism. glibc encodes "default" specially in the attribute object
      and reads the actual default at thread creation time. with this
      commit, we now copy the current default into the attribute object at
      pthread_attr_init time, so that applications that query the properties
      of the attribute object will see the right values.
      14992d43
  2. 24 7月, 2018 1 次提交
    • F
      bsearch: simplify and optimize · 3d8322c7
      Fangrui Song 提交于
      maintainer's note: the key observation here is that the compared
      element is the first slot of the second ceil(half) of the array, and
      thus can be removed for further comparison when it does not match, so
      that we descend into the second ceil(half)-1 rather than ceil(half)
      elements. this change ensures that nel strictly decreases with each
      iteration, so that the case of != but nel==1 does not need to be
      special-cased anymore.
      3d8322c7
  3. 20 7月, 2018 2 次提交
    • M
      move inclusion of linux headers for kd.h, soundcard.h, vt.h to bits · f2c6dbe2
      midipix 提交于
      maintainer's note: while musl does not use the linux kernel headers,
      it does provide these three sys/* headers which do nothing but include
      the corresponding linux/* headers, since the sys/* versions are the
      ones documented for application use (and they arguably provide
      interfaces that are not linux-specific but common to other unices).
      these headers should probably not be provided by libc (rather by a
      separate package), but as long as they are, use the bits header
      framework as an aid to out-of-tree ports of musl for non-linux systems
      that want to implement them in some other way.
      f2c6dbe2
    • M
      remove inclusion guard hacks for sys/kd.h · 2fab90a7
      midipix 提交于
      maintainer's note: at some point, probably long before linux separated
      the uapi headers, it was the case, or at least I believed it was the
      case, that linux/types.h was unsafe to include from userspace. thus,
      the inclusion guard macro _LINUX_TYPES_H was defined in sys/kd.h to
      prevent linux/kd.h from including linux/types.h (which it spuriously
      includes but does not use). as far as I can tell, whatever problem
      this was meant to solve does not seem to have been present for a long
      time, and the hack was not done correctly anyway, so removing it is
      the right thing to do.
      2fab90a7
  4. 19 7月, 2018 2 次提交
  5. 18 7月, 2018 3 次提交
    • S
      add support for arch-specific ptrace command macros · df6d9450
      Szabolcs Nagy 提交于
      sys/ptrace.h is target specific, use bits/ptrace.h to add target
      specific macro definitions.
      
      these macros are kept in the generic sys/ptrace.h even though some
      targets don't support them:
      
      PTRACE_GETREGS
      PTRACE_SETREGS
      PTRACE_GETFPREGS
      PTRACE_SETFPREGS
      PTRACE_GETFPXREGS
      PTRACE_SETFPXREGS
      
      so no macro definition got removed in this patch on any target. only
      s390x has a numerically conflicting macro definition (PTRACE_SINGLEBLOCK).
      
      the PT_ aliases follow glibc headers, otherwise the definitions come
      from linux uapi headers except ones that are skipped in glibc and
      there is no real kernel support (s390x PTRACE_*_AREA) or need special
      type definitions (mips PTRACE_*_WATCH_*) or only relevant for linux
      2.4 compatibility (PTRACE_OLDSETOPTIONS).
      df6d9450
    • S
      sys/ptrace.h: add missing PTRACE_EVENT_STOP · 7ea32a82
      Szabolcs Nagy 提交于
      new in linux v3.1 commit 3544d72a0e10d0aa1c1bd59ed77a53a59cdc12f7
      changed in linux v3.4 commit 5cdf389aee90109e2e3d88085dea4dd5508a3be7
      
      A tracer recieves this event in the waitpid status of a PTRACED_SEIZED
      process.
      7ea32a82
    • S
      uchar.h: define char16_t and char32_t for old c++ · cbf16c4a
      Szabolcs Nagy 提交于
      including uchar.h in c++ code is only well defined in c++11 onwards
      where char16_t and char32_t type definitions must be hidden since they
      are keywords.  however some c++ code compiled for older c++ standard
      include uchar.h too and they need the typedefs, this fix makes such
      code work.
      cbf16c4a
  6. 17 7月, 2018 2 次提交
    • R
      block dlopen of libraries with initial-exec refs to dynamic TLS · 5c2f46a2
      Rich Felker 提交于
      previously, this operation succeeded, and the relocation results
      worked for access from new threads created after dlopen, but produced
      invalid accesses (and possibly clobbered other memory) from threads
      that already existed.
      
      the way the check is written, it still permits dlopen of libraries
      containing initial-exec references to static TLS (TLS in the main
      program or in a dynamic library loaded at startup).
      5c2f46a2
    • R
      fix inefficient choice of tlsdesc function due to off-by-one · 5fdccbcd
      Rich Felker 提交于
      tls_id is one-based, whereas [static_]tls_cnt is a count, so
      comparison for checking that a given tls_id is dynamic rather than
      static needs to use strict inequality.
      5fdccbcd
  7. 15 7月, 2018 1 次提交
    • R
      implement getaddrinfo's AI_ADDRCONFIG flag · 187bcc3b
      Rich Felker 提交于
      this flag is notoriously under-/mis-specified, and in the past it was
      implemented as a nop, essentially considering the absence of a
      loopback interface with 127.0.0.1 and ::1 addresses an unsupported
      configuration. however, common real-world container environments omit
      IPv6 support (even for the network-namespaced loopback interface), and
      some kernels omit IPv6 support entirely. future systems on the other
      hand might omit IPv4 entirely.
      
      treat these as supported configurations and suppress results of the
      unconfigured/unsupported address families when AI_ADDRCONFIG is
      requested. use routability of the loopback address to make the
      determination; unlike other implementations, we do not exclude
      loopback from the "an address is configured" condition, since there is
      no basis in the specification for such exclusion. obtaining a result
      with AI_ADDRCONFIG does not imply routability of the result, and
      applications must still be able to cope with unroutable results even
      if they pass AI_ADDRCONFIG.
      187bcc3b
  8. 14 7月, 2018 1 次提交
    • R
      fix writes outside buffer by ungetc after setvbuf · 9cad27a3
      Rich Felker 提交于
      commit 0b80a7b0, which added non-stub
      setvbuf, applied the UNGET pushback adjustment to the size of the
      buffer passed in, but inadvertently omitted offsetting the start by
      the same amount, thereby allowing unget to clobber up to 8 bytes
      before the start of the buffer. this bug was introduced in the present
      release cycle; no releases are affected.
      9cad27a3
  9. 13 7月, 2018 1 次提交
  10. 12 7月, 2018 1 次提交
    • R
      resolver: don't depend on v4mapped ipv6 to probe routability of v4 addrs · 4f35eb75
      Rich Felker 提交于
      to produce sorted results roughly corresponding to RFC 3484/6724,
      __lookup_name computes routability and choice of source address via
      dummy UDP connect operations (which do not produce any packets). since
      at the logical level, the properties fed into the sort key are
      computed on ipv6 addresses, the code was written to use the v4mapped
      ipv6 form of ipv4 addresses and share a common code path for them all.
      however, on kernels where ipv6 support has been completely omitted,
      this causes ipv4 to appear equally unroutable as ipv6, thereby putting
      unreachable ipv6 addresses before ipv4 addresses in the results.
      
      instead, use only ipv4 sockets to compute routability for ipv4
      addresses. some gratuitous conversion back and forth is left so that
      the logic is not affected by these changes. it may be possible to
      simplify the ipv4 case considerably, thereby reducing code size and
      complexity.
      4f35eb75
  11. 03 7月, 2018 1 次提交
  12. 29 6月, 2018 3 次提交
    • R
      avoid spurious dso matches by dladdr outside bounds of load segments · 193338e6
      Rich Felker 提交于
      since slack space at the beginning and/or end of writable load maps is
      donated to malloc, the application could obtain valid pointers in
      these ranges which dladdr would erroneously identify as part of the
      shared object whose mapping they came from.
      
      instead of checking the queried address against the mapping base and
      length, check it against the load segments from the program headers,
      and only match the dso if it lies within the bounds of one of them.
      
      as a shortcut, if the address does match the range of the mapping but
      not any of the load segments, we know it cannot match any other dso
      and can immediately return failure.
      193338e6
    • R
      make dladdr consistently produce the first symbol in presence of aliases · f6870d6b
      Rich Felker 提交于
      the early-exit condition for the symbol match loop on exact matches
      caused dladdr to produce the first match for an exact match, but the
      last match for an inexact match. in the interest of consistency,
      require a strictly-closer match to replace an already-found one.
      f6870d6b
    • R
      fix symtab-order-dependent spurious matches in dladdr · c8b49b2f
      Rich Felker 提交于
      commit 8b8fb7f0 added logic to prevent
      matching a symbol with no recorded size (closest-match) when there is
      an intervening symbol whose size was recorded, but it only worked when
      the intervening symbol was encountered later in the search.
      
      instead of rejecting symbols where addr falls outside their recorded
      size during the closest-match search, accept them to find the true
      closest-match, then reject such a result only once the search has
      finished.
      c8b49b2f
  13. 28 6月, 2018 2 次提交
    • R
      correctly handle non-matching symbols in dladdr · 8b8fb7f0
      Rich Felker 提交于
      based on patch by Axel Siebenborn, with fixes discussed on the mailing
      list after submission and and rebased around the UB fix in commit
      e829695f.
      
      avoid spurious symbol matches by dladdr beyond symbol size. for
      symbols with a size recorded, only match if the queried address lies
      within the address range determined by the symbol address and size.
      for symbols with no size recorded, the old closest-match behavior is
      kept, as long as there is no intervening symbol with a recorded size.
      
      the case where no symbol is matched, but the address does lie within
      the memory range of a shared object, is specified as success. fix the
      return value and produce a valid (with null dli_sname and dli_saddr)
      Dl_info structure.
      8b8fb7f0
    • R
      avoid using undefined pointer arithmetic in dladdr · e829695f
      Rich Felker 提交于
      e829695f
  14. 27 6月, 2018 9 次提交
    • P
    • D
      add explicit_bzero implementation · 05ac345f
      David Carlier 提交于
      maintainer's note: past sentiment was that, despite being imperfect
      and unable to force clearing of all possible copies of sensitive data
      (e.g. in registers, register spills, signal contexts left on the
      stack, etc.) this function would be added if major implementations
      agreed on it, which has happened -- several BSDs and glibc all include
      it.
      05ac345f
    • A
      inet_ntop: do not compress single zeros in IPv6 · 5c8e6926
      Arthur Jones 提交于
      maintainer's note: this change is for conformance with RFC 5952,
      4.2.2, which explicitly forbids use of :: to shorten a single 16-bit 0
      field when producing the canonical text representation for an IPv6
      address. fixes a test failure reported by Philip Homburg, who also
      submitted a patch, but this fix is simpler and should produce smaller
      code.
      5c8e6926
    • D
      strftime: fix underlying format string in %z format · da5851e9
      Daniel Sabogal 提交于
      the expression (tm->__tm_gmtoff)/3600 has type long. use %+.2ld instead.
      da5851e9
    • R
      resolver: omit final dot (root/suppress-search) in canonical name · 63e2e40e
      Rich Felker 提交于
      if a final dot was included in the queried host name to anchor it to
      the dns root/suppress search domains, and the result was not a CNAME,
      the returned canonical name included the final dot. this was not
      consistent with other implementations, confused some applications, and
      does not seem desirable.
      
      POSIX specifies returning a pointer to, or to a copy of, the input
      nodename, when the canonical name is not available, but does not
      attempt to specify what constitutes "not available". in the case of
      search, we already have an implementation-defined "availability" of a
      canonical name as the fully-qualified name resulting from search, so
      defining it similarly in the no-search case seems reasonable in
      addition to being consistent with other implementations.
      
      as a bonus, fix the case where more than one trailing dot is included,
      since otherwise the changes made here would wrongly cause lookups with
      two trailing dots to succeed. previously this case resulted in
      malformed dns queries and produced EAI_AGAIN after a timeout. now it
      fails immediately with EAI_NONAME.
      63e2e40e
    • R
      fix regression in powerpc[64] SO_PEERSEC definition · efda534b
      Rich Felker 提交于
      commit 587f5a53 moved the definition
      of SO_PEERSEC to bits/socket.h for archs where the SO_* macros differ
      from their standard values, but failed to add copies of the generic
      definition for powerpc and powerpc64.
      efda534b
    • R
      fix value of SO_PEERSEC on mips archs · 587f5a53
      Rich Felker 提交于
      adapted from patch by Matthias Schiffer.
      587f5a53
    • R
      add m68k reg.h and user.h · 471497ab
      Rich Felker 提交于
      471497ab
    • R
      fix dynamic linker mapping/clearing bss in first/only LOAD segment · 68a5a23a
      Rich Felker 提交于
      writable load segments can have size-in-memory larger than their size
      in the ELF file, representing bss or equivalent. the initial partial
      page has to be zero-filled, and additional anonymous pages have to be
      mapped such that accesses don't failt with SIGBUS.
      
      map_library skips redundant MAP_FIXED mapping of the initial
      (lowest-address) segment when processing LOAD segments since it was
      already mapped when reserving the virtual address range, but in doing
      so, inadvertently also skipped the code to fill/map bss. typical
      executable and library files have two or more LOAD segments, and the
      first one is text/rodata (non-writable) and thus has no bss, but it is
      syntactically valid for an ELF program/library to put its writable
      segment first, or to have only one segment (everything writable). the
      binutils bfd-based linker has been observed to create such programs in
      the presence of unusual sections or linker scripts.
      
      fix by moving only the mmap_fixed operation under the conditional
      rather than skipping the remainder of the loop body. add a check to
      avoid bss processing in the case where the segment is not writable;
      this should not happen, but if it does, the change would be a crashing
      regression without this check.
      68a5a23a
  15. 21 6月, 2018 3 次提交
  16. 20 6月, 2018 7 次提交