1. 15 6月, 2017 2 次提交
    • A
      getdate: correctly specify error number · 10800088
      A. Wilcox 提交于
      POSIX defines getdate error #5 as:
      "An I/O error is encountered while reading the template file."
      
      POSIX defines getdate error #7 as:
      "There is no line in the template that matches the input."
      
      This change correctly disambiguates between the two error conditions.
      10800088
    • A
      catopen: set errno to EOPNOTSUPP · af051730
      A. Wilcox 提交于
      Per 1003.1-2008 (2016 ed.), catopen must set errno on failure.
      
      We set errno to EOPNOTSUPP because musl does not currently support
      message catalogues.
      af051730
  2. 09 6月, 2017 2 次提交
    • R
      fix glob failure to match plain "/" to root directory · 84eff797
      Rich Felker 提交于
      the check to prevent matching empty string wrongly blocked matching
      of "/" due to checking emptiness after stripping leading slashes
      rather than checking the full original argument string.
      
      simplified from patch by Julien Ramseier.
      84eff797
    • R
      use hard-coded sh4a atomic opcodes to avoid linker errors on sh · bc313e88
      Rich Felker 提交于
      when using the sh4a opcodes, the assembler tags the resulting object
      file as requiring sh4a. the linker then refuses to (static) link it
      with object files marked as requiring j2, since there is no isa level
      that includes both sh4a and j2 instructions.
      bc313e88
  3. 01 6月, 2017 3 次提交
    • N
      towupper/towlower: fast path for ascii chars · 179766aa
      Natanael Copa 提交于
      Make a fast path for ascii chars which is assumed to be the most common
      case. This has significant performance benefit on xml json and similar
      179766aa
    • R
      remove long-obsolete clang workarounds from mips* syscall_arch.h files · 1c497005
      Rich Felker 提交于
      at one point, clang reportedly failed to support the asm register
      constraints needed for inline syscalls. versions of clang that old
      have much bigger problems that preclude using them to compile musl
      libc.
      1c497005
    • R
      fix fstatat syscall on mips64 · 4073f03a
      Rich Felker 提交于
      mips64 requires 'struct stat' conversion due to incorrect 32-bit
      fields where time_t should be in the kernel version of the structure.
      syscall_arch.h already performed the correct translation for stat,
      fstat, and lstat syscalls, but omitted special handling for fstatat.
      4073f03a
  4. 28 5月, 2017 2 次提交
    • S
      fix fchown fallback on arches without chown(2) · 81f4a120
      Samuel Holland 提交于
      The flags argument was missing, causing uninitalized data to be passed
      to fchownat(2). The correct value of flags should match the fallback for
      chown(3).
      81f4a120
    • R
      fix iconv conversions to legacy 8bit encodings · 97bd6b09
      Rich Felker 提交于
      there was missing reverse-conversion logic for the case, handled
      specially in the character set tables, where a byte represents a
      unicode codepoint with the same value.
      
      this patch adds code to handle the case, and refactors the two-level
      10-bit table lookup for legacy character sets into a function to avoid
      repeating it yet another time as part of the fix.
      97bd6b09
  5. 23 4月, 2017 5 次提交
    • R
      have posix_spawnattr_setflags check for supported flags · f9f686b7
      Rich Felker 提交于
      per POSIX, EINVAL is not a mandatory error, only an optional one. but
      reporting unsupported flags allows an application to fallback
      gracefully when a requested feature is not supported. this is not
      helpful now, but it may be in the future if additional flags are
      added.
      
      had this checking been present before, applications would have been
      able to check for the newly-added POSIX_SPAWN_SETSID feature (added in
      commit bb439bb1) at runtime.
      f9f686b7
    • R
      add no-op POSIX_SPAWN_USEVFORK to spawn.h · 77e895dc
      Rich Felker 提交于
      the bit is reserved anyway for ABI-compat reasons; this documents it
      and makes it so we can have posix_spawnattr_setflags check for flag
      validity without hard-coding an anonymous bit value.
      77e895dc
    • B
      s390x: provide sigcontext struct definition · 55550416
      Bobby Bingham 提交于
      This structure was missed when creating the s390x port.
      
      This is based on the report and patch from William Pitcock, but with a
      modified structure defintion to more closely match the kernel's
      definition.
      55550416
    • R
      implement new posix_spawn flag POSIX_SPAWN_SETSID · bb439bb1
      Rich Felker 提交于
      this functionality has been adopted for inclusion in the next issue of
      POSIX as the result of Austin Group issue #1044.
      
      based on patch by Daurnimator.
      bb439bb1
    • R
      remove va_arg hacks in printf core with undefined behavior · 58e2396a
      Rich Felker 提交于
      the code being removed was written to optimize for size assuming the
      compiler cannot collapse code paths for different types with the same
      underlying representation. modern compilers sometimes succeed in
      making this optimization themselves, but either way it's a small size
      difference and not worth the source-level complexity or the UB
      involved in this hack.
      
      some incorrect use of va_arg still remains, particularly use of void *
      where the actual argument has a different pointer type. fixing this
      requires some actual code additions, rather than just removing cruft,
      so I'm leaving it to be done later as a separate commit.
      58e2396a
  6. 22 4月, 2017 4 次提交
    • R
      make ttyname[_r] return ENODEV rather than ENOENT · e1232f5b
      Rich Felker 提交于
      commit 0a950dcf added checking that
      the pathname a tty device was opened with actually matches the device,
      which can fail to hold when a container inherits a tty from outside
      the container. the error code added at the time was ENOENT; however,
      discussions between affected applications and glibc developers
      resulted in glibc adopting ENODEV as the error for this condition, and
      this has now been documented in the man pages project as well. adopt
      the same error code for consistency.
      
      patch by Christian Brauner.
      e1232f5b
    • R
      fix regression in support for resolv.conf attempts option · 1a7fa5e5
      Rich Felker 提交于
      commit d6cb08bc moved the code and
      introduced an incorrect string offset for the new parsing, probably
      due to a copy-and-paste error.
      
      patch by Stefan Sedich.
      1a7fa5e5
    • S
      fix scalbn when result is in the subnormal range · 8c44a060
      Szabolcs Nagy 提交于
      in nearest rounding mode scalbn could introduce double rounding error
      when an intermediate value and the final result were both in the
      subnormal range e.g.
      
        scalbn(0x1.7ffffffffffffp-1, -1073)
      
      returned 0x1p-1073 instead of 0x1p-1074, because the intermediate
      computation got rounded to 0x1.8p-1023.
      
      with the fix an intermediate value can only be in the subnormal range
      if the final result is 0 which is correct even after double rounding.
      (there still can be two roundings so signals may be raised twice, but
      that's only observable with trapping exceptions which is not supported.)
      8c44a060
    • R
      allow full-range file offsets to mmap on archs with 64-bit syscall args · 2577b1bc
      Rich Felker 提交于
      normally 32-bit archs use the mmap2 syscall and are limited to an
      offset of 2^32 pages. however some 32-bit archs (mainly ILP32-on-64
      ones like x32) have 64-bit syscall argument slots and thus can accept
      the full range. don't artifically limit them.
      2577b1bc
  7. 12 4月, 2017 2 次提交
    • R
      fix dl_iterate_phdr in static PIE binaries · b3751c32
      Rich Felker 提交于
      analogous to commit 5bf7eba2, use of
      AT_PHDR/PT_PHDR does not actually work to find the program base, and
      the method with _DYNAMIC vs PT_DYNAMIC must be used as an alternative.
      
      patch by Shiz, along with testing to confirm that this fixes unwinding
      in static PIE.
      b3751c32
    • R
      fix read past end of buffer in getaddrinfo backend · 1ca59755
      Rich Felker 提交于
      due to testing buf[i].family==AF_INET before checking i==cnt, it was
      possible to read past the end of the array, or past the valid part. in
      practice, without active bounds/indeterminate-value checking by the
      compiler, the worst that happened was failure to return early and
      optimize out the sorting that's unneeded for v4-only results.
      
      returning on i==cnt-1 rather than i==cnt would be an alternate fix,
      but the approach this patch takes is more idiomatic and less
      error-prone.
      
      patch by Timo Teräs.
      1ca59755
  8. 22 3月, 2017 6 次提交
    • S
      aarch64: add single instruction math functions · 54807d47
      Szabolcs Nagy 提交于
      this should increase performance and reduce code size on aarch64.
      
      the compiled code was checked against using __builtin_* instead
      of inline asm with gcc-6.2.0.
      
      lrint is two instructions.
      
      c with inline asm is used because it is safer than a pure asm
      implementation, this prevents ll{rint,round} to be an alias
      of l{rint,round} (because the types don't match) and depends
      on gcc style inline asm support.
      
      ceil, floor, round, trunc can either raise inexact on finite
      non-integer inputs or not raise any exceptions. the new
      implementation does not raise exceptions while the generic
      c code does.
      
      on aarch64, the underflow exception is signaled before rounding
      (ieee 754 allows both before and after rounding, but it must be
      consistent), the generic fma c code signals it after rounding
      so using single instruction fixes a slight conformance issue too.
      54807d47
    • J
      fix strptime output for %C without %y · b6e1fe0d
      Julien Ramseier 提交于
      in this case, a potentially-uninitialized or unrelated existing value
      in tm_year was being used. instead use 0 if %y was not present.
      b6e1fe0d
    • J
      fix processing of strptime %p format · 834ef7af
      Julien Ramseier 提交于
      string pointer was not advanced after matching.
      834ef7af
    • J
      fix off-by-one in strptime %j · 85dfab7e
      Julien Ramseier 提交于
      tm_yday range is 0-365 while %j is 1-366
      85dfab7e
    • J
      regex: fix newline matching with negated brackets · 9571c531
      Julien Ramseier 提交于
      With REG_NEWLINE, POSIX says:
      "A <newline> in string shall not be matched by a period outside
      a bracket expression or by any form of a non-matching list"
      9571c531
    • R
      increase limit on locale name length from 15 to 23 bytes · e6917ece
      Rich Felker 提交于
      the old limit was one byte too short to support locale names of the
      form xx_XX.UTF-8@modifier where modifier is more than 3 bytes, a form
      which various real-world locale names take. the problem could be
      avoided by omitting the useless ".UTF-8" part, but users may need to
      have it present when operating on mixed-libc systems or when it will
      be carried over (e.g. across ssh) to other systems.
      
      the new limit is chosen sufficient for existing/reasonable locale
      names while still keeping the size of setlocale's static buffer small.
      
      also add locale_impl.h to the Makefile's list of headers which force
      rebuild of source files, to prevent dangerously inconsistent object
      files from getting used after this change.
      e6917ece
  9. 21 3月, 2017 3 次提交
    • R
      search locale name variants for gettext translations · e4fc9ad7
      Rich Felker 提交于
      often translations will be named only by language, whereas locale
      names may also include a territory code, modifier, and codeset
      portion. previously, only translations exactly matching the locale
      name were loaded. this was a major usability issue, requiring
      workarounds like symlinks or tweaking of the locale name.
      
      with these changes, gettext now searches for translations by first
      removing the codeset portion of the locale name, then trying the
      remainder in full, with modifier (@mod) removed, with territory code
      (_XX) removed, and with both removed.
      
      part of the reason gettext lacked support for searching fallbacks
      before is that the candidate pathname for a translation file was
      constructed on each call and used as the key to lookup an
      already-mapped translation file. this was very costly/inefficient. we
      now use the tuple of textdomain binding pointer, locale map pointer,
      and integer category id as the key for looking up a translation file
      mapping.
      
      based on patch by He X.
      e4fc9ad7
    • R
      make setlocale return a single name for LC_ALL if all categories match · 16319a5d
      Rich Felker 提交于
      when called for LC_ALL, setlocale has to return a string representing
      the state of all locale categories. the simplest way to do this was to
      always return a delimited list of values for each category, but that's
      not friendly in the fairly common case where all categories have the
      same setting. He X proposed a patch to check for this case and return
      a single name; this patch is a simplified approach to do the same.
      16319a5d
    • R
      fix dlopen/dlsym regression opening libs already loaded at startup · 0c53178e
      Rich Felker 提交于
      commit 4ff234f6 erroneously changed
      the condition for running certain code at dlopen time to check whether
      the library was already relocated rather than whether it already had
      its deps[] table filled. this was out of concern over whether the code
      under the conditional would be idempotent/safe to call on an
      already-loaded libraries. however, I missed a consideration in the
      opposite direction: if a library was loaded at program startup rather
      than dlopen, its deps[] table was not yet allocated/filled, and
      load_deps needs to be called at dlopen time in order for dlsym to be
      able to perform dependency-order symbol lookups.
      
      in order to avoid wasteful allocation of lazy-binding relocation
      tables for libraries which were already loaded and relocated at
      startup, the check for !p->relocated is not deleted entirely, but
      moved to apply only to allocation of these dables.
      0c53178e
  10. 16 3月, 2017 3 次提交
    • R
      fix POSIX-format TZ dst transition times for southern hemisphere · dbff2bb8
      Rich Felker 提交于
      the time of day at which daylight time switches over is specified in
      local time in the dst state prior to the transition. the code for
      handling this wrongly assumed it needed to switch whether dst or
      standard offset is applied to the transition time when the dst end
      date is before the dst start date (souther hemisphere summer), but in
      fact the end transition time should always be adjusted for dst, and
      the start transition time should always be adjusted for standard time.
      dbff2bb8
    • T
      s390x: fix fpreg_t and remove unused per_struct · 74bca42e
      Tuan M. Hoang 提交于
      Including sys/procfs.h complains unknown type name 'fpreg_t' in
      bits/user.h. fpreg_t in bits/signal.h and elf_fpreg_t in bits/user.h
      are practically the same.
      
      per_struct is never used, even conflicts with kernel header
      asm/ptrace.h
      74bca42e
    • R
      precalculate gnu hash rather than doing it lazily in find_sym inner loop · a393d5cc
      Rich Felker 提交于
      this change was suggested based on testing done by Timo Teräs almost
      two years ago; the branch (and probably call prep overhead) in the
      inner loop was found to contribute noticably to total symbol lookup
      time. this change will make lookup slightly slower if libraries were
      built with only the traditional "sysv" ELF hash table, but based on
      how much slower lookup tends to be without the gnu hash table, it
      seems reasonable to assume that (1) users building without gnu hash
      don't care about dynamic linking performance, and (2) the extra time
      spent computing the gnu hash is likely to be dominated by the slowness
      of the sysv hash table lookup anyway.
      a393d5cc
  11. 15 3月, 2017 8 次提交