1. 03 7月, 2014 2 次提交
    • R
      add locale framework · 0bc03091
      Rich Felker 提交于
      this commit adds non-stub implementations of setlocale, duplocale,
      newlocale, and uselocale, along with the data structures and minimal
      code needed for representing the active locale on a per-thread basis
      and optimizing the common case where thread-local locale settings are
      not in use.
      
      at this point, the data structures only contain what is necessary to
      represent LC_CTYPE (a single flag) and LC_MESSAGES (a name for use in
      finding message translation files). representation for the other
      categories will be added later; the expectation is that a single
      pointer will suffice for each.
      
      for LC_CTYPE, the strings "C" and "POSIX" are treated as special; any
      other string is accepted and treated as "C.UTF-8". for other
      categories, any string is accepted after being truncated to a maximum
      supported length (currently 15 bytes). for LC_MESSAGES, the name is
      kept regardless of whether libc itself can use such a message
      translation locale, since applications using catgets or gettext should
      be able to use message locales libc is not aware of. for other
      categories, names which are not successfully loaded as locales (which,
      at present, means all names) are treated as aliases for "C". setlocale
      never fails.
      
      locale settings are not yet used anywhere, so this commit should have
      no visible effects except for the contents of the string returned by
      setlocale.
      0bc03091
    • R
      fix failure of wide printf/scanf functions to set wide orientation · 984c25b7
      Rich Felker 提交于
      in some cases, these functions internally call a byte-based input or
      output function before calling getwc/putwc, so they cannot rely on the
      latter to set the orientation.
      984c25b7
  2. 02 7月, 2014 4 次提交
  3. 30 6月, 2014 2 次提交
    • R
      fix regression in mips dynamic linker · 2d8cc92a
      Rich Felker 提交于
      this issue caused the address of functions in shared libraries to
      resolve to their PLT thunks in the main program rather than their
      correct addresses. it was observed causing crashes, though the
      mechanism of the crash was not thoroughly investigated. since the
      issue is very subtle, it calls for some explanation:
      
      on all well-behaved archs, GOT entries that belong to the PLT use a
      special relocation type, typically called JMP_SLOT, so that the
      dynamic linker can avoid having the jump destinations for the PLT
      resolve to PLT thunks themselves (they also provide a definition for
      the symbol, which must be used whenever the address of the function is
      taken so that all DSOs see the same address).
      
      however, the traditional mips PIC ABI lacked such a JMP_SLOT
      relocation type, presumably because, due to the way PIC works, the
      address of the PLT thunk was never needed and could always be ignored.
      
      prior to commit adf94c19, the mips
      version of reloc.h contained a hack that caused all symbol lookups to
      be treated like JMP_SLOT, inhibiting undefined symbols from ever being
      used to resolve symbolic relocations. this hack goes all the way back
      to commit babf8201, when the mips
      dynamic linker was first made usable.
      
      during the recent refactoring to eliminate arch-specific relocation
      processing (commit adf94c19), this
      hack was overlooked and no equivalent functionality was provided in
      the new code.
      
      fixing the problem is not as simple as adding back an equivalent hack,
      since there is now also a "non-PIC ABI" that can be used for the main
      executable, which actually does use a PLT. the closest thing to
      official documentation I could find for this ABI is nonpic.txt,
      attached to Message-ID: 20080701202236.GA1534@caradoc.them.org, which
      can be found in the gcc mailing list archives and elsewhere. per this
      document, undefined symbols corresponding to PLT thunks have the
      STO_MIPS_PLT bit set in the symbol's st_other field. thus, I have
      added an arch-specific rule for mips, applied at the find_sym level
      rather than the relocation level, to reject undefined symbols with the
      STO_MIPS_PLT bit clear.
      
      the previous hack of treating all mips relocations as JMP_SLOT-like,
      rather than rejecting the unwanted symbols in find_sym, probably also
      caused dlsym to wrongly return PLT thunks in place of the correct
      address of a function under at least some conditions. this should now
      be fixed, at least for global-scope symbol lookups.
      2d8cc92a
    • R
      fix regression in dynamic linker error reporting · 9a4ad022
      Rich Felker 提交于
      due to a mistake when refactoring the error printing for the dynamic
      linker (commit 7c73cacd), all messages
      were suppressed and replaced by blank lines.
      9a4ad022
  4. 25 6月, 2014 1 次提交
  5. 24 6月, 2014 1 次提交
  6. 22 6月, 2014 5 次提交
    • R
      add __sysv_signal abi-compat alias for the signal function · 6ce1fade
      Rich Felker 提交于
      it should be noted that the "real" __sysv_signal, which we do not
      implement, is semantically different from signal. references to
      __sysv_signal arise in code built against glibc under certain
      combinations of feature test macros, and are almost surely
      unintentional since the legacy sysv signal behavior has fundamental
      race conditions that cannot be worked around and which make it
      impossible to use safely.
      6ce1fade
    • R
      add __xmknod and __xmknodat abi-compat functions · 1fd0f6e3
      Rich Felker 提交于
      these are put alongside the similar functions for __xstat, etc. in
      __xstat.c to avoid bloating the number of source files.
      1fd0f6e3
    • R
      consolidate __xstat abi-compat functions into a single source file · 76f2bcc7
      Rich Felker 提交于
      these are mostly intended for use with dynamic linking (although they
      can also be used statically with object files compiled against glibc
      headers), so having them broken down into separate source files to
      optimize for static linking is unlikely to be worth the cost having
      more files in the source tree (which contributes to libc.a overhead,
      compile time, link time, ar/linker command line size exhaustion, and
      so on).
      76f2bcc7
    • R
      implement fmtmsg function · 5474a346
      Rich Felker 提交于
      contributed by Isaac Dunham. this seems to be the last interface that
      was missing for complete POSIX 2008 base + XSI coverage.
      5474a346
    • R
  7. 20 6月, 2014 5 次提交
  8. 19 6月, 2014 6 次提交
    • R
      separate __tls_get_addr implementation from dynamic linker/init_tls · 5ba238e1
      Rich Felker 提交于
      such separation serves multiple purposes:
      
      - by having the common path for __tls_get_addr alone in its own
        function with a tail call to the slow case, code generation is
        greatly improved.
      
      - by having __tls_get_addr in it own file, it can be replaced on a
        per-arch basis as needed, for optimization or ABI-specific purposes.
      
      - by removing __tls_get_addr from __init_tls.c, a few bytes of code
        are shaved off of static binaries (which are unlikely to use this
        function unless the linker messed up).
      5ba238e1
    • R
      add tlsdesc support for i386 · 4e0b4a5d
      Rich Felker 提交于
      4e0b4a5d
    • R
      optimize i386 ___tls_get_addr asm · 880c479f
      Rich Felker 提交于
      880c479f
    • R
      change dynamic TLS installation strategy to optimize access · e75b16cf
      Rich Felker 提交于
      previously, accesses to dynamic TLS had to check two conditions before
      being able to use a dtv slot: (1) that the module index was within the
      bounds of the current dtv size, and (2) that the dynamic tls for the
      requested module index was already installed in the dtv.
      
      this commit changes the installation strategy so that, whenever an
      attempt is made to access dynamic TLS that's not yet installed in the
      dtv, the dynamic TLS for all lower-index modules is also installed.
      thus it provides a new invariant: if a given module index is within
      the bounds of the current dtv size, we automatically know that its TLS
      is installed and directly available. the requirement that the second
      condition (above) be checked is eliminated.
      e75b16cf
    • R
      add arch-generic support for tlsdesc relocations to dynamic linker · 9d15d5e7
      Rich Felker 提交于
      this code is non-functional without further changes to link up the
      arch-specific reloc types for tlsdesc and add asm implementations of
      __tlsdesc_static and __tlsdesc_dynamic.
      9d15d5e7
    • R
      fix incorrect comparison loop condition in memmem · cef0f289
      Rich Felker 提交于
      the logic for this loop was copied from null-terminated-string logic
      in strstr without properly adapting it to work with explicit lengths.
      
      presumably this error could result in false negatives (wrongly
      comparing past the end of the needle/haystack), false positives
      (stopping comparison early when the needle contains null bytes), and
      crashes (from runaway reads past the end of mapped memory).
      cef0f289
  9. 18 6月, 2014 2 次提交
    • R
      reduce code duplication in dynamic linker error paths · 7c73cacd
      Rich Felker 提交于
      eventually this should help making dlerror thread-safe too.
      7c73cacd
    • R
      refactor to remove arch-specific relocation code from dynamic linker · adf94c19
      Rich Felker 提交于
      this was one of the main instances of ugly code duplication: all archs
      use basically the same types of relocations, but roughly equivalent
      logic was duplicated for each arch to account for the different naming
      and numbering of relocation types and variation in whether REL or RELA
      records are used.
      
      as an added bonus, both REL and RELA are now supported on all archs,
      regardless of which is used by the standard toolchain.
      adf94c19
  10. 14 6月, 2014 1 次提交
  11. 12 6月, 2014 1 次提交
  12. 10 6月, 2014 3 次提交
    • R
      simplify errno implementation · ac31bf27
      Rich Felker 提交于
      the motivation for the errno_ptr field in the thread structure, which
      this commit removes, was to allow the main thread's errno to keep its
      address when lazy thread pointer initialization was used. &errno was
      evaluated prior to setting up the thread pointer and stored in
      errno_ptr for the main thread; subsequently created threads would have
      errno_ptr pointing to their own errno_val in the thread structure.
      
      since lazy initialization was removed, there is no need for this extra
      level of indirection; __errno_location can simply return the address
      of the thread's errno_val directly. this does cause &errno to change,
      but the change happens before entry to application code, and thus is
      not observable.
      ac31bf27
    • R
      replace all remaining internal uses of pthread_self with __pthread_self · df15168c
      Rich Felker 提交于
      prior to version 1.1.0, the difference between pthread_self (the
      public function) and __pthread_self (the internal macro or inline
      function) was that the former would lazily initialize the thread
      pointer if it was not already initialized, whereas the latter would
      crash in this case. since lazy initialization is no longer supported,
      use of pthread_self no longer makes sense; it simply generates larger,
      slower code.
      df15168c
    • R
      add thread-pointer support for pre-2.6 kernels on i386 · 64e32287
      Rich Felker 提交于
      such kernels cannot support threads, but the thread pointer is also
      important for other purposes, most notably stack protector. without a
      valid thread pointer, all code compiled with stack protector will
      crash. the same applies to any use of thread-local storage by
      applications or libraries.
      
      the concept of this patch is to fall back to using the modify_ldt
      syscall, which has been around since linux 1.0, to setup the gs
      segment register. since the kernel does not have a way to
      automatically assign ldt entries, use of slot zero is hard-coded. if
      this fallback path is used, __set_thread_area returns a positive value
      (rather than the usual zero for success, or negative for error)
      indicating to the caller that the thread pointer was successfully set,
      but only for the main thread, and that thread creation will not work
      properly. the code in __init_tp has been changed accordingly to record
      this result for later use by pthread_create.
      64e32287
  13. 07 6月, 2014 7 次提交
    • R
      avoid spurious lookup failures from badly-behaved nameservers · 246e752d
      Rich Felker 提交于
      the results of a dns query, whether it's performed as part of one of
      the standard name-resolving functions or directly by res_send, should
      be a function of the query, not of the particular nameserver that
      responds to it. thus, all responses which indicate a failure or
      refusal by the nameserver, as opposed to a positive or negative result
      for the query, should be ignored.
      
      the strategy used is to re-issue the query immediately (but with a
      limit on the number of retries, in case the server is really broken)
      when a response code of 2 (server failure, typically transient) is
      seen, and otherwise take no action on bad responses (which generally
      indicate a misconfigured nameserver or one which the client does not
      have permission to use), allowing the normal retry interval to apply
      and of course accepting responses from other nameservers queried in
      parallel.
      
      empirically this matches the traditional resolver behavior for
      nameservers that respond with a code of 2 in the case where there is
      just a single nameserver configured. the behavior diverges when
      multiple nameservers are available, since musl is querying them in
      parallel. in this case we are mildly more aggressive at retrying.
      246e752d
    • R
      use default timezone from /etc/localtime if $TZ is unset/blank · f6162949
      Rich Felker 提交于
      the way this is implemented, it also allows explicit setting of
      TZ=/etc/localtime even for suid programs. this is not a problem
      because /etc/localtime is a trusted path, much like the trusted
      zoneinfo search path.
      f6162949
    • T
      implement %y and %C specifiers in strptime · 348fc556
      Timo Teräs 提交于
      348fc556
    • R
      avoid invalid use of va_arg in open · 9c2d437c
      Rich Felker 提交于
      reading the variadic mode argument is only valid when the O_CREAT flag
      is present. this probably does not matter, but is needed for formal
      correctness, and could affect LTO or other full-program analysis.
      9c2d437c
    • R
      add O_CLOEXEC fallback for open and related functions · 7765706c
      Rich Felker 提交于
      since there is no easy way to detect whether open honored or ignored
      the O_CLOEXEC flag, the optimal solution to providing a fallback is
      simply to make the fcntl syscall to set the close-on-exec flag
      immediately after open returns.
      7765706c
    • R
      optimize SOCK_CLOEXEC fallback for socket function · 1cacc01d
      Rich Felker 提交于
      the fcntl function is heavy, so make the syscall directly instead.
      also, avoid the code size and runtime overhead of querying the old
      flags, since it's reasonable to assume nothing will be set on a
      newly-created socket. this code is only used on old kernels which lack
      proper atomic close-on-exec support, so future changes that might
      invalidate such an assumption do not need to be considered.
      1cacc01d
    • R
      add SOCK_CLOEXEC fallback for socketpair on old kernels · 1d348566
      Rich Felker 提交于
      as usual, this is non-atomic, but better than producing an error or
      failing to set the close-on-exec flag at all.
      1d348566